From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [RFC PATCH] drm/i915: fix potential dangling else problems in for_each_ macros Date: Wed, 2 Dec 2015 14:51:17 +0000 Message-ID: <565F0565.5000804@intel.com> References: <1448386585-4144-1-git-send-email-jani.nikula@intel.com> <20151124222601.GB16277@nuc-i3427.alporthouse.com> <20151124234726.GA29196@nuc-i3427.alporthouse.com> <20151125092323.GP17050@phenom.ffwll.local> <565EF231.3020100@intel.com> <20151202134651.GC13583@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 25D896E12B for ; Wed, 2 Dec 2015 06:51:20 -0800 (PST) In-Reply-To: <20151202134651.GC13583@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDIvMTIvMTUgMTM6NDYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBXZWQsIERlYyAwMiwg MjAxNSBhdCAwMToyOToyMVBNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gT24gMjUvMTEv MTUgMDk6MjMsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+PiBPbiBUdWUsIE5vdiAyNCwgMjAxNSBh dCAxMTo0NzoyNlBNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+Pj4gT24gVHVlLCBOb3Yg MjQsIDIwMTUgYXQgMTA6MjY6MDFQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4+PiBP biBUdWUsIE5vdiAyNCwgMjAxNSBhdCAwNzozNjoyNVBNICswMjAwLCBKYW5pIE5pa3VsYSB3cm90 ZToKPj4+Pj4+ICAgLyogSXRlcmF0ZSBvdmVyIGluaXRpYWxpc2VkIHJpbmdzICovCj4+Pj4+PiAg ICNkZWZpbmUgZm9yX2VhY2hfcmluZyhyaW5nX18sIGRldl9wcml2X18sIGlfXykgXAo+Pj4+Pj4g ICAJZm9yICgoaV9fKSA9IDA7IChpX18pIDwgSTkxNV9OVU1fUklOR1M7IChpX18pKyspIFwKPj4+ Pj4+IC0JCWlmICgoKHJpbmdfXykgPSAmKGRldl9wcml2X18pLT5yaW5nWyhpX18pXSksIGludGVs X3JpbmdfaW5pdGlhbGl6ZWQoKHJpbmdfXykpKQo+Pj4+Pj4gKwkJZm9yX2VhY2hfaWYgKCgoKHJp bmdfXykgPSAmKGRldl9wcml2X18pLT5yaW5nWyhpX18pXSksIGludGVsX3JpbmdfaW5pdGlhbGl6 ZWQoKHJpbmdfXykpKSkKPj4+Pj4KPj4+Pj4gSWRseSB3b25kZXJpbmcgaWYgd2Ugd291bGQgYmUg aGFwcHkgd2l0aAo+Pj4+Pgo+Pj4+PiBmb3JfZWFjaF9yaW5nKHJpbmdfXywgZGV2X3ByaXZfXykK Pj4+Pj4gCWZvciAoKHJpbmdfXykgPSAmKGRldl9wcml2X18pLT5yaW5nWzBdOwo+Pj4+PiAJICAg ICAocmluZ19fKSA8PSAmKGRldl9wcml2X18pLT5yaW5nW0k5MTVfTlVNX1JJTkdTXTsKPj4+Pj4g CSAgICAgKHJpbmdfXykrKykKPj4+Pj4gCSAgICAgZm9yX2VhY2hfaWYoaW50ZWxfcmluZ19pbml0 aWFsaXplZChyaW5nX18pKQo+Pj4+Pgo+Pj4+PiA/Cj4+Pj4+Cj4+Pj4+IFRoZSBkb3duc2lkZSBp cyB0aGF0IHdlIGhhdmUgdXNlZCBpX18gaW4gc2V2ZXJhbCBwbGFjZXMgcmF0aGVyIHRoYW4KPj4+ Pj4gcmluZy0+aWQuCj4+Pj4KPj4+PiBGd2l3LCAxMyBmaWxlcyBjaGFuZ2VkLCAxMTMgaW5zZXJ0 aW9ucygrKSwgMTQwIGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gU2VlbXMgYSByZWFzb25hYmxlIHNo cmlua2FnZS4KPj4+Cj4+PiBNYXliZSBmb3JfZWFjaF9lbmdpbmUgZXZlbiwgYW5kIHBoYXNlIG91 dCBmb3JfZWFjaF9yaW5nIGNvbXBsZXRlbHk/Cj4+PiAtRGFuaWVsCj4+Pgo+Pgo+PiBXb3VsZG4n dCBpdCBiZSBuaWNlciAoYW5kIHNhZmVyKSBub3QgdG8gYnVpbGQgbWFjcm9zIHRoYXQgZm9sZCB0 aGUKPj4gbG9vcCBzdHJ1Y3R1cmUgaW50byB0aGUgbWFjcm8gKGluIGNvbnRyYXZlbnRpb24gb2Yg a2VybmVsCj4+IHByb2dyYW1taW5nIGd1aWRlbGluZXMpLgo+Pgo+PiBTbyBob3cgYWJvdXQgTk9U IGluY2x1ZGluZyB0aGUgYWN0dWFsIGZvcigpIGluc2lkZSB0aGUgbWFjcm8sIHNvCj4+IHRoYXQg aW5zdGVhZCBvZiB3cml0aW5nCj4+Cj4+IAlmb3JfZWFjaF9lbmdpbmUoZW5naW5lLCBkZXZfcHJp dikKPj4gCQlkb19zdHVmZihlbmdpbmUpCj4+Cj4+IHdlIHdvdWxkIHdyaXRlIGl0IGFzCj4+Cj4+ IAlmb3IgKEVBQ0hfRU5HSU5FKGVuZ2luZSwgZGV2X3ByaXYpKQo+PiAJCWluaXRpYWxpc2UoZW5n aW5lKQo+Pgo+PiAJZm9yIChFQUNIX0FDVElWRV9FTkdJTkUoZW5naW5lLCBkZXZfcHJpdikpIHsK Pj4gCQlzZXJ2aWNlKGVuZ2luZSkKPj4gCQlyZXN0YXJ0KGVuZ2luZSkKPj4gCX0KPj4KPj4gZXRj LiBUaGUgZm9yLWxvb3AgaXMgdmlzaWJsZSBhbmQgdGhlIHNjb3BlIGRvZXNuJ3QgZ2l2ZSB5b3Ug YW55IHN1cnByaXNlcy4KPj4KPj4gW1RoZSBFQUNIX0VOR0lORSgpIG1hY3JvcyBleHBhbmRzIHRv IGEgc2VtaWNvbG9uLXNlcGFyYXRlZCB0cmlwbGV0Cj4+IG9mIGV4cHJlc3Npb25zOyBzdGlsbCBh IHZpb2xhdGlvbiBvZiB0aGUgImRvbid0IHVzZSBtYWNyb3MgdG8KPj4gcmVkZWZpbmUgQyBzeW50 YXgiIGd1aWRlbGluZSwgYnV0IG11Y2ggbGVzcyBlZ3JlZ2lvdXMgdGhhbiBtYWNyb3MKPj4gdGhh dCBjb250YWluIGVtYmVkZGVkICdmb3IncyBhbmQgJ2lmJ3MuCj4KPiBmb3JfZWFjaCgpIGlzIGNv bW1vbiBwcmFjdGljZSBpbiB0aGUga2VybmVsLCBzbyBoaWRpbmcgdGhlIGZvcigpIGluc2lkZQo+ IHRoZSBtYWNybyBpc24ndCB0aGF0IGVncmVnaW91cy4gVGhlIHByb2JsZW0gaXMgZGVmaW5pbmcg RUFDSF9BQ1RJVkVfRU5HSU5FKCkKPiBzaW1wbHksIHByZWZlcnJhYmx5IHdpdGhvdXQgdGhlIHVz ZSBvZiBhbm90aGVyIGxvb3AgaW5zaWRlIHRoZSBmb3IoOzspLgoKTm90aGluZyB3cm9uZyB3aXRo IGFub3RoZXIgbG9vcCA6KSBBbHRob3VnaCwgdG8ga2VlcCBpdCB0aWR5LCBpdCBjYW4gYmUgCmlu c2lkZSBhbiBpbmxpbmUgaGVscGVyIGZ1bmN0aW9uIHRoYXQgc2tpcHMgb3ZlciB0aGUgdW53YW50 ZWQgaXRlbXMgaW4gCnRoZSBpdGVyYXRpb24uIEkgdGhpbmsgaXQncyBiZXR0ZXIgdG8gaGF2ZSB0 aGUgaWYtcmVhZHkgY29uZGl0aW9uIHRlc3QgCmluc2lkZSB0aGUgaXRlcmF0b3IgKGFuZCB0aGVy ZWZvcmUgY2xlYXJseSBib3VuZGVkKSB0aGFuIGxldCBpdCBkYW5nbGUgCmF0IHRoZSBlbmQgb2Yg dGhlIG1hY3JvLgoKPiBPbmUgaXMgdG8gcGFjayB0aGUgaTkxNS0+ZW5naW5lc1tdIGFuZCBoYXZl IGk5MTUtPm51bV9lbmdpbmVzIGFuZAo+IGludGVsX2xvb2t1cF9lbmdpbmUgKG9yIGFuIGk5MTUt PmVuZ2luZV9mb3JfaWRbXSkgZm9yIHRoZSBvY2Nhc2lvbmFsCj4gY2FzZSB3aGVyZSB3ZSBsb29r IHVwIGUuZy4gJmk5MTUtPmVuZ2luZXNbQkNTXS4KPiAtQ2hyaXMKCk9yLCBwdXQgdGhlIGFjdGl2 ZSBvbmVzIG9uIGEgbGlua2VkIGxpc3QsIG9yIGtlZXAgYSBiaXRtYXNrIG9mIHdoaWNoIApvbmVz IGhhdmUgYmVlbiBpbml0aWFsaXNlZCBpbnNpZGUgdGhlIGRldl9wcml2IHN0cnVjdHVyZSwgc28g eW91IGRvbid0IApoYXZlIHRvIGV2ZW4gZGVyZWZlcmVuY2UgdGhlIGVuZ2luZVtdIGFycmF5IHRv IHdvcmsgb3V0IHdoZXRoZXIgYSAKcGFydGljdWxhciBlbmdpbmUgaXMgaW5pdGlhbGlzZWQuIEFw cm9wb3Mgd2hpY2gsIHdvdWxkbid0IGl0IGJlIG11Y2ggCm1vcmUgZWZmaWNpZW50IHRvIGRvIHRo YXQsIGJlY2F1c2UgaW50ZWxfcmluZ19pbml0aWFsaXplZCgpIGlzIHF1aXRlIApoZWF2eXdlaWdo dCBhbmQgdGhlIHJlc3VsdHMgc3VyZWx5IGRvbid0IGNoYW5nZSBvZnRlbiwgaWYgYXQgYWxsLCBk dXJpbmcgCm5vcm1hbCBvcGVyYXRpb24uIFNvIHdlIHNob3VsZCBvbmx5IGV2YWx1YXRlIGl0IHdo ZW4gc29tZXRoaW5nIGhhcyAKY2hhbmdlZCwgYW5kIGNhY2hlIHRoZSBib29sIHJlc3VsdCBmb3Ig dXNlIGluIGFsbCB0aG9zZSBmb3JfZWFjaCgpIGxvb3BzIQoKLkRhdmUuCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==