From: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/skl: Disable coarse power gating up until F0
Date: Tue, 8 Dec 2015 15:03:20 +0530 [thread overview]
Message-ID: <5666A3E0.8090300@intel.com> (raw)
In-Reply-To: <1449505785-20812-1-git-send-email-mika.kuoppala@intel.com>
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
On 12/7/2015 9:59 PM, Mika Kuoppala wrote:
> There is conflicting info between E0 and F0 steppings
> for this workarounds. Trust more authoritative source and
> be conservative and extend also for F0.
>
> This prevents numerous (>50) gpu hangs with SKL GT4e
> during piglit run.
>
> References: HSD: gen9lp/2134184
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index ee05ce8..7096c06 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4717,7 +4717,7 @@ static void gen9_enable_rc6(struct drm_device *dev)
> */
> if (IS_BXT_REVID(dev, 0, BXT_REVID_A1) ||
> ((IS_SKL_GT3(dev) || IS_SKL_GT4(dev)) &&
> - IS_SKL_REVID(dev, 0, SKL_REVID_E0)))
> + IS_SKL_REVID(dev, 0, SKL_REVID_F0)))
> I915_WRITE(GEN9_PG_ENABLE, 0);
> else
> I915_WRITE(GEN9_PG_ENABLE, (rc6_mask & GEN6_RC_CTL_RC6_ENABLE) ?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-08 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 16:29 [PATCH 1/2] drm/i915/skl: Disable coarse power gating up until F0 Mika Kuoppala
2015-12-07 16:29 ` [PATCH 2/2] drm/i915/skl: Double RC6 WRL always on Mika Kuoppala
2015-12-08 5:25 ` Kamble, Sagar A
2015-12-08 9:33 ` Kamble, Sagar A [this message]
2015-12-08 14:23 ` [PATCH 1/2] drm/i915/skl: Disable coarse power gating up until F0 Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666A3E0.8090300@intel.com \
--to=sagar.a.kamble@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox