From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v7] drm/i915: Slaughter the thundering i915_wait_request herd Date: Tue, 8 Dec 2015 14:53:27 +0000 Message-ID: <5666EEE7.7040106@intel.com> References: <565DE84C.6040300@intel.com> <1449159727-27526-1-git-send-email-chris@chris-wilson.co.uk> <5665A0EC.7040909@linux.intel.com> <20151208104415.GC26418@nuc-i3427.alporthouse.com> <5666E33B.1020206@linux.intel.com> <20151208143354.GD26418@nuc-i3427.alporthouse.com> <1448278471-31181-1-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 02572891E7 for ; Tue, 8 Dec 2015 06:53:29 -0800 (PST) In-Reply-To: <1448278471-31181-1-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, "Rogozhkin, Dmitry V" , "Gong, Zhipeng" , "Harrison, John C" List-Id: intel-gfx@lists.freedesktop.org T24gMDgvMTIvMTUgMTQ6MzMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUdWUsIERlYyAwOCwg MjAxNSBhdCAwMjowMzozOVBNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4gT24gMDgv MTIvMTUgMTA6NDQsIENocmlzIFdpbHNvbiB3cm90ZToKPj4+IE9uIE1vbiwgRGVjIDA3LCAyMDE1 IGF0IDAzOjA4OjI4UE0gKzAwMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Pj4+IEVxdWFsbHks IHdoeSB3b3VsZG4ndCB3ZSB3YWtlIHVwIGFsbCB3YWl0ZXJzIGZvciB3aGljaCB0aGUgcmVxdWVz dHMKPj4+PiBoYXZlIGJlZW4gY29tcGxldGVkPwo+Pj4KPj4+IEJlY2F1c2Ugd2Ugbm8gbG9uZ2Vy IHRyYWNrIHRoZSByZXF1ZXN0cyB0byBiZSBjb21wbGV0ZWQsIGhhdmluZyBtb3ZlZCB0bwo+Pj4g YSBjaGFpbiBvZiB3YWl0aW5nIHByb2Nlc3NlcyBpbnN0ZWFkIG9mIGEgY2hhaW4gb2YgcmVxdWVz dHMuIEkgY291bGQKPj4+IGluc2VydCBhIHdhaXRxdWV1ZSBpbnRvIHRoZSBpbnRlbF9icmVhZGNy dW1iIGFuZCB0aGF0IHdvdWxkIGluZGVlZAo+Pj4gbmVjZXNzaXRhdGUgbG9ja2luZyBpbiB0aGUg aXJxIGhhbmRsZXIgKGFuZCBpcnEgbG9ja3MgZXZlcnl3aGVyZSA6KC4KPj4KPj4gWW91IGhhdmUg YSB0cmVlIG9mIHNlcW5vcyBlYWNoIHdpdGggYSB3YWl0LT50YXNrIGFuZCBjdXJyZW50IHNlcW5v Cj4+IG9uIHRoZSBlbmdpbmUgY2FuIGJlIHF1ZXJpZWQuIFNvIEkgZG9uJ3Qgc2VlIHdoZXJlIGlz IHRoZSBwcm9ibGVtPwo+Cj4gVGhlICJwcm9ibGVtIiBpcyB0aGF0IGV2ZXJ5IHByb2Nlc3Mgd2ls bCBkbyBpdHMgb3duIHBvc3QtaXJxIHNlcW5vIGNoZWNrCj4gYWZ0ZXIgYmVpbmcgd29rZW4gdXAs IHRoZW4gZ3JhYiB0aGUgY29tbW9uIHNwaW5sb2NrIHRvIHJlbW92ZSBpdHNlbGYKPiBmcm9tIHRo ZSB0cmVlLgo+Cj4gV2UgY291bGQgYXZvaWQgdGhhdCBieSB1c2luZyBSQl9OT0RFX0VNUFRZIHNo b3J0Y2lyY3VpdGluZyBJIHN1cHBvc2UuCj4KPj4+PiBXb3VsZCBiZSBhIGNoZWFwIGNoZWNrIGhl cmUgYW5kIGl0IHdvdWxkIHNhdmUgYSBjYXNjYWRpbmcgZ3Jvd2luZwo+Pj4+IGxhdGVuY3kgYXMg b25lIHRhc2sgd2FrZXMgdXAgdGhlIG5leHQgb25lLgo+Pj4KPj4+IFdlbGwsIGl0IGNhbid0IGJl IGhlcmUgc2luY2Ugd2UgbWF5IHJlbW92ZV93YWl0ZXIgYWZ0ZXIgYSBzaWduYWwKPj4+IChpbmNv bXBsZXRlIHdhaXQpLiBTbyB0aGlzIHBhcnQgaGFzIHRvIHdhbGsgdGhlIGNoYWluIG9mIHByb2Nl c3Nlcy4gVWdoLAo+Pj4gYW5kIGhhdmUgdG8gbW92ZSB0aGUgd2FpdHF1ZXVlIGZyb20gb25lIHdh aXRlciB0byB0aGUgbmV4dC4uLgo+Pgo+PiBPayBvbiBpbnRlcnJ1cHRlZCB3YWl0ZXJzIGl0IG1h a2VzIG5vIHNlbnNlLCBidXQgb24gbm9ybWFsIHdhaXRlcgo+PiByZW1vdmFsIGl0IHdvdWxkIGp1 c3QgbWVhbiBjb21wYXJpbmcgZW5naW5lLT5nZXRfc2Vxbm8oKSB2cyB0aGUKPj4gZmlyc3Qgd2Fp dGVyIHNlcW5vIGFuZCB3YWtpbmcgdXAgYWxsIHVudGlsIHRoZSB1bmNvbXBsZXRlZCBvbmUgaXMK Pj4gZm91bmQ/Cj4KPiBJdCdzIGEgdHJhZGVvZmYgd2hldGhlciBpdCBjYW4gYmUgd3JpdHRlbiBt b3JlIG5lYXRseSB0aGFuOgo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggYmU3NjA4 Ni4uNDc0NjM2ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0xMjc5LDYgKzEy NzksOSBAQCBpbnQgX19pOTE1X3dhaXRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVl c3QgKnJlcSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAgICAgICAgICAg ICAgICB9Cj4KPiArICAgICAgICAgICAgICAgaWYgKFJCX0VNUFRZX05PREUoJndhaXQubm9kZSkp Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gKwo+ICAgICAgICAgICAgICAgICAg c2V0X3Rhc2tfc3RhdGUod2FpdC50YXNrLCBzdGF0ZSk7Cj4KPiAgICAgICAgICAgICAgICAgIC8q IEJlZm9yZSB3ZSBkbyB0aGUgaGVhdmllciBjb2hlcmVudCByZWFkIG9mIHRoZSBzZXFubywKPiBA QCAtMTMxMiw3ICsxMzE1LDcgQEAgaW50IF9faTkxNV93YWl0X3JlcXVlc3Qoc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXEsCj4gICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ ICAgICAgICAgIH0KPiAgIG91dDoKPiAtICAgICAgIGludGVsX2VuZ2luZV9yZW1vdmVfYnJlYWRj cnVtYihyZXEtPnJpbmcsICZ3YWl0KTsKPiArICAgICAgIGludGVsX2VuZ2luZV9yZW1vdmVfYnJl YWRjcnVtYihyZXEtPnJpbmcsICZ3YWl0LCByZXQpOwo+ICAgICAgICAgIF9fc2V0X3Rhc2tfc3Rh dGUod2FpdC50YXNrLCBUQVNLX1JVTk5JTkcpOwo+ICAgICAgICAgIHRyYWNlX2k5MTVfZ2VtX3Jl cXVlc3Rfd2FpdF9lbmQocmVxKTsKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9icmVhZGNydW1icy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRj cnVtYnMuYwo+IGluZGV4IGFlM2VlM2MuLjQyMWMyMTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBAQCAtMTY5LDEwICsxNjksMTQgQEAgdm9pZCBpbnRl bF9lbmdpbmVfZW5hYmxlX2Zha2VfaXJxKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkK PiAgIH0KPgo+ICAgdm9pZCBpbnRlbF9lbmdpbmVfcmVtb3ZlX2JyZWFkY3J1bWIoc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0cnVjdCBpbnRlbF9icmVhZGNydW1iICp3YWl0KQo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9icmVhZGNydW1iICp3YWl0LAo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCByZXQpCj4gICB7Cj4gICAgICAgICAgc3Ry dWN0IGludGVsX2JyZWFkY3J1bWJzICpiID0gJmVuZ2luZS0+YnJlYWRjcnVtYnM7Cj4KPiArICAg ICAgIGlmIChSQl9FTVBUWV9OT0RFKCZ3YWl0LT5ub2RlKSkKPiArICAgICAgICAgICAgICAgcmV0 dXJuOwo+ICsKPiAgICAgICAgICBzcGluX2xvY2soJmItPmxvY2spOwo+Cj4gICAgICAgICAgaWYg KGItPmZpcnN0X3dhaXRlciA9PSB3YWl0LT50YXNrKSB7Cj4gQEAgLTE4Nyw2ICsxOTEsMTggQEAg dm9pZCBpbnRlbF9lbmdpbmVfcmVtb3ZlX2JyZWFkY3J1bWIoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lLAo+ICAgICAgICAgICAgICAgICAgICogY29tcGxldGlvbiBjaGVjay4KPiAgICAg ICAgICAgICAgICAgICAqLwo+ICAgICAgICAgICAgICAgICAgbmV4dCA9IHJiX25leHQoJndhaXQt Pm5vZGUpOwo+ICsgICAgICAgICAgICAgICBpZiAocmV0ID09IDApIHsKPiArICAgICAgICAgICAg ICAgICAgICAgICB1MzIgc2Vxbm8gPSBpbnRlbF9yaW5nX2dldF9zZXFubyhlbmdpbmUpOwo+ICsg ICAgICAgICAgICAgICAgICAgICAgIHdoaWxlIChuZXh0ICYmCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGk5MTVfc2Vxbm9fcGFzc2VkKHNlcW5vLAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0b19jcnVtYihuZXh0KS0+c2Vxbm8pKSB7 Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcmJfbm9kZSAqbiA9IHJi X25leHQobmV4dCk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3YWtlX3VwX3By b2Nlc3MobmV4dC0+dGFzayk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByYl9l cmFzZShuZXh0LCAmYi0+cmVxdWVzdHMpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgUkJfQ0xFQVJfTk9ERShuZXh0KTsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IG5leHQgPSBuOwo+ICsgICAgICAgICAgICAgICAgICAgICAgIH0KPiArICAgICAgICAgICAgICAg fQo+ICAgICAgICAgICAgICAgICAgdGFzayA9IG5leHQgPyB0b19jcnVtYihuZXh0KS0+dGFzayA6 IE5VTEw7Cj4KPiAgICAgICAgICAgICAgICAgIGItPmZpcnN0X3dhaXRlciA9IHRhc2s7Cj4KPiBN eSBiaWdnZXN0IGNvbXBsYWludCBpcyB0aGF0IHdlIGFyZSBtaXhpbmcgcmVxdWVzdC1jb21wbGV0 ZSBhbmQgZGlyZWN0Cj4gZXZhbHVhdGlvbiBvZiBpOTE1X3NlcW5vX3Bhc3NlZCBub3cuIChJIGV4 cGVjdCB0aGF0IHdlIGNhbiB0aWR5IHRoZSBjb2RlCj4gdXAgc29tZXdoYXQuKQo+IC1DaHJpcwoK U28gaG93IGlzIHRoaXMgZ29pbmcgdG8gd29yayBpbiB0aGUgbmV3ICJzdHJ1Y3QgZmVuY2UiIHJl Z2ltZT8gKFNlZSBKb2huIApIYXJyaXNvbidzIFJGQyBvZiAyM3JkIE5vdmVtYmVyKS4KClRoZSBm ZW5jZSBzdHJ1Y3R1cmUgY29udGFpbnMgdGhlIHBlci1yZXF1ZXN0IGNvbXBsZXRpb24gaW5kaWNh dG9yLCBzbyAKb25jZSBhIGZlbmNlIGhhcyBiZWVuIHNpZ25hbGxlZCB0aGUgb3duZXIgb25seSBu ZWVkcyB0byBjaGVjayB0aGF0LCBhbmQgCmRvZXNuJ3QgbmVlZCB0byByZWV2YWx1YXRlIGFueSBz ZXFubyBjb21wYXJpc29ucyBhZnRlciB3YWtpbmcgdXAuCgpEb2VzIHRoYXQgaGVscD8KCi5EYXZl LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=