From: Yu Dai <yu.dai@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: Move GuC wq_reserve_space to ring_reserve_space
Date: Wed, 9 Dec 2015 09:08:24 -0800 [thread overview]
Message-ID: <56686008.6030509@intel.com> (raw)
In-Reply-To: <20151209090500.GJ26418@nuc-i3427.alporthouse.com>
On 12/09/2015 01:05 AM, Chris Wilson wrote:
> On Tue, Dec 08, 2015 at 05:04:50PM -0800, yu.dai@intel.com wrote:
> > From: Alex Dai <yu.dai@intel.com>
> >
> > Split GuC work queue space reserve and submission and move the space
> > reserve to where ring space is reserved. The reason is that failure
> > in intel_logical_ring_advance_and_submit won't be handled. In the
> > case timeout happens, driver can return early in order to handle the
> > error.
>
> Not here. You want the request_alloc_extras callback.
OK. That is even before touching the ring.
Thanks,
Alex
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-09 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 1:04 [PATCH] drm/i915/guc: Move GuC wq_reserve_space to ring_reserve_space yu.dai
2015-12-09 9:05 ` Chris Wilson
2015-12-09 17:08 ` Yu Dai [this message]
2015-12-09 18:50 ` [PATCH v2] drm/i915/guc: Move GuC wq_reserve_space to alloc_request_extras yu.dai
2015-12-10 17:14 ` Dave Gordon
2015-12-11 0:22 ` Yu Dai
2015-12-11 1:17 ` [PATCH v3] drm/i915/guc: Move GuC wq_check_space " yu.dai
2015-12-15 15:45 ` Dave Gordon
2015-12-16 19:45 ` [PATCH v4] " yu.dai
2015-12-23 15:39 ` Dave Gordon
2016-01-05 10:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56686008.6030509@intel.com \
--to=yu.dai@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).