From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH v3] drm/i915: Avoid writing relocs with addresses in non-canonical form Date: Fri, 11 Dec 2015 14:43:24 +0000 Message-ID: <566AE10C.9080404@intel.com> References: <1449242443-32493-1-git-send-email-michal.winiarski@intel.com> <1449843217-29875-1-git-send-email-michal.winiarski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id EA0166E041 for ; Fri, 11 Dec 2015 06:43:28 -0800 (PST) In-Reply-To: <1449843217-29875-1-git-send-email-michal.winiarski@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Micha=c5=82_Winiarski?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTIvMTEvMjAxNSAyOjEzIFBNLCBNaWNoYcWCIFdpbmlhcnNraSB3cm90ZToKPiBBY2NvcmRp bmcgdG8gYnNwZWMsIHNvbWUgcGFydHMgb2YgSFcgcmVxdWlyZSB0aGUgYWRkcmVzc2VzIHRvIGJl IGluCj4gYSBjYW5vbmljYWwgZm9ybSwgd2hlcmUgYml0cyBbNjM6NDhdID09IFs0N10uIExldCdz IGNvbnZlcnQgYWRkcmVzc2VzIHRvCj4gY2Fub25pY2FsIGZvcm0gcHJpb3IgdG8gcmVsb2NhdGlu ZyBhbmQgcmV0dXJuIGNvbnZlcnRlZCBvZmZzZXRzIHRvCj4gdXNlcnNwYWNlLiBXZSBhbHNvIG5l ZWQgdG8gbWFrZSBzdXJlIHRoYXQgdXNlcnNwYWNlIGlzIHVzaW5nIGFkZHJlc3Nlcwo+IGluIGNh bm9uaWNhbCBmb3JtIGluIGNhc2Ugb2Ygc29mdHBpbi4KPgo+IHYyOiBXaGl0ZXNwYWNlIGZpeHVw LCBnZW44X2Nhbm9uaWNhbF9hZGRyIGRlc2NyaXB0aW9uIChDaHJpcywgVmlsbGUpCj4gdjM6IFJl YmFzZSBvbiB0b3Agb2Ygc29mdHBpbiwgZml4IGEgaG9sZSBpbiByZWxvY2F0ZV9lbnRyeSwKPiAg ICAgIHMvZXhwZWN0L3JlcXVpcmUgKENocmlzKQo+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNA Y2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNaWNoZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVycnlA aW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1pY2hhxYIgV2luaWFyc2tpIDxtaWNoYWwud2luaWFy c2tpQGludGVsLmNvbT4KCldpdGggdXBkYXRlZCBnZW1fc29mdHBpbiAKW2h0dHA6Ly9wYXRjaHdv cmsuZnJlZWRlc2t0b3Aub3JnL3BhdGNoL21zZ2lkLzE0NDk4NDMyNTUtMzI2NDAtMS1naXQtc2Vu ZC1lbWFpbC1taWNoZWwudGhpZXJyeUBpbnRlbC5jb21dCgpUZXN0ZWQtYnk6IE1pY2hlbCBUaGll cnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYyAgICAgICAgICAgIHwgIDkgKysrKysrKy0tCj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgfCAyMSArKysrKysrKysrKysrKystLS0t LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oICAgICAgICB8IDEyICsr KysrKysrKysrKwo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggOGUyYWNkZS4uYjgzMjA3 YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0zNDgyLDEyICszNDgyLDE3IEBA IGk5MTVfZ2VtX29iamVjdF9iaW5kX3RvX3ZtKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpv YmosCj4KPiAgIAlpZiAoZmxhZ3MgJiBQSU5fT0ZGU0VUX0ZJWEVEKSB7Cj4gICAJCXVpbnQ2NF90 IG9mZnNldCA9IGZsYWdzICYgUElOX09GRlNFVF9NQVNLOwo+ICsJCXVpbnQ2NF90IG5vbmNhbm9u aWNhbF9vZmZzZXQgPSBvZmZzZXQgJiAoKDFVTEwgPDwgNDgpIC0gMSk7Cj4KPiAtCQlpZiAob2Zm c2V0ICYgKGFsaWdubWVudCAtIDEpIHx8IG9mZnNldCArIHNpemUgPiBlbmQpIHsKPiArCQlpZiAo b2Zmc2V0ICYgKGFsaWdubWVudCAtIDEpIHx8Cj4gKwkJICAgIG5vbmNhbm9uaWNhbF9vZmZzZXQg KyBzaXplID4gZW5kIHx8Cj4gKwkJICAgIG9mZnNldCAhPSBnZW44X2Nhbm9uaWNhbF9hZGRyKG9m ZnNldCkpIHsKPiAgIAkJCXJldCA9IC1FSU5WQUw7Cj4gICAJCQlnb3RvIGVycl9mcmVlX3ZtYTsK PiAgIAkJfQo+IC0JCXZtYS0+bm9kZS5zdGFydCA9IG9mZnNldDsKPiArCQkvKiBXaGlsZSB1c2Vy c3BhY2UgaXMgdXNpbmcgYWRkcmVzc2VzIGluIGNhbm9uaWNhbCBmb3JtLCBvdXIKPiArCQkgKiBh bGxvY2F0b3IgaXMgdW5hd2FyZSBvZiB0aGlzICovCj4gKwkJdm1hLT5ub2RlLnN0YXJ0ID0gbm9u Y2Fub25pY2FsX29mZnNldDsKPiAgIAkJdm1hLT5ub2RlLnNpemUgPSBzaXplOwo+ICAgCQl2bWEt Pm5vZGUuY29sb3IgPSBvYmotPmNhY2hlX2xldmVsOwo+ICAgCQlyZXQgPSBkcm1fbW1fcmVzZXJ2 ZV9ub2RlKCZ2bS0+bW0sICZ2bWEtPm5vZGUpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9leGVjYnVmZmVyLmMKPiBpbmRleCA0OGVjNDg0Li40NDVjY2M3IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+IEBAIC0yNDksNiArMjQ5LDEz IEBAIHN0YXRpYyBpbmxpbmUgaW50IHVzZV9jcHVfcmVsb2Moc3RydWN0IGRybV9pOTE1X2dlbV9v YmplY3QgKm9iaikKPiAgIAkJb2JqLT5jYWNoZV9sZXZlbCAhPSBJOTE1X0NBQ0hFX05PTkUpOwo+ ICAgfQo+Cj4gK3N0YXRpYyBpbmxpbmUgdWludDY0X3QKPiArcmVsb2NhdGlvbl90YXJnZXQoc3Ry dWN0IGRybV9pOTE1X2dlbV9yZWxvY2F0aW9uX2VudHJ5ICpyZWxvYywKPiArCQkgIHVpbnQ2NF90 IHRhcmdldF9vZmZzZXQpCj4gK3sKPiArCXJldHVybiBnZW44X2Nhbm9uaWNhbF9hZGRyKChpbnQp cmVsb2MtPmRlbHRhICsgdGFyZ2V0X29mZnNldCk7Cj4gK30KPiArCj4gICBzdGF0aWMgaW50Cj4g ICByZWxvY2F0ZV9lbnRyeV9jcHUoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAg IAkJICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZWxvY2F0aW9uX2VudHJ5ICpyZWxvYywKPiBAQCAt MjU2LDcgKzI2Myw3IEBAIHJlbG9jYXRlX2VudHJ5X2NwdShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29i amVjdCAqb2JqLAo+ICAgewo+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBvYmotPmJhc2Uu ZGV2Owo+ICAgCXVpbnQzMl90IHBhZ2Vfb2Zmc2V0ID0gb2Zmc2V0X2luX3BhZ2UocmVsb2MtPm9m ZnNldCk7Cj4gLQl1aW50NjRfdCBkZWx0YSA9IHJlbG9jLT5kZWx0YSArIHRhcmdldF9vZmZzZXQ7 Cj4gKwl1aW50NjRfdCBkZWx0YSA9IHJlbG9jYXRpb25fdGFyZ2V0KHJlbG9jLCB0YXJnZXRfb2Zm c2V0KTsKPiAgIAljaGFyICp2YWRkcjsKPiAgIAlpbnQgcmV0Owo+Cj4gQEAgLTI5Miw3ICsyOTks NyBAQCByZWxvY2F0ZV9lbnRyeV9ndHQoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwK PiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gb2JqLT5iYXNlLmRldjsKPiAgIAlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+IC0J dWludDY0X3QgZGVsdGEgPSByZWxvYy0+ZGVsdGEgKyB0YXJnZXRfb2Zmc2V0Owo+ICsJdWludDY0 X3QgZGVsdGEgPSByZWxvY2F0aW9uX3RhcmdldChyZWxvYywgdGFyZ2V0X29mZnNldCk7Cj4gICAJ dWludDY0X3Qgb2Zmc2V0Owo+ICAgCXZvaWQgX19pb21lbSAqcmVsb2NfcGFnZTsKPiAgIAlpbnQg cmV0Owo+IEBAIC0zNDcsNyArMzU0LDcgQEAgcmVsb2NhdGVfZW50cnlfY2xmbHVzaChzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAgewo+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpk ZXYgPSBvYmotPmJhc2UuZGV2Owo+ICAgCXVpbnQzMl90IHBhZ2Vfb2Zmc2V0ID0gb2Zmc2V0X2lu X3BhZ2UocmVsb2MtPm9mZnNldCk7Cj4gLQl1aW50NjRfdCBkZWx0YSA9IChpbnQpcmVsb2MtPmRl bHRhICsgdGFyZ2V0X29mZnNldDsKPiArCXVpbnQ2NF90IGRlbHRhID0gcmVsb2NhdGlvbl90YXJn ZXQocmVsb2MsIHRhcmdldF9vZmZzZXQpOwo+ICAgCWNoYXIgKnZhZGRyOwo+ICAgCWludCByZXQ7 Cj4KPiBAQCAtMzk1LDcgKzQwMiw3IEBAIGk5MTVfZ2VtX2V4ZWNidWZmZXJfcmVsb2NhdGVfZW50 cnkoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgIAl0YXJnZXRfaTkxNV9vYmog PSB0YXJnZXRfdm1hLT5vYmo7Cj4gICAJdGFyZ2V0X29iaiA9ICZ0YXJnZXRfdm1hLT5vYmotPmJh c2U7Cj4KPiAtCXRhcmdldF9vZmZzZXQgPSB0YXJnZXRfdm1hLT5ub2RlLnN0YXJ0Owo+ICsJdGFy Z2V0X29mZnNldCA9IGdlbjhfY2Fub25pY2FsX2FkZHIodGFyZ2V0X3ZtYS0+bm9kZS5zdGFydCk7 Cj4KPiAgIAkvKiBTYW5keWJyaWRnZSBQUEdUVCBlcnJhdGE6IFdlIG5lZWQgYSBnbG9iYWwgZ3R0 IG1hcHBpbmcgZm9yIE1JIGFuZAo+ICAgCSAqIHBpcGVfY29udHJvbCB3cml0ZXMgYmVjYXVzZSB0 aGUgZ3B1IGRvZXNuJ3QgcHJvcGVybHkgcmVkaXJlY3QgdGhlbQo+IEBAIC01ODMsNiArNTkwLDcg QEAgaTkxNV9nZW1fZXhlY2J1ZmZlcl9yZXNlcnZlX3ZtYShzdHJ1Y3QgaTkxNV92bWEgKnZtYSwK PiAgIAlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqID0gdm1hLT5vYmo7Cj4gICAJc3Ry dWN0IGRybV9pOTE1X2dlbV9leGVjX29iamVjdDIgKmVudHJ5ID0gdm1hLT5leGVjX2VudHJ5Owo+ ICAgCXVpbnQ2NF90IGZsYWdzOwo+ICsJdWludDY0X3Qgb2Zmc2V0Owo+ICAgCWludCByZXQ7Cj4K PiAgIAlmbGFncyA9IFBJTl9VU0VSOwo+IEBAIC02MjUsOCArNjMzLDkgQEAgaTkxNV9nZW1fZXhl Y2J1ZmZlcl9yZXNlcnZlX3ZtYShzdHJ1Y3QgaTkxNV92bWEgKnZtYSwKPiAgIAkJCWVudHJ5LT5m bGFncyB8PSBfX0VYRUNfT0JKRUNUX0hBU19GRU5DRTsKPiAgIAl9Cj4KPiAtCWlmIChlbnRyeS0+ b2Zmc2V0ICE9IHZtYS0+bm9kZS5zdGFydCkgewo+IC0JCWVudHJ5LT5vZmZzZXQgPSB2bWEtPm5v ZGUuc3RhcnQ7Cj4gKwlvZmZzZXQgPSBnZW44X2Nhbm9uaWNhbF9hZGRyKHZtYS0+bm9kZS5zdGFy dCk7Cj4gKwlpZiAoZW50cnktPm9mZnNldCAhPSBvZmZzZXQpIHsKPiArCQllbnRyeS0+b2Zmc2V0 ID0gb2Zmc2V0Owo+ICAgCQkqbmVlZF9yZWxvYyA9IHRydWU7Cj4gICAJfQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiBpbmRleCBiNDQ4YWQ4Li5mYTFmM2FiIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiBAQCAtNTA0LDYgKzUwNCwxOCBAQCBzdGF0aWMg aW5saW5lIHNpemVfdCBnZW44X3B0ZV9jb3VudCh1aW50NjRfdCBhZGRyZXNzLCB1aW50NjRfdCBs ZW5ndGgpCj4gICAJcmV0dXJuIGk5MTVfcHRlX2NvdW50KGFkZHJlc3MsIGxlbmd0aCwgR0VOOF9Q REVfU0hJRlQpOwo+ICAgfQo+Cj4gKy8qIFVzZWQgdG8gY29udmVydCBhbnkgYWRkcmVzcyB0byBj YW5vbmljYWwgZm9ybS4KPiArICogU3RhcnRpbmcgZnJvbSBnZW44LCBzb21lIGNvbW1hbmRzIChl LmcuIFNUQVRFX0JBU0VfQUREUkVTUywKPiArICogTUlfTE9BRF9SRUdJU1RFUl9NRU0gYW5kIG90 aGVycywgc2VlIEJyb2Fkd2VsbCBQUk0gVm9sMmEpIHJlcXVpcmUgdGhlCj4gKyAqIGFkZHJlc3Nl cyB0byBiZSBpbiBhIGNhbm9uaWNhbCBmb3JtOgo+ICsgKiAiR3JhcGhpY3NBZGRyZXNzWzYzOjQ4 XSBhcmUgaWdub3JlZCBieSB0aGUgSFcgYW5kIGFzc3VtZWQgdG8gYmUgaW4gY29ycmVjdAo+ICsg KiBjYW5vbmljYWwgZm9ybSBbNjM6NDhdID09IFs0N10uIgo+ICsgKi8KPiArc3RhdGljIGlubGlu ZSB1aW50NjRfdCBnZW44X2Nhbm9uaWNhbF9hZGRyKHVpbnQ2NF90IGFkZHJlc3MpCj4gK3sKPiAr CXJldHVybiAoKGludDY0X3QpYWRkcmVzcyA8PCAxNikgPj4gMTY7Cj4gK30KPiArCj4gICBzdGF0 aWMgaW5saW5lIGRtYV9hZGRyX3QKPiAgIGk5MTVfcGFnZV9kaXJfZG1hX2FkZHIoY29uc3Qgc3Ry dWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0LCBjb25zdCB1bnNpZ25lZCBuKQo+ICAgewo+Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==