Re: [PATCH 01/11] drm/i915: Introduce drm_i915_gem_request_node for request tracking

Tvrtko Ursulin
2015-12-14T15:58:54Z

Hi,

On 14/12/15 11:36, Chris Wilson wrote:
> In the next patch, request tracking is made more generic and for that we
> need a new expanded struct and to separate out the logic changes from
> the mechanical churn, we split out the structure renaming into this
> patch. For extra fun, create a new i915_gem_request.h.

Subject and patch disagree on the new structure name. :)

Could you draw a nice diagram demonstrating the new design? It is not
straightforward to derive it from the patch series.

Emphasis on relationships between engines, requests and request_active etc.

Also I notice even though you later add vma->last_read, I don't see that
obj->last_read is never removed.

Regards,

Tvrtko