Re: [PATCH 01/11] drm/i915: Introduce drm_i915_gem_request_node for request tracking

Chris Wilson
2015-12-14T16:11:22Z

On Mon, Dec 14, 2015 at 03:58:42PM +0000, Tvrtko Ursulin wrote:
>
> Hi,
>
>
> On 14/12/15 11:36, Chris Wilson wrote:
> >In the next patch, request tracking is made more generic and for that we
> >need a new expanded struct and to separate out the logic changes from
> >the mechanical churn, we split out the structure renaming into this
> >patch. For extra fun, create a new i915_gem_request.h.
>
> Subject and patch disagree on the new structure name. :)
>
> Could you draw a nice diagram demonstrating the new design? It is
> not straightforward to derive it from the patch series.
>
> Emphasis on relationships between engines, requests and request_active etc.

It's the same as before. Instead of explicitly named functions to call
on retiring, you have a list of callbacks.

> Also I notice even though you later add vma->last_read, I don't see
> that obj->last_read is never removed.

Why would it? obj is for the GEM api, vma is for internal - they have
different lifetimes and track different state as I thought I explained.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre