From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915/backlight: prefer dev_priv over dev pointer Date: Fri, 18 Dec 2015 17:02:15 +0000 Message-ID: <56743C17.9060501@intel.com> References: <1450428695-28831-1-git-send-email-jani.nikula@intel.com> <20151218091037.GA26780@nuc-i3427.alporthouse.com> <87twngccj0.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 7CA126EAC6 for ; Fri, 18 Dec 2015 09:02:28 -0800 (PST) In-Reply-To: <87twngccj0.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTgvMTIvMTUgMDk6NDksIEphbmkgTmlrdWxhIHdyb3RlOgo+IE9uIEZyaSwgMTggRGVjIDIw MTUsIENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPiB3cm90ZToKPj4gT24g RnJpLCBEZWMgMTgsIDIwMTUgYXQgMTA6NTE6MzVBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3JvdGU6 Cj4+PiBVc2UgZGV2X3ByaXYgcmF0aGVyIHRoYW4gZGV2IHBvaW50ZXIgd2hlcmUgYXBwbGljYWJs ZS4gUmVtb3ZlIHBsZW50eSBvZgo+Pj4gdW5uZWNlc3NhcnkgdGVtcCB2YXJpYWJsZXMuIE5vIGZ1 bmN0aW9uYWwgY2hhbmdlcy4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFu aS5uaWt1bGFAaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3BhbmVsLmMgfCAxNTYgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ Pj4gICAxIGZpbGUgY2hhbmdlZCwgNTggaW5zZXJ0aW9ucygrKSwgOTggZGVsZXRpb25zKC0pCj4+ Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4+PiBpbmRleCBmNWI0Yzk4ZGU2MDgu LjIxZWU2NDc3YmY5OCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3BhbmVsLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPj4+ IEBAIC00NjEsOCArNDYxLDcgQEAgc3RhdGljIGlubGluZSB1MzIgc2NhbGVfaHdfdG9fdXNlcihz dHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IsCj4+PiAgIHN0YXRpYyB1MzIgaW50ZWxf cGFuZWxfY29tcHV0ZV9icmlnaHRuZXNzKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3Rv ciwKPj4+ICAgCQkJCQkgIHUzMiB2YWwpCj4+PiAgIHsKPj4+IC0Jc3RydWN0IGRybV9kZXZpY2Ug KmRldiA9IGNvbm5lY3Rvci0+YmFzZS5kZXY7Cj4+PiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4+PiAgIAlzdHJ1 Y3QgaW50ZWxfcGFuZWwgKnBhbmVsID0gJmNvbm5lY3Rvci0+cGFuZWw7Cj4+Pgo+Pj4gICAJV0FS Tl9PTihwYW5lbC0+YmFja2xpZ2h0Lm1heCA9PSAwKTsKPj4+IEBAIC00ODAsNDUgKzQ3OSw0MCBA QCBzdGF0aWMgdTMyIGludGVsX3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhzdHJ1Y3QgaW50ZWxf Y29ubmVjdG9yICpjb25uZWN0b3IsCj4+Pgo+Pj4gICBzdGF0aWMgdTMyIGxwdF9nZXRfYmFja2xp Z2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPj4+ICAgewo+Pj4gLQlzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2ID0gY29ubmVjdG9yLT5iYXNlLmRldjsKPj4+IC0Jc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4+ICsJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJhc2UuZGV2 KTsKPj4+Cj4+PiAgIAlyZXR1cm4gSTkxNV9SRUFEKEJMQ19QV01fUENIX0NUTDIpICYgQkFDS0xJ R0hUX0RVVFlfQ1lDTEVfTUFTSzsKPj4+ICAgfQo+Pj4KPj4+ICAgc3RhdGljIHUzMiBwY2hfZ2V0 X2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4+PiAgIHsKPj4+ IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNvbm5lY3Rvci0+YmFzZS5kZXY7Cj4+PiAtCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+PiAr CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5i YXNlLmRldik7Cj4+Pgo+Pj4gICAJcmV0dXJuIEk5MTVfUkVBRChCTENfUFdNX0NQVV9DVEwpICYg QkFDS0xJR0hUX0RVVFlfQ1lDTEVfTUFTSzsKPj4+ICAgfQo+Pj4KPj4+ICAgc3RhdGljIHUzMiBp OXh4X2dldF9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+Pj4g ICB7Cj4+PiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjb25uZWN0b3ItPmJhc2UuZGV2Owo+ Pj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRl Owo+Pj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNvbm5l Y3Rvci0+YmFzZS5kZXYpOwo+Pj4gICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZjb25u ZWN0b3ItPnBhbmVsOwo+Pj4gICAJdTMyIHZhbDsKPj4+Cj4+PiAgIAl2YWwgPSBJOTE1X1JFQUQo QkxDX1BXTV9DVEwpICYgQkFDS0xJR0hUX0RVVFlfQ1lDTEVfTUFTSzsKPj4+IC0JaWYgKElOVEVM X0lORk8oZGV2KS0+Z2VuIDwgNCkKPj4+ICsJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW4g PCA0KQo+Pj4gICAJCXZhbCA+Pj0gMTsKPj4+Cj4+PiAgIAlpZiAocGFuZWwtPmJhY2tsaWdodC5j b21iaW5hdGlvbl9tb2RlKSB7Cj4+PiAgIAkJdTggbGJwYzsKPj4+Cj4+PiAtCQlwY2lfcmVhZF9j b25maWdfYnl0ZShkZXYtPnBkZXYsIFBDSV9MQlBDLCAmbGJwYyk7Cj4+PiArCQlwY2lfcmVhZF9j b25maWdfYnl0ZShkZXZfcHJpdi0+ZGV2LT5wZGV2LCBQQ0lfTEJQQywgJmxicGMpOwo+Pgo+PiBk ZXZfcHJpdi0+ZGV2LT5wZGV2Cj4+IHRvX3BjaV9kZXYoZGV2X3ByaXYpCj4KPiBNYWtlcyBzZW5z ZS4KPgo+PiB0b19pOTE1KGNvbm5lY3Rvci0+YmFzZS5kZXYpOwo+PiB0b19pOTE1X2Zyb21fY29u bmVjdG9yKGNvbm5lY3Rvcik7Cj4+Cj4+IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+PiB0b19p OTE1X2Zyb21fY3J0YyhjcnRjKTsKPgo+IEluIHByYWN0aXNlLCB0b19pOTE1X2Zyb21fY29ubmVj dG9yKCZpbnRlbF9jb25uZWN0b3ItPmJhc2UpIGlzIG5vdCBzbwo+IG5lYXQuIFdvdWxkIGhhdmUg dG8gdHJ5IG91dCBzb21lIHBhdGNoZXMgdG8gc2VlIHdoYXQgaXQgdHVybnMgb3V0IHRvIGJlCj4g bGlrZS4KClByZWZlciBjcnRjX3RvX2k5MTUoKSBhbmQgY29ubmVjdG9yX3RvX2k5MTUoKS4gYy5m LiBndWNfdG9faTkxNSgpCgpPciB3ZSBjb3VsZCBldmVudHVhbGx5IG1ha2UgYSBtYWdpYyBtYWNy byB0aGF0IHRha2VzIGFueSBvYmplY3QgdGhhdCBpdCAKa25vd3MgYWJvdXQ6IGFueV90b19pOTE1 KHRoaW5nKSA6KQoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==