From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: introduce for_each_engine(),
 rework for_each_ring()
Date: Mon, 4 Jan 2016 15:42:47 +0000
Message-ID: <568A92F7.4090806@intel.com>
References: <1451415598-24056-1-git-send-email-david.s.gordon@intel.com>
 <20151229191814.GT31221@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id DBD5E6E4B2
 for <intel-gfx@lists.freedesktop.org>; Mon,  4 Jan 2016 07:42:49 -0800 (PST)
In-Reply-To: <20151229191814.GT31221@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Nikula, Jani" <jani.nikula@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gMjkvMTIvMTUgMTk6MTgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUdWUsIERlYyAyOSwg
MjAxNSBhdCAwNjo1OTo1N1BNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gSW4gdGhlIGRp
c2N1c3Npb25zIGFyb3VuZCBjb21taXQgMzczNzAxYjEgKEphbmkgTmlrdWxhKQo+PiAgICAgIGRy
bTogZml4IHBvdGVudGlhbCBkYW5nbGluZyBlbHNlIHByb2JsZW1zIGluIGZvcl9lYWNoXyBtYWNy
b3MKPj4gRGFuaWVsIFZldHRlciBtb290ZWQgdGhlIGlkZWEgb2YgYSBmb3JfZWFjaF9lbmdpbmUo
cmluZywgZGV2X3ByaXYpCj4+IG1hY3JvIHRoYXQgZGlkbid0IHVzZSBvciByZWx5IG9uIGhhdmlu
ZyBhbiBpbnRlZ2VyIGluZGV4IHZhcmlhYmxlLgo+Pgo+PiBTbyBoZXJlIGl0IGlzOyBhbmQsIGZv
ciBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSwgYW4gdXBkYXRlZCB2ZXJzaW9uCj4+IG9mIGZvcl9l
YWNoX3JpbmcoKSBpbXBsZW1lbnRlZCB1c2luZyB0aGUgc2FtZSBpbnRlcm5hbHMuIEFzIGFuIGV4
YW1wbGUKPj4gb2YgdGhlIHVzZSBvZiB0aGlzIG5ldyBtYWNybywgdGhlIGZ1bmN0aW9ucyBpbiBp
bnRlbF91bmNvcmUuYyBoYXZlCj4+IGJlZW4gY29udmVydGVkIHRvIHVzZSBpdCBpbiBwcmVmZXJl
bmNlIHRvIGZvcl9lYWNoX3JpbmcoKSB3aGVyZXZlcgo+PiBwb3NzaWJsZS4gQSBzdWJzZXF1ZW50
IHBhdGNoIHdpbGwgY29udmVydCBtYW55IG9mIHRoZSB1c2VzIGluIG90aGVyCj4+IHNvdXJjZSBm
aWxlcy4KPj4KPj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPj4gQ2M6IEph
bmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+IENjOiBDaHJpcyBXaWxzb24gPGNo
cmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRh
dmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv
aTkxNV9kcnYuaCAgICAgfCAzMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+PiAg
IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIHwgIDUgKystLS0KPj4gICAyIGZp
bGVzIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYg
LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9kcnYuaAo+PiBpbmRleCBjZjdlMGZjLi5hNjQ1N2VlIDEwMDY0NAo+PiAtLS0g
YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfZHJ2LmgKPj4gQEAgLTE5NjgsMTAgKzE5NjgsMzQgQEAgc3RhdGljIGlubGlu
ZSBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZ3VjX3RvX2k5MTUoc3RydWN0IGludGVsX2d1YyAq
Z3VjKQo+PiAgIAlyZXR1cm4gY29udGFpbmVyX29mKGd1Yywgc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUsIGd1Yyk7Cj4+ICAgfQo+Pgo+PiAtLyogSXRlcmF0ZSBvdmVyIGluaXRpYWxpc2VkIHJpbmdz
ICovCj4+IC0jZGVmaW5lIGZvcl9lYWNoX3JpbmcocmluZ19fLCBkZXZfcHJpdl9fLCBpX18pIFwK
Pj4gLQlmb3IgKChpX18pID0gMDsgKGlfXykgPCBJOTE1X05VTV9SSU5HUzsgKGlfXykrKykgXAo+
PiAtCQlmb3JfZWFjaF9pZiAoKCgocmluZ19fKSA9ICYoZGV2X3ByaXZfXyktPnJpbmdbKGlfXyld
KSwgaW50ZWxfcmluZ19pbml0aWFsaXplZCgocmluZ19fKSkpKQo+PiArLyogSGVscGVycyBmb3Ig
dGhlIGZvcl9lYWNoXyogbWFjcm9zIGJlbG93ICovCj4+ICsjZGVmaW5lCV9fSU5JVF9FTkdJTkVf
UFRSKGVuZ2luZSwgZGV2X3ByaXYpCQkJCVwKPj4gKwkoewkJCQkJCQkJXAo+PiArCSAJc3RydWN0
IGludGVsX2VuZ2luZV9jcyAqZXAgPSAoZGV2X3ByaXYpLT5yaW5nOwkJXAo+PiArCQkoZW5naW5l
KSA9IC0tZXA7CQkJCQlcCj4+ICsJfSkKPj4gKyNkZWZpbmUJX19ORVhUX0FDVElWRV9FTkdJTkUo
ZW5naW5lLCBkZXZfcHJpdiwgbnIpCQkJXAo+PiArCSh7CQkJCQkJCQlcCj4+ICsJCXN0cnVjdCBp
bnRlbF9lbmdpbmVfY3MgKmVuZCA9ICYoZGV2X3ByaXYpLT5yaW5nW25yXTsJXAo+PiArCQlzdHJ1
Y3QgaW50ZWxfZW5naW5lX2NzICplcCA9IChlbmdpbmUpOwkJCVwKPj4gKwkJYm9vbCBpbl9yYW5n
ZTsJCQkJCQlcCj4+ICsJCWRvIHsJCQkJCQkJXAo+PiArCQkJaW5fcmFuZ2UgPSArKyhlcCkgPCBl
bmQ7CQkJXAo+PiArCQl9IHdoaWxlIChpbl9yYW5nZSAmJiAhaW50ZWxfcmluZ19pbml0aWFsaXpl
ZChlcCkpOwlcCj4+ICsJIAkoZW5naW5lKSA9IGVwOwkJCQkJCVwKPj4gKwkJaW5fcmFuZ2U7CQkJ
CQkJXAo+PiArCX0pCj4+ICsKPj4gKy8qIEl0ZXJhdGUgb3ZlciBpbml0aWFsaXNlZCBlbmdpbmVz
ICovCj4+ICsjZGVmaW5lIGZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2KQkJCQlcCj4+
ICsJZm9yIChfX0lOSVRfRU5HSU5FX1BUUihlbmdpbmUsIGRldl9wcml2KTsJCQlcCj4+ICsJICAg
ICBfX05FWFRfQUNUSVZFX0VOR0lORShlbmdpbmUsIGRldl9wcml2LCBJOTE1X05VTV9SSU5HUyk7
ICkKPj4gKwo+PiArLyogQmFja3dhcmRzIGNvbXBhdGliaWxpdHk6IGl0ZXJhdGUgb3ZlciBpbml0
aWFsaXNlZCAicmluZ3MiICovCj4+ICsjZGVmaW5lIGZvcl9lYWNoX3JpbmcoZW5naW5lLCBkZXZf
cHJpdiwgcmluZ19pZCkJCQlcCj4+ICsJZm9yIChfX0lOSVRfRU5HSU5FX1BUUihlbmdpbmUsIGRl
dl9wcml2KTsJCQlcCj4+ICsJICAgICBfX05FWFRfQUNUSVZFX0VOR0lORShlbmdpbmUsIGRldl9w
cml2LCBJOTE1X05VTV9SSU5HUykgJiYJXAo+PiArCSAgICAgKChyaW5nX2lkKSA9IChlbmdpbmUp
LT5pZCwgdHJ1ZSk7ICkKPgo+IE5vLCB0aGF0IGlzIGhhcmQgdG8gcmVhZCBhbmQgYmxvYXRzIHRo
ZSBrZXJuZWwgZm9yIG5vIGJlbmVmaXQuIEV2ZW4gbW9yZQo+IHNvIGNvbXBhcmVkIGFnYWluc3Qg
anVzdAoKV2VsbCBJIGFncmVlIHRoYXQgX19ORVhUX0FDVElWRV9FTkdJTkUoKSB0YWtlcyBhIGJp
dCBvZiB0aGlua2luZyBhYm91dCwgCmJ1dCBhdCBsZWFzdCBpdCB1c2VzIGNsZWFybHkgbmFtZWQg
dmFyaWFibGVzIHRoYXQgdGVsbCB5b3Ugd2hhdCB0aGV5IApzdGFuZCBmb3IsIGFuZCBjYW4gYmUg
Zm9ybWF0dGVkIHdpdGhvdXQgYW55IGxpbmUgYnJlYWtzIHdpdGhpbiAKc3RhdGVtZW50cywgd2hp
Y2ggSU1ITyBtYWtlcyBpdCBtdWNoIEVBU0lFUiB0byByZWFkIHRoYW4gdGhlbiBtZXNzIG9mIAoo
cGFyZW50aGVzZXMpLCBfX3VuZGVyc2NvcmVzX18sICYgcmFuZG9tLT5wdW5jdHVhdGlvbiB0aGF0
IHdlIGhhZC4KQW5kIGJyZWFraW5nIHRoZSBkZXRhaWxzIG91dCBpbnRvIHR3byBoZWxwZXJzIG1h
a2VzIHRoZSBhY3R1YWwgZW5kLXVzZXIgCm1hY3JvIHNvIG11Y2ggY2xlYXJlcjsgYWZ0ZXIgYWxs
LCB0aGUgY29tcGxpY2F0ZWQgaW5uYXJkcyBvbmx5IGhhdmUgdG8gCmJlIGNoZWNrZWQgYW5kIHZl
cmlmaWVkIG9uY2UsIGhlcmUgb24gdGhlIG1haWxpbmcgbGlzdCwgYW5kIHRoZW4gCmV2ZXJ5b25l
IGNhbiBzZWUgd2hhdCB0aGUgZm9yX2VhY2hfZW5naW5lKCkgbWFjcm8gaXMgZG9pbmcgd2l0aG91
dCAKaGF2aW5nIHRvIHdvcnJ5IGFib3V0IHRoZSBHQ0MgbWFnaWMgaW5zaWRlLgoKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA1NzhmOTU0ZGJhMWQuLjczOTU2OTQ1OGJiNyAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0xOTY3LDggKzE5NjcsOCBAQCBzdGF0aWMgaW5s
aW5lIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpndWNfdG9faTkxNShzdHJ1Y3QgaW50ZWxfZ3Vj
ICpndWMpCj4KPiAgIC8qIEl0ZXJhdGUgb3ZlciBpbml0aWFsaXNlZCByaW5ncyAqLwo+ICAgI2Rl
ZmluZSBmb3JfZWFjaF9yaW5nKHJpbmdfXywgZGV2X3ByaXZfXywgaV9fKSBcCj4gLSAgICAgICBm
b3IgKChpX18pID0gMDsgKGlfXykgPCBJOTE1X05VTV9SSU5HUzsgKGlfXykrKykgXAo+IC0gICAg
ICAgICAgICAgICBmb3JfZWFjaF9pZiAoKCgocmluZ19fKSA9ICYoZGV2X3ByaXZfXyktPnJpbmdb
KGlfXyldKSwgaW50ZWxfZW5naW5lX2luaXRpYWxpemVkKChyaW5nX18pKSkpCj4gKyAgICAgICBm
b3IgKChyaW5nX18pID0gJihkZXZfcHJpdl9fKS0+cmluZ1swXTsgKHJpbmdfXykgPCAmKGRldl9w
cml2X18pLT5yaW5nW0k5MTVfTlVNX1JJTkdTXTsgKHJpbmdfXykrKykgXAo+ICsgICAgICAgICAg
ICAgICBmb3JfZWFjaF9pZiAoaW50ZWxfZW5naW5lX2luaXRpYWxpemVkKChyaW5nX18pKSkKPgo+
ICAgZW51bSBoZG1pX2ZvcmNlX2F1ZGlvIHsKPiAgICAgICAgICBIRE1JX0FVRElPX09GRl9EVkkg
PSAtMiwgICAgICAgIC8qIG5vIGF1eCBkYXRhIGZvciBIRE1JLURWSSBjb252ZXJ0ZXIgKi8KPgo+
ICh3aGljaCBpcyBhIG5ldCB3aW4gb3ZlciB0aGUgY3VycmVudCBjb2RlLCBwcmVzdW1hYmx5IHNv
bGVseSBkdWUgdG8KPiBlbGltaW5hdGluZyBkZWFkIGxvY2FscykKPiAtQ2hyaXMKCldlbGwgYWN0
dWFsbHkgaXQgaXNuJ3QuCgpGaXJzdCBvZmYsIHRoYXQgZG9lc24ndCBldmVuIGNvbXBpbGUsIGl0
IGxlYXZlcyBsb3RzIG9mICJ2YXJpYWJsZSB1c2VkIAp1bmluaXRpYWxpc2VkIiB0eXBlIGVycm9y
cyBpbiB1c2VycyBvZiB0aGUgbWFjcm8sIGJlY2F1c2UgdGhvc2UgdXNlcnMgCmFjdHVhbGx5IHJl
cXVpcmUgdGhlIGluZGV4LCB3aGljaCBpcyB3aHkgbXkgcGF0Y2hlcyBjb252ZXJ0ZWQgb25seSB0
aG9zZSAKdGhhdCBkaWRuJ3QuCgpXaXRoIHRoZSBhYm92ZSAod2l0aCB0aGUgYWRkaXRpb24gb2Yg
ImlfXyA9IDAiIC4uLiAiKGlfXykrKyIpIHVzZWQgYXMgCnRoZSBkZWZpbml0aW9uIG9mIGZvcl9l
YWNoX3JpbmcoKSwgYW5kIGFsc28gKGJ1dCB3aXRob3V0IHRoZSBwYXJhbWV0ZXIgCiJpX18iKSBh
cyB0aGUgZGVmaW5pdGlvbiBvZiBmb3JfZWFjaF9lbmdpbmUoKSwgcGx1cyBteSBzZWNvbmQgcGF0
Y2ggdGhhdCAKY29udmVydHMgYXMgbWFueSBhcyBwb3NzaWJsZSwgd2UgZmluZCB0aGUgZm9sbG93
aW5nOgoKLXJ3LXItLXItLSAzMDg2NjQ3NSBKYW4gNCAxNDo1NSBpOTE1LWRybS5rbwkjIGJhc2Vs
aW5lCi1ydy1yLS1yLS0gMzA4NzE0NDcgSmFuIDQgMTQ6NTYgaTkxNS1jdy5rbwkjIHRoaXMgdmVy
c2lvbgotcnctci0tci0tIDMwODc3NTI0IEphbiA0IDE0OjU2IGk5MTUtZHNnLmtvCSMgbXkgdmVy
c2lvbgoKc28gaXQgbG9va3MgbGlrZSB0aGlzIGluY3JlYXNlcyB0aGUgc2l6ZSwgYW5kIG1pbmUg
aW5jcmVhc2VzIGl0IGV2ZW4gCm1vcmUuIEJ1dCBhY3R1YWxseSwgd2hlbiB3ZSBsb29rIGF0IENP
REUgc2l6ZSByYXRoZXIgdGhhbiBmaWxlIHNpemU6CgogICAgdGV4dAkgICBkYXRhCSAgICBic3MJ
ICAgIGRlYwkgICAgaGV4CWZpbGVuYW1lCjEwOTI0MTYgICAyNDIzMyAgICAgNTEyIDExMTcxNjEg
IDExMGJlOSBpOTE1LWRybS5rbwkjIGJhc2VsaW5lCjEwOTI4MjAJICAyNDIzMwkgICAgNTEyCTEx
MTc1NjUJIDExMGQ3ZAlpOTE1LWN3LmtvCSMgdGhpcyB2ZXJzaW9uCjEwOTIyNDQJICAyNDIzMwkg
ICAgNTEyCTExMTY5ODkJIDExMGIzZAlpOTE1LWRzZy5rbwkjIG15IHZlcnNpb24KCndlIGZpbmQg
anVzdCB0aGUgb3Bwb3NpdGUuIFRoaXMgbWFrZXMgdGhlIGNvZGUgfjQwMGIgbGFyZ2VyLCB3aGVy
ZWFzIG15IApwYXRjaCBtYWRlIGl0IH4yMDBiIHNtYWxsZXIuIEkgdGhpbmsgaXQncyBiZWNhdXNl
IEdDQyBrbm93cyBob3cgdG8gYWxpYXMgCnZhcmlhYmxlcyB3aXRoIGRpZmZlcmVudCBzY29wZXMg
dG8gdGhlIHNhbWUgcmVnaXN0ZXJzLCBzbyBjYWNoaW5nIAppbnRlcm1lZGlhdGUgcmVzdWx0cyBp
biB2ZXJ5LWxvY2FsLXZhcmlhYmxlcyBpcyBnZW5lcmFsbHkgYSB3aW4uIEl0J3MgCmRlZmluaXRl
bHkgbm90ICJrZXJuZWwgYmxvYXQiLgoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp
c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4Cg==