From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v3 1/3] drm/i915: simplify allocation of driver-internal requests Date: Thu, 7 Jan 2016 12:34:39 +0000 Message-ID: <568E5B5F.8020109@intel.com> References: <1452162052-22573-1-git-send-email-david.s.gordon@intel.com> <1452162052-22573-2-git-send-email-david.s.gordon@intel.com> <20160107115846.GI652@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 009B28A3A2 for ; Thu, 7 Jan 2016 04:34:40 -0800 (PST) In-Reply-To: <20160107115846.GI652@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Jesse Barnes List-Id: intel-gfx@lists.freedesktop.org T24gMDcvMDEvMTYgMTE6NTgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUaHUsIEphbiAwNywg MjAxNiBhdCAxMDoyMDo1MEFNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gVGhlcmUgYXJl IGEgbnVtYmVyIG9mIHBsYWNlcyB3aGVyZSB0aGUgZHJpdmVyIG5lZWRzIGEgcmVxdWVzdCwgYnV0 IGlzbid0Cj4+IHdvcmtpbmcgb24gYmVoYWxmIG9mIGFueSBzcGVjaWZpYyB1c2VyIG9yIGluIGEg c3BlY2lmaWMgY29udGV4dC4gQXQKPj4gcHJlc2VudCwgd2UgYXNzb2NpYXRlIHRoZW0gd2l0aCB0 aGUgcGVyLWVuZ2luZSBkZWZhdWx0IGNvbnRleHQuIEEgZnV0dXJlCj4+IHBhdGNoIHdpbGwgYWJv bGlzaCB0aG9zZSBwZXItZW5naW5lIGNvbnRleHQgcG9pbnRlcnM7IGJ1dCB3ZSBjYW4gYWxyZWFk eQo+PiBlbGltaW5hdGUgYSBsb3Qgb2YgdGhlIHJlZmVyZW5jZXMgdG8gdGhlbSwganVzdCBieSBt YWtpbmcgdGhlIGFsbG9jYXRvcgo+PiBhbGxvdyBOVUxMIGFzIGEgc2hvcnRoYW5kIGZvciAiYW4g YXBwcm9wcmlhdGUgY29udGV4dCBmb3IgdGhpcyByaW5nIiwKPj4gd2hpY2ggd2lsbCBtZWFuIHRo YXQgdGhlIGNhbGxlcnMgZG9uJ3QgbmVlZCB0byBrbm93IGFueXRoaW5nIGFib3V0IGhvdwo+PiB0 aGUgImFwcHJvcHJpYXRlIGNvbnRleHQiIGlzIGZvdW5kIChlLmcuIHBlci1yaW5nIHZzIHBlci1k ZXZpY2UsIGV0YykuCj4+Cj4+IFNvIHRoaXMgcGF0Y2ggcmVuYW1lcyB0aGUgZXhpc3RpbmcgaTkx NV9nZW1fcmVxdWVzdF9hbGxvYygpLCBhbmQgbWFrZXMKPj4gaXQgbG9jYWwgKHN0YXRpYyBpbmxp bmUpLCBhbmQgcmVwbGFjZXMgaXQgd2l0aCBhIHdyYXBwZXIgdGhhdCBwcm92aWRlcwo+PiBhIGRl ZmF1bHQgaWYgdGhlIGNvbnRleHQgaXMgTlVMTCwgYW5kIGFsc28gaGFzIGEgbmljZXIgY2FsbGlu Zwo+PiBjb252ZW50aW9uIChkb2Vzbid0IHJlcXVpcmUgYSBwb2ludGVyIHRvIGFuIG91dHB1dCBw YXJhbWV0ZXIpLiBUaGVuIHdlCj4+IGNoYW5nZSBhbGwgY2FsbGVycyB0byB1c2UgdGhlIG5ldyBj b252ZW50aW9uOgo+PiBPTEQ6Cj4+IAllcnIgPSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHJpbmcs IHVzZXJfY3R4LCAmcmVxKTsKPj4gCWlmIChlcnIpIC4uLgo+PiBORVc6Cj4+IAlyZXEgPSBpOTE1 X2dlbV9yZXF1ZXN0X2FsbG9jKHJpbmcsIHVzZXJfY3R4KTsKPj4gCWlmIChJU19FUlIocmVxKSkg Li4uCj4+IE9MRDoKPj4gCWVyciA9IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2MocmluZywgcmluZy0+ ZGVmYXVsdF9jb250ZXh0LCAmcmVxKTsKPj4gCWlmIChlcnIpIC4uLgo+PiBORVc6Cj4+IAlyZXEg PSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHJpbmcsIE5VTEwpOwo+PiAJaWYgKElTX0VSUihyZXEp KSAuLi4KPgo+IE5hay4gWW91IGhhdmVuJ3QgZml4ZWQgaTkxNV9nZW1fcmVxdWVzdF9hbGxvYygp IGF0IGFsbC4KPgo+IGh0dHA6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+aWNrbGUvbGludXgtMi42 L2NvbW1pdC8/aD1icmVhZGNydW1icyZpZD04MmM3MmUxYTJiNDM4NWYwYWIwN2RjY2VlNDVhY2Vm MzgzMDNlOTZmCj4gaXMgdGhlIHBhdGNoIEkgaGF2ZSBiZWVuIGNhcnJ5aW5nIGV2ZXIgc2luY2Uu Cj4gLUNocmlzCgpJIHRoaW5rIHlvdSdsbCBmaW5kIHRoYXQgdGhlIHZlcnNpb24gb2YgaTkxNV9n ZW1fcmVxdWVzdF9hbGxvYygpIEkndmUgCmltcGxlbWVudGVkIGlzIGVxdWl2YWxlbnQgdG8geW91 cnMsIHdpdGggdGhlICphZGRpdGlvbmFsKiAoYW5kIGJldHRlcikgCnNlbWFudGljIG9mIG5vdCBy ZXF1aXJpbmcgdGhlIGNhbGxlciB0byBzcGVjaWZ5IChyaW5nLT5kZWZhdWx0X3BhcmFtKSBhcyAK dGhlIGNvbnRleHQgcGFyYW1ldGVyICh3aGljaCBpcyB0aGUgbWFpbiBwb2ludCwgYXMgZmFyIGFz IEknbSBjb25jZXJuZWQ7IAptYWtpbmcgdGhlIGNhbGxpbmcgY29udmVudGlvbiBuaWNlciB3YXMg anVzdCBpbmNpZGVudGFsKS4KCipNSU5FKjoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmggCmIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAppbmRleCBj NmRkNGRiLi5jMmIwMDBhIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKQEAgLTIyNjAsOSArMjI2 MCw5IEBAIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCB7CgogIH07CgotaW50IGk5MTVfZ2Vt X3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKLQkJCSAgIHN0cnVj dCBpbnRlbF9jb250ZXh0ICpjdHgsCi0JCQkgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3Qg KipyZXFfb3V0KTsKK3N0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqIF9fbXVzdF9jaGVjawor aTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCisJ CSAgICAgICBzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY3R4KTsKICB2b2lkIGk5MTVfZ2VtX3JlcXVl c3RfY2FuY2VsKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKTsKICB2b2lkIGk5MTVf Z2VtX3JlcXVlc3RfZnJlZShzdHJ1Y3Qga3JlZiAqcmVxX3JlZik7CiAgaW50IGk5MTVfZ2VtX3Jl cXVlc3RfYWRkX3RvX2NsaWVudChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKLi4u CgoqWU9VUlMqOgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVx dWVzdC5oIApiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaAppbmRleCAw ODY5NTA1Li4yZGE5ZTBiIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9yZXF1ZXN0LmgKKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5o CkBAIC0xMTgsOSArMTE4LDkgQEAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0IHsKICAJaW50 IGVsc3Bfc3VibWl0dGVkOwogIH07CgotaW50IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqcmluZywKLQkJCSAgIHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHgs Ci0JCQkgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKipyZXFfb3V0KTsKK3N0cnVjdCBk cm1faTkxNV9nZW1fcmVxdWVzdCAqCitpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKnJpbmcsCisJCSAgICAgICBzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY3R4KTsK ICB2b2lkIGk5MTVfZ2VtX3JlcXVlc3RfY2FuY2VsKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVz dCAqcmVxKTsKICBpbnQgaTkxNV9nZW1fcmVxdWVzdF9hZGRfdG9fY2xpZW50KHN0cnVjdCBkcm1f aTkxNV9nZW1fcmVxdWVzdCAqcmVxLAogIAkJCQkgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpOwou Li4KCllvdSBzZWVtIHRvIGhhdmUgZG9uZSBFWEFDVExZIFRIRSBTQU1FIHRyYW5zZm9ybWF0aW9u IG9mIHRoZSBmdW5jdGlvbiAKc2lnbmF0dXJlIChleGNlcHQgSSByZW1lbWJlcmVkIHRvIGFkZCBf X211c3RfY2hlY2ssIGFuZCB3cm90ZSBzb21lIAprZXJuZWxkb2MgZm9yIGl0KSwgc28gd2hhdCdz IG5vdCB0byBsaWtlPwoKSSBoYXZlbid0IGRvbmUgYW55dGhpbmcgdG8ge19ffWk5MTVfZ2VtX29i amVjdF9zeW5jKCksIGJ1dCB0aGF0J3MgYSAKc2VwYXJhdGUgaXNzdWUgdGhhdCB5b3UgY2FuIGZp eCBvbiB0b3Agb2YgdGhpcy4KCi5EYXZlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK