From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH] drm/i915/guc: Fix a memory leak where
 guc->execbuf_client is not freed
Date: Tue, 12 Jan 2016 12:11:56 +0000
Message-ID: <5694ED8C.9070603@intel.com>
References: <1452113637-12981-1-git-send-email-yu.dai@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 421176E2BD
 for <intel-gfx@lists.freedesktop.org>; Tue, 12 Jan 2016 04:11:58 -0800 (PST)
In-Reply-To: <1452113637-12981-1-git-send-email-yu.dai@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: yu.dai@intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMDYvMDEvMTYgMjA6NTMsIHl1LmRhaUBpbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogQWxleCBE
YWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4KPiBEdXJpbmcgZHJpdmVyIHVubG9hZGluZywgdGhlIGd1
Y19jbGllbnQgY3JlYXRlZCBmb3IgY29tbWFuZCBzdWJtaXNzaW9uCj4gbmVlZHMgdG8gYmUgcmVs
ZWFzZWQgdG8gYXZvaWQgbWVtb3J5IGxlYWsuCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbGV4IERhaSA8
eXUuZGFpQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3Vj
X3N1Ym1pc3Npb24uYyB8IDMgKysrCj4gICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp
Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv
bi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXgg
OWMyNDQyNC4uOGNlNGYzMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2d1Y19zdWJtaXNzaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19z
dWJtaXNzaW9uLmMKPiBAQCAtOTk1LDYgKzk5NSw5IEBAIHZvaWQgaTkxNV9ndWNfc3VibWlzc2lv
bl9maW5pKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgIAlzdHJ1Y3QgaW50ZWxfZ3VjICpn
dWMgPSAmZGV2X3ByaXYtPmd1YzsKPgo+ICsJaWYgKGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9u
KQo+ICsJCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShkZXYpOwo+ICsKPiAgIAlnZW1fcmVs
ZWFzZV9ndWNfb2JqKGRldl9wcml2LT5ndWMuYWRzX29iaik7Cj4gICAJZ3VjLT5hZHNfb2JqID0g
TlVMTDsKClRoaXMgbG9va3MgbGlrZSB0aGUgcmlnaHQgdGhpbmcgdG8gZG8sIGJ1dCB0aGUgd3Jv
bmcgcGxhY2UgdG8gZG8gaXQuCgppOTE1X2d1Y19zdWJtaXNzaW9uX3tpbml0LGVuYWJsZSxkaXNh
YmxlLGZpbml9IGFyZSB0aGUgdG9wLWxldmVsIApmdW5jdGlvbnMgZXhwb3J0ZWQgZnJvbSB0aGlz
IHNvdXJjZSBmaWxlIGFuZCBjYWxsZWQgKG9ubHkpIGZyb20gCmludGVsX2d1Y19sb2FkZXIuYwoK
VGhlcmVmb3JlLCB0aGUgY29kZSBpbiBpbnRlbF9ndWNfdWNvZGVfZmluaSgpIHNob3VsZCBjYWxs
IApzdWJtaXNzaW9uX2Rpc2FibGUoKSBiZWZvcmUgc3VibWlzc2lvbl9maW5pKCksIGxpa2UgdGhp
czoKCi8qKgogICogaW50ZWxfZ3VjX3Vjb2RlX2ZpbmkoKSAtIGNsZWFuIHVwIGFsbCBhbGxvY2F0
ZWQgcmVzb3VyY2VzCiAgKiBAZGV2OiAgICAgICAgZHJtIGRldmljZQogICovCnZvaWQgaW50ZWxf
Z3VjX3Vjb2RlX2Zpbmkoc3RydWN0IGRybV9kZXZpY2UgKmRldikKewogICAgICAgICBzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwogICAgICAgICBz
dHJ1Y3QgaW50ZWxfZ3VjX2Z3ICpndWNfZncgPSAmZGV2X3ByaXYtPmd1Yy5ndWNfZnc7CgogICAg
ICAgICBkaXJlY3RfaW50ZXJydXB0c190b19ob3N0KGRldl9wcml2KTsKKwlpOTE1X2d1Y19zdWJt
aXNzaW9uX2Rpc2FibGUoZGV2KTsKCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShkZXYpOwoKICAg
ICAgICAgbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwogICAgICAgICBpZiAoZ3VjX2Z3
LT5ndWNfZndfb2JqKQogICAgICAgICAgICAgICAgIGRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNl
KCZndWNfZnctPmd1Y19md19vYmotPmJhc2UpOwogICAgICAgICBndWNfZnctPmd1Y19md19vYmog
PSBOVUxMOwogICAgICAgICBtdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKCiAgICAg
ICAgIGd1Y19mdy0+Z3VjX2Z3X2ZldGNoX3N0YXR1cyA9IEdVQ19GSVJNV0FSRV9OT05FOwp9CgpU
aGVyZSdzIG5vIG5lZWQgZm9yIGl0IHRvIGJlIGNvbmRpdGlvbmFsLCBhcyBkaXNhYmxlIChhbmQg
ZmluaSkgYXJlIAppZGVtcG90ZW50OyBpZiBhIHRoaW5nIGhhc24ndCBiZWVuIGFsbG9jYXRlZCwg
b3IgaGFzIGFscmVhZHkgYmVlbiAKZGVhbGxvY2F0ZWQsIHRoZW4gdGhlc2UgZnVuY3Rpb25zIHdp
bGwganVzdCBkbyBub3RoaW5nLgoKSE9XRVZFUiwKCndoaWxlIHJldmlld2luZyB0aGlzIEkndmUg
bm90aWNlZCB0aGF0IHRoZSBsb2NraW5nIGlzIGFsbCBzY3Jld2VkIHVwOyAKYmFzaWNhbGx5ICJi
ZjI0OGNhIGRybS9pOTE1OiBGaXggbG9ja2luZyBhcm91bmQgR3VDIGZpcm13YXJlIGxvYWQiCnJl
bW92ZWQgbG9ja2luZyByb3VuZCB0aGUgY2FsbHMgaW50byBpOTE1X2d1Y19sb2FkZXIuYyBhbmQg
YWRkZWQgaXQgYmFjayAKaW4gYSBmZXcgcGxhY2VzLCBidXQgbm90IGVub3VnaC4KCkl0IHdvdWxk
IHByb2JhYmx5IGhhdmUgYmVlbiBiZXR0ZXIgdG8gaGF2ZSBsZWZ0IHRoZSBsb2NraW5nIGluIHRo
ZSAKY2FsbGVyLCBhbmQgaGVuY2Ugcm91bmQgdGhlIGVudGlyZXR5IG9mIHRoZSBjYWxscyB0byBf
aW5pdCwgX2xvYWQsIApfZmluaSwgYW5kIHRoZW4gZXhwbGljaXRseSBEUk9QIHRoZSBtdXRleCBv
bmx5IGZvciB0aGUgZHVyYXRpb24gb2YgdGhlIApyZXF1ZXN0X2Zpcm13YXJlIGNhbGwuCgpJdCB3
b3VsZCBoYXZlIGJlZW4gYmV0dGVyIHN0aWxsIG5vdCB0byBpbnNpc3Qgb24gc3luY2hyb25vdXMg
ZmlybXdhcmUgCmxvYWQgaW4gdGhlIGZpcnN0IHBsYWNlOyB0aGUgb3JpZ2luYWwgZ2VuZXJpYyAo
YW5kIGFzeW5jaHJvbm91cykgbG9hZGVyIApkaWRuJ3QgcmVxdWlyZSBzdHJ1Y3RfbXV0ZXggb3Ig
YW55IG90aGVyIGxvY2tpbmcgYXJvdW5kIHRoZSAKcmVxdWVzdF9maXJtd2FyZSgpIGNhbGwsIHNv
IHdlIHdvdWxkbid0IG5vdyBoYXZlIHRvIGZpeCBpdCAoYWdhaW4pLgoKQXQgcHJlc2VudCwgaW4g
aW50ZWxfZ3VjX2xvYWRlci5jLCBpbnRlbF9ndWNfdWNvZGVfbG9hZCgpIGlzIGNhbGxlZCB3aXRo
IAp0aGUgc3RydWN0X211dGV4IGFscmVhZHkgaGVsZCBieSB0aGUgY2FsbGVyLCBidXQgX2luaXQo
KSBhbmQgX2ZpbmkoKSBhcmUgCmNhbGxlZCB3aXRoIGl0IE5PVCBoZWxkLgoKQWxsIGV4cG9ydGVk
IGZ1bmN0aW9ucyBpbiBpOTE1X2d1Y19zdWJtaXNzaW9uLmMgZXhwZWN0IGl0IHRvIGJlIGhlbGQg
CndoZW4gdGhleSdyZSBjYWxsZWQuCgpPbiB0aGF0IGJhc2lzLCB3aGF0IHdlIG5lZWQgbm93IGlz
OgoKZ3VjX2Z3X2ZldGNoKCkgbmVlZHMgdG8gdGFrZSAmIHJlbGVhc2UgdGhlIG11dGV4IHJvdW5k
IHRoZSB1bnJlZmVyZW5jZSAKaW4gdGhlIGZhaWw6IHBhdGggKGxpa2UgdGhlIGNvZGUgaW4gX2Zp
bmkgYWJvdmUpLgoKaW50ZWxfZ3VjX3Vjb2RlX2ZpbmkoKSBuZWVkcyB0byBleHRlbmQgdGhlIHNj
b3BlIG9mIHRoZSBsb2NrIHRvIGVuY2xvc2UgCmFsbCBjYWxscyB0byBfc3VibWlzc2lvbl8gZnVu
Y3Rpb25zLiBTbyB0aGUgYWJvdmUgYmVjb21lczoKCi8qKgoqIGludGVsX2d1Y191Y29kZV9maW5p
KCkgLSBjbGVhbiB1cCBhbGwgYWxsb2NhdGVkIHJlc291cmNlcwoqIEBkZXY6IGRybSBkZXZpY2UK
Ki8Kdm9pZCBpbnRlbF9ndWNfdWNvZGVfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQp7Cglz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwoJc3Ry
dWN0IGludGVsX2d1Y19mdyAqZ3VjX2Z3ID0gJmRldl9wcml2LT5ndWMuZ3VjX2Z3OwoKCW11dGV4
X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKCWRpcmVjdF9pbnRlcnJ1cHRzX3RvX2hvc3QoZGV2
X3ByaXYpOwoJaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKGRldik7CglpOTE1X2d1Y19zdWJt
aXNzaW9uX2ZpbmkoZGV2KTsKCglpZiAoZ3VjX2Z3LT5ndWNfZndfb2JqKQoJCWRybV9nZW1fb2Jq
ZWN0X3VucmVmZXJlbmNlKCZndWNfZnctPmd1Y19md19vYmotPmJhc2UpOwoJZ3VjX2Z3LT5ndWNf
Zndfb2JqID0gTlVMTDsKCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwoKCWd1Y19m
dy0+Z3VjX2Z3X2ZldGNoX3N0YXR1cyA9IEdVQ19GSVJNV0FSRV9OT05FOwp9CgpGSU5BTExZLAoK
aW50ZWxfZ3VjX3Vjb2RlX2xvYWQoKSBzaG91bGQgcHJvYmFibHkgY2FsbCBpOTE1X2d1Y19zdWJt
aXNzaW9uX2ZpbmkoKSAKaW4gdGhlIGZhaWx1cmUgcGF0aCAoYWZ0ZXIgc3VibWlzc2lvbl9kaXNh
YmxlKCkpIGFzIGl0IGNhbGxlZCAKc3VibWlzc2lvbl9pbml0KCkgZWFybGllci4gTm90IGNyaXRp
Y2FsLCBhcyBpdCB3aWxsIGdldCBjYWxsZWQgZnJvbSAKdWNvZGVfZmluaSgpIGFueXdheSwgYnV0
IGl0IGltcHJvdmVzIHN5bW1ldHJ5LgoKLkRhdmUuCl9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp
c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4Cg==