From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Dai Subject: Re: [PATCH] drm/i915/guc: Fix a memory leak where guc->execbuf_client is not freed Date: Tue, 12 Jan 2016 14:57:28 -0800 Message-ID: <569584D8.9080203@intel.com> References: <1452113637-12981-1-git-send-email-yu.dai@intel.com> <5694ED8C.9070603@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F7CB6E30A for ; Tue, 12 Jan 2016 15:01:09 -0800 (PST) In-Reply-To: <5694ED8C.9070603@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwMS8xMi8yMDE2IDA0OjExIEFNLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAwNi8wMS8x NiAyMDo1MywgeXUuZGFpQGludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IEFsZXggRGFpIDx5dS5k YWlAaW50ZWwuY29tPgo+ID4KPiA+IER1cmluZyBkcml2ZXIgdW5sb2FkaW5nLCB0aGUgZ3VjX2Ns aWVudCBjcmVhdGVkIGZvciBjb21tYW5kIHN1Ym1pc3Npb24KPiA+IG5lZWRzIHRvIGJlIHJlbGVh c2VkIHRvIGF2b2lkIG1lbW9yeSBsZWFrLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEFsZXggRGFp IDx5dS5kYWlAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDMgKysrCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2Vy dGlvbnMoKykKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n dWNfc3VibWlzc2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv bi5jCj4gPiBpbmRleCA5YzI0NDI0Li44Y2U0ZjMyIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiA+IEBAIC05OTUsNiArOTk1LDkgQEAgdm9p ZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Zpbmkoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAg CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4g PiAgIAlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmZGV2X3ByaXYtPmd1YzsKPiA+Cj4gPiArCWlm IChpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbikKPiA+ICsJCWk5MTVfZ3VjX3N1Ym1pc3Npb25f ZGlzYWJsZShkZXYpOwo+ID4gKwo+ID4gICAJZ2VtX3JlbGVhc2VfZ3VjX29iaihkZXZfcHJpdi0+ Z3VjLmFkc19vYmopOwo+ID4gICAJZ3VjLT5hZHNfb2JqID0gTlVMTDsKPgo+IFRoaXMgbG9va3Mg bGlrZSB0aGUgcmlnaHQgdGhpbmcgdG8gZG8sIGJ1dCB0aGUgd3JvbmcgcGxhY2UgdG8gZG8gaXQu Cj4KPiBpOTE1X2d1Y19zdWJtaXNzaW9uX3tpbml0LGVuYWJsZSxkaXNhYmxlLGZpbml9IGFyZSB0 aGUgdG9wLWxldmVsCj4gZnVuY3Rpb25zIGV4cG9ydGVkIGZyb20gdGhpcyBzb3VyY2UgZmlsZSBh bmQgY2FsbGVkIChvbmx5KSBmcm9tCj4gaW50ZWxfZ3VjX2xvYWRlci5jCj4KPiBUaGVyZWZvcmUs IHRoZSBjb2RlIGluIGludGVsX2d1Y191Y29kZV9maW5pKCkgc2hvdWxkIGNhbGwKPiBzdWJtaXNz aW9uX2Rpc2FibGUoKSBiZWZvcmUgc3VibWlzc2lvbl9maW5pKCksIGxpa2UgdGhpczoKPgo+IC8q Kgo+ICAgICogaW50ZWxfZ3VjX3Vjb2RlX2ZpbmkoKSAtIGNsZWFuIHVwIGFsbCBhbGxvY2F0ZWQg cmVzb3VyY2VzCj4gICAgKiBAZGV2OiAgICAgICAgZHJtIGRldmljZQo+ICAgICovCj4gdm9pZCBp bnRlbF9ndWNfdWNvZGVfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+IHsKPiAgICAgICAg ICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsK PiAgICAgICAgICAgc3RydWN0IGludGVsX2d1Y19mdyAqZ3VjX2Z3ID0gJmRldl9wcml2LT5ndWMu Z3VjX2Z3Owo+Cj4gICAgICAgICAgIGRpcmVjdF9pbnRlcnJ1cHRzX3RvX2hvc3QoZGV2X3ByaXYp Owo+ICsJaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKGRldik7Cj4gCWk5MTVfZ3VjX3N1Ym1p c3Npb25fZmluaShkZXYpOwo+Cj4gICAgICAgICAgIG11dGV4X2xvY2soJmRldi0+c3RydWN0X211 dGV4KTsKPiAgICAgICAgICAgaWYgKGd1Y19mdy0+Z3VjX2Z3X29iaikKPiAgICAgICAgICAgICAg ICAgICBkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmZ3VjX2Z3LT5ndWNfZndfb2JqLT5iYXNl KTsKPiAgICAgICAgICAgZ3VjX2Z3LT5ndWNfZndfb2JqID0gTlVMTDsKPiAgICAgICAgICAgbXV0 ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4KPiAgICAgICAgICAgZ3VjX2Z3LT5ndWNf ZndfZmV0Y2hfc3RhdHVzID0gR1VDX0ZJUk1XQVJFX05PTkU7Cj4gfQo+Cj4gVGhlcmUncyBubyBu ZWVkIGZvciBpdCB0byBiZSBjb25kaXRpb25hbCwgYXMgZGlzYWJsZSAoYW5kIGZpbmkpIGFyZQo+ IGlkZW1wb3RlbnQ7IGlmIGEgdGhpbmcgaGFzbid0IGJlZW4gYWxsb2NhdGVkLCBvciBoYXMgYWxy ZWFkeSBiZWVuCj4gZGVhbGxvY2F0ZWQsIHRoZW4gdGhlc2UgZnVuY3Rpb25zIHdpbGwganVzdCBk byBub3RoaW5nLgoKSSBhZ3JlZS4gV2Ugd2lsbCBrZWVwIHRoZSBzeW1tZXRyeSBoZXJlIAppOTE1 X2d1Y19zdWJtaXNzaW9uX2luaXQoX2VuYWJsZSwgX2Rpc2FibGUgYW5kIF9maW5pKS4KPiBIT1dF VkVSLAo+Cj4gd2hpbGUgcmV2aWV3aW5nIHRoaXMgSSd2ZSBub3RpY2VkIHRoYXQgdGhlIGxvY2tp bmcgaXMgYWxsIHNjcmV3ZWQgdXA7Cj4gYmFzaWNhbGx5ICJiZjI0OGNhIGRybS9pOTE1OiBGaXgg bG9ja2luZyBhcm91bmQgR3VDIGZpcm13YXJlIGxvYWQiCj4gcmVtb3ZlZCBsb2NraW5nIHJvdW5k IHRoZSBjYWxscyBpbnRvIGk5MTVfZ3VjX2xvYWRlci5jIGFuZCBhZGRlZCBpdCBiYWNrCj4gaW4g YSBmZXcgcGxhY2VzLCBidXQgbm90IGVub3VnaC4KPgo+IEl0IHdvdWxkIHByb2JhYmx5IGhhdmUg YmVlbiBiZXR0ZXIgdG8gaGF2ZSBsZWZ0IHRoZSBsb2NraW5nIGluIHRoZQo+IGNhbGxlciwgYW5k IGhlbmNlIHJvdW5kIHRoZSBlbnRpcmV0eSBvZiB0aGUgY2FsbHMgdG8gX2luaXQsIF9sb2FkLAo+ IF9maW5pLCBhbmQgdGhlbiBleHBsaWNpdGx5IERST1AgdGhlIG11dGV4IG9ubHkgZm9yIHRoZSBk dXJhdGlvbiBvZiB0aGUKPiByZXF1ZXN0X2Zpcm13YXJlIGNhbGwuCj4KPiBJdCB3b3VsZCBoYXZl IGJlZW4gYmV0dGVyIHN0aWxsIG5vdCB0byBpbnNpc3Qgb24gc3luY2hyb25vdXMgZmlybXdhcmUK PiBsb2FkIGluIHRoZSBmaXJzdCBwbGFjZTsgdGhlIG9yaWdpbmFsIGdlbmVyaWMgKGFuZCBhc3lu Y2hyb25vdXMpIGxvYWRlcgo+IGRpZG4ndCByZXF1aXJlIHN0cnVjdF9tdXRleCBvciBhbnkgb3Ro ZXIgbG9ja2luZyBhcm91bmQgdGhlCj4gcmVxdWVzdF9maXJtd2FyZSgpIGNhbGwsIHNvIHdlIHdv dWxkbid0IG5vdyBoYXZlIHRvIGZpeCBpdCAoYWdhaW4pLgo+Cj4gQXQgcHJlc2VudCwgaW4gaW50 ZWxfZ3VjX2xvYWRlci5jLCBpbnRlbF9ndWNfdWNvZGVfbG9hZCgpIGlzIGNhbGxlZCB3aXRoCj4g dGhlIHN0cnVjdF9tdXRleCBhbHJlYWR5IGhlbGQgYnkgdGhlIGNhbGxlciwgYnV0IF9pbml0KCkg YW5kIF9maW5pKCkgYXJlCj4gY2FsbGVkIHdpdGggaXQgTk9UIGhlbGQuCj4KPiBBbGwgZXhwb3J0 ZWQgZnVuY3Rpb25zIGluIGk5MTVfZ3VjX3N1Ym1pc3Npb24uYyBleHBlY3QgaXQgdG8gYmUgaGVs ZAo+IHdoZW4gdGhleSdyZSBjYWxsZWQuCj4KPiBPbiB0aGF0IGJhc2lzLCB3aGF0IHdlIG5lZWQg bm93IGlzOgo+Cj4gZ3VjX2Z3X2ZldGNoKCkgbmVlZHMgdG8gdGFrZSAmIHJlbGVhc2UgdGhlIG11 dGV4IHJvdW5kIHRoZSB1bnJlZmVyZW5jZQo+IGluIHRoZSBmYWlsOiBwYXRoIChsaWtlIHRoZSBj b2RlIGluIF9maW5pIGFib3ZlKS4KCkkgcHJlZmVyIHRoZSBjdXJyZW50IGFwcHJvYWNoIHRoYXQg b25seSB0YWtlcyBsb2NrIGZvciBuZWNlc3NhcnkgCmNyaXRpY2FsIHNlc3Npb24uCj4gaW50ZWxf Z3VjX3Vjb2RlX2ZpbmkoKSBuZWVkcyB0byBleHRlbmQgdGhlIHNjb3BlIG9mIHRoZSBsb2NrIHRv IGVuY2xvc2UKPiBhbGwgY2FsbHMgdG8gX3N1Ym1pc3Npb25fIGZ1bmN0aW9ucy4gU28gdGhlIGFi b3ZlIGJlY29tZXM6Cj4KPiAvKioKPiAqIGludGVsX2d1Y191Y29kZV9maW5pKCkgLSBjbGVhbiB1 cCBhbGwgYWxsb2NhdGVkIHJlc291cmNlcwo+ICogQGRldjogZHJtIGRldmljZQo+ICovCj4gdm9p ZCBpbnRlbF9ndWNfdWNvZGVfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+IHsKPiAJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAJc3Ry dWN0IGludGVsX2d1Y19mdyAqZ3VjX2Z3ID0gJmRldl9wcml2LT5ndWMuZ3VjX2Z3Owo+Cj4gCW11 dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAJZGlyZWN0X2ludGVycnVwdHNfdG9faG9z dChkZXZfcHJpdik7Cj4gCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShkZXYpOwo+IAlpOTE1 X2d1Y19zdWJtaXNzaW9uX2ZpbmkoZGV2KTsKPgo+IAlpZiAoZ3VjX2Z3LT5ndWNfZndfb2JqKQo+ IAkJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoJmd1Y19mdy0+Z3VjX2Z3X29iai0+YmFzZSk7 Cj4gCWd1Y19mdy0+Z3VjX2Z3X29iaiA9IE5VTEw7Cj4gCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1 Y3RfbXV0ZXgpOwo+Cj4gCWd1Y19mdy0+Z3VjX2Z3X2ZldGNoX3N0YXR1cyA9IEdVQ19GSVJNV0FS RV9OT05FOwo+IH0KClRoaXMgaXMgZG9uZSBieSBwYXRjaCBodHRwczovL3BhdGNod29yay5mcmVl ZGVza3RvcC5vcmcvcGF0Y2gvNjg3MDgvLiAKUGxlYXNlIHJldmlldyB0aGlzIG9uZS4KPiBGSU5B TExZLAo+Cj4gaW50ZWxfZ3VjX3Vjb2RlX2xvYWQoKSBzaG91bGQgcHJvYmFibHkgY2FsbCBpOTE1 X2d1Y19zdWJtaXNzaW9uX2ZpbmkoKQo+IGluIHRoZSBmYWlsdXJlIHBhdGggKGFmdGVyIHN1Ym1p c3Npb25fZGlzYWJsZSgpKSBhcyBpdCBjYWxsZWQKPiBzdWJtaXNzaW9uX2luaXQoKSBlYXJsaWVy LiBOb3QgY3JpdGljYWwsIGFzIGl0IHdpbGwgZ2V0IGNhbGxlZCBmcm9tCj4gdWNvZGVfZmluaSgp IGFueXdheSwgYnV0IGl0IGltcHJvdmVzIHN5bW1ldHJ5Lgo+Cj4KCldlIGRvbid0IGhhdmUgdWNv ZGVfdW5sb2FkKCkuIFRoZSB1Y29kZV9maW5pKCkgaXMgYWN0dWFsbHkgZG9pbmcgdGhlIAp1bmxv YWQgam9iLiBCZWNhdXNlIHVjb2RlX2ZpbmkoKSBuZWVkcyB0byBhY3F1aXJlIHRoZSBsb2NrIGJ1 dCAKdWNvZGVfbG9hZCgpIGV4cGVjdHMgdGhhdCBsb2NrIGlzIGhlbGQgYnkgY2FsbGVyLCBjYWxs aW5nIHVjb2RlX2ZpbmkoKSAKaW5zaWRlIHVjb2RlX2xvYWQoKSBpcyBub3QgZ29vZC4gSSBkb24n dCB0aGluayBpdCBpcyB3b3J0aCB0byB3cmFwIHVwIGEgCnVjb2RlX3VubG9hZCgpIGNhbGwgd2hp Y2ggb25seSBpbmNsdWRlcyB0d28gbGluZXMgCihkaXJlY3RfaW50ZXJydXB0c190b19ob3N0IGFu ZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUpLgoKVGhhbmtzLApBbGV4Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==