[PATCH 0/3] LPSS PWM support for devices that support it

[PATCH 0/3] LPSS PWM support for devices that support it

[Shobhit Kumar]

Hi,
This is an untested attempt to enable LPSS PWM in the driver. As part
of this did some restructuring for encapsulating the pwm_info inside the
panel->backlight itself. This makes enabling LPSS PWM clean and simple.

Not sending yet to pwm mailing list as this is all untested. C.B. please
test the patches and see if they work at all for you. For testing Please
enable -

CONFIG_PWM_LPSS=y
CONFIG_PWM_LPSS_PLATFORM=y

Regards
Shobhit

Shobhit Kumar (3):
  drm/i915: Encapsulate the pwm_device in a pwm_info structure
  pwm: lpss: Add intel-gfx as consumer device in lookup table
  drm/i915: Add support for LPSS PWM on devices that support it

 drivers/gpu/drm/i915/intel_drv.h   |  8 +++++-
 drivers/gpu/drm/i915/intel_panel.c | 59 +++++++++++++++++++++++++++-----------
 drivers/pwm/pwm-lpss-platform.c    |  8 ++++++
 3 files changed, 57 insertions(+), 18 deletions(-)

-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/3] LPSS PWM support for devices that support it

[C. B.]

On 12 January 2016 at 08:59, Shobhit Kumar <shobhit.kumar@intel.com> wrote:

> Not sending yet to pwm mailing list as this is all untested. C.B. please
> test the patches and see if they work at all for you. For testing Please
> enable -
>
> CONFIG_PWM_LPSS=y
> CONFIG_PWM_LPSS_PLATFORM=y

I applied these patches to 4.4-rc8. So far no progress:

[   14.251512] [drm:pwm_setup_backlight [i915]] *ERROR* Failed to own
the pwm chip: pm_backlight

I dug in a little and found that dev_priv->vbt.dsi.config->pwm_blc ==
0,  I wonder if some of these Dell Venue's have different hardware?
This is the model I have:

[   16.370481] Hardware name: Dell Inc. Venue 8 Pro 5830/09RP78, BIOS
A13 11/27/2015

Let me know what I can provide to help

CB
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/3] LPSS PWM support for devices that support it

[Kumar, Shobhit]

On 01/13/2016 11:00 AM, C. B. wrote:
> On 12 January 2016 at 08:59, Shobhit Kumar <shobhit.kumar@intel.com> wrote:
>
>> Not sending yet to pwm mailing list as this is all untested. C.B. please
>> test the patches and see if they work at all for you. For testing Please
>> enable -
>>
>> CONFIG_PWM_LPSS=y
>> CONFIG_PWM_LPSS_PLATFORM=y
>
> I applied these patches to 4.4-rc8. So far no progress:
>
> [   14.251512] [drm:pwm_setup_backlight [i915]] *ERROR* Failed to own
> the pwm chip: pm_backlight

Are you sure this is pm_backlight, it should have printed pwm_backlight 
as that is the name for the PMIC bases PWM. I checked the code and I 
have not made a typo there.

>
> I dug in a little and found that dev_priv->vbt.dsi.config->pwm_blc ==
> 0,  I wonder if some of these Dell Venue's have different hardware?
> This is the model I have:
>

This means that this device is using PMIC base PWM and not LPSS. I have 
heard from Brain, that my CRC PWM driver is also broken in latest kernel 
which should be probably used in this device. I am looking into that 
separately.

Regards
Shobhit

> [   16.370481] Hardware name: Dell Inc. Venue 8 Pro 5830/09RP78, BIOS
> A13 11/27/2015
>
> Let me know what I can provide to help
>
> CB
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/3] LPSS PWM support for devices that support it

[Luka Karinja]

[-- Attachment #1.1: Type: text/plain, Size: 445 bytes --]

Hello
> Hi,
> This is an untested attempt to enable LPSS PWM in the driver. As part
> of this did some restructuring for encapsulating the pwm_info inside the
> panel->backlight itself. This makes enabling LPSS PWM clean and simple.
>
I did try it on my Asus T100 TAF without success.
The error in dmesg:
[    1.204866] [drm:pwm_setup_backlight [i915]] *ERROR* Failed to own 
the pwm chip: pwm_lpss

how can i further debug it for you?

Thanks


[-- Attachment #1.2: Type: text/html, Size: 996 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx