From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v3 4/7] drm/atomic: Fix atomic helpers to
	use the new iterator macros.
Date: Tue, 17 Jan 2017 03:01:57 +0200
Message-ID: <5696725.2aGLkINkpF@avalon>
References: <1484559464-27107-1-git-send-email-maarten.lankhorst@linux.intel.com>
 <1484559464-27107-5-git-send-email-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1484559464-27107-5-git-send-email-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

SGkgTWFhcnRlbiwKCihDQydpbmcgRGFuaWVsKQoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpP
biBNb25kYXkgMTYgSmFuIDIwMTcgMTA6Mzc6NDEgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4g
U2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4
LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMg
fCAyOTMgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs
IDE1MiBpbnNlcnRpb25zKCspLCAxNDEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vZHJt
X2F0b21pY19oZWxwZXIuYyBpbmRleCBkMTUzZThhNzI5MjEuLmIyNmNmNzg2Y2UxMgo+IDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKCltzbmlwXQoKPiBAQCAtMjQ1LDIyICsy
NDYsMjIgQEAgc3RlYWxfZW5jb2RlcihzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4g
IHsKPiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiAgCXN0cnVjdCBkcm1f
Y29ubmVjdG9yICpjb25uZWN0b3I7Cj4gLQlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29u
bmVjdG9yX3N0YXRlOwo+ICsJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKm9sZF9jb25uZWN0
b3Jfc3RhdGUsICpuZXdfY29ubmVjdG9yX3N0YXRlOwoKVGhlIGtlcm5lbCBmYXZvdXJzIG9uZSB2
YXJpYWJsZSBkZWNsYXJhdGlvbiBwZXIgbGluZSwgYW5kIEkgdGhpbmsgdGhpcyBmaWxlIApkb2Vz
IGFzIHdlbGwsIGF0IGxlYXN0IG1vc3RseSAodGhpcyBjb21tZW50IGhvbGRzIGZvciB0aGUgcmVz
dCBvZiB0aGlzIHBhdGNoIAphbmQgdGhlIG90aGVyIHBhdGNoZXMgaW4gdGhlIHNlcmllcykuCgo+
ICAJaW50IGk7Cj4gCj4gLQlmb3JfZWFjaF9jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNvbm5l
Y3RvciwgY29ubmVjdG9yX3N0YXRlLCBpKSB7Cj4gKwlmb3JfZWFjaF9vbGRuZXdfY29ubmVjdG9y
X2luX3N0YXRlKHN0YXRlLCBjb25uZWN0b3IsCj4gb2xkX2Nvbm5lY3Rvcl9zdGF0ZSwgbmV3X2Nv
bm5lY3Rvcl9zdGF0ZSwgaSkgewoKVGhpcyBpcyBnZXR0aW5nIHF1aXRlIGxvbmcsIHlvdSBjb3Vs
ZCB3cmFwIHRoZSBsaW5lLgoKPiAJCXN0cnVjdCBkcm1fY3J0YyAqZW5jb2Rlcl9jcnRjOwo+IAo+
IC0JCWlmIChjb25uZWN0b3Jfc3RhdGUtPmJlc3RfZW5jb2RlciAhPSBlbmNvZGVyKQo+ICsJCWlm
IChuZXdfY29ubmVjdG9yX3N0YXRlLT5iZXN0X2VuY29kZXIgIT0gZW5jb2RlcikKPiAgCQkJY29u
dGludWU7Cj4gCj4gLQkJZW5jb2Rlcl9jcnRjID0gY29ubmVjdG9yLT5zdGF0ZS0+Y3J0YzsKPiAr
CQllbmNvZGVyX2NydGMgPSBvbGRfY29ubmVjdG9yX3N0YXRlLT5jcnRjOwo+IAo+ICAJCURSTV9E
RUJVR19BVE9NSUMoIltFTkNPREVSOiVkOiVzXSBpbiB1c2Ugb24gW0NSVEM6JWQ6JXNdLCAKc3Rl
YWxpbmcgaXRcbiIsCj4gZW5jb2Rlci0+YmFzZS5pZCwgZW5jb2Rlci0+bmFtZSwKPiAgCQkJCSBl
bmNvZGVyX2NydGMtPmJhc2UuaWQsIGVuY29kZXJfY3J0Yy0+bmFtZSk7Cj4gCj4gLQkJc2V0X2Jl
c3RfZW5jb2RlcihzdGF0ZSwgY29ubmVjdG9yX3N0YXRlLCBOVUxMKTsKPiArCQlzZXRfYmVzdF9l
bmNvZGVyKHN0YXRlLCBuZXdfY29ubmVjdG9yX3N0YXRlLCBOVUxMKTsKPiAKPiAgCQljcnRjX3N0
YXRlID0gZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY3J0Y19zdGF0ZShzdGF0ZSwgCmVuY29kZXJf
Y3J0Yyk7Cj4gIAkJY3J0Y19zdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkID0gdHJ1ZTsKCltzbmlw
XQoKPiBAQCAtNTE2LDE0ICs1MTgsMTUgQEAgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfbW9kZXNl
dChzdHJ1Y3QgZHJtX2RldmljZQo+ICpkZXYsIGlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAK
PiAtCWZvcl9lYWNoX2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0ZSwgY29ubmVjdG9yLCBjb25uZWN0
b3Jfc3RhdGUsIGkpIHsKPiArCWZvcl9lYWNoX29sZG5ld19jb25uZWN0b3JfaW5fc3RhdGUoc3Rh
dGUsIGNvbm5lY3RvciwKPiBvbGRfY29ubmVjdG9yX3N0YXRlLCBuZXdfY29ubmVjdG9yX3N0YXRl
LCBpKSB7CgpMaW5lIHdyYXAgaGVyZSB0b28gPwoKPiAJCS8qCj4gIAkJICogVGhpcyBvbmx5IHNl
dHMgY3J0Yy0+Y29ubmVjdG9yc19jaGFuZ2VkIGZvciByb3V0aW5nIApjaGFuZ2VzLAo+ICAJCSAq
IGRyaXZlcnMgbXVzdCBzZXQgY3J0Yy0+Y29ubmVjdG9yc19jaGFuZ2VkIHRoZW1zZWx2ZXMgd2hl
bgo+ICAJCSAqIGNvbm5lY3RvciBwcm9wZXJ0aWVzIG5lZWQgdG8gYmUgdXBkYXRlZC4KPiAgCQkg
Ki8KPiAgCQlyZXQgPSB1cGRhdGVfY29ubmVjdG9yX3JvdXRpbmcoc3RhdGUsIGNvbm5lY3RvciwK
PiAtCQkJCQkgICAgICAgY29ubmVjdG9yX3N0YXRlKTsKPiArCQkJCQkgICAgICAgb2xkX2Nvbm5l
Y3Rvcl9zdGF0ZSwKPiArCQkJCQkgICAgICAgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSk7Cj4gIAkJaWYg
KHJldCkKPiAgCQkJcmV0dXJuIHJldDsKPiAgCX0KCltzbmlwXQoKPiBAQCAtNTk5LDE1ICs2MDIs
MTUgQEAgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVzKHN0cnVjdCBkcm1fZGV2aWNlICpk
ZXYsCj4gc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpj
cnRjX3N0YXRlOwo+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gLQlzdHJ1Y3QgZHJtX3Bs
YW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBsYW5l
X3N0YXRlLCAqb2xkX3BsYW5lX3N0YXRlOwoKSW4gc29tZSBsb2NhdGlvbiB5b3UgdXNlIG5ld18q
X3N0YXRlIGFuZCBpbiBvdGhlcnMgKl9zdGF0ZS4gSSBiZWxpZXZlIHRoaXMgCnNob3VsZCB0aGlz
IGJlIHN0YW5kYXJkaXplZCB0byBhdm9pZCBjb25mdXNpb24gKHRoZSBjb2RlIGlzIGhhcmQgZW5v
dWdoIHRvIApyZWFkIGFzIGl0IGlzIDotKSkuCgpTaW1pbGFybHksIHlvdSBzb21ldGltZXMgdXNl
ICpfY29ubl9zdGF0ZSBhbmQgc29tZXRpbWVzICpfY29ubmVjdG9yX3N0YXRlLiAKVGhhdCBzaG91
bGQgYmUgc3RhbmRhcmRpemVkIGFzIHdlbGwuCgo+ICAJaW50IGksIHJldCA9IDA7Cj4gCj4gLQlm
b3JfZWFjaF9wbGFuZV9pbl9zdGF0ZShzdGF0ZSwgcGxhbmUsIHBsYW5lX3N0YXRlLCBpKSB7Cj4g
Kwlmb3JfZWFjaF9vbGRuZXdfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBsYW5lLCBvbGRfcGxhbmVf
c3RhdGUsCj4gcGxhbmVfc3RhdGUsIGkpIHsKPiAJCWNvbnN0IHN0cnVjdCBkcm1fcGxhbmVfaGVs
cGVyX2Z1bmNzICpmdW5jczsKPiAKPiAgCQlmdW5jcyA9IHBsYW5lLT5oZWxwZXJfcHJpdmF0ZTsK
PiAKPiAtCQlkcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9jaGFuZ2VkKHN0YXRlLCBwbGFuZV9zdGF0
ZSwgcGxhbmUpOwo+ICsJCWRybV9hdG9taWNfaGVscGVyX3BsYW5lX2NoYW5nZWQoc3RhdGUsIG9s
ZF9wbGFuZV9zdGF0ZSwKPiBwbGFuZV9zdGF0ZSwgcGxhbmUpOwo+IAo+ICAJCWlmICghZnVuY3Mg
fHwgIWZ1bmNzLT5hdG9taWNfY2hlY2spCj4gIAkJCWNvbnRpbnVlOwoKW3NuaXBdCgo+IEBAIC05
NzQsMTggKzk3NywxOCBAQCB2b2lkIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9tb2Rlc2V0X2Vu
YWJsZXMoc3RydWN0Cj4gZHJtX2RldmljZSAqZGV2LCB9Cj4gIAl9Cj4gCj4gLQlmb3JfZWFjaF9j
b25uZWN0b3JfaW5fc3RhdGUob2xkX3N0YXRlLCBjb25uZWN0b3IsIG9sZF9jb25uX3N0YXRlLCBp
KSB7Cj4gKwlmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRlKG9sZF9zdGF0ZSwgY29ubmVj
dG9yLCBjb25uX3N0YXRlLCBpKSB7CgpOb3Qgc3RyaWN0bHkgcmVsYXRlZCB0byB0aGlzIHBhdGNo
LCBidXQgSSd2ZSBiZWVuIHdvbmRlcmluZyBob3cgdGhpcyB3b3JrcywgCmdpdmVuIHRoYXQgd2Ug
bmVlZCB0byBsb29wIG92ZXIgY29ubmVjdG9ycyBpbiB0aGUgbmV3IHN0YXRlLCBub3QgdGhlIG9s
ZCAKc3RhdGUuIEFmdGVyIHNvbWUgaW52ZXN0aWdhdGlvbiBJJ3ZlIHJlYWxpemVkIHRoYXQgYm90
aCB0aGUgb2xkIGFuZCBuZXcgc3RhdGVzIApjb250YWluIHRoZSBzYW1lIGxpc3Qgb2Ygb2JqZWN0
cywgYXMgd2UgZG9uJ3Qga2VlcCBhIGNvcHkgb2YgdGhlIG9sZCBnbG9iYWwgCmF0b21pYyBzdGF0
ZS4gb2xkX3N0YXRlIHdhcyB0aGUgbmV3IHN0YXRlIGJlZm9yZSB0aGUgc3RhdGUgc3dhcCwgYW5k
IHRoZSBzd2FwIApvcGVyYXRpb24gc2V0cyBzdGF0ZS0+L29iamVjdHMvWypdLnN0YXRlIHRvIHRo
ZSBvbGQgc3RhdGUgZm9yIGFsbCBvYmplY3RzLCBidXQgCmRvZXNuJ3QgbW9kaWZ5IHRoZSBvYmpl
Y3QgcG9pbnRlcnMuIFRoaXMgaXMgcG9zc2libHkgbW9yZSBvZiBhIHF1ZXN0aW9uIGZvciAKRGFu
aWVsLCBzaG91bGQgdGhpcyBiZSBjYXB0dXJlZCBpbiB0aGUgZG9jdW1lbnRhdGlvbiBzb21ld2hl
cmUgKGFuZCBpcyBteSAKdW5kZXJzdGFuZGluZyBjb3JyZWN0KSA/Cgo+ICAJCWNvbnN0IHN0cnVj
dCBkcm1fZW5jb2Rlcl9oZWxwZXJfZnVuY3MgKmZ1bmNzOwo+ICAJCXN0cnVjdCBkcm1fZW5jb2Rl
ciAqZW5jb2RlcjsKPiAKPiAtCQlpZiAoIWNvbm5lY3Rvci0+c3RhdGUtPmJlc3RfZW5jb2RlcikK
PiArCQlpZiAoIWNvbm5fc3RhdGUtPmJlc3RfZW5jb2RlcikKPiAgCQkJY29udGludWU7Cj4gCj4g
LQkJaWYgKCFjb25uZWN0b3ItPnN0YXRlLT5jcnRjLT5zdGF0ZS0+YWN0aXZlIHx8Cj4gLQkJICAg
ICFkcm1fYXRvbWljX2NydGNfbmVlZHNfbW9kZXNldChjb25uZWN0b3ItPnN0YXRlLT5jcnRjLQo+
c3RhdGUpKQo+ICsJCWlmICghY29ubl9zdGF0ZS0+Y3J0Yy0+c3RhdGUtPmFjdGl2ZSB8fAo+ICsJ
CSAgICAhZHJtX2F0b21pY19jcnRjX25lZWRzX21vZGVzZXQoY29ubl9zdGF0ZS0+Y3J0Yy0+c3Rh
dGUpKQo+ICAJCQljb250aW51ZTsKPiAKPiAtCQllbmNvZGVyID0gY29ubmVjdG9yLT5zdGF0ZS0+
YmVzdF9lbmNvZGVyOwo+ICsJCWVuY29kZXIgPSBjb25uX3N0YXRlLT5iZXN0X2VuY29kZXI7Cj4g
IAkJZnVuY3MgPSBlbmNvZGVyLT5oZWxwZXJfcHJpdmF0ZTsKPiAKPiAgCQlEUk1fREVCVUdfQVRP
TUlDKCJlbmFibGluZyBbRU5DT0RFUjolZDolc11cbiIsCgpbc25pcF0KCj4gQEAgLTE5MjEsMTIg
KzE5MTksMTkgQEAgdm9pZCBkcm1fYXRvbWljX2hlbHBlcl9jbGVhbnVwX3BsYW5lcyhzdHJ1Y3QK
PiBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpvbGRfc3RhdGUpCj4g
IHsKPiAgCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+IC0Jc3RydWN0IGRybV9wbGFuZV9zdGF0
ZSAqcGxhbmVfc3RhdGU7Cj4gKwlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSwg
Km5ld19wbGFuZV9zdGF0ZTsKPiAgCWludCBpOwo+IAo+IC0JZm9yX2VhY2hfcGxhbmVfaW5fc3Rh
dGUob2xkX3N0YXRlLCBwbGFuZSwgcGxhbmVfc3RhdGUsIGkpIHsKPiArCWZvcl9lYWNoX29sZG5l
d19wbGFuZV9pbl9zdGF0ZShvbGRfc3RhdGUsIHBsYW5lLCBwbGFuZV9zdGF0ZSwKCj4gbmV3X3Bs
YW5lX3N0YXRlLCBpKSB7Cj4gCQljb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2hlbHBlcl9mdW5jcyAq
ZnVuY3M7Cj4gCj4gKwkJLyoKPiArCQkgKiBUaGlzIG1pZ2h0IGJlIGNhbGxlZCBiZWZvcmUgc3dh
cHBpbmcgd2hlbiBjb21taXQgaXMgCmFib3J0ZWQsCj4gKwkJICogaW4gd2hpY2ggY2FzZSB3ZSBo
YXZlIHRvIGZyZWUgdGhlIG5ldyBzdGF0ZS4KClNob3VsZCB0aGlzIGJlICJjbGVhbnVwIHRoZSBu
ZXcgc3RhdGUiIGluc3RlYWQgb2YgImZyZWUgdGhlIG5ldyBzdGF0ZSIgPwoKPiArCQkgKi8KPiAr
CQlpZiAocGxhbmVfc3RhdGUgPT0gcGxhbmUtPnN0YXRlKQo+ICsJCQlwbGFuZV9zdGF0ZSA9IG5l
d19wbGFuZV9zdGF0ZTsKPiArCj4gIAkJZnVuY3MgPSBwbGFuZS0+aGVscGVyX3ByaXZhdGU7Cj4g
Cj4gIAkJaWYgKGZ1bmNzLT5jbGVhbnVwX2ZiKQoKW3NuaXBdCgotLSAKUmVnYXJkcywKCkxhdXJl
bnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y
ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm
eAo=