From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v1] drm/i915/guc: Fix a memory leak where guc->execbuf_client is not freed Date: Wed, 13 Jan 2016 18:15:54 +0000 Message-ID: <5696945A.7050002@intel.com> References: <1452113637-12981-1-git-send-email-yu.dai@intel.com> <1452640652-24404-1-git-send-email-yu.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 387E46E981 for ; Wed, 13 Jan 2016 10:15:56 -0800 (PST) In-Reply-To: <1452640652-24404-1-git-send-email-yu.dai@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: yu.dai@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTIvMDEvMTYgMjM6MTcsIHl1LmRhaUBpbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogQWxleCBE YWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4KPiBEdXJpbmcgZHJpdmVyIHVubG9hZGluZywgdGhlIGd1 Y19jbGllbnQgY3JlYXRlZCBmb3IgY29tbWFuZCBzdWJtaXNzaW9uCj4gbmVlZHMgdG8gYmUgcmVs ZWFzZWQgdG8gYXZvaWQgbWVtb3J5IGxlYWsuCj4KPiBUaGUgc3RydWN0X211dGV4IG5lZWRzIHRv IGJlIGhlbGQgYmVmb3JlIHRlYXJpbmcgZG93biBHdUMuCj4KPiB2MTogTW92ZSBpOTE1X2d1Y19z dWJtaXNzaW9uX2Rpc2FibGUgb3V0IG9mIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaSBhbmQKPiAg ICAgIHRha2Ugc3RydWN0X211dGV4IGxvY2sgYmVmb3JlIHJlbGVhc2UgR3VDIGNsaWVudC4gKERh dmUgR29yZG9uKQoKWW91IGRvbid0IHNlZW0gdG8gaGF2ZSBpbXBsZW1lbnRlZCBhbGwgdGhlIHBv aW50cyBJIG1lbnRpb25lZD8gSSB0aGluayAKeW91IHdhbnQ6Cgpkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWNfbG9hZGVyLmM6CkBAIC00NDUsNiArNDQ1LDcgQEAgaW50IGludGVsX2d1Y191 Y29kZV9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCgogICAgICAgICBkaXJlY3RfaW50ZXJy dXB0c190b19ob3N0KGRldl9wcml2KTsKICAgICAgICAgaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNh YmxlKGRldik7CisgICAgICAgaTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKGRldik7CgpPcHRpb25h bCwgYnV0IGNsZWFuZXIuIFdlIGNhbGxlZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoKSBlYXJs aWVyIGluIAp0aGlzIGZ1bmN0aW9uLCBzbyB3ZSBzaG91bGQgY2FsbCBpOTE1X2d1Y19zdWJtaXNz aW9uX2ZpbmkoKSBpbiB0aGUgCmZhaWx1cmUgcGF0aC4gVGhhdCB3YXksIHdlIGVpdGhlciBzdWNj ZWVkLCBvciBsZWF2ZSB0aGUgc3lzdGVtIHN0YXRlIAp1bmNoYW5nZWQsIE5PVCBsZWF2aW5nIGV4 dHJhIG9iamVjdHMgYWxsb2NhdGVkLgoKICAgICAgICAgcmV0dXJuIGVycjsKICB9CgpAQCAtNTYx LDEwICs1NjIsMTIgQEAgc3RhdGljIHZvaWQgZ3VjX2Z3X2ZldGNoKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIApzdHJ1Y3QgaW50ZWxfZ3VjX2Z3ICpndWNfZncpCiAgCURSTV9FUlJPUigiRmFpbGVk IHRvIGZldGNoIEd1QyBmaXJtd2FyZSBmcm9tICVzIChlcnJvciAlZClcbiIsCiAgCQkgIGd1Y19m dy0+Z3VjX2Z3X3BhdGgsIGVycik7CgorCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsK ICAJb2JqID0gZ3VjX2Z3LT5ndWNfZndfb2JqOwogIAlpZiAob2JqKQogIAkJZHJtX2dlbV9vYmpl Y3RfdW5yZWZlcmVuY2UoJm9iai0+YmFzZSk7CiAgCWd1Y19mdy0+Z3VjX2Z3X29iaiA9IE5VTEw7 CisJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7CgpUaGlzIGlzIHRoZSBsb2NraW5n IHRoYXQgbmVlZHMgdG8gYmUgYWRkZWQgdG8gdGhlIGZhaWx1cmUgcGF0aC4KVGhpcyBpcyByZXF1 aXJlZCAqaW4gYWRkaXRpb24gdG8qIHRoZSBsb2NraW5nIHJlb3JnYW5pc2F0aW9uIGJlbG93LgoK PiBTaWduZWQtb2ZmLWJ5OiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiBpbmRleCBkMjA3ODhmLi43MGZhOGY1IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IEBAIC02MzEsMTAg KzYzMSwxMSBAQCB2b2lkIGludGVsX2d1Y191Y29kZV9maW5pKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJp dmF0ZTsKPiAgIAlzdHJ1Y3QgaW50ZWxfZ3VjX2Z3ICpndWNfZncgPSAmZGV2X3ByaXYtPmd1Yy5n dWNfZnc7Cj4KPiArCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgIAlkaXJlY3Rf aW50ZXJydXB0c190b19ob3N0KGRldl9wcml2KTsKPiArCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlz YWJsZShkZXYpOwo+ICAgCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShkZXYpOwo+Cj4gLQltdXRl eF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gICAJaWYgKGd1Y19mdy0+Z3VjX2Z3X29iaikK PiAgIAkJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoJmd1Y19mdy0+Z3VjX2Z3X29iai0+YmFz ZSk7Cj4gICAJZ3VjX2Z3LT5ndWNfZndfb2JqID0gTlVMTDsKClRoaXMgYml0IGlzIGZpbmUsIGJ1 dCBpbmNvbXBsZXRlIHdpdGhvdXQgdGhlIG90aGVyIGNoYW5nZXMgYWJvdmUuCgouRGF2ZS4KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK