From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v1] drm/i915/guc: Fix a memory leak where guc->execbuf_client is not freed Date: Wed, 13 Jan 2016 18:51:44 +0000 Message-ID: <56969CC0.2020303@intel.com> References: <1452113637-12981-1-git-send-email-yu.dai@intel.com> <1452640652-24404-1-git-send-email-yu.dai@intel.com> <5696945A.7050002@intel.com> <569694BE.6050702@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id F1F936E1F3 for ; Wed, 13 Jan 2016 10:51:57 -0800 (PST) In-Reply-To: <569694BE.6050702@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Yu Dai , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTMvMDEvMTYgMTg6MTcsIFl1IERhaSB3cm90ZToKPgo+IE9uIDAxLzEzLzIwMTYgMTA6MTUg QU0sIERhdmUgR29yZG9uIHdyb3RlOgo+PiBPbiAxMi8wMS8xNiAyMzoxNywgeXUuZGFpQGludGVs LmNvbSB3cm90ZToKPj4gPiBGcm9tOiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPj4gPgo+ PiA+IER1cmluZyBkcml2ZXIgdW5sb2FkaW5nLCB0aGUgZ3VjX2NsaWVudCBjcmVhdGVkIGZvciBj b21tYW5kIHN1Ym1pc3Npb24KPj4gPiBuZWVkcyB0byBiZSByZWxlYXNlZCB0byBhdm9pZCBtZW1v cnkgbGVhay4KPj4gPgo+PiA+IFRoZSBzdHJ1Y3RfbXV0ZXggbmVlZHMgdG8gYmUgaGVsZCBiZWZv cmUgdGVhcmluZyBkb3duIEd1Qy4KPj4gPgo+PiA+IHYxOiBNb3ZlIGk5MTVfZ3VjX3N1Ym1pc3Np b25fZGlzYWJsZSBvdXQgb2YgaTkxNV9ndWNfc3VibWlzc2lvbl9maW5pCj4+IGFuZAo+PiA+ICAg ICAgdGFrZSBzdHJ1Y3RfbXV0ZXggbG9jayBiZWZvcmUgcmVsZWFzZSBHdUMgY2xpZW50LiAoRGF2 ZSBHb3Jkb24pCj4+Cj4+IFlvdSBkb24ndCBzZWVtIHRvIGhhdmUgaW1wbGVtZW50ZWQgYWxsIHRo ZSBwb2ludHMgSSBtZW50aW9uZWQ/IEkgdGhpbmsKPj4geW91IHdhbnQ6Cj4+Cj4+IGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYzoKPj4gQEAgLTQ0NSw2ICs0NDUsNyBAQCBp bnQgaW50ZWxfZ3VjX3Vjb2RlX2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4KPj4gICAg ICAgICAgIGRpcmVjdF9pbnRlcnJ1cHRzX3RvX2hvc3QoZGV2X3ByaXYpOwo+PiAgICAgICAgICAg aTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKGRldik7Cj4+ICsgICAgICAgaTkxNV9ndWNfc3Vi bWlzc2lvbl9maW5pKGRldik7Cj4+Cj4+IE9wdGlvbmFsLCBidXQgY2xlYW5lci4gV2UgY2FsbGVk IGk5MTVfZ3VjX3N1Ym1pc3Npb25faW5pdCgpIGVhcmxpZXIgaW4KPj4gdGhpcyBmdW5jdGlvbiwg c28gd2Ugc2hvdWxkIGNhbGwgaTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKCkgaW4gdGhlCj4+IGZh aWx1cmUgcGF0aC4gVGhhdCB3YXksIHdlIGVpdGhlciBzdWNjZWVkLCBvciBsZWF2ZSB0aGUgc3lz dGVtIHN0YXRlCj4+IHVuY2hhbmdlZCwgTk9UIGxlYXZpbmcgZXh0cmEgb2JqZWN0cyBhbGxvY2F0 ZWQuCj4+Cj4+ICAgICAgICAgICByZXR1cm4gZXJyOwo+PiAgICB9Cj4KPiBJIGRvbid0IHdhbnQg dGhpcyBiZWNhdXNlIHN0cnVjdF9tdXRleCBpcyBoZWxkIGJ5IGNhbGxlciBhbHJlYWR5IHdoaWxl Cj4gdGhlIGZpbmkoKSB3aWxsIGFjcXVpcmUgaXQgdG9vLgoKWWVzIGl0IGlzIGFuZCBubyBpdCB3 b24ndC4gVGhhdCdzIGd1Y18qc3VibWlzc2lvbipfZmluaSgpIEkgd2FudCB0byBjYWxsIAood2hp Y2ggcmVxdWlyZXMgdGhlIG11dGV4IGhlbGQpLCBub3QgaW50ZWxfZ3VjXyp1Y29kZSpfZmluaSgp ICh3aGljaCwgYXMgCnlvdSBzYXksIGFjcXVpcmVzIGl0KS4KCi5EYXZlLgoKPj4gQEAgLTU2MSwx MCArNTYyLDEyIEBAIHN0YXRpYyB2b2lkIGd1Y19md19mZXRjaChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+PiBzdHJ1Y3QgaW50ZWxfZ3VjX2Z3ICpndWNfZncpCj4+ICAgICAgICBEUk1fRVJST1Io IkZhaWxlZCB0byBmZXRjaCBHdUMgZmlybXdhcmUgZnJvbSAlcyAoZXJyb3IgJWQpXG4iLAo+PiAg ICAgICAgICAgICAgZ3VjX2Z3LT5ndWNfZndfcGF0aCwgZXJyKTsKPj4KPj4gKyAgICBtdXRleF9s b2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4+ICAgICAgICBvYmogPSBndWNfZnctPmd1Y19md19v Ymo7Cj4+ICAgICAgICBpZiAob2JqKQo+PiAgICAgICAgICAgIGRybV9nZW1fb2JqZWN0X3VucmVm ZXJlbmNlKCZvYmotPmJhc2UpOwo+PiAgICAgICAgZ3VjX2Z3LT5ndWNfZndfb2JqID0gTlVMTDsK Pj4gKyAgICBtdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPj4KPj4gVGhpcyBpcyB0 aGUgbG9ja2luZyB0aGF0IG5lZWRzIHRvIGJlIGFkZGVkIHRvIHRoZSBmYWlsdXJlIHBhdGguCj4+ IFRoaXMgaXMgcmVxdWlyZWQgKmluIGFkZGl0aW9uIHRvKiB0aGUgbG9ja2luZyByZW9yZ2FuaXNh dGlvbiBiZWxvdy4KPgo+IEkgbWlzc2VkIHRoaXMgcGFydC4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBB bGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPj4gPgo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4gPiBpbmRleCBkMjA3ODhmLi43MGZhOGY1IDEwMDY0NAo+ PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+PiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+PiA+IEBAIC02MzEs MTAgKzYzMSwxMSBAQCB2b2lkIGludGVsX2d1Y191Y29kZV9maW5pKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4+ID4gICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2 LT5kZXZfcHJpdmF0ZTsKPj4gPiAgICAgICBzdHJ1Y3QgaW50ZWxfZ3VjX2Z3ICpndWNfZncgPSAm ZGV2X3ByaXYtPmd1Yy5ndWNfZnc7Cj4+ID4KPj4gPiArICAgIG11dGV4X2xvY2soJmRldi0+c3Ry dWN0X211dGV4KTsKPj4gPiAgICAgICBkaXJlY3RfaW50ZXJydXB0c190b19ob3N0KGRldl9wcml2 KTsKPj4gPiArICAgIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShkZXYpOwo+PiA+ICAgICAg IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShkZXYpOwo+PiA+Cj4+ID4gLSAgICBtdXRleF9sb2Nr KCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4+ID4gICAgICAgaWYgKGd1Y19mdy0+Z3VjX2Z3X29iaikK Pj4gPiAgICAgICAgICAgZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoJmd1Y19mdy0+Z3VjX2Z3 X29iai0+YmFzZSk7Cj4+ID4gICAgICAgZ3VjX2Z3LT5ndWNfZndfb2JqID0gTlVMTDsKPj4KPj4g VGhpcyBiaXQgaXMgZmluZSwgYnV0IGluY29tcGxldGUgd2l0aG91dCB0aGUgb3RoZXIgY2hhbmdl cyBhYm92ZS4KPj4KPj4gLkRhdmUuCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==