From: Dave Gordon <david.s.gordon@intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
"Kristian Høgsberg Kristensen" <krh@bitplanet.net>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Allow i915_gem_object_get_page() on userptr as well
Date: Wed, 13 Jan 2016 19:08:11 +0000 [thread overview]
Message-ID: <5696A09B.6090705@intel.com> (raw)
In-Reply-To: <20160112234939.GC25945@nuc-i3427.alporthouse.com>
On 12/01/16 23:49, Chris Wilson wrote:
> On Tue, Jan 12, 2016 at 11:40:06PM +0000, Chris Wilson wrote:
>> struct drm_i915_gem_object_ops {
>> + const unsigned int flags;
>
> Bleh, const is redundant as the definitions should be const themselves.
> -Chris
Yeah, the const-ness attaches to the instances of and references to the
structure rather than the abstract type. But it doesn't actually do any
harm, so with or without the redundant 'const' it gets:
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-13 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 23:40 [PATCH] drm/i915: Allow i915_gem_object_get_page() on userptr as well Chris Wilson
2016-01-12 23:49 ` Chris Wilson
2016-01-13 19:08 ` Dave Gordon [this message]
2016-01-21 23:28 ` Kristian Høgsberg
2016-01-13 9:20 ` ✓ success: Fi.CI.BAT Patchwork
2016-01-22 18:32 ` [PATCH v2] drm/i915: Allow i915_gem_object_get_page() on userptr as well Chris Wilson
2016-01-23 7:13 ` ✗ Fi.CI.BAT: warning for drm/i915: Allow i915_gem_object_get_page() on userptr as well (rev2) Patchwork
2016-01-25 16:08 ` Daniel Vetter
2016-01-28 12:18 ` ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5696A09B.6090705@intel.com \
--to=david.s.gordon@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krh@bitplanet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox