From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Seal busy-ioctl uABI and prevent leaking of internal ids Date: Fri, 15 Jan 2016 11:58:32 +0000 Message-ID: <5698DEE8.6090003@linux.intel.com> References: <1452856013-29728-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 29AAC6EB5C for ; Fri, 15 Jan 2016 03:58:34 -0800 (PST) In-Reply-To: <1452856013-29728-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE1LzAxLzE2IDExOjA2LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gVHZydGtvIHdhcyBsb29r aW5nIHRocm91Z2ggdGhlIGV4ZWNidWZmZXItaW9jdGwgYW5kIG5vdGljZWQgdGhhdCB0aGUKPiB1 QUJJIHdhcyB0aWdodGx5IGNvdXBsZWQgdG8gb3VyIGludGVybmFsIGVuZ2luZSBpZGVudGlmaWVy cy4gQ2xvc2UKPiBpbnNwZWN0aW9uIGFsc28gcmV2ZWFsZWQgdGhhdCB3ZSBsZWFrIHRob3NlIGlu dGVybmFsIGVuZ2luZSBpZGVudGlmaWVycwo+IHRocm91Z2ggdGhlIGJ1c3ktaW9jdGwsIGFuZCB0 aG9zZSBpbnRlcm5hbCBpZGVudGlmaWVycyBhbHJlYWR5IGRvIG5vdAo+IG1hdGNoIHRoZSB1c2Vy IGlkZW50aWZpZXJzLiBGb3J0dWl0aW91c2x5LCB0aGVyZSBpcyBvbmx5IG9uZSB1c2VyIG9mIHRo ZQo+IHNldCBvZiBidXN5IHJpbmdzIGZyb20gdGhlIGJ1c3ktaW9jdGwsIGFuZCB0aGV5IG9ubHkg d2lzaCB0byBjaG9vc2UKPiBiZXR3ZWVuIHRoZSBSRU5ERVIgYW5kIHRoZSBCTFQgZW5naW5lcy4K Pgo+IExldCdzIGZpeCB0aGUgdXNlcnNwYWNlIEFCSSB3aGlsZSB3ZSBzdGlsbCBjYW4uCj4KPiBT aWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBD YzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMgICAgICAgICB8IDE4ICsrKysrKysrKysrKysrLS0tLQo+ICAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgIHwgIDUgKysrKysKPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyB8ICA1ICsrKysrCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggfCAgMSArCj4gICA0IGZpbGVzIGNoYW5n ZWQsIDI1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMKPiBpbmRleCBiYjQ0YmFkMTU0MDMuLjg1Nzk3ODEzYTNkZSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+IEBAIC00MzI4LDEwICs0MzI4LDIwIEBAIGk5MTVfZ2VtX2J1c3lfaW9j dGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgIAlpZiAocmV0KQo+ICAg CQlnb3RvIHVucmVmOwo+Cj4gLQlCVUlMRF9CVUdfT04oSTkxNV9OVU1fUklOR1MgPiAxNik7Cj4g LQlhcmdzLT5idXN5ID0gb2JqLT5hY3RpdmUgPDwgMTY7Cj4gLQlpZiAob2JqLT5sYXN0X3dyaXRl X3JlcSkKPiAtCQlhcmdzLT5idXN5IHw9IG9iai0+bGFzdF93cml0ZV9yZXEtPnJpbmctPmlkOwo+ ICsJYXJncy0+YnVzeSA9IDA7Cj4gKwlpZiAob2JqLT5hY3RpdmUpIHsKPiArCQlpbnQgaTsKPiAr Cj4gKwkJZm9yIChpID0gMDsgaSA8IEk5MTVfTlVNX1JJTkdTOyBpKyspIHsKPiArCQkJc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXE7Cj4gKwo+ICsJCQlyZXEgPSBvYmotPmxhc3RfcmVh ZF9yZXFbaV07Cj4gKwkJCWlmIChyZXEpCj4gKwkJCQlhcmdzLT5idXN5IHw9IDEgPDwgKDE2ICsg cmVxLT5yaW5nLT5leGVjX2lkKTsKCklmIEkgZ290IGl0IHJpZ2h0IGJpdCAxNiB3YXMgUkNTLCBu b3cgd2lsbCBhbHdheXMgYmUgY2xlYXIuIEFuZCBibGl0dGVyIAp3YXMgYml0IDE3IGFuZCBub3cg aXMgMTkuCgpSZWdhcmRzLAoKVHZydGtvCgo+ICsJCX0KPiArCQlpZiAob2JqLT5sYXN0X3dyaXRl X3JlcSkKPiArCQkJYXJncy0+YnVzeSB8PSBvYmotPmxhc3Rfd3JpdGVfcmVxLT5yaW5nLT5leGVj X2lkOwo+ICsJfQo+Cj4gICB1bnJlZjoKPiAgIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgm b2JqLT5iYXNlKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IGY1ZDg5Yzg0NWVk ZS4uNGFhMjA5NDgzMjM3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMjAy NCw2ICsyMDI0LDcgQEAgc3RhdGljIGludCBsb2dpY2FsX3JlbmRlcl9yaW5nX2luaXQoc3RydWN0 IGRybV9kZXZpY2UgKmRldikKPgo+ICAgCXJpbmctPm5hbWUgPSAicmVuZGVyIHJpbmciOwo+ICAg CXJpbmctPmlkID0gUkNTOwo+ICsJcmluZy0+ZXhlY19pZCA9IEk5MTVfRVhFQ19SRU5ERVI7Cj4g ICAJcmluZy0+bW1pb19iYXNlID0gUkVOREVSX1JJTkdfQkFTRTsKPgo+ICAgCWxvZ2ljYWxfcmlu Z19kZWZhdWx0X2lycXMocmluZywgR0VOOF9SQ1NfSVJRX1NISUZUKTsKPiBAQCAtMjA3Myw2ICsy MDc0LDcgQEAgc3RhdGljIGludCBsb2dpY2FsX2JzZF9yaW5nX2luaXQoc3RydWN0IGRybV9kZXZp Y2UgKmRldikKPgo+ICAgCXJpbmctPm5hbWUgPSAiYnNkIHJpbmciOwo+ICAgCXJpbmctPmlkID0g VkNTOwo+ICsJcmluZy0+ZXhlY19pZCA9IEk5MTVfRVhFQ19CU0Q7Cj4gICAJcmluZy0+bW1pb19i YXNlID0gR0VONl9CU0RfUklOR19CQVNFOwo+Cj4gICAJbG9naWNhbF9yaW5nX2RlZmF1bHRfaXJx cyhyaW5nLCBHRU44X1ZDUzFfSVJRX1NISUZUKTsKPiBAQCAtMjA4OCw2ICsyMDkwLDcgQEAgc3Rh dGljIGludCBsb2dpY2FsX2JzZDJfcmluZ19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4K PiAgIAlyaW5nLT5uYW1lID0gImJzZDIgcmluZyI7Cj4gICAJcmluZy0+aWQgPSBWQ1MyOwo+ICsJ cmluZy0+ZXhlY19pZCA9IEk5MTVfRVhFQ19CU0Q7Cj4gICAJcmluZy0+bW1pb19iYXNlID0gR0VO OF9CU0QyX1JJTkdfQkFTRTsKPgo+ICAgCWxvZ2ljYWxfcmluZ19kZWZhdWx0X2lycXMocmluZywg R0VOOF9WQ1MyX0lSUV9TSElGVCk7Cj4gQEAgLTIxMDMsNiArMjEwNiw3IEBAIHN0YXRpYyBpbnQg bG9naWNhbF9ibHRfcmluZ19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4KPiAgIAlyaW5n LT5uYW1lID0gImJsaXR0ZXIgcmluZyI7Cj4gICAJcmluZy0+aWQgPSBCQ1M7Cj4gKwlyaW5nLT5l eGVjX2lkID0gSTkxNV9FWEVDX0JMVDsKPiAgIAlyaW5nLT5tbWlvX2Jhc2UgPSBCTFRfUklOR19C QVNFOwo+Cj4gICAJbG9naWNhbF9yaW5nX2RlZmF1bHRfaXJxcyhyaW5nLCBHRU44X0JDU19JUlFf U0hJRlQpOwo+IEBAIC0yMTE4LDYgKzIxMjIsNyBAQCBzdGF0aWMgaW50IGxvZ2ljYWxfdmVib3hf cmluZ19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4KPiAgIAlyaW5nLT5uYW1lID0gInZp ZGVvIGVuaGFuY2VtZW50IHJpbmciOwo+ICAgCXJpbmctPmlkID0gVkVDUzsKPiArCXJpbmctPmV4 ZWNfaWQgPSBJOTE1X0VYRUNfVkVCT1g7Cj4gICAJcmluZy0+bW1pb19iYXNlID0gVkVCT1hfUklO R19CQVNFOwo+Cj4gICAJbG9naWNhbF9yaW5nX2RlZmF1bHRfaXJxcyhyaW5nLCBHRU44X1ZFQ1Nf SVJRX1NISUZUKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmlu Z2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5k ZXggOGNkOGFhYmNjM2ZmLi4zMTBkMTUxYzBkYjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcmluZ2J1ZmZlci5jCj4gQEAgLTI2ODAsNiArMjY4MCw3IEBAIGludCBpbnRlbF9pbml0 X3JlbmRlcl9yaW5nX2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+Cj4gICAJcmluZy0+ bmFtZSA9ICJyZW5kZXIgcmluZyI7Cj4gICAJcmluZy0+aWQgPSBSQ1M7Cj4gKwlyaW5nLT5leGVj X2lkID0gSTkxNV9FWEVDX1JFTkRFUjsKPiAgIAlyaW5nLT5tbWlvX2Jhc2UgPSBSRU5ERVJfUklO R19CQVNFOwo+Cj4gICAJaWYgKElOVEVMX0lORk8oZGV2KS0+Z2VuID49IDgpIHsKPiBAQCAtMjgy OCw2ICsyODI5LDcgQEAgaW50IGludGVsX2luaXRfYnNkX3JpbmdfYnVmZmVyKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpCj4KPiAgIAlyaW5nLT5uYW1lID0gImJzZCByaW5nIjsKPiAgIAlyaW5nLT5p ZCA9IFZDUzsKPiArCXJpbmctPmV4ZWNfaWQgPSBJOTE1X0VYRUNfQlNEOwo+Cj4gICAJcmluZy0+ d3JpdGVfdGFpbCA9IHJpbmdfd3JpdGVfdGFpbDsKPiAgIAlpZiAoSU5URUxfSU5GTyhkZXYpLT5n ZW4gPj0gNikgewo+IEBAIC0yOTA0LDYgKzI5MDYsNyBAQCBpbnQgaW50ZWxfaW5pdF9ic2QyX3Jp bmdfYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4KPiAgIAlyaW5nLT5uYW1lID0gImJz ZDIgcmluZyI7Cj4gICAJcmluZy0+aWQgPSBWQ1MyOwo+ICsJcmluZy0+ZXhlY19pZCA9IEk5MTVf RVhFQ19CU0Q7Cj4KPiAgIAlyaW5nLT53cml0ZV90YWlsID0gcmluZ193cml0ZV90YWlsOwo+ICAg CXJpbmctPm1taW9fYmFzZSA9IEdFTjhfQlNEMl9SSU5HX0JBU0U7Cj4gQEAgLTI5MzQsNiArMjkz Nyw3IEBAIGludCBpbnRlbF9pbml0X2JsdF9yaW5nX2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+Cj4gICAJcmluZy0+bmFtZSA9ICJibGl0dGVyIHJpbmciOwo+ICAgCXJpbmctPmlkID0g QkNTOwo+ICsJcmluZy0+ZXhlY19pZCA9IEk5MTVfRVhFQ19CTFQ7Cj4KPiAgIAlyaW5nLT5tbWlv X2Jhc2UgPSBCTFRfUklOR19CQVNFOwo+ICAgCXJpbmctPndyaXRlX3RhaWwgPSByaW5nX3dyaXRl X3RhaWw7Cj4gQEAgLTI5OTEsNiArMjk5NSw3IEBAIGludCBpbnRlbF9pbml0X3ZlYm94X3Jpbmdf YnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4KPiAgIAlyaW5nLT5uYW1lID0gInZpZGVv IGVuaGFuY2VtZW50IHJpbmciOwo+ICAgCXJpbmctPmlkID0gVkVDUzsKPiArCXJpbmctPmV4ZWNf aWQgPSBJOTE1X0VYRUNfVkVCT1g7Cj4KPiAgIAlyaW5nLT5tbWlvX2Jhc2UgPSBWRUJPWF9SSU5H X0JBU0U7Cj4gICAJcmluZy0+d3JpdGVfdGFpbCA9IHJpbmdfd3JpdGVfdGFpbDsKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gaW5kZXggNzM0OWQ5MjU4MTkxLi4yMDY3 ZjQ3MDBjYWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4g QEAgLTE1Niw2ICsxNTYsNyBAQCBzdHJ1Y3QgIGludGVsX2VuZ2luZV9jcyB7Cj4gICAJfSBpZDsK PiAgICNkZWZpbmUgSTkxNV9OVU1fUklOR1MgNQo+ICAgI2RlZmluZSBMQVNUX1VTRVJfUklORyAo VkVDUyArIDEpCj4gKwl1bnNpZ25lZCBpbnQgZXhlY19pZDsKPiAgIAl1MzIJCW1taW9fYmFzZTsK PiAgIAlzdHJ1Y3QJCWRybV9kZXZpY2UgKmRldjsKPiAgIAlzdHJ1Y3QgaW50ZWxfcmluZ2J1ZmZl ciAqYnVmZmVyOwo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==