From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Seal busy-ioctl uABI and prevent leaking of internal ids Date: Fri, 15 Jan 2016 13:22:39 +0000 Message-ID: <5698F29F.5030008@linux.intel.com> References: <1452856013-29728-1-git-send-email-chris@chris-wilson.co.uk> <5698DEE8.6090003@linux.intel.com> <20160115122730.GG8308@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A6444A04C for ; Fri, 15 Jan 2016 05:22:41 -0800 (PST) In-Reply-To: <20160115122730.GG8308@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE1LzAxLzE2IDEyOjI3LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gRnJpLCBKYW4gMTUs IDIwMTYgYXQgMTE6NTg6MzJBTSArMDAwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9u IDE1LzAxLzE2IDExOjA2LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBUdnJ0a28gd2FzIGxvb2tp bmcgdGhyb3VnaCB0aGUgZXhlY2J1ZmZlci1pb2N0bCBhbmQgbm90aWNlZCB0aGF0IHRoZQo+Pj4g dUFCSSB3YXMgdGlnaHRseSBjb3VwbGVkIHRvIG91ciBpbnRlcm5hbCBlbmdpbmUgaWRlbnRpZmll cnMuIENsb3NlCj4+PiBpbnNwZWN0aW9uIGFsc28gcmV2ZWFsZWQgdGhhdCB3ZSBsZWFrIHRob3Nl IGludGVybmFsIGVuZ2luZSBpZGVudGlmaWVycwo+Pj4gdGhyb3VnaCB0aGUgYnVzeS1pb2N0bCwg YW5kIHRob3NlIGludGVybmFsIGlkZW50aWZpZXJzIGFscmVhZHkgZG8gbm90Cj4+PiBtYXRjaCB0 aGUgdXNlciBpZGVudGlmaWVycy4gRm9ydHVpdGlvdXNseSwgdGhlcmUgaXMgb25seSBvbmUgdXNl ciBvZiB0aGUKPj4+IHNldCBvZiBidXN5IHJpbmdzIGZyb20gdGhlIGJ1c3ktaW9jdGwsIGFuZCB0 aGV5IG9ubHkgd2lzaCB0byBjaG9vc2UKPj4+IGJldHdlZW4gdGhlIFJFTkRFUiBhbmQgdGhlIEJM VCBlbmdpbmVzLgo+Pj4KPj4+IExldCdzIGZpeCB0aGUgdXNlcnNwYWNlIEFCSSB3aGlsZSB3ZSBz dGlsbCBjYW4uCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4+PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu dGVsLmNvbT4KPj4+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ Pj4gLS0tCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgICAgICB8IDE4 ICsrKysrKysrKysrKysrLS0tLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMu YyAgICAgICAgfCAgNSArKysrKwo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5n YnVmZmVyLmMgfCAgNSArKysrKwo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5n YnVmZmVyLmggfCAgMSArCj4+PiAgIDQgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+IGluZGV4IGJi NDRiYWQxNTQwMy4uODU3OTc4MTNhM2RlIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0u Ywo+Pj4gQEAgLTQzMjgsMTAgKzQzMjgsMjAgQEAgaTkxNV9nZW1fYnVzeV9pb2N0bChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+Pj4gICAJaWYgKHJldCkKPj4+ICAgCQlnb3Rv IHVucmVmOwo+Pj4KPj4+IC0JQlVJTERfQlVHX09OKEk5MTVfTlVNX1JJTkdTID4gMTYpOwo+Pj4g LQlhcmdzLT5idXN5ID0gb2JqLT5hY3RpdmUgPDwgMTY7Cj4+PiAtCWlmIChvYmotPmxhc3Rfd3Jp dGVfcmVxKQo+Pj4gLQkJYXJncy0+YnVzeSB8PSBvYmotPmxhc3Rfd3JpdGVfcmVxLT5yaW5nLT5p ZDsKPj4+ICsJYXJncy0+YnVzeSA9IDA7Cj4+PiArCWlmIChvYmotPmFjdGl2ZSkgewo+Pj4gKwkJ aW50IGk7Cj4+PiArCj4+PiArCQlmb3IgKGkgPSAwOyBpIDwgSTkxNV9OVU1fUklOR1M7IGkrKykg ewo+Pj4gKwkJCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxOwo+Pj4gKwo+Pj4gKwkJ CXJlcSA9IG9iai0+bGFzdF9yZWFkX3JlcVtpXTsKPj4+ICsJCQlpZiAocmVxKQo+Pj4gKwkJCQlh cmdzLT5idXN5IHw9IDEgPDwgKDE2ICsgcmVxLT5yaW5nLT5leGVjX2lkKTsKPj4KPj4gSWYgSSBn b3QgaXQgcmlnaHQgYml0IDE2IHdhcyBSQ1MsIG5vdyB3aWxsIGFsd2F5cyBiZSBjbGVhci4gQW5k Cj4+IGJsaXR0ZXIgd2FzIGJpdCAxNyBhbmQgbm93IGlzIDE5Lgo+Cj4gU3NzaC4gWW91IHdlcmVu J3QgbWVhbnQgdG8gcG9pbnQgdGhhdCBvdXQuCj4KPiBJIGFtIHdpbGxpbmcgdG8gdGFrZSB0aGUg aGl0IGluIG9yZGVyIHRvIGRlY291cGxlIHRoZSB1QUJJIGZyb20KPiBpbnRlcm5hbHMuCj4KPiBJ IGFtIGFsc28gd2lsbGluZyB0byBjb2RpZnkgdGhpcyBidXN5LWlvY3RsIEFCSSBpbnRvIGlndCEK Ckxvb2tzIGxpa2UgeW91ciBERFggaXMgdGhlIG9ubHkgdXNlciBub3QgdXNpbmcgaXQgaW4gdGhl IGJvb2xlYW4gbW9kZT8KCkFuZCBsaWJkcm0gaXMgYSBiaXQgY29uZnVzZWQgaW4gaXRzIHJldHVy biBzdGF0ZW1lbnRzOgoKICAgICAgICAgcmV0ID0gZHJtSW9jdGwoYnVmbWdyX2dlbS0+ZmQsIERS TV9JT0NUTF9JOTE1X0dFTV9CVVNZLCAmYnVzeSk7CiAgICAgICAgIGlmIChyZXQgPT0gMCkgewog ICAgICAgICAgICAgICAgIGJvX2dlbS0+aWRsZSA9ICFidXN5LmJ1c3k7CiAgICAgICAgICAgICAg ICAgcmV0dXJuIGJ1c3kuYnVzeTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIChyZXQgPT0gMCAmJiBidXN5 LmJ1c3kpOwoKTG9va3MgbGlrZSBpdCB3YXMgYSBib29sZWFuIGFzIHdlbGwgdW50aWwgY29tbWl0 IAowMmY5M2MyMWU2ZTFjM2RhZDlkOTkzNDk5ODlkYWE4NGE4YzBiNWZiIHF1aXRlIHBvc3NpYmx5 IGJ5IGFjY2lkZW50IApzdGFydGVkIGV4cG9zaW5nIHRoZSBiaXRzLgoKUmVnYXJkcywKClR2cnRr bwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=