From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH 3/3] drm/i915: Cache LRC state page in the context
Date: Fri, 15 Jan 2016 16:05:24 +0000 [thread overview]
Message-ID: <569918C4.8020503@linux.intel.com> (raw)
In-Reply-To: <20160115160153.GL8308@nuc-i3427.alporthouse.com>
On 15/01/16 16:01, Chris Wilson wrote:
> On Fri, Jan 15, 2016 at 03:10:29PM +0000, Tvrtko Ursulin wrote:
>> @@ -1118,15 +1126,22 @@ void intel_lr_context_unpin(struct drm_i915_gem_request *rq)
>> + if (--rq->ctx->engine[ring->id].pin_count == 0) {
>> + lrc_state_page = i915_gem_object_get_dirty_page(ctx_obj,
>> + LRC_STATE_PN);
>
> Interesting choice. We called set_page_dirty() when we took the mapping.
> Should that page flag be preserved whilst we hold the kmap - I think so,
> i.e. the mm cannot flush the page whilst it has an elevated mapcount. So
> calling set_page_dirty() again is redundant, right?
If you call mindless copy & paste interesting. :D
Any other concerns or I can respin with that only?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-15 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 15:10 [PATCH 1/3] drm/i915: Do not call API requiring struct_mutex where it is not available Tvrtko Ursulin
2016-01-15 15:10 ` [PATCH 2/3] drm/i915: Cache ringbuffer GTT VMA Tvrtko Ursulin
2016-01-15 15:10 ` [PATCH 3/3] drm/i915: Cache LRC state page in the context Tvrtko Ursulin
2016-01-15 16:01 ` Chris Wilson
2016-01-15 16:05 ` Tvrtko Ursulin [this message]
2016-01-15 16:17 ` Chris Wilson
2016-01-15 16:39 ` [PATCH v5] " Tvrtko Ursulin
2016-01-15 17:02 ` Chris Wilson
2016-01-15 17:12 ` [PATCH v6] " Tvrtko Ursulin
2016-01-15 20:51 ` Chris Wilson
2016-01-15 16:20 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Do not call API requiring struct_mutex where it is not available Patchwork
2016-01-16 7:49 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Do not call API requiring struct_mutex where it is not available (rev3) Patchwork
2016-01-18 10:04 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569918C4.8020503@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=david.s.gordon@intel.com \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).