From: Yu Dai <yu.dai@intel.com>
To: Peter Antoine <peter.antoine@intel.com>, intel-gfx@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch, dave.gordon@intel.com
Subject: Re: [PATCH] i915/guc: Add Kabylake GuC Loading
Date: Tue, 19 Jan 2016 10:17:34 -0800 [thread overview]
Message-ID: <569E7DBE.8070000@intel.com> (raw)
In-Reply-To: <1453128099-27596-1-git-send-email-peter.antoine@intel.com>
I am OK with change here. However, in i915_drv.h, please check
definition of HAS_GUC_UCODE() and HAS_GUC_SCHED(). I believe they are
disabled for KBL.
Thanks,
Alex
On 01/18/2016 06:41 AM, Peter Antoine wrote:
> This patch added the loading of the GuC for Kabylake.
> It loads a 2.4 firmware.
>
> Signed-off-by: Peter Antoine <peter.antoine@intel.com>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> ---
> drivers/gpu/drm/i915/intel_guc_loader.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c
> index 3accd91..bbfa8f3 100644
> --- a/drivers/gpu/drm/i915/intel_guc_loader.c
> +++ b/drivers/gpu/drm/i915/intel_guc_loader.c
> @@ -61,6 +61,8 @@
>
> #define I915_SKL_GUC_UCODE "i915/skl_guc_ver4.bin"
> MODULE_FIRMWARE(I915_SKL_GUC_UCODE);
> +#define I915_KBL_GUC_UCODE "i915/kbl_guc_ver2.bin"
> +MODULE_FIRMWARE(I915_KBL_GUC_UCODE);
>
> /* User-friendly representation of an enum */
> const char *intel_guc_fw_status_repr(enum intel_guc_fw_status status)
> @@ -597,6 +599,10 @@ void intel_guc_ucode_init(struct drm_device *dev)
> fw_path = I915_SKL_GUC_UCODE;
> guc_fw->guc_fw_major_wanted = 4;
> guc_fw->guc_fw_minor_wanted = 3;
> + } else if (IS_KABYLAKE(dev)) {
> + fw_path = I915_KBL_GUC_UCODE;
> + guc_fw->guc_fw_major_wanted = 2;
> + guc_fw->guc_fw_minor_wanted = 4;
> } else {
> i915.enable_guc_submission = false;
> fw_path = ""; /* unknown device */
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-19 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 14:41 [PATCH] i915/guc: Add Kabylake GuC Loading Peter Antoine
2016-01-18 15:20 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-01-19 18:17 ` Yu Dai [this message]
2016-01-19 21:19 ` [PATCH] " Antoine, Peter
2016-01-19 21:51 ` Antoine, Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569E7DBE.8070000@intel.com \
--to=yu.dai@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=peter.antoine@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox