From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/3] drm/i915: Fix premature LRC unpin in GuC mode Date: Wed, 20 Jan 2016 14:06:43 +0000 Message-ID: <569F9473.6020300@linux.intel.com> References: <1453297257-4707-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1453297257-4707-3-git-send-email-tvrtko.ursulin@linux.intel.com> <20160120135500.GB16147@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 2708A6E94B for ; Wed, 20 Jan 2016 06:07:40 -0800 (PST) In-Reply-To: <20160120135500.GB16147@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , Nick Hoath List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIwLzAxLzE2IDEzOjU1LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gV2VkLCBKYW4gMjAs IDIwMTYgYXQgMDE6NDA6NTdQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IEluIEd1QyBt b2RlIExSQyBwaW5uaW5nIGxpZmV0aW1lIGRlcGVuZHMgZXhjbHVzaXZlbHkgb24gdGhlCj4+IHJl cXVlc3QgbGlmdGltZS4gU2luY2UgdGhhdCBpcyB0ZXJtaW5hdGVkIGJ5IHRoZSBzZXFubyB1cGRh dGUKPj4gdGhhdCBvcGVucyB1cCBhIHJhY2UgY29uZGl0aW9uIGJldHdlZW4gR1BVIGZpbmlzaGlu ZyB3cml0aW5nCj4+IG91dCB0aGUgY29udGV4dCBpbWFnZSBhbmQgdGhlIGRyaXZlciB1bnBpbm5p bmcgdGhlIExSQy4KPj4KPj4gVG8gZXh0ZW5kIHRoZSBMUkMgbGlmZXRpbWUgd2Ugd2lsbCBlbXBs b3kgYSBzaW1pbGFyIGFwcHJvYWNoCj4+IHRvIHdoYXQgbGVnYWN5IHJpbmdidWZmZXIgc3VibWlz c2lvbiBkb2VzLgo+Pgo+PiBXZSB3aWxsIHN0YXJ0IHRyYWNraW5nIHRoZSBsYXN0IHN1Ym1pdHRl ZCBjb250ZXh0IHBlciBlbmdpbmUKPj4gYW5kIGtlZXAgaXQgcGlubmVkIHVudGlsIGl0IGlzIHJl cGxhY2VkIGJ5IGFub3RoZXIgb25lLgo+Pgo+PiBOb3RlIHRoYXQgdGhlIGRyaXZlciB1bmxvYWQg cGF0aCBpcyBhIGJpdCBmcmFnaWxlIGFuZCBjb3VsZAo+PiBiZW5lZml0IGdyZWF0bHkgZnJvbSBl ZmZvcnRzIHRvIHVuaWZ5IHRoZSBsZWdhY3kgYW5kIGV4ZWMKPj4gbGlzdCBzdWJtaXNzaW9uIGNv ZGUgcGF0aHMuCj4+Cj4+IEF0IHRoZSBtb21lbnQgaTkxNV9nZW1fY29udGV4dF9maW5pIGhhcyBz cGVjaWFsIGNhc2luZyBmb3IgdGhlCj4+IHR3byB3aGljaCBhcmUgcG90ZW50aWFseSBub3QgbmVl ZGVkLCBhbmQgYWxzbyBkZXBlbmRzIG9uCj4+IGk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlciBy dW5uaW5nIGJlZm9yZSBpdHNlbGYuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+IElzc3VlOiBWSVotNDI3Nwo+PiBDYzogQ2hy aXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IENjOiBOaWNrIEhvYXRoIDxu aWNob2xhcy5ob2F0aEBpbnRlbC5jb20+Cj4+IC0tLQo+PiBJIGNhbm5vdCB0ZXN0IHRoaXMgd2l0 aCBHdUMgYnV0IGl0IHBhc3NlcyBCQVQgd2l0aCBleGVjbGlzdHMKPj4gYW5kIHNvbWUgcmVhbCB3 b3JsZCBzbW9rZSB0ZXN0cy4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fY29udGV4dC5jIHwgNCArKystCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMgICAgICAgIHwgNyArKysrKysrCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbV9jb250ZXh0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250 ZXh0LmMKPj4gaW5kZXggYzI1MDgzYzc4YmE3Li4wYjQxOWUxNjU4MzYgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMKPj4gQEAgLTQzOCw3ICs0MzgsOSBAQCB2 b2lkIGk5MTVfZ2VtX2NvbnRleHRfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgIAlm b3IgKGkgPSAwOyBpIDwgSTkxNV9OVU1fUklOR1M7IGkrKykgewo+PiAgIAkJc3RydWN0IGludGVs X2VuZ2luZV9jcyAqcmluZyA9ICZkZXZfcHJpdi0+cmluZ1tpXTsKPj4KPj4gLQkJaWYgKHJpbmct Pmxhc3RfY29udGV4dCkKPj4gKwkJaWYgKHJpbmctPmxhc3RfY29udGV4dCAmJiBpOTE1LmVuYWJs ZV9leGVjbGlzdHMpCj4+ICsJCQlpbnRlbF9scl9jb250ZXh0X3VucGluKHJpbmctPmxhc3RfY29u dGV4dCwgcmluZyk7Cj4+ICsJCWVsc2UgaWYgKHJpbmctPmxhc3RfY29udGV4dCkKPj4gICAJCQlp OTE1X2dlbV9jb250ZXh0X3VucmVmZXJlbmNlKHJpbmctPmxhc3RfY29udGV4dCk7Cj4+Cj4+ICAg CQlyaW5nLT5kZWZhdWx0X2NvbnRleHQgPSBOVUxMOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMu Ywo+PiBpbmRleCA1YzNmNTdmZWQ5MTYuLmI4YTdlMTI2ZDZkMiAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMKPj4gQEAgLTkxOCw2ICs5MTgsNyBAQCBpbnQgaW50ZWxfZXhlY2xpc3Rz X3N1Ym1pc3Npb24oc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcywKPj4gICAJ c3RydWN0IGludGVsX2VuZ2luZV9jcyAgKnJpbmcgPSBwYXJhbXMtPnJpbmc7Cj4+ICAgCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+ICAgCXN0 cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmID0gcGFyYW1zLT5jdHgtPmVuZ2luZVtyaW5n LT5pZF0ucmluZ2J1ZjsKPj4gKwlzdHJ1Y3QgaW50ZWxfY29udGV4dCAgICAqY3R4ID0gcGFyYW1z LT5yZXF1ZXN0LT5jdHg7Cj4+ICAgCXU2NCBleGVjX3N0YXJ0Owo+PiAgIAlpbnQgaW5zdHBfbW9k ZTsKPj4gICAJdTMyIGluc3RwX21hc2s7Cj4+IEBAIC05ODIsNiArOTgzLDEyIEBAIGludCBpbnRl bF9leGVjbGlzdHNfc3VibWlzc2lvbihzdHJ1Y3QgaTkxNV9leGVjYnVmZmVyX3BhcmFtcyAqcGFy YW1zLAo+Pgo+PiAgIAl0cmFjZV9pOTE1X2dlbV9yaW5nX2Rpc3BhdGNoKHBhcmFtcy0+cmVxdWVz dCwgcGFyYW1zLT5kaXNwYXRjaF9mbGFncyk7Cj4+Cj4+ICsJaWYgKHJpbmctPmxhc3RfY29udGV4 dCAmJiByaW5nLT5sYXN0X2NvbnRleHQgIT0gY3R4KSB7Cj4+ICsJCWludGVsX2xyX2NvbnRleHRf dW5waW4ocmluZy0+bGFzdF9jb250ZXh0LCByaW5nKTsKPj4gKwkJaW50ZWxfbHJfY29udGV4dF9w aW4oY3R4LCByaW5nKTsKPj4gKwkJcmluZy0+bGFzdF9jb250ZXh0ID0gY3R4Owo+PiArCX0KPgo+ IEkgdGhpbmsgdGhpcyBpcyB0aGUgd3JvbmcgbG9jYXRpb24gYW5kIHNob3VsZCBiZSBwYXJ0IG9m IHN1Ym1pdHRpbmcgdGhlCj4gY29udGV4dCBpbnNpZGUgdGhlIGVuZ2luZSAoYmVjYXVzZSBpbnRl bF9leGVjbGlzdHNfc3VibWlzc2lvbiBzaG91bGQgbm90Cj4gYXMgaXQgaXMgZW50aXJlbHkgZHVw bGljYXRpbmcgdGhlIGNvbW1vbiBHRU0gYmF0Y2ggc3VibWlzaW9uIGNvZGUgYW5kCj4gdGhlIHVu aXF1ZSBwYXJ0IGlzIGVuZ2luZS0+YWRkX3JlcXVlc3QoKSkuCgpTbyBpbnRvIGVuZ2luZS0+ZW1p dF9yZXF1ZXN0IHlvdSBhcmUgc2F5aW5nPyBUaGF0IHdvcmtzIGp1c3QgYXMgd2VsbCAKQUZBSUNT LCBqdXN0IG1ha2luZyBzdXJlIEkgdW5kZXJzdG9vZCBjb3JyZWN0bHkuCgo+IE5vdGUgdGhhdCBp dCBzaG91bGQgYmU6Cj4KPiBpZiAoZW5naW5lLT5sYXN0X2NvbnRleHQgIT0gcmVxdWVzdC0+Y3R4 KSB7Cj4gCWlmIChlbmdpbmUtPmxhc3RfY29udGV4dCkKPiAJCWludGVsX2xyX2NvbnRleHRfdW5w aW4oZW5naW5lLT5sYXN0X2NvbnRleHQsIGVuZ2luZSk7Cj4gCWVuZ2luZS0+bGFzdF9jb250ZXh0 ID0gcmVxdWVzdC0+Y3R4Owo+IAlpbnRlbF9scl9jb250ZXh0X3BpbihlbmdpbmUtPmxhc3RfY29u dGV4dCwgZW5naW5lKTsKPiB9CgpPb29wcyEKClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK