From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Hoath Subject: Re: [PATCH 3/3] drm/i915: Fix premature LRC unpin in GuC mode Date: Wed, 20 Jan 2016 14:21:08 +0000 Message-ID: <569F97D4.8000906@intel.com> References: <1453297257-4707-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1453297257-4707-3-git-send-email-tvrtko.ursulin@linux.intel.com> <20160120135500.GB16147@nuc-i3427.alporthouse.com> <569F9473.6020300@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C6E446E952 for ; Wed, 20 Jan 2016 06:21:11 -0800 (PST) In-Reply-To: <569F9473.6020300@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Chris Wilson , "Intel-gfx@lists.freedesktop.org" , "Ursulin, Tvrtko" List-Id: intel-gfx@lists.freedesktop.org T24gMjAvMDEvMjAxNiAxNDowNiwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4KPiBPbiAyMC8wMS8x NiAxMzo1NSwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+PiBPbiBXZWQsIEphbiAyMCwgMjAxNiBhdCAw MTo0MDo1N1BNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4+IEZyb206IFR2cnRrbyBV cnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Pgo+Pj4gSW4gR3VDIG1vZGUgTFJD IHBpbm5pbmcgbGlmZXRpbWUgZGVwZW5kcyBleGNsdXNpdmVseSBvbiB0aGUKPj4+IHJlcXVlc3Qg bGlmdGltZS4gU2luY2UgdGhhdCBpcyB0ZXJtaW5hdGVkIGJ5IHRoZSBzZXFubyB1cGRhdGUKPj4+ IHRoYXQgb3BlbnMgdXAgYSByYWNlIGNvbmRpdGlvbiBiZXR3ZWVuIEdQVSBmaW5pc2hpbmcgd3Jp dGluZwo+Pj4gb3V0IHRoZSBjb250ZXh0IGltYWdlIGFuZCB0aGUgZHJpdmVyIHVucGlubmluZyB0 aGUgTFJDLgo+Pj4KPj4+IFRvIGV4dGVuZCB0aGUgTFJDIGxpZmV0aW1lIHdlIHdpbGwgZW1wbG95 IGEgc2ltaWxhciBhcHByb2FjaAo+Pj4gdG8gd2hhdCBsZWdhY3kgcmluZ2J1ZmZlciBzdWJtaXNz aW9uIGRvZXMuCj4+Pgo+Pj4gV2Ugd2lsbCBzdGFydCB0cmFja2luZyB0aGUgbGFzdCBzdWJtaXR0 ZWQgY29udGV4dCBwZXIgZW5naW5lCj4+PiBhbmQga2VlcCBpdCBwaW5uZWQgdW50aWwgaXQgaXMg cmVwbGFjZWQgYnkgYW5vdGhlciBvbmUuCj4+Pgo+Pj4gTm90ZSB0aGF0IHRoZSBkcml2ZXIgdW5s b2FkIHBhdGggaXMgYSBiaXQgZnJhZ2lsZSBhbmQgY291bGQKPj4+IGJlbmVmaXQgZ3JlYXRseSBm cm9tIGVmZm9ydHMgdG8gdW5pZnkgdGhlIGxlZ2FjeSBhbmQgZXhlYwo+Pj4gbGlzdCBzdWJtaXNz aW9uIGNvZGUgcGF0aHMuCj4+Pgo+Pj4gQXQgdGhlIG1vbWVudCBpOTE1X2dlbV9jb250ZXh0X2Zp bmkgaGFzIHNwZWNpYWwgY2FzaW5nIGZvciB0aGUKPj4+IHR3byB3aGljaCBhcmUgcG90ZW50aWFs eSBub3QgbmVlZGVkLCBhbmQgYWxzbyBkZXBlbmRzIG9uCj4+PiBpOTE1X2dlbV9jbGVhbnVwX3Jp bmdidWZmZXIgcnVubmluZyBiZWZvcmUgaXRzZWxmLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFR2 cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+PiBJc3N1ZTogVklaLTQy NzcKPj4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+IENj OiBOaWNrIEhvYXRoIDxuaWNob2xhcy5ob2F0aEBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+IEkgY2Fu bm90IHRlc3QgdGhpcyB3aXRoIEd1QyBidXQgaXQgcGFzc2VzIEJBVCB3aXRoIGV4ZWNsaXN0cwo+ Pj4gYW5kIHNvbWUgcmVhbCB3b3JsZCBzbW9rZSB0ZXN0cy4KPj4+IC0tLQo+Pj4gICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jIHwgNCArKystCj4+PiAgICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgfCA3ICsrKysrKysKPj4+ICAgIDIgZmls ZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pj4KPj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMKPj4+IGluZGV4IGMyNTA4M2M3OGJhNy4u MGI0MTllMTY1ODM2IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fY29udGV4dC5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250 ZXh0LmMKPj4+IEBAIC00MzgsNyArNDM4LDkgQEAgdm9pZCBpOTE1X2dlbV9jb250ZXh0X2Zpbmko c3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4+ICAgIAlmb3IgKGkgPSAwOyBpIDwgSTkxNV9OVU1f UklOR1M7IGkrKykgewo+Pj4gICAgCQlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nID0gJmRl dl9wcml2LT5yaW5nW2ldOwo+Pj4KPj4+IC0JCWlmIChyaW5nLT5sYXN0X2NvbnRleHQpCj4+PiAr CQlpZiAocmluZy0+bGFzdF9jb250ZXh0ICYmIGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykKPj4+ICsJ CQlpbnRlbF9scl9jb250ZXh0X3VucGluKHJpbmctPmxhc3RfY29udGV4dCwgcmluZyk7Cj4+PiAr CQllbHNlIGlmIChyaW5nLT5sYXN0X2NvbnRleHQpCj4+PiAgICAJCQlpOTE1X2dlbV9jb250ZXh0 X3VucmVmZXJlbmNlKHJpbmctPmxhc3RfY29udGV4dCk7Cj4+Pgo+Pj4gICAgCQlyaW5nLT5kZWZh dWx0X2NvbnRleHQgPSBOVUxMOwo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4+IGluZGV4 IDVjM2Y1N2ZlZDkxNi4uYjhhN2UxMjZkNmQyIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4+PiBAQCAtOTE4LDYgKzkxOCw3IEBAIGludCBpbnRlbF9leGVjbGlzdHNfc3VibWlz c2lvbihzdHJ1Y3QgaTkxNV9leGVjYnVmZmVyX3BhcmFtcyAqcGFyYW1zLAo+Pj4gICAgCXN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgICpyaW5nID0gcGFyYW1zLT5yaW5nOwo+Pj4gICAgCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+PiAgICAJc3Ry dWN0IGludGVsX3JpbmdidWZmZXIgKnJpbmdidWYgPSBwYXJhbXMtPmN0eC0+ZW5naW5lW3Jpbmct PmlkXS5yaW5nYnVmOwo+Pj4gKwlzdHJ1Y3QgaW50ZWxfY29udGV4dCAgICAqY3R4ID0gcGFyYW1z LT5yZXF1ZXN0LT5jdHg7Cj4+PiAgICAJdTY0IGV4ZWNfc3RhcnQ7Cj4+PiAgICAJaW50IGluc3Rw X21vZGU7Cj4+PiAgICAJdTMyIGluc3RwX21hc2s7Cj4+PiBAQCAtOTgyLDYgKzk4MywxMiBAQCBp bnQgaW50ZWxfZXhlY2xpc3RzX3N1Ym1pc3Npb24oc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJh bXMgKnBhcmFtcywKPj4+Cj4+PiAgICAJdHJhY2VfaTkxNV9nZW1fcmluZ19kaXNwYXRjaChwYXJh bXMtPnJlcXVlc3QsIHBhcmFtcy0+ZGlzcGF0Y2hfZmxhZ3MpOwo+Pj4KPj4+ICsJaWYgKHJpbmct Pmxhc3RfY29udGV4dCAmJiByaW5nLT5sYXN0X2NvbnRleHQgIT0gY3R4KSB7Cj4+PiArCQlpbnRl bF9scl9jb250ZXh0X3VucGluKHJpbmctPmxhc3RfY29udGV4dCwgcmluZyk7Cj4+PiArCQlpbnRl bF9scl9jb250ZXh0X3BpbihjdHgsIHJpbmcpOwo+Pj4gKwkJcmluZy0+bGFzdF9jb250ZXh0ID0g Y3R4Owo+Pj4gKwl9Cj4+Cj4+IEkgdGhpbmsgdGhpcyBpcyB0aGUgd3JvbmcgbG9jYXRpb24gYW5k IHNob3VsZCBiZSBwYXJ0IG9mIHN1Ym1pdHRpbmcgdGhlCj4+IGNvbnRleHQgaW5zaWRlIHRoZSBl bmdpbmUgKGJlY2F1c2UgaW50ZWxfZXhlY2xpc3RzX3N1Ym1pc3Npb24gc2hvdWxkIG5vdAo+PiBh cyBpdCBpcyBlbnRpcmVseSBkdXBsaWNhdGluZyB0aGUgY29tbW9uIEdFTSBiYXRjaCBzdWJtaXNp b24gY29kZSBhbmQKPj4gdGhlIHVuaXF1ZSBwYXJ0IGlzIGVuZ2luZS0+YWRkX3JlcXVlc3QoKSku Cj4KPiBTbyBpbnRvIGVuZ2luZS0+ZW1pdF9yZXF1ZXN0IHlvdSBhcmUgc2F5aW5nPyBUaGF0IHdv cmtzIGp1c3QgYXMgd2VsbAo+IEFGQUlDUywganVzdCBtYWtpbmcgc3VyZSBJIHVuZGVyc3Rvb2Qg Y29ycmVjdGx5LgoKSSB0aGluayBpdCBzaG91bGQgZ28gaW4gdG8gaW50ZWxfbG9naWNhbF9yaW5n X2FkdmFuY2VfYW5kX3N1Ym1pdC4gVGhlIApleHRyYSBwaW5uaW5nIGlzIGJlaW5nIHB1dCBpbiBw bGFjZSB0byBjb3ZlciBHUFUgdXNhZ2Ugb2YgdGhlIHBpbi4gSXQgCnNob3VsZCBwcm9iYWJseSB0 aGVyZWZvcmUgZ28gaW4gdG8gdGhlIGxhc3QgY29tbW9uIHBsYWNlIGJldHdlZW4gCmV4ZWNsaXN0 cyAmIEdVQywgYXMgY2xvc2UgdG8gaGFyZHdhcmUgc3VibWlzc2lvbiBhcyBwb3NzaWJsZS4KCj4K Pj4gTm90ZSB0aGF0IGl0IHNob3VsZCBiZToKPj4KPj4gaWYgKGVuZ2luZS0+bGFzdF9jb250ZXh0 ICE9IHJlcXVlc3QtPmN0eCkgewo+PiAJaWYgKGVuZ2luZS0+bGFzdF9jb250ZXh0KQo+PiAJCWlu dGVsX2xyX2NvbnRleHRfdW5waW4oZW5naW5lLT5sYXN0X2NvbnRleHQsIGVuZ2luZSk7Cj4+IAll bmdpbmUtPmxhc3RfY29udGV4dCA9IHJlcXVlc3QtPmN0eDsKPj4gCWludGVsX2xyX2NvbnRleHRf cGluKGVuZ2luZS0+bGFzdF9jb250ZXh0LCBlbmdpbmUpOwo+PiB9Cj4KPiBPb29wcyEKPgo+IFJl Z2FyZHMsCj4KPiBUdnJ0a28KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK