From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/6] drm: introduce color correction properties
Date: Fri, 22 Jan 2016 10:20:08 +0000 [thread overview]
Message-ID: <56A20258.3090607@intel.com> (raw)
In-Reply-To: <20160121192021.GB13311@intel.com>
On 21/01/16 19:20, Matt Roper wrote:
> On Thu, Jan 21, 2016 at 03:03:49PM +0000, Lionel Landwerlin wrote:
> ...
>> diff --git a/Documentation/DocBook/gpu.tmpl b/Documentation/DocBook/gpu.tmpl
>> index 351e801..d2f682c 100644
>> --- a/Documentation/DocBook/gpu.tmpl
>> +++ b/Documentation/DocBook/gpu.tmpl
>> @@ -2092,6 +2092,54 @@ void intel_crt_init(struct drm_device *dev)
>> <td valign="top" >TBD</td>
>> </tr>
>> <tr>
>> + <td valign="top" >“DEGAMMA_LUT”</td>
>> + <td valign="top" >BLOB</td>
>> + <td valign="top" ></td>
>> + <td valign="top" >CRTC</td>
>> + <td valign="top" >DRM property to set the degamma LUT mapping
>> + pixel data from the framebuffer before it is given to the
>> + transformation matrix. The data is an interpreted as an array
>> + of struct drm_color_lut elements.</td>
>> + </tr>
>> + <tr>
>> + <td valign="top" >“DEGAMMA_LUT_SIZE”</td>
>> + <td valign="top" >IMMUTABLE</td>
> IMMUTABLE by itself isn't a property type, just a flag that you can
> apply in addition to the type. You probably want "RANGE | IMMUTABLE"
> here (and also on GAMMA_LUT_SIZE below).
>
> ...snip...
>> + <td valign="top" >“GAMMA_LUT_SIZE”</td>
>> + <td valign="top" >IMMUTABLE</td>
>> + <td valign="top" ></td>
>> + <td valign="top" >CRTC</td>
>> + <td valign="top" >DRM property to gives the size of the LUT to
>> + be set on the GAMMA_LUT property (the size depends on the
>> + underlying hardware).</td>
>> + </tr>
>> + <tr>
>> <td rowspan="20" valign="top" >i915</td>
>> <td rowspan="2" valign="top" >Generic</td>
>> <td valign="top" >"Broadcast RGB"</td>
> ...snip...
>> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
>> index d40bab2..6f96c04 100644
>> --- a/drivers/gpu/drm/drm_crtc.c
>> +++ b/drivers/gpu/drm/drm_crtc.c
>> @@ -1542,6 +1542,41 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
>> return -ENOMEM;
>> dev->mode_config.prop_mode_id = prop;
>>
>> + prop = drm_property_create(dev,
>> + DRM_MODE_PROP_BLOB,
>> + "DEGAMMA_LUT", 0);
>> + if (!prop)
>> + return -ENOMEM;
>> + dev->mode_config.degamma_lut_property = prop;
>> +
>> + prop = drm_property_create(dev,
>> + DRM_MODE_PROP_IMMUTABLE,
> As noted above, you still need to OR in a valid property type (in this
> case DRM_MODE_PROP_RANGE); otherwise you'll trip over the the check in
> drm_property_type_valid() that gets called at the end of
> drm_property_create().
>
>
> Matt
>
Thanks Matt,
Just realized that yesterday while talking to Damien.
Will fix in v2.
-
Lionel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-22 10:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 15:03 [PATCH 0/6] Pipe level color management Lionel Landwerlin
2016-01-21 15:03 ` [PATCH 1/6] drm/i915: Extract out gamma table and CSC to their own file Lionel Landwerlin
2016-01-21 15:24 ` Daniel Stone
2016-01-21 15:03 ` [PATCH 2/6] drm: introduce color correction properties Lionel Landwerlin
2016-01-21 19:20 ` Matt Roper
2016-01-22 10:20 ` Lionel Landwerlin [this message]
2016-01-21 15:03 ` [PATCH 3/6] drm/i915: enable CSC for pipe C Lionel Landwerlin
2016-01-21 15:03 ` [PATCH 4/6] drm/i915: enable legacy palette " Lionel Landwerlin
2016-01-21 15:03 ` [PATCH 5/6] drm/i915: Implement color management on bdw/skl/bxt/kbl Lionel Landwerlin
2016-01-21 15:03 ` [PATCH 6/6] drm/i915: Implement color management on chv Lionel Landwerlin
2016-01-21 15:42 ` ✗ Fi.CI.BAT: warning for Pipe level color management Patchwork
2016-01-22 15:04 ` [PATCH 0/6] " Daniel Stone
2016-01-22 15:38 ` [Intel-gfx] " Deucher, Alexander
2016-01-22 16:06 ` Lionel Landwerlin
2016-01-22 16:21 ` Daniel Vetter
2016-01-22 17:07 ` Daniel Stone
2016-01-26 12:18 ` [Intel-gfx] " Daniel Stone
-- strict thread matches above, loose matches on Subject: below --
2016-01-22 12:12 [PATCH 0/6] Pipe level color management V2 Lionel Landwerlin
2016-01-22 12:12 ` [PATCH 2/6] drm: introduce color correction properties Lionel Landwerlin
2016-01-22 21:20 ` Matt Roper
2016-01-25 10:57 ` Daniel Stone
2016-01-27 9:02 ` Matt Roper
2016-02-01 15:18 [PATCH 0/6] Pipe level color management V3 Lionel Landwerlin
2016-02-01 15:18 ` [PATCH 2/6] drm: introduce color correction properties Lionel Landwerlin
2016-02-09 12:19 [PATCH 0/6] Pipe level color management V4 Lionel Landwerlin
2016-02-09 12:19 ` [PATCH 2/6] drm: introduce color correction properties Lionel Landwerlin
2016-02-18 1:55 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A20258.3090607@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).