From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v3 3/3] drm/i915: Fix premature LRC unpin in
	GuC mode
Date: Fri, 22 Jan 2016 16:33:18 +0000
Message-ID: <56A259CE.8050408@linux.intel.com>
References: <1453371042-4109-1-git-send-email-tvrtko.ursulin@linux.intel.com>
 <1453371042-4109-3-git-send-email-tvrtko.ursulin@linux.intel.com>
 <20160121110250.GG16147@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 30F536E33E
 for <Intel-gfx@lists.freedesktop.org>; Fri, 22 Jan 2016 08:33:23 -0800 (PST)
In-Reply-To: <20160121110250.GG16147@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com>, Nick Hoath <nicholas.hoath@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDIxLzAxLzE2IDExOjAyLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gVGh1LCBKYW4gMjEs
IDIwMTYgYXQgMTA6MTA6NDJBTSArMDAwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206
IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IEluIEd1QyBt
b2RlIExSQyBwaW5uaW5nIGxpZmV0aW1lIGRlcGVuZHMgZXhjbHVzaXZlbHkgb24gdGhlCj4+IHJl
cXVlc3QgbGlmdGltZS4gU2luY2UgdGhhdCBpcyB0ZXJtaW5hdGVkIGJ5IHRoZSBzZXFubyB1cGRh
dGUKPj4gdGhhdCBvcGVucyB1cCBhIHJhY2UgY29uZGl0aW9uIGJldHdlZW4gR1BVIGZpbmlzaGlu
ZyB3cml0aW5nCj4+IG91dCB0aGUgY29udGV4dCBpbWFnZSBhbmQgdGhlIGRyaXZlciB1bnBpbm5p
bmcgdGhlIExSQy4KPj4KPj4gVG8gZXh0ZW5kIHRoZSBMUkMgbGlmZXRpbWUgd2Ugd2lsbCBlbXBs
b3kgYSBzaW1pbGFyIGFwcHJvYWNoCj4+IHRvIHdoYXQgbGVnYWN5IHJpbmdidWZmZXIgc3VibWlz
c2lvbiBkb2VzLgo+Pgo+PiBXZSB3aWxsIHN0YXJ0IHRyYWNraW5nIHRoZSBsYXN0IHN1Ym1pdHRl
ZCBjb250ZXh0IHBlciBlbmdpbmUKPj4gYW5kIGtlZXAgaXQgcGlubmVkIHVudGlsIGl0IGlzIHJl
cGxhY2VkIGJ5IGFub3RoZXIgb25lLgo+Pgo+PiBOb3RlIHRoYXQgdGhlIGRyaXZlciB1bmxvYWQg
cGF0aCBpcyBhIGJpdCBmcmFnaWxlIGFuZCBjb3VsZAo+PiBiZW5lZml0IGdyZWF0bHkgZnJvbSBl
ZmZvcnRzIHRvIHVuaWZ5IHRoZSBsZWdhY3kgYW5kIGV4ZWMKPj4gbGlzdCBzdWJtaXNzaW9uIGNv
ZGUgcGF0aHMuCj4+Cj4+IEF0IHRoZSBtb21lbnQgaTkxNV9nZW1fY29udGV4dF9maW5pIGhhcyBz
cGVjaWFsIGNhc2luZyBmb3IgdGhlCj4+IHR3byB3aGljaCBhcmUgcG90ZW50aWFseSBub3QgbmVl
ZGVkLCBhbmQgYWxzbyBkZXBlbmRzIG9uCj4+IGk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlciBy
dW5uaW5nIGJlZm9yZSBpdHNlbGYuCj4+Cj4+IHYyOgo+PiAgICogTW92ZSBwaW5uaW5nIGludG8g
ZW5naW5lLT5lbWl0X3JlcXVlc3QgYW5kIGFjdHVhbGx5IGZpeAo+PiAgICAgdGhlIHJlZmVyZW5j
ZS91bnJlZmVyZW5jZSBsb2dpYy4gKENocmlzIFdpbHNvbikKPj4KPj4gICAqIHJpbmctPmRldiBj
YW4gYmUgTlVMTCBvbiBkcml2ZXIgdW5sb2FkIHNvIHVzZSBhIGRpZmZlcmVudAo+PiAgICAgcm91
dGUgdG93YXJkcyBpdC4KPj4KPj4gdjM6Cj4+ICAgKiBSZWJhc2UuCj4+ICAgKiBIYW5kbGUgdGhl
IHJlc2V0IHBhdGguIChDaHJpcyBXaWxzb24pCj4+ICAgKiBFeGNsdWRlIGRlZmF1bHQgY29udGV4
dCBmcm9tIHRoZSBwaW5uaW5nIC0gaXQgaXMgaW1wb3NzaWJsZQo+PiAgICAgdG8gZ2V0IGl0IHJp
Z2h0IGJlZm9yZSBkZWZhdWx0IGNvbnRleHQgc3BlY2lhbCBjYXNpbmcgaW4KPj4gICAgIGdlbmVy
YWwgaXMgZWxpbWluYXRlZC4KPgo+IFNpbmNlIHlvdSBoYXZlIHRoZSByZWZhY3RvcmluZyBpbiBw
bGFjZSwgZWxpbWluYXRpbmcgdGhlIHNwZWNpYWwgY2FzZSBpcwo+IHRyaXZpYWwuIFNvIHBhdGNo
IDIuNT8KPgo+IExvb2tzIGxpa2UgaHR0cDovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0
Y2gvNjk5NzIvIGJ1dCB5b3UgYWxyZWFkeQo+IGhhdmUgaGFsZiBvZiB0aGF0IHBhdGNoIGluIHBs
YWNlLgo+Cj4gQWxzbyBpZiB3ZSB0YWtlIGEgc3RlcCB0byBhZGQgcGF0Y2ggMi4xOgo+Cj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+IGluZGV4IGMyNTA4M2M3OGJhNy4u
ZDQzYzg4NmZkOTVhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt
X2NvbnRleHQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQu
Ywo+IEBAIC0zMjEsNiArMzIxLDE0IEBAIGVycl9kZXN0cm95Ogo+ICAgICAgICAgIHJldHVybiBF
UlJfUFRSKHJldCk7Cj4gICB9Cj4KPiArc3RhdGljIHZvaWQgaTkxNV9nZW1fY29udGV4dF91bnBp
bihzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY3R4LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmNzKQo+ICt7Cj4gKyAgICAgICBpZiAo
cmNzLT5pZCA9PSBSQ1MgJiYgY3R4LT5sZWdhY3lfaHdfY3R4LnJjc19zdGF0ZSkKPiArICAgICAg
ICAgICAgICAgaTkxNV9nZW1fb2JqZWN0X2dndHRfdW5waW4oY3R4LT5sZWdhY3lfaHdfY3R4LnJj
c19zdGF0ZSk7Cj4gKyAgICAgICBpOTE1X2dlbV9jb250ZXh0X3VucmVmZXJlbmNlKGN0eCk7Cj4g
K30KPiArCj4gICB2b2lkIGk5MTVfZ2VtX2NvbnRleHRfcmVzZXQoc3RydWN0IGRybV9kZXZpY2Ug
KmRldikKPiAgIHsKPiAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg
PSBkZXYtPmRldl9wcml2YXRlOwo+IEBAIC0zMzgsMTMgKzM0Niw5IEBAIHZvaWQgaTkxNV9nZW1f
Y29udGV4dF9yZXNldChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+Cj4gICAgICAgICAgZm9yIChp
ID0gMDsgaSA8IEk5MTVfTlVNX1JJTkdTOyBpKyspIHsKPiAgICAgICAgICAgICAgICAgIHN0cnVj
dCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcgPSAmZGV2X3ByaXYtPnJpbmdbaV07Cj4gLSAgICAgICAg
ICAgICAgIHN0cnVjdCBpbnRlbF9jb250ZXh0ICpsY3R4ID0gcmluZy0+bGFzdF9jb250ZXh0Owo+
Cj4gLSAgICAgICAgICAgICAgIGlmIChsY3R4KSB7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAg
aWYgKGxjdHgtPmxlZ2FjeV9od19jdHgucmNzX3N0YXRlICYmIGkgPT0gUkNTKQo+IC0gICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgaTkxNV9nZW1fb2JqZWN0X2dndHRfdW5waW4obGN0eC0+
bGVnYWN5X2h3X2N0eC5yY3Nfc3RhdGUpOwo+IC0KPiAtICAgICAgICAgICAgICAgICAgICAgICBp
OTE1X2dlbV9jb250ZXh0X3VucmVmZXJlbmNlKGxjdHgpOwo+ICsgICAgICAgICAgICAgICBpZiAo
cmluZy0+bGFzdF9jb250ZXh0KSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgaTkxNV9nZW1f
Y29udGV4dF91bnBpbihyaW5nLT5sYXN0X2NvbnRleHQsIHJpbmcpOwo+ICAgICAgICAgICAgICAg
ICAgICAgICAgICByaW5nLT5sYXN0X2NvbnRleHQgPSBOVUxMOwo+ICAgICAgICAgICAgICAgICAg
fQo+Cj4gQEAgLTQyNCwyNSArNDI4LDE4IEBAIHZvaWQgaTkxNV9nZW1fY29udGV4dF9maW5pKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAgICAgICAgICAgICAgICAgKiB0byBvZmZzZXQgdGhl
IGRvX3N3aXRjaCBwYXJ0LCBzbyB0aGF0IGk5MTVfZ2VtX2NvbnRleHRfdW5yZWZlcmVuY2UoKQo+
ICAgICAgICAgICAgICAgICAgICogY2FuIHRoZW4gZnJlZSB0aGUgYmFzZSBvYmplY3QgY29ycmVj
dGx5LiAqLwo+ICAgICAgICAgICAgICAgICAgV0FSTl9PTighZGV2X3ByaXYtPnJpbmdbUkNTXS5s
YXN0X2NvbnRleHQpOwo+IC0gICAgICAgICAgICAgICBpZiAoZGV2X3ByaXYtPnJpbmdbUkNTXS5s
YXN0X2NvbnRleHQgPT0gZGN0eCkgewo+IC0gICAgICAgICAgICAgICAgICAgICAgIC8qIEZha2Ug
c3dpdGNoIHRvIE5VTEwgY29udGV4dCAqLwo+IC0gICAgICAgICAgICAgICAgICAgICAgIFdBUk5f
T04oZGN0eC0+bGVnYWN5X2h3X2N0eC5yY3Nfc3RhdGUtPmFjdGl2ZSk7Cj4gLSAgICAgICAgICAg
ICAgICAgICAgICAgaTkxNV9nZW1fb2JqZWN0X2dndHRfdW5waW4oZGN0eC0+bGVnYWN5X2h3X2N0
eC5yY3Nfc3RhdGUpOwo+IC0gICAgICAgICAgICAgICAgICAgICAgIGk5MTVfZ2VtX2NvbnRleHRf
dW5yZWZlcmVuY2UoZGN0eCk7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgZGV2X3ByaXYtPnJp
bmdbUkNTXS5sYXN0X2NvbnRleHQgPSBOVUxMOwo+IC0gICAgICAgICAgICAgICB9Cj4gLQo+ICAg
ICAgICAgICAgICAgICAgaTkxNV9nZW1fb2JqZWN0X2dndHRfdW5waW4oZGN0eC0+bGVnYWN5X2h3
X2N0eC5yY3Nfc3RhdGUpOwo+ICAgICAgICAgIH0KPgo+ICAgICAgICAgIGZvciAoaSA9IDA7IGkg
PCBJOTE1X05VTV9SSU5HUzsgaSsrKSB7Cj4gICAgICAgICAgICAgICAgICBzdHJ1Y3QgaW50ZWxf
ZW5naW5lX2NzICpyaW5nID0gJmRldl9wcml2LT5yaW5nW2ldOwo+Cj4gLSAgICAgICAgICAgICAg
IGlmIChyaW5nLT5sYXN0X2NvbnRleHQpCj4gLSAgICAgICAgICAgICAgICAgICAgICAgaTkxNV9n
ZW1fY29udGV4dF91bnJlZmVyZW5jZShyaW5nLT5sYXN0X2NvbnRleHQpOwo+ICsgICAgICAgICAg
ICAgICBpZiAocmluZy0+bGFzdF9jb250ZXh0KSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg
aTkxNV9nZW1fY29udGV4dF91bnBpbihyaW5nLT5sYXN0X2NvbnRleHQsIHJpbmcpOwo+ICsgICAg
ICAgICAgICAgICAgICAgICAgIHJpbmctPmxhc3RfY29udGV4dCA9IE5VTEw7Cj4gKyAgICAgICAg
ICAgICAgIH0KPgo+ICAgICAgICAgICAgICAgICAgcmluZy0+ZGVmYXVsdF9jb250ZXh0ID0gTlVM
TDsKPiAtICAgICAgICAgICAgICAgcmluZy0+bGFzdF9jb250ZXh0ID0gTlVMTDsKPiAgICAgICAg
ICB9Cj4KPiAgICAgICAgICBpOTE1X2dlbV9jb250ZXh0X3VucmVmZXJlbmNlKGRjdHgpOwo+Cj4g
VGhlbiB3ZSBqdXN0IGVuZCB1cCB3aXRoCj4KPiBpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKQo+
IAlpbnRlbF9scl9jb250ZXh0X3VucGluKHJpbmctPmxhc3RfY29udGV4dCwgcmluZyk7Cj4gZWxz
ZQo+IAlpOTE1X2dlbV9jb250ZXh0X3VucGluKHJpbmctPmxhc3RfY29udGV4dCwgcmluZyk7Cj4K
PiB3aGljaCBpcyBtdWNoIGxlc3MgbWVzc3kgaW4gdGhpcyBwYXRjaCBhbmQgb25lIHN0ZXAgY2xv
c2VyIHRvIHVuaWZ5aW5nCj4gZW5naW5lLT5waW5fY29udGV4dCgpL2VuZ2luZS0+dW5waW5fY29u
dGV4dCgpIHZmdW5zLgo+Cj4gVGhlIG9ubHkgdHJpY2t5IHBhcnQgdGhlcmUgaXMgaGF2aW5nIHRv
IGRpc2VudGFuZ2xlIHRoZSBsZWdhY3kgcGF0aHMsCj4gYnV0IGRvaW5nIHNvIHNob3VsZCBhbGxv
dyB1cyB0byBzZWUgY2xlYXJseSB0aGF0IHRoZSBzZXF1ZW5jZSBpcyBqdXN0Cj4KPiBpbnRlbF9n
cHVfcmVzZXQoKTsKPiBmb3JfZWFjaF9lbmdpbmUoKSB1bnBpbihlbmdpbmUtPmxhc3RfY29udGV4
dCk7Cj4gdW5waW4oZGV2X3ByaXYtPmRlZmF1bHRfY29udGV4dCk7Cj4KPiBBZnRlciBhIGZldyBt
b3JlIHBhc3Nlcywgd2Ugc2hvdWxkIGJlIGFibGUgdG8gY2FsbCB0aGUgcmVzZXQgYW5kIGNsZWFu
dXAKPiBmdW5jdGlvbnMgaGlnaGVyIHVwIChhcyBwYXJ0IG9mIHRoZSBzdG9wcGluZyB0aGUgR1BV
IHVwb24gc3VzcGVuZAo+IHByb2NlZHVyZSBiZWZvcmUgdGVhcmluZyBkb3duIHRoZSBzdyBzdHJ1
Y3RzKSBhdCB3aGljaCBwb2ludCB3ZSBvbmx5Cj4gbmVlZCB0aGUgdW5waW4oZGVmYXVsdF9jb250
ZXh0KSBoZXJlLgoKSSB3YXMgY29uZnVzZWQgYnkgdGhlIGN1cnJlbnQgY29kZSB3aGljaCBkb2Vz
IHRoZSByZXNldCBhZnRlciB1bnBpbm5pbmc6CgouLi4KCWk5MTVfZ2VtX3Jlc2V0KGRldik7CgoJ
c2ltdWxhdGVkID0gZGV2X3ByaXYtPmdwdV9lcnJvci5zdG9wX3JpbmdzICE9IDA7CgoJcmV0ID0g
aW50ZWxfZ3B1X3Jlc2V0KGRldik7Ci4uLgoKCldoYXQgaXMgcmlnaHQgdGhlbj8KClNvdW5kcyBi
YWQgdG8gYmUgdW5waW5uaW5nIHdpdGggdGhlIEdQVSBpbiB1bmtub3duIHN0YXRlLiBCdXQgb2J2
aW91c2x5IAppdCBoYXMgYmVlbiBsaWtlIHRoaXMgZm9yIHdobyBrbm93cyBob3cgbG9uZy4gU28g
SSBoYXZlIG5vIGlkZWEuIDooCgpBc2tpbmcgc2luY2UgR3VDIGlzIGF0IHRoZSBtb21lbnQgc3Ry
dWdnbGluZyB3aXRoIHJlc2V0LCBidXQgdGhlbiBhZ2FpbiAKdGhhdCBtaWdodCBiZSBzb21ldGhp
bmcgY29tcGxldGVseSBlbHNlLi4uCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==