From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v2 5/6] drm/i915: HWSP should be unmapped earlier in LRC teardown sequence Date: Mon, 25 Jan 2016 12:27:06 +0000 Message-ID: <56A6149A.6000403@intel.com> References: <1453504211-7982-1-git-send-email-david.s.gordon@intel.com> <1453504211-7982-6-git-send-email-david.s.gordon@intel.com> <20160125105607.GD10520@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id C79CE6E436 for ; Mon, 25 Jan 2016 04:27:07 -0800 (PST) In-Reply-To: <20160125105607.GD10520@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjUvMDEvMTYgMTA6NTYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBGcmksIEphbiAyMiwg MjAxNiBhdCAxMToxMDoxMFBNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gSW4gTFJDIG1v ZGUsIHRoZSBIV1NQIGlzIHBhcnQgb2YgdGhlIGRlZmF1bHQgY29udGV4dCBvYmplY3QsIGFuZAo+ PiB0aGVyZWZvcmUgZG9lcyBub3QgZXhpc3QgaW5kZXBlbmRlbnRseS4gV29yc2UsIGl0IGRvZXNu J3QgY29udHJpYnV0ZQo+PiB0byB0aGUgcmVmY291bnQgb24gdGhlIGRlZmF1bHQgY29udGV4dCBv YmplY3QgZWl0aGVyLgo+Pgo+PiBDdXJyZW50bHksIHRoZSBkZWZhdWx0IGNvbnRleHQgaXMgZGVh bGxvY2F0ZWQgaW4gaW50ZWxfbHJfY29udGV4dF9mcmVlKCksCj4+IGJ1dCB0aGUgSFdTUCBrbWFw cGluZyBpcyBub3QgdG9ybiBkb3duIHVudGlsIHRoZSBzdWJzZXF1ZW50IGNhbGwgdG8KPj4gaW50 ZWxfbG9naWNhbF9yaW5nX2NsZWFudXAoKS4gQmV0d2VlbiB0aGVzZSBjYWxscywgcmluZy0+c3Rh dHVzX3BhZ2Uub2JqCj4+IGNvbnRpbnVlcyB0byBwb2ludCB0byB0aGUgKG5vdyBub24tZXhpc3Rl bnQpIGRlZmF1bHQgY29udGV4dCBvYmplY3QsCj4+IGFuZCB0aGUga2VybmVsIG1hcHBpbmcgbGlr ZXdpc2UgcG9pbnRzIHRvIGEgcGFnZSB3aGljaCBpcyBub3cgZnJlZS4KPj4KPj4gVGhlIHNvbHV0 aW9uIGlzIHRvIGRpc3Bvc2Ugb2YgdGhlIEhXU1Aga21hcHBpbmcgYW5kIHBvaW50ZXIgYmVmb3Jl IHRoZQo+PiBvYmplY3QgaXRzZWxmIGlzIGZyZWVkLCBzbyB0aGlzIHBhdGNoIG1vdmVzIHRoZSBr bWFwIHRlYXJkb3duIGNvZGUgZnJvbQo+PiBpbnRlbF9scl9jb250ZXh0X2ZyZWUoKSB0byBpbnRl bF9sb2dpY2FsX3JpbmdfY2xlYW51cCgpLgo+Pgo+PiBUaGlzIGNvZGUgd2FzIGludHJvZHVjZWQg aW4KPj4KPj4gICAgICA0OGQ4MjM4IGRybS9pOTE1L2JkdzogR2VuZXJpYyBsb2dpY2FsIHJpbmcg aW5pdCBhbmQgY2xlYW51cAo+Pgo+PiBpLmUuIGl0IGhhcyBiZWVuIHRoZXJlIGV2ZXIgc2luY2Ug TFJDIG1vZGUgd2FzIGZpcnN0IGltcGxlbWVudGVkLgo+Pgo+PiB2MjoKPj4gICAgICBTcGxpdCBm cm9tICJoYW5kbGUgdGVhcmRvd24gb2YgSFdTUCB3aGVuIGNvbnRleHQgaXMgZnJlZWQiLgo+Pgo+ PiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+ PiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IC0t LQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMjYgKysrKysrKysrKysr KysrKysrKy0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgNyBk ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gaW5kZXggYTNhYjJi NC4uYzcwMmZjMiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gQEAgLTE5ODYs MTMgKzE5ODYsOSBAQCB2b2lkIGludGVsX2xvZ2ljYWxfcmluZ19jbGVhbnVwKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKnJpbmcpCj4+ICAgCWk5MTVfY21kX3BhcnNlcl9maW5pX3JpbmcocmluZyk7 Cj4+ICAgCWk5MTVfZ2VtX2JhdGNoX3Bvb2xfZmluaSgmcmluZy0+YmF0Y2hfcG9vbCk7Cj4+Cj4+ IC0JaWYgKHJpbmctPnN0YXR1c19wYWdlLm9iaikgewo+PiAtCQlzdHJ1Y3QgcGFnZSAqcGFnZTsK Pj4gLQo+PiAtCQlwYWdlID0gaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKHJpbmctPnN0YXR1c19w YWdlLm9iaiwgTFJDX1BQSFdTUF9QTik7Cj4+IC0JCWt1bm1hcChwYWdlKTsKPj4gLQkJcmluZy0+ c3RhdHVzX3BhZ2Uub2JqID0gTlVMTDsKPj4gLQl9Cj4+ICsJLyogU3RhdHVzIHBhZ2Ugc2hvdWxk IGhhdmUgZ29uZSBhbHJlYWR5ICovCj4+ICsJV0FSTl9PTihyaW5nLT5zdGF0dXNfcGFnZS5wYWdl X2FkZHIpOwo+PiArCVdBUk5fT04ocmluZy0+c3RhdHVzX3BhZ2Uub2JqKTsKPj4KPj4gICAJcmlu Zy0+ZGlzYWJsZV9saXRlX3Jlc3RvcmVfd2EgPSBmYWxzZTsKPj4gICAJcmluZy0+Y3R4X2Rlc2Nf dGVtcGxhdGUgPSAwOwo+PiBAQCAtMjQzMSw2ICsyNDI3LDIyIEBAIHZvaWQgaW50ZWxfbHJfY29u dGV4dF9mcmVlKHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHgpCj4+ICAgCQkJY29udGludWU7Cj4+ Cj4+ICAgCQlpZiAoY3R4ID09IGN0eC0+aTkxNS0+a2VybmVsX2NvbnRleHQpIHsKPj4gKwkJCXN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcgPSByaW5nYnVmLT5yaW5nOwo+PiArCj4+ICsJCQkv Kgo+PiArCQkJICogVGhlIEhXU1AgaXMgcGFydCBvZiB0aGUga2VybmVsIGNvbnRleHQKPj4gKwkJ CSAqIG9iamVjdCBpbiBMUkMgbW9kZSwgc28gdGVhciBpdCBkb3duIG5vdy4KPj4gKwkJCSAqLwo+ PiArCQkJaWYgKHJpbmctPnN0YXR1c19wYWdlLm9iaikgewo+PiArCQkJCXN0cnVjdCBwYWdlICpw YWdlOwo+PiArCj4+ICsJCQkJcGFnZSA9IGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZSgKPj4gKwkJ CQkJCXJpbmctPnN0YXR1c19wYWdlLm9iaiwKPj4gKwkJCQkJCUxSQ19QUEhXU1BfUE4pOwo+PiAr CQkJCWt1bm1hcChwYWdlKTsKPj4gKwkJCQlyaW5nLT5zdGF0dXNfcGFnZS5vYmogPSBOVUxMOwo+ PiArCQkJfQo+Cj4gTm8uIEkgc2VlIG5vIHJlYXNvbiB3aHkgd2UgbmVlZCB0byBhZGQgc3BlY2lh bCBjb2RlIHRvIHRoZSBjb250ZXh0LWZyZWUuCj4gLUNocmlzCgpUaGUgc3BlY2lhbC1jYXNlLWtl cm5lbC1jb250ZXh0IHRlc3QgL2lzIGFscmVhZHkgdGhlcmUvLgoKSSdtIGp1c3QgbWFraW5nIGl0 IGRvIHRoZSByaWdodCB0aGluZyBieSBtb3ZpbmcgdGhpcyBibG9jayBvdXQgb2YgCmludGVsX2xv Z2ljYWxfcmluZ19jbGVhbnVwKCkgYW5kIGludG8gdGhlIC9leGlzdGluZy8gc3BlY2lhbCBjYXNl LgoKR2V0dGluZyByaWQgb2YgdGhlIHNwZWNpYWwgY2FzZSBlbnRpcmVseSBpcyBhIHByb2plY3Qg Zm9yIGFub3RoZXIgZGF5LCAKd2hlcmVhcyB0aGlzIGlzIGEgYnVnIGZpeCAoTk9UIHVubWFwcGlu ZyBpdCBoZXJlIGxlYXZlcyBhIGRhbmdsaW5nIApyZWZlcmVuY2UgdG8gYW4gb2JqZWN0IHRoYXQg aGFzIGJlZW4gZnJlZWQpLgoKT1RPSCBJIGNhbiBjaGFuZ2UgdGhpcyB0byB1c2U6CglrdW5tYXAo a21hcF90b19wYWdlKHJpbmctPnN0YXR1c19wYWdlLnBhZ2VfYWRkcikpOwpwZXIgdGhlIHByZXZp b3VzIHJlcGx5LCB3aGljaCB3aWxsIG1ha2UgaXQgYSBiaXQgbmVhdGVyLgoKLkRhdmUuCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==