From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/4] drm/i915: Fix context/engine cleanup order Date: Tue, 26 Jan 2016 10:45:42 +0000 Message-ID: <56A74E56.8060108@linux.intel.com> References: <1453405067-32890-1-git-send-email-david.s.gordon@intel.com> <1453405067-32890-3-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DF1E6E20B for ; Tue, 26 Jan 2016 02:45:44 -0800 (PST) In-Reply-To: <1453405067-32890-3-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIxLzAxLzE2IDE5OjM3LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBGcm9tOiBOaWNrIEhvYXRo IDxuaWNob2xhcy5ob2F0aEBpbnRlbC5jb20+Cj4KPiBTd2FwIHRoZSBvcmRlciBvZiBjb250ZXh0 ICYgZW5naW5lIGNsZWFudXAsIHNvIHRoYXQgY29udGV4dHMgYXJlIGNsZWFuZWQKPiB1cCBmaXJz dCwgYW5kICp0aGVuKiBlbmdpbmVzLiBUaGlzIGlzIGEgbW9yZSBzZW5zaWJsZSBvcmRlciBhbnl3 YXksIGJ1dAo+IGluIHBhcnRpY3VsYXIgaGFzIGJlY29tZSBuZWNlc3Nhcnkgc2luY2UgdGhlICdp bnRlbF9yaW5nX2luaXRpYWxpemVkKCkKPiBtdXN0IGJlIHNpbXBsZSBhbmQgaW5saW5lJyBwYXRj aCwgd2hpY2ggbm93IHVzZXMgcmluZy0+ZGV2IGFzIGFuCj4gJ2luaXRpYWxpc2VkJyBmbGFnLCBz byBpdCBjYW4gbm93IGJlIE5VTEwgYWZ0ZXIgZW5naW5lIHRlYXJkb3duLiBUaGlzCj4gaW4gdHVy biBjYW4gY2F1c2UgYSBwcm9ibGVtIGluIHRoZSBjb250ZXh0IGNvZGUsIHdoaWNoICh1c2VkIHRv KSBjaGVjawo+IHRoZSByaW5nLT5kZXYtPnN0cnVjdF9tdXRleCAtLSBjYXVzaW5nIGEgZmF1bHQg aWYgcmluZy0+ZGV2IHdhcyBOVUxMLgo+Cj4gQWxzbyByZW5hbWUgdGhlIGNsZWFudXAgZnVuY3Rp b24gdG8gcmVmbGVjdCB3aGF0IGl0IGFjdHVhbGx5IGRvZXMKPiAoY2xlYW51cCBlbmdpbmVzLCBu b3QgYSByaW5nYnVmZmVyKSwgYW5kIGZpeCBhbiBhbm5veWluZyB3aGl0ZXNwYWNlIGlzc3VlLgo+ Cj4gdjI6IEFsc28gbWFrZSB0aGUgZml4IGluIGk5MTVfbG9hZF9tb2Rlc2V0X2luaXQsIG5vdCBq dXN0IGluCj4gICAgICBpOTE1X2RyaXZlcl91bmxvYWQgKENocmlzIFdpbHNvbikKPiB2MzogSGFk IGV4dHJhIHN0dWZmIGluIGl0Lgo+IHY0OiBSZXZlcnRlZCBleHRyYSBzdHVmZiAoc28gd2UncmUg YmFjayB0byB2MikuCj4gICAgICBSZWJhc2VkIGFuZCB1cGRhdGVkIGNvbW1lbnRhcnkgYWJvdmUg KERhdmUgR29yZG9uKS4KPgo+IFNpZ25lZC1vZmYtYnk6IE5pY2sgSG9hdGggPG5pY2hvbGFzLmhv YXRoQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jk b25AaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4gKHYyKQo+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGlu dXguaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNo Pgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPgo+IC0tLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYyB8ICA0ICsrLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggfCAgMiArLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYyB8IDIzICsrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gICAzIGZpbGVzIGNoYW5n ZWQsIDE1IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2RtYS5jCj4gaW5kZXggZDcwZDk2Zi4uNDcyNWU4ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2RtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k bWEuYwo+IEBAIC00NTEsOCArNDUxLDggQEAgc3RhdGljIGludCBpOTE1X2xvYWRfbW9kZXNldF9p bml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4KPiAgIGNsZWFudXBfZ2VtOgo+ICAgCW11dGV4 X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAtCWk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZl cihkZXYpOwo+ICAgCWk5MTVfZ2VtX2NvbnRleHRfZmluaShkZXYpOwo+ICsJaTkxNV9nZW1fY2xl YW51cF9lbmdpbmVzKGRldik7Cj4gICAJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7 Cj4gICBjbGVhbnVwX2lycToKPiAgIAlpbnRlbF9ndWNfdWNvZGVfZmluaShkZXYpOwo+IEBAIC0x MTk2LDggKzExOTYsOCBAQCBpbnQgaTkxNV9kcml2ZXJfdW5sb2FkKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4KPiAgIAlpbnRlbF9ndWNfdWNvZGVfZmluaShkZXYpOwo+ICAgCW11dGV4X2xvY2so JmRldi0+c3RydWN0X211dGV4KTsKPiAtCWk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlcihkZXYp Owo+ICAgCWk5MTVfZ2VtX2NvbnRleHRfZmluaShkZXYpOwo+ICsJaTkxNV9nZW1fY2xlYW51cF9l bmdpbmVzKGRldik7Cgpjb250ZXh0X2ZpbmkgYXNzdW1lcyBpdCBpcyB0aGUgb25lIHdobyBpcyBk cm9wcGluZyB0aGUgbGFzdCByZWZlcmVuY2UgdG8gCnRoZSBkZWZhdWx0L2tlcm5lbCBjb250ZXh0 IGFuZCBOVUxMcyB0aGUgcG9pbnRlci4KCkdvaW5nIGZvcndhcmQgdGhpcyBtZWFucyB0aGVyZSBp cyB0aGlzIGhpZGRlbiBkZXBlbmRlbmN5IHRoYXQgZW5naW5lcyAKbXVzdCBub3QgaG9sZCB0aGUg cmVmZXJlbmNlIHRvIHRoZSBrZXJuZWwgY29udGV4dCwgYXQgbGVhc3Qgbm90IHJlbHkgb24gCmRl dl9wcml2LT5rZXJuZWxfY29udGV4dCwgb3Igd2Ugd291bGQgZWl0aGVyIGxlYWsgdGhlIHJlZmVy ZW5jZSBvciBudWxsIApwdHIgZGVyZWYuCgpJIGRvbid0IGtub3csIHNvbWVob3cgZmVlbHMgYSBi aXQgZnJhZ2lsZS4gQnV0IGEgbG90IG9mIHRoaW5ncyBzZWVtIApmcmFnaWxlIGFyb3VuZCBoZXJl LgoKSWYgdGhlIG1haW4gbW90aXZhdGlvbiBpcyB0byBlbnN1cmUgYWNjZXNzIHRvIHJpbmctPmRl diwgdGhlbiBjdHgtPmk5MTUgCmNvdWxkIGJlIHVzZWQgZnJvbSB0aGUgY29udGV4dCBjbGVhbnVw IGNvZGUuIEZvciB0aGUgb3JkZXJpbmcgaXRzZWxmIEkgCmFtIG5vdCBzdXJlIHdoYXQgaXMgbW9y ZSBsb2dpY2FsLiBJZGxlIEdQVSAtPiBzaHV0ZG93biBlbmdpbmVzIC0+IApjbGVhbnVwIGNvbnRl eHRzIHNvdW5kcyBPSyB0byBtZSBzaW5jZSB0aGUgZW5naW5lcyBhcmUgdGhlIG9uZXMgd2hpY2gg CmNhbiBob2xkIHJlZmVyZW5jZXMgdG8gY29udGV4dHMuIFNvIGxvZ2ljYWxseSBjbGVhbmluZyB1 cCBjb250ZXh0IGJlZm9yZSAKZW5naW5lcyBmZWVscyBzdHJhbmdlLiBCdXQgSSBhbSBzdXJlIGFu IG9wcG9zaXRlIGFyZ3VtZW50IGNvdWxkIGFsc28gYmUgCm1hZGU/CgpSZWdhcmRzLAoKVHZydGtv Cgo+ICAgCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCWludGVsX2ZiY19j bGVhbnVwX2NmYihkZXZfcHJpdik7Cj4gICAJaTkxNV9nZW1fY2xlYW51cF9zdG9sZW4oZGV2KTsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCAyMDQ2NjFmLi4wMjFlODhhIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTMwMTIsNyArMzAxMiw3IEBAIGludCBpOTE1X2dl bV9pbml0X3JpbmdzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICAgaW50IF9fbXVzdF9jaGVj ayBpOTE1X2dlbV9pbml0X2h3KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICAgaW50IGk5MTVf Z2VtX2wzX3JlbWFwKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLCBpbnQgc2xpY2Up Owo+ICAgdm9pZCBpOTE1X2dlbV9pbml0X3N3aXp6bGluZyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KTsKPiAtdm9pZCBpOTE1X2dlbV9jbGVhbnVwX3JpbmdidWZmZXIoc3RydWN0IGRybV9kZXZpY2Ug KmRldik7Cj4gK3ZvaWQgaTkxNV9nZW1fY2xlYW51cF9lbmdpbmVzKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpOwo+ICAgaW50IF9fbXVzdF9jaGVjayBpOTE1X2dwdV9pZGxlKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpOwo+ICAgaW50IF9fbXVzdF9jaGVjayBpOTE1X2dlbV9zdXNwZW5kKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpOwo+ICAgdm9pZCBfX2k5MTVfYWRkX3JlcXVlc3Qoc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXEsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggMzcx YmJiMi4uNzk5YTUzYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC00OTEyLDcg KzQ5MTIsNyBAQCBpbnQgaTkxNV9nZW1faW5pdF9yaW5ncyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQo+ICAgCQlyZXEgPSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHJpbmcsIE5VTEwpOwo+ICAgCQlp ZiAoSVNfRVJSKHJlcSkpIHsKPiAgIAkJCXJldCA9IFBUUl9FUlIocmVxKTsKPiAtCQkJaTkxNV9n ZW1fY2xlYW51cF9yaW5nYnVmZmVyKGRldik7Cj4gKwkJCWk5MTVfZ2VtX2NsZWFudXBfZW5naW5l cyhkZXYpOwo+ICAgCQkJZ290byBvdXQ7Cj4gICAJCX0KPgo+IEBAIC00OTI1LDcgKzQ5MjUsNyBA QCBpbnQgaTkxNV9nZW1faW5pdF9yaW5ncyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCQlp ZiAocmV0ICYmIHJldCAhPSAtRUlPKSB7Cj4gICAJCQlEUk1fRVJST1IoIlBQR1RUIGVuYWJsZSBy aW5nICMlZCBmYWlsZWQgJWRcbiIsIGksIHJldCk7Cj4gICAJCQlpOTE1X2dlbV9yZXF1ZXN0X2Nh bmNlbChyZXEpOwo+IC0JCQlpOTE1X2dlbV9jbGVhbnVwX3JpbmdidWZmZXIoZGV2KTsKPiArCQkJ aTkxNV9nZW1fY2xlYW51cF9lbmdpbmVzKGRldik7Cj4gICAJCQlnb3RvIG91dDsKPiAgIAkJfQo+ Cj4gQEAgLTQ5MzMsNyArNDkzMyw3IEBAIGludCBpOTE1X2dlbV9pbml0X3JpbmdzKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4gICAJCWlmIChyZXQgJiYgcmV0ICE9IC1FSU8pIHsKPiAgIAkJCURS TV9FUlJPUigiQ29udGV4dCBlbmFibGUgcmluZyAjJWQgZmFpbGVkICVkXG4iLCBpLCByZXQpOwo+ ICAgCQkJaTkxNV9nZW1fcmVxdWVzdF9jYW5jZWwocmVxKTsKPiAtCQkJaTkxNV9nZW1fY2xlYW51 cF9yaW5nYnVmZmVyKGRldik7Cj4gKwkJCWk5MTVfZ2VtX2NsZWFudXBfZW5naW5lcyhkZXYpOwo+ ICAgCQkJZ290byBvdXQ7Cj4gICAJCX0KPgo+IEBAIC01MDA4LDcgKzUwMDgsNyBAQCBpbnQgaTkx NV9nZW1faW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgfQo+Cj4gICB2b2lkCj4gLWk5 MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICtpOTE1 X2dlbV9jbGVhbnVwX2VuZ2luZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIHsKPiAgIAlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAg CXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmc7Cj4gQEAgLTUwMTcsMTMgKzUwMTcsMTQgQEAg aW50IGk5MTVfZ2VtX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAlmb3JfZWFjaF9y aW5nKHJpbmcsIGRldl9wcml2LCBpKQo+ICAgCQlkZXZfcHJpdi0+Z3QuY2xlYW51cF9yaW5nKHJp bmcpOwo+Cj4gLSAgICBpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKQo+IC0gICAgICAgICAgICAv Kgo+IC0gICAgICAgICAgICAgKiBOZWl0aGVyIHRoZSBCSU9TLCBvdXJzZWx2ZXMgb3IgYW55IG90 aGVyIGtlcm5lbAo+IC0gICAgICAgICAgICAgKiBleHBlY3RzIHRoZSBzeXN0ZW0gdG8gYmUgaW4g ZXhlY2xpc3RzIG1vZGUgb24gc3RhcnR1cCwKPiAtICAgICAgICAgICAgICogc28gd2UgbmVlZCB0 byByZXNldCB0aGUgR1BVIGJhY2sgdG8gbGVnYWN5IG1vZGUuCj4gLSAgICAgICAgICAgICAqLwo+ IC0gICAgICAgICAgICBpbnRlbF9ncHVfcmVzZXQoZGV2KTsKPiArCWlmIChpOTE1LmVuYWJsZV9l eGVjbGlzdHMpIHsKPiArCQkvKgo+ICsJCSAqIE5laXRoZXIgdGhlIEJJT1MsIG91cnNlbHZlcyBv ciBhbnkgb3RoZXIga2VybmVsCj4gKwkJICogZXhwZWN0cyB0aGUgc3lzdGVtIHRvIGJlIGluIGV4 ZWNsaXN0cyBtb2RlIG9uIHN0YXJ0dXAsCj4gKwkJICogc28gd2UgbmVlZCB0byByZXNldCB0aGUg R1BVIGJhY2sgdG8gbGVnYWN5IG1vZGUuCj4gKwkJICovCj4gKwkJaW50ZWxfZ3B1X3Jlc2V0KGRl dik7Cj4gKwl9Cj4gICB9Cj4KPiAgIHN0YXRpYyB2b2lkCj4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK