From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms. Date: Wed, 27 Jan 2016 12:27:16 +0000 Message-ID: <56A8B7A4.3090404@intel.com> References: <1453750159-26475-1-git-send-email-rodrigo.vivi@intel.com> <20160125211715.GA9621@nuc-i3427.alporthouse.com> <20160126082958.GC32190@nuc-i3427.alporthouse.com> <20160126140648.GL8281@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 470A96E6B8 for ; Wed, 27 Jan 2016 04:27:19 -0800 (PST) In-Reply-To: <20160126140648.GL8281@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Rodrigo Vivi , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org T24gMjYvMDEvMTYgMTQ6MDYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUdWUsIEphbiAyNiwg MjAxNiBhdCAwMTo1MToxOVBNICswMDAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4+ICAgICBPbiBU dWUsIEphbiAyNiwgMjAxNiBhdCAxMjozMCBBTSBDaHJpcyBXaWxzb24KPj4gICAgIDxbMV1jaHJp c0BjaHJpcy13aWxzb24uY28udWs+IHdyb3RlOgo+Pgo+PiAgICAgICBPbiBNb24sIEphbiAyNSwg MjAxNiBhdCAwOToxNzoxNVBNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+ICAgICAgID4g T24gTW9uLCBKYW4gMjUsIDIwMTYgYXQgMTE6Mjk6MTlBTSAtMDgwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+PiAgICAgICA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK Pj4gICAgICAgPiA+IEBAIC03NjQsMTggKzc2NCwxOCBAQCBpbnRlbF9sb2dpY2FsX3JpbmdfYWR2 YW5jZV9hbmRfc3VibWl0KHN0cnVjdAo+PiAgICAgICBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVx dWVzdCkKPj4gICAgICAgPiA+ICB7Cj4+ICAgICAgID4gPiAgICAgc3RydWN0IGludGVsX3Jpbmdi dWZmZXIgKnJpbmdidWYgPSByZXF1ZXN0LT5yaW5nYnVmOwo+PiAgICAgICA+ID4gICAgIHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJlcXVlc3QtPmk5MTU7Cj4+ICAgICAgID4g PiArICAgaW50IGk7Cj4+ICAgICAgID4gPgo+PiAgICAgICA+ID4gICAgIGludGVsX2xvZ2ljYWxf cmluZ19hZHZhbmNlKHJpbmdidWYpOwo+PiAgICAgICA+ID4gICAgIHJlcXVlc3QtPnRhaWwgPSBy aW5nYnVmLT50YWlsOwo+PiAgICAgICA+ID4KPj4gICAgICAgPiA+ICAgICAvKgo+PiAgICAgICA+ ID4gLSAgICAqIEhlcmUgd2UgYWRkIHR3byBleHRyYSBOT09QcyBhcyBwYWRkaW5nIHRvIGF2b2lk Cj4+ICAgICAgID4gPiArICAgICogSGVyZSB3ZSBhZGQgZXh0cmEgTk9PUHMgYXMgcGFkZGluZyB0 byBhdm9pZAo+PiAgICAgICA+ID4gICAgICAqIGxpdGUgcmVzdG9yZSBvZiBhIGNvbnRleHQgd2l0 aCBIRUFEPT1UQUlMLgo+PiAgICAgICA+ID4gLSAgICAqCj4+ICAgICAgID4gPiAtICAgICogQ2Fs bGVyIG11c3QgcmVzZXJ2ZSBXQV9UQUlMX0RXT1JEUyBmb3IgdXMhCj4+ICAgICAgID4gPiAgICAg ICovCj4+ICAgICAgID4gPiAtICAgaW50ZWxfbG9naWNhbF9yaW5nX2VtaXQocmluZ2J1ZiwgTUlf Tk9PUCk7Cj4+ICAgICAgID4gPiAtICAgaW50ZWxfbG9naWNhbF9yaW5nX2VtaXQocmluZ2J1Ziwg TUlfTk9PUCk7Cj4+ICAgICAgID4gPiArICAgZm9yIChpID0gMDsgaSA8IHJpbmdidWYtPndhX3Rh aWxfZHdvcmRzOyBpKyspCj4+ICAgICAgID4gPiArICAgICAgICAgICBpbnRlbF9sb2dpY2FsX3Jp bmdfZW1pdChyaW5nYnVmLCBNSV9OT09QKTsKPj4gICAgICAgPiA+ICsKPj4gICAgICAgPiA+ICAg ICBpbnRlbF9sb2dpY2FsX3JpbmdfYWR2YW5jZShyaW5nYnVmKTsKPj4gICAgICAgPiA+Cj4+ICAg ICAgID4gPiAgICAgaWYgKGludGVsX3Jpbmdfc3RvcHBlZChyZXF1ZXN0LT5yaW5nKSkKPj4gICAg ICAgPiA+IEBAIC04NzYsNiArODc2LDE2IEBAIGludCBpbnRlbF9sb2dpY2FsX3JpbmdfYmVnaW4o c3RydWN0Cj4+ICAgICAgIGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEsIGludCBudW1fZHdvcmRz KQo+PiAgICAgICA+ID4gICAgIGlmIChyZXQpCj4+ICAgICAgID4gPiAgICAgICAgICAgICByZXR1 cm4gcmV0Owo+PiAgICAgICA+ID4KPj4gICAgICAgPiA+ICsgICBpZiAoSVNfR0VOOChyZXEtPnJp bmctPmRldikgfHwgSVNfR0VOOShyZXEtPnJpbmctPmRldikpCj4+ICAgICAgID4KPj4gICAgICAg PiByZXEtPmk5MTUKPj4gICAgICAgPgo+PiAgICAgICA+IFRoaXMgaXMgYXR0cm9jaW91cy4gSnVz dCBhbGxvY2F0ZSB0aGUgZXh0cmEgc3BhY2Ugd2hlbiByZXF1aXJlZC4KPj4KPj4gICAgIGJ5IHRo aXMgbG9naWMgSSBzaG91bGQganVzdCBlbWl0IHRoZSBtaV9ub29wcyB3aGVuIHJlcXVpcmVkIGFz IHdlbGwsCj4+ICAgICByaWdodD8KPgo+IFllcywgSSBkaWRuJ3QgbGlrZSB0aGUgcGxhY2VtZW50 IG9mIHRoZSB3YV90YWlsIGJ1dCBJIHdlbnQgd2l0aCB0aGF0IHRvCj4gYXZvaWQgdGhlIGNvZGUg ZHVwbGljYXRpb24uCj4KPj4gICAgICAgU2xpZ2h0bHkgbGVzcyBncnVtcHkgdGhpcyBtb3JuaW5n Lgo+Pgo+PiAgICAgdGhhbmtzCj4+Cj4+ICAgICAgIDEuIFRoaXMgaXMgZHVwbGljYXRpbmcgdGhl IHJlc2VydmVkLXNwYWNlIG1lY2hhbmlzbSwgYnkgb3Blbi1jb2RpbmcgdGhlCj4+ICAgICAgIHJl cXVpcmVtZW50cyBmb3IgZXhlY2xpc3RzLiBGaW5lLXR1bmluZyB0aGUgcmVzZXJ2ZWQgc3BhY2Ug cGVyIHJpbmcgbWF5Cj4+ICAgICAgIGJlIHdvcnRoIGl0LCBidXQgcHJvYmFibHkgbm90LiBPdmVy IHJlc2VydmluZyBzcGFjZSBpcyBub3QgYSBodW5nIGlzc3VlCj4+ICAgICAgIChpdCBqdXN0IGVm ZmVjdGl2ZWx5IHJlZHVjZXMgdGhlIHNpemUgb2YgdGhlIHJpbmcpLCBhbmQgdGhlIGdyYW51bGFy aXR5Cj4+ICAgICAgIGlzIHRoZSBzaXplIG9mIHRoZSBhdmVyYWdlIHJlcXVlc3QuCj4+Cj4+ICAg ICBmb3JnaXZlIHRoaXMgY2x1ZWxlc3MgbWluZCBoZXJlLCBidXQgSSBkb24ndCBzZWUgaG93IEkn bSBkdXBsaWNhdGluZyB0aGUKPj4gICAgIHJlc2VydmVkLXNwYWNlLi4uCj4KPiBZb3UgYXJlIGV4 dGVuZGluZyBldmVyeSBiZWdpbiBieSB0aGUgb3ZlcmFsbG9jYXRpb24gcmVxdWlyZWQgdG8gZW1p dAo+IHRoZSB0YWlsIGR3b3Jkcy4gV2UgYWxyZWFkeSBleHRlbmQgZXZlcnkgYmVnaW4gYnkgdGhl IG92ZXJhbGxvY2F0aW9uCj4gcmVxdWlyZWQgdG8gZW1pdCB0aGUgcmVxdWVzdCAodW50aWwgd2Ug Y29tZSB0byBlbWl0IHRoZSByZXF1ZXN0LCB3aGVyZQo+IHRoZXJlIGlzIG5vIG1vcmUgb3ZlcmFs bG9jYXRpb24gYXBwbGllZCkuCj4KPj4gICAgICAgMi4gWW91IGFyZSBoaWRpbmcgaG93IG11Y2gg c3BhY2UgaXMgYWN0dWFsbHkgdXNlZCBkdXJpbmcgcmVxdWVzdAo+PiAgICAgICBlbWlzc2lvbi4g VGhpcyBtYWtlcyByZXZpZXcgaW1wb3NzaWJsZSwgYW5kIHdlIGRlcGVuZCB1cG9uIHJldmlldyB0 bwo+PiAgICAgICB2ZXJpZnkgdGhhdCB0aGUgaW50ZWxfcmluZ19iZWdpbigpIG1hdGNoZXMgdGhl IG51bWJlciBvZiBkd29yZHMgZW1pdHRlZC4KPj4KPj4gICAgIGJ1dCB0aGUgbWlfbm9vcHMgYXJl IGhpZGRlbiBvbiB0aGUgc3VibWl0IGFuZCBhZHZhbmNlLi4uIHNob3VsZG4ndCB3ZSBtb3ZlCj4+ ICAgICBpdCBiYWNrIHRvIHRoZSBwbGFjZXMgdGhhdCBhbGxvY2F0ZXMgaXQuCj4KPiBIZW5jZSB3 aHkgSSBzdHJlc3NlZCB0aGF0IGluIHRoZSBjb21tZW50cyAtIGJ1dCBpdCBpcyBhIHRhaWwgY2Fs bCwganVzdAo+IHJlYWQgaXQgYXMgb25lIGZ1bmN0aW9uLiBUaGUgaW1wb3J0YW50IHNlcXVlbmNl IGlzIHRoYXQKPgo+IGludGVsX3JpbmdfYmVnaW4oY291bnQpCj4gLi4uCj4gY291bnQgeCBpbnRl bF9yaW5nX2VtaXQKPiAuLi4KPiBpbnRlbF9yaW5nX2FkdmFuY2UoKQo+Cj4gaXMgY2xlYXIgdG8g dGhlIHJlYWRlci4gWWVzLCB0aGlzIGJyZWFrcyB0aGF0IHJ1bGUgYnkgcmVwbGFjaW5nCj4gaW50 ZWxfcmluZ19hZHZhbmNlKCkgd2l0aCBhIGN1c3RvbSBscl9yaW5nX2FkdmFuY2VfYW5kX3N1Ym1p dCgpIGFuZAo+IHBlcmhhcHMgaXQgd291bGQgYmUgY2xlYXJlciB0byBhZGQgbHJfcmluZ19iZWdp bl9mb3Jfc3VibWl0KCkgb3IKPiBzb21ldGhpbmcgdG8gc3RyZXNzIHRoZSBzbGlnaHQgZGlzY3Jl cGFuY3ksIGJ1dCBzdGlsbCBtYWtlIHRoZSBwYWlyaW5nCj4gY2xlYXIuCj4KPj4gICAgICAgMy4g SXMgdGhpcyBldmVuIHRoZSByaWdodCBtZWNoYW5pc20gY29uc2lkZXJpbmcgdGhlIG51bWJlciBv ZiBvdGhlciB3YXlzCj4+ICAgICAgIG9mIGF1dG9tYXRpY2FsbHkgZW1pdHRpbmcgaW5zdHJ1Y3Rp b25zIGJldHdlZW4gYmF0Y2hlcyBhbmQgY29udGV4dHM/IFdlCj4+ICAgICAgIGNhbm5vdCBhbnN3 ZXIgdGhhdCBhcyB0aGlzIHBhdGNoIGlzIG91dCBvZiBjb250ZXh0Lgo+Pgo+PiAgICAgeWVhcCwg c29ycnkgYWdhaW4sIEkgd2FzIGp1c3QgZ29pbmcgdG8gdGhlIGVhc2llc3QgcGF0aCB0byBiZSBh YmxlIHRvCj4+ICAgICBhdm9pZCB0aGUgbnVsbHMgcGVyIHBsYXRmb3JtIHdpdGhvdXQgYWRkaW5n IDMgaWZzLi4KPj4gICAgIEJ1dCBJIHdvbmRlciBpZiB5b3UgbWVhbiBvbiBjb21tZW50ICIxLiIg dGhhdCB3ZSBjYW4gbGl2ZSB3aXRoCj4+ICAgICBXQV9UQUlMX0RXT1JEUyAyIGFuZCBhdm9pZCBv bmx5IHRoZSBOVUxMcyB3aGVuIG5lZWRlZC4uLiBJcyB0aGlzIHRoZSBjYXNlPwo+Cj4gSWYgeW91 IHdhbnQgbW9yZSBkd29yZHMgaW4gdGhlIGFkZF9yZXF1ZXN0IGNhbGxiYWNrLCB3ZSBuZWVkIHRv IGFkZAo+IHRob3NlIHRvIHRoZSBNSU5fU1BBQ0VfRk9SX0FERF9SRVFVRVNULiBJZiB3ZSBuZWVk IHRvIGFkZCBhIGxvdCwgdGhlbgo+IG1ha2luZyBpdCB2YXJpYWJsZSBzZWVtcyBmaW5lIC0gYnV0 IGl0IHNob3VsZCBqdXN0IGhvb2sgaW50byB0aGUgY29tbW9uCj4gbWVjaGFuaXNtIGkuZS4gdGhl IG1pbmltdW0gc3BhY2Ugc2hvdWxkIGJlIGNvbXB1dGVkIGR1cmluZyBlbmdpbmUKPiBpbml0aWFs aXNhdGlvbiBhbmQgdGhlIHJlc2VydmF0aW9uIGFwcGxpZWQgYXQgaTkxNV9nZW1fZWVxdWVzdF9h bGxvYygpLgo+IC1DaHJpcwoKSSB0aGluayB0aGUgY2xlYW5lc3QgcGFydGl0aW9uaW5nIG9mIHRo ZSBmdW5jdGlvbmFsaXR5IHdvdWxkIGJlOgogICAgIDEuIFRoZSBzcGFjZSBmb3IgdGhlIE5PT1Bz IHNob3VsZCBiZSBhY2NvdW50ZWQgZm9yIGluIHRoZSByZXNlcnZlZAogICAgICAgIHNwYWNlLCBi ZWNhdXNlIGl0J3MganVzdCBwYXJ0IG9mIHRoZSB0b3RhbCBzcGFjZSByZXF1aXJlZCB0bwogICAg ICAgIGNvbXBsZXRlIGFuIGFkZF9yZXF1ZXN0L2VtaXRfcmVxdWVzdCgpLiBTaW5jZSB0aGUgYW1v dW50CiAgICAgICAgcmVzZXJ2ZWQgaXMgZGV0ZXJtaW5lZCBpbiBpbnRlbF97bG9naWNhbF99cmlu Z19yZXNlcnZlX3NwYWNlKCkKICAgICAgICBpdCBjb3VsZCBiZSBhZGRlZCBvbmx5IGluIHRoZSBM UkMgcGF0aCwgaWYgd2Ugd2VyZSBjb25jZXJuZWQKICAgICAgICBhYm91dCB0aGUgZXh0cmEgc3Bh Y2UgKHdoaWNoIEkgZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIGJlKS4KCiAgICAgMi4gY2FsbGVycyBk byBiZWdpbihOKSwgTiplbWl0KCksIGFkdmFuY2UoKSwgYWRkX3JlcXVlc3QoKS4gVGhleQogICAg ICAgIGRvbid0IGJvdGhlciBhYm91dCBleHRyYSBOT09Qcy4KCiAgICAgMy4gZ2VuOF9lbWl0X3Jl cXVlc3QoKSBzaG91bGRuJ3QgaGF2ZSB0byBib3RoZXIgd2l0aCB0aGVtIGVpdGhlciwgb3IKICAg ICAgICBldmVuIHdpdGggY2xhaW1pbmcgdGhlIHNwYWNlIGZvciB0aGVtLgoKICAgICA0LiBhZHZh bmNlX2FuZF9zdWJtaXQoKSAod2hpY2ggaXMgZXhlY2xpc3Qgc3BlY2lmaWMpIGNhbiBkbyBhbiBl eHRyYQogICAgICAgIGJlZ2luKCkganVzdCB0byBrZWVwIGJlZ2luL2FkdmFuY2UgYmFsYW5jZWQg LS0gaXQgY2FuJ3QgZmFpbCBvcgogICAgICAgIHdhaXQsICdjb3MgaXQncyBpbiB0aGUgcmVzZXJ2 ZWQgc3BhY2UgLS0gYW5kIGVtaXRzIHRoZSBleHRyYQogICAgICAgIE5PT1BzLiBUaGlzIGlzIHdo ZXJlIGl0IGNhbiBiZSBtYWRlIGNvbmRpdGlvbmFsIG9uIHNwZWNpZmljIEdFTnMsCiAgICAgICAg aWYgeW91IHdhbnQgdGhhdCB0byBiZSBleHBsaWNpdCwgdGhvdWdoIHNpbmNlIHRoZSBvdmVyaGVh ZCBpcyBzbwogICAgICAgIHNtYWxsIEknZCBiZSBpbmNsaW5lZCB0byBhbHdheXMgZW5hYmxlIGl0 IGhlcmUsIGFuZCBvbmx5IGNoZWNrCiAgICAgICAgd2hldGhlciB0byBhY3R1YWxseSBhcHBseSB0 aGUgVEFJTC1idW1wIGluIHRoZSBFTFNQLXBva2luZyBjb2RlLgoKSW4gc3VtbWFyeTogbW9zdGx5 IGFzIENocmlzIGhhZCBpdCwgYnV0IHdpdGhvdXQgdGhlIGV4dHJhIHNwYWNlIGJlaW5nIAphZGRl ZCB0byB0aGUgYmVnaW4oKSBjYWxsIGluIGdlbjhfZW1pdF9yZXF1ZXN0KCkgKGFzIFJvZHJpZ28g aGFzIGl0KS4KCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=