From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Dave Gordon <david.s.gordon@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] Fix pointer tests in error-handling paths
Date: Wed, 27 Jan 2016 12:41:35 +0000 [thread overview]
Message-ID: <56A8BAFF.2010300@linux.intel.com> (raw)
In-Reply-To: <56A8B920.1080709@linux.intel.com>
On 27/01/16 12:33, Maarten Lankhorst wrote:
> Hey,
>
> Op 25-01-16 om 18:57 schreef Dave Gordon:
>> In the error-handling paths of i915_gem_do_execbuffer() and
>> intel_crtc_page_flip(), the local pointer-to-request variables
>> were expected to be either valid pointers or NULL. Since
>>
>> 2682708 drm/i915: simplify allocation of driver-internal requests
>>
>> they could also be ERR_PTR() values, so the tests need to be
>> updated to accommodate this case.
>>
>> v2: Added testcase (Chris Wilson)
>>
>> Testcase: igt/gem_close_race
>> Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> The testcase you mentioned doesn't work, it crashes on my machine instead of running to completion or triggering the bug.
It worked for me but I think I was running with GuC enabled at the time
so that might be the differenct.
gem_close_race in general worked for me just yesterday.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-27 12:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 19:02 [PATCH v4 0/3] improve handling of the driver's default (kernel) context Dave Gordon
2016-01-19 19:02 ` [PATCH v4 1/3] drm/i915: simplify allocation of driver-internal requests Dave Gordon
2016-01-20 9:56 ` Tvrtko Ursulin
2016-01-20 10:20 ` Chris Wilson
2016-01-22 11:12 ` Tvrtko Ursulin
2016-01-22 12:19 ` [PATCH] Fix pointer tests in error-handling paths Dave Gordon
2016-01-22 13:01 ` Chris Wilson
2016-01-22 13:17 ` Tvrtko Ursulin
2016-01-22 13:34 ` Chris Wilson
2016-01-25 17:54 ` Dave Gordon
2016-01-22 13:07 ` Tvrtko Ursulin
2016-01-25 16:28 ` Daniel Vetter
2016-01-25 17:07 ` Tvrtko Ursulin
2016-01-25 17:57 ` [PATCH v2] " Dave Gordon
2016-01-27 12:33 ` Maarten Lankhorst
2016-01-27 12:41 ` Tvrtko Ursulin [this message]
2016-01-27 13:45 ` Maarten Lankhorst
2016-01-19 19:02 ` [PATCH v4 2/3] drm/i915: abolish separate per-ring default_context pointers Dave Gordon
2016-01-19 19:02 ` [PATCH v4 3/3] drm/i915: tidy up a few leftovers Dave Gordon
2016-01-20 7:49 ` ✗ Fi.CI.BAT: warning for improve handling of the driver's default (kernel) context Patchwork
2016-01-20 17:31 ` Dave Gordon
2016-01-21 8:19 ` Daniel Vetter
2016-01-21 8:21 ` [PATCH v4 0/3] " Daniel Vetter
2016-01-27 15:43 ` ✓ Fi.CI.BAT: success for improve handling of the driver's default (kernel) context (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8BAFF.2010300@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox