From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v4 2/6] drm/i915: tidy up initialisation failure paths (GEM & LRC) Date: Mon, 1 Feb 2016 09:45:25 +0000 Message-ID: <56AF2935.1040409@intel.com> References: <1454095171-22475-1-git-send-email-david.s.gordon@intel.com> <1454095171-22475-3-git-send-email-david.s.gordon@intel.com> <20160130105627.GQ24534@nuc-i3427.alporthouse.com> <20160130112818.GV24534@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 57F4F6E2F0 for ; Mon, 1 Feb 2016 01:45:31 -0800 (PST) In-Reply-To: <20160130112818.GV24534@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMzAvMDEvMTYgMTE6MjgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBTYXQsIEphbiAzMCwg MjAxNiBhdCAxMDo1NjoyN0FNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+IE9uIEZyaSwg SmFuIDI5LCAyMDE2IGF0IDA3OjE5OjI3UE0gKzAwMDAsIERhdmUgR29yZG9uIHdyb3RlOgo+Pj4g MS4gYWRkIGNhbGwgdG8gaTkxNV9nZW1fY29udGV4dF9maW5pKCkgdG8gZGVhbGxvY2F0ZSB0aGUg ZGVmYXVsdAo+Pj4gICAgIGNvbnRleHQocykgaWYgdGhlIGNhbGwgdG8gaW5pdF9yaW5ncygpIGZh aWxzLCBzbyB0aGF0IHdlIGRvbid0Cj4+PiAgICAgbGVhayB0aGUgY29udGV4dCBpbiB0aGF0IHNp dHVhdGlvbi4KPj4+Cj4+PiAyLiByZW1vdmUgdXNlbGVzcyBjb2RlIGluIGludGVsX2xvZ2ljYWxf cmluZ19jbGVhbnVwKCksIHByZXN1bWFibHkKPj4+ICAgICBjb3B5cGFzdGVkIGZyb20gbGVnYWN5 IHJpbmdidWZmZXIgdmVyc2lvbiBhdCBjcmVhdGlvbi4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBE YXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgIHwgIDUgKysrKy0KPj4+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMgfCAxMCArKy0tLS0tLS0tCj4+PiAgIDIgZmlsZXMgY2hhbmdl ZCwgNiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYwo+Pj4gaW5kZXggYTkyODgyMy4uNWE0ZDQ2OCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMKPj4+IEBAIC00OTg2LDggKzQ5ODYsMTEgQEAgaW50IGk5MTVfZ2VtX2luaXQo c3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4+ICAgCQlnb3RvIG91dF91bmxvY2s7Cj4+Pgo+Pj4g ICAJcmV0ID0gZGV2X3ByaXYtPmd0LmluaXRfcmluZ3MoZGV2KTsKPj4+IC0JaWYgKHJldCkKPj4+ ICsJaWYgKHJldCkgewo+Pj4gKwkJaTkxNV9nZW1fY29udGV4dF9maW5pKGRldik7Cj4+PiArCQkv KiBYWFg6IGFueXRoaW5nIGVsc2UgdG8gYmUgdW5kb25lIGhlcmU/ICovCj4+Cj4+IFllcy4gTWFr ZSB0aGlzIGEgc2VwYXJhdGUgcGF0Y2ggYW5kIGJlZ2luIHRoZSBvbmlvbiB1bndpbmQuCj4KPiBI bW0uIEFjdHVhbGx5LCB3ZSBoYXZlIHRvIG1ha2Ugc3VyZSB0aGF0IHdlIGNhbiBzdGlsbCBtb2Rl c2V0IGlmIHRoaXMKPiBmdW5jdGlvbiBmYWlscyAtIHRoYXQgaXMgYW55dGhpbmcgYnV0IHV0dGVy IGNhdGFzdHJvcGhlIHNob3VsZCBqdXN0Cj4gcmVzdWx0IGluIGxvc3Mgb2YgZnVuY3Rpb25hbGl0 eSAobm8gc3RvbGVuLCBubyBHRU0gZXhlY3V0aW9uIGV0YykgYnV0IHdlCj4gY2FuIHN0aWxsIGRy aXZlIHRoZSBkaXNwbGF5cyBzbyB0aGUgdXNlciBjYW4gc2VlIGhvdyBiYWQgdGhlIGRhbWFnZSBp cy4KPiAtQ2hyaXMKClllcywgTWlrYSBzYWlkIHRoYXQncyB3aHkgKGhlIHRob3VnaHQpIHRoZXJl IHdhc24ndCBhIGNvbXBsZXRlIHJldmVyc2FsIApvZiBldmVyeXRoaW5nIHRoZSBkcml2ZXIgaGFz IGRvbmUgdXAgdG8gdGhpcyBwb2ludC4KClRoZSBhZGRpdGlvbiBvZiB0aGUgY29udGV4dF9maW5p KCkgc2VlbXMgcmVhc29uYWJsZSwgdGhhdCdzIGdvaW5nIHRvIAptYWtlIGl0IGxlYWsgYSBiaXQg bGVzcywgd2hpbGUgc3RpbGwgbGVhdmluZyBiYXNpYyBmcmFtZWJ1ZmZlciB3b3JraW5nLgoKQ291 bGQgYmUgYSBzZXBhcmF0ZSBwYXRjaCBpZiB5b3UgbGlrZSwgYnV0IGhhcmRseSBzZWVtcyB3b3J0 aCBzcGxpdHRpbmcgCmZyb20gdGhlIG90aGVyIGNodW5rLCB3aGljaCBhZnRlciBhbGwgb25seSBy ZXBsYWNlcyB1bnJlYWNoYWJsZSBjb2RlIAp3aXRoIGEgV0FSTmluZy4KCi5EYXZlLgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=