From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 01/12] drm/i915: Add wait_for_us
Date: Tue, 2 Feb 2016 14:04:55 +0000 [thread overview]
Message-ID: <56B0B787.70706@linux.intel.com> (raw)
In-Reply-To: <20160202115743.GF15851@nuc-i3427.alporthouse.com>
On 02/02/16 11:57, Chris Wilson wrote:
> On Tue, Feb 02, 2016 at 11:06:19AM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> This is for callers who want micro-second precision but are not
>> waiting from the atomic context.
>
> linux/time.h provides us with USEC_PER_MSEC that would help to break up
> these large numbers better for human consumption.
>
> 2000 -> 2*USEC_PER_SEC
> 10 -> 10*USEC_PER_MSEC
>
> Maybe:
>
> #define wait_for_seconds(x) ((x)*USEC_PER_SEC)
> #define wait_for_milliseconds(x) ((x)*USEC_PER_MSEC)
>
> if (_wait_for((I915_READ(pp_stat_reg) & mask) == value,
> wait_for_seconds(5) /* timeout */,
> wait_for_millseconds(10) /* interval */))
There are only two callers where it would be a bit interesting so it
just feels like needless change to me at the moment. Better to keep the
established conventions for these two macros.
>> @@ -55,7 +55,7 @@
>> break; \
>> } \
>> if ((W) && drm_can_sleep()) { \
>
> Note after the atomic conversion, we can also do the !atomic assert here
> and kill the drm_can_sleep() check
Noted. Maybe I'll put a comment somewhere.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-02 14:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 11:06 [PATCH 00/12] Misc locking fixes and GEM debugging Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 01/12] drm/i915: Add wait_for_us Tvrtko Ursulin
2016-02-02 11:57 ` Chris Wilson
2016-02-02 14:04 ` Tvrtko Ursulin [this message]
2016-02-02 15:43 ` Chris Wilson
2016-02-02 13:35 ` Dave Gordon
2016-02-02 13:58 ` Tvrtko Ursulin
2016-02-02 14:44 ` [PATCH v2 " Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 02/12] drm/i915: Do not wait atomically for display clocks Tvrtko Ursulin
2016-02-02 12:00 ` Chris Wilson
2016-02-02 14:08 ` Dave Gordon
2016-02-02 15:39 ` Chris Wilson
2016-02-02 11:06 ` [PATCH 03/12] drm/i915/guc: Do not wait for firmware load atomically Tvrtko Ursulin
2016-02-02 14:13 ` Dave Gordon
2016-02-02 11:06 ` [PATCH 04/12] drm/i915/lrc: Do not wait atomically when stopping engines Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 05/12] drm/i915: Kconfig for extra driver debugging Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 06/12] drm/i915: Do not lie about atomic wait granularity Tvrtko Ursulin
2016-02-02 12:29 ` Chris Wilson
2016-02-02 14:45 ` [PATCH v3 " Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 07/12] drm/i915: GEM operations need to be done under the big lock Tvrtko Ursulin
2016-02-02 12:05 ` Chris Wilson
2016-02-02 14:46 ` [PATCH v4 " Tvrtko Ursulin
2016-02-02 15:49 ` Chris Wilson
2016-02-11 10:13 ` Chris Wilson
2016-02-15 16:09 ` Daniel Vetter
2016-02-11 10:07 ` [PATCH " Chris Wilson
2016-02-02 11:06 ` [PATCH 08/12] drm/i915: Fix struct mutex vs. RPS lock inversion Tvrtko Ursulin
2016-02-02 13:16 ` Chris Wilson
2016-02-02 14:13 ` Tvrtko Ursulin
2016-02-02 14:48 ` Chris Wilson
2016-02-02 14:46 ` [PATCH v3 " Tvrtko Ursulin
2016-02-11 10:06 ` Chris Wilson
2016-02-02 11:06 ` [PATCH 09/12] drm/i915/ilk: Move register read under spinlock Tvrtko Ursulin
2016-02-02 12:01 ` Chris Wilson
2016-02-02 11:06 ` [PATCH 10/12] drm/i915: Introduce dedicated object VMA iterator Tvrtko Ursulin
2016-02-02 11:36 ` Chris Wilson
2016-02-02 12:10 ` Tvrtko Ursulin
2016-02-02 12:58 ` Chris Wilson
2016-02-02 13:56 ` Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 11/12] drm/i915: Introduce dedicated safe " Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 12/12] drm/i915: Add BKL asserts to get page helpers Tvrtko Ursulin
2016-02-02 11:39 ` Chris Wilson
2016-02-02 12:02 ` Tvrtko Ursulin
2016-02-02 11:22 ` ✓ Fi.CI.BAT: success for Misc locking fixes and GEM debugging Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B0B787.70706@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).