From: "Thulasimani, Sivakumar" <sivakumar.thulasimani@intel.com>
To: Ramalingam C <ramalingam.c@intel.com>, intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: Re: [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll
Date: Wed, 3 Feb 2016 07:51:53 +0530 [thread overview]
Message-ID: <56B16441.4000608@intel.com> (raw)
In-Reply-To: <1454435509-28943-1-git-send-email-ramalingam.c@intel.com>
just realized that intel_dsi_init is not called from setup outputs for
BXT. is this expected ?
if so when is it expected to be added ?
Again, the current code in intel_setup_outputs calls intel_dsi_init from
vlv/chv section so please confirm if this is needed for all platforms
or just in BXT.
On 2/2/2016 11:21 PM, Ramalingam C wrote:
> We need to enable DSI PLL before configuring the DSI registers.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 91cef35..378f879 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -478,8 +478,8 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)
>
> DRM_DEBUG_KMS("\n");
>
> - intel_dsi_prepare(encoder);
> intel_enable_dsi_pll(encoder);
> + intel_dsi_prepare(encoder);
>
> /* Panel Enable over CRC PMIC */
> if (intel_dsi->gpio_panel)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-03 2:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 17:51 [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll Ramalingam C
2016-02-03 2:21 ` Thulasimani, Sivakumar [this message]
2016-02-03 9:27 ` Jani Nikula
2016-02-03 10:26 ` Mika Kahola
2016-02-03 10:59 ` Jani Nikula
2016-02-03 11:55 ` Jani Nikula
2016-02-03 12:32 ` Ramalingam C
2016-02-03 12:50 ` Ramalingam C
2016-02-03 7:26 ` Mika Kahola
2016-02-03 7:46 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-02-03 9:28 ` [PATCH] " Jani Nikula
2016-02-03 12:59 ` Mika Kahola
2016-02-15 16:18 ` Daniel Vetter
2016-02-03 13:52 ` ✗ Fi.CI.BAT: failure for drm/i915/BXT: Configure DSI after enabling DSI pll (rev2) Patchwork
2016-02-04 9:09 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B16441.4000608@intel.com \
--to=sivakumar.thulasimani@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).