From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH v4 03/38] drm/i915: Prelude to splitting i915_gem_do_execbuffer in two Date: Thu, 4 Feb 2016 09:01:23 -0800 Message-ID: <56B383E3.104@virtuousgeek.org> References: <1448278774-31376-1-git-send-email-John.C.Harrison@Intel.com> <1452537788-32136-1-git-send-email-John.C.Harrison@Intel.com> <1452537788-32136-4-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by gabe.freedesktop.org (Postfix) with SMTP id AC9616E12D for ; Thu, 4 Feb 2016 09:01:36 -0800 (PST) In-Reply-To: <1452537788-32136-4-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gMDEvMTEvMjAxNiAxMDo0MiBBTSwgSm9obi5DLkhhcnJpc29uQEludGVsLmNvbSB3cm90ZToK PiBGcm9tOiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25ASW50ZWwuY29tPgo+IAo+IFRo ZSBzY2hlZHVsZXIgZGVjb3VwbGVzIHRoZSBzdWJtaXNzaW9uIG9mIGJhdGNoIGJ1ZmZlcnMgdG8g dGhlIGRyaXZlcgo+IHdpdGggdGhlaXIgc3VibWlzc2lvbiB0byB0aGUgaGFyZHdhcmUuIFRoaXMg YmFzaWNhbGx5IG1lYW5zIHNwbGl0dGluZwo+IHRoZSBleGVjYnVmZmVyKCkgZnVuY3Rpb24gaW4g aGFsZi4gVGhpcyBjaGFuZ2UgcmVhcnJhbmdlcyBzb21lIGNvZGUKPiByZWFkeSBmb3IgdGhlIHNw bGl0IHRvIG9jY3VyLgo+IAo+IEZvcjogVklaLTE1ODcKPiBTaWduZWQtb2ZmLWJ5OiBKb2huIEhh cnJpc29uIDxKb2huLkMuSGFycmlzb25ASW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgfCA2MyArKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgICAgIHwg MTggKysrKysrLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNTEgaW5zZXJ0aW9ucygrKSwgMzAgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X2V4ZWNidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIu Ywo+IGluZGV4IGJmYzRjMTcuLjBlY2EyYjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gQEAgLTkzMywxMCArOTMzLDcgQEAgaTkxNV9nZW1fZXhl Y2J1ZmZlcl9tb3ZlX3RvX2dwdShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAg CWlmIChmbHVzaF9kb21haW5zICYgSTkxNV9HRU1fRE9NQUlOX0dUVCkKPiAgCQl3bWIoKTsKPiAg Cj4gLQkvKiBVbmNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZSBncHUgY2FjaGVzIGFuZCBlbnN1cmUg dGhhdCB3ZSBkbyBmbHVzaAo+IC0JICogYW55IHJlc2lkdWFsIHdyaXRlcyBmcm9tIHRoZSBwcmV2 aW91cyBiYXRjaC4KPiAtCSAqLwo+IC0JcmV0dXJuIGludGVsX3JpbmdfaW52YWxpZGF0ZV9hbGxf Y2FjaGVzKHJlcSk7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGJvb2wKPiBAQCAt MTE4OSwxNyArMTE4Niw2IEBAIGk5MTVfZ2VtX3JpbmdidWZmZXJfc3VibWlzc2lvbihzdHJ1Y3Qg aTkxNV9leGVjYnVmZmVyX3BhcmFtcyAqcGFyYW1zLAo+ICAJdTMyIGluc3RwX21hc2s7Cj4gIAlp bnQgcmV0Owo+ICAKPiAtCXJldCA9IGk5MTVfZ2VtX2V4ZWNidWZmZXJfbW92ZV90b19ncHUocGFy YW1zLT5yZXF1ZXN0LCB2bWFzKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiAtCj4g LQlyZXQgPSBpOTE1X3N3aXRjaF9jb250ZXh0KHBhcmFtcy0+cmVxdWVzdCk7Cj4gLQlpZiAocmV0 KQo+IC0JCXJldHVybiByZXQ7Cj4gLQo+IC0JV0FSTihwYXJhbXMtPmN0eC0+cHBndHQgJiYgcGFy YW1zLT5jdHgtPnBwZ3R0LT5wZF9kaXJ0eV9yaW5ncyAmICgxPDxyaW5nLT5pZCksCj4gLQkgICAg ICIlcyBkaWRuJ3QgY2xlYXIgcmVsb2FkXG4iLCByaW5nLT5uYW1lKTsKPiAtCj4gIAlpbnN0cF9t b2RlID0gYXJncy0+ZmxhZ3MgJiBJOTE1X0VYRUNfQ09OU1RBTlRTX01BU0s7Cj4gIAlpbnN0cF9t YXNrID0gSTkxNV9FWEVDX0NPTlNUQU5UU19NQVNLOwo+ICAJc3dpdGNoIChpbnN0cF9tb2RlKSB7 Cj4gQEAgLTEyMzMsMTEgKzEyMTksMzcgQEAgaTkxNV9nZW1fcmluZ2J1ZmZlcl9zdWJtaXNzaW9u KHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMsCj4gIAkJcmV0dXJuIC1FSU5W QUw7Cj4gIAl9Cj4gIAo+ICsJcmV0ID0gaTkxNV9nZW1fZXhlY2J1ZmZlcl9tb3ZlX3RvX2dwdShw YXJhbXMtPnJlcXVlc3QsIHZtYXMpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsK PiArCWk5MTVfZ2VtX2V4ZWNidWZmZXJfbW92ZV90b19hY3RpdmUodm1hcywgcGFyYW1zLT5yZXF1 ZXN0KTsKPiArCj4gKwkvKiBUbyBiZSBzcGxpdCBpbnRvIHR3byBmdW5jdGlvbnMgaGVyZS4uLiAq Lwo+ICsKPiArCWludGVsX3J1bnRpbWVfcG1fZ2V0KGRldl9wcml2KTsKPiArCj4gKwkvKgo+ICsJ ICogVW5jb25kaXRpb25hbGx5IGludmFsaWRhdGUgZ3B1IGNhY2hlcyBhbmQgZW5zdXJlIHRoYXQg d2UgZG8gZmx1c2gKPiArCSAqIGFueSByZXNpZHVhbCB3cml0ZXMgZnJvbSB0aGUgcHJldmlvdXMg YmF0Y2guCj4gKwkgKi8KPiArCXJldCA9IGludGVsX3JpbmdfaW52YWxpZGF0ZV9hbGxfY2FjaGVz KHBhcmFtcy0+cmVxdWVzdCk7Cj4gKwlpZiAocmV0KQo+ICsJCWdvdG8gZXJyb3I7Cj4gKwo+ICsJ LyogU3dpdGNoIHRvIHRoZSBjb3JyZWN0IGNvbnRleHQgZm9yIHRoZSBiYXRjaCAqLwo+ICsJcmV0 ID0gaTkxNV9zd2l0Y2hfY29udGV4dChwYXJhbXMtPnJlcXVlc3QpOwo+ICsJaWYgKHJldCkKPiAr CQlnb3RvIGVycm9yOwo+ICsKPiArCVdBUk4ocGFyYW1zLT5jdHgtPnBwZ3R0ICYmIHBhcmFtcy0+ Y3R4LT5wcGd0dC0+cGRfZGlydHlfcmluZ3MgJiAoMTw8cmluZy0+aWQpLAo+ICsJICAgICAiJXMg ZGlkbid0IGNsZWFyIHJlbG9hZFxuIiwgcmluZy0+bmFtZSk7Cj4gKwo+ICAJaWYgKHJpbmcgPT0g JmRldl9wcml2LT5yaW5nW1JDU10gJiYKPiAgCSAgICBpbnN0cF9tb2RlICE9IGRldl9wcml2LT5y ZWxhdGl2ZV9jb25zdGFudHNfbW9kZSkgewo+ICAJCXJldCA9IGludGVsX3JpbmdfYmVnaW4ocGFy YW1zLT5yZXF1ZXN0LCA0KTsKPiAgCQlpZiAocmV0KQo+IC0JCQlyZXR1cm4gcmV0Owo+ICsJCQln b3RvIGVycm9yOwo+ICAKPiAgCQlpbnRlbF9yaW5nX2VtaXQocmluZywgTUlfTk9PUCk7Cj4gIAkJ aW50ZWxfcmluZ19lbWl0KHJpbmcsIE1JX0xPQURfUkVHSVNURVJfSU1NKDEpKTsKPiBAQCAtMTI1 MSw3ICsxMjYzLDcgQEAgaTkxNV9nZW1fcmluZ2J1ZmZlcl9zdWJtaXNzaW9uKHN0cnVjdCBpOTE1 X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMsCj4gIAlpZiAoYXJncy0+ZmxhZ3MgJiBJOTE1X0VY RUNfR0VON19TT0xfUkVTRVQpIHsKPiAgCQlyZXQgPSBpOTE1X3Jlc2V0X2dlbjdfc29sX29mZnNl dHMoZGV2LCBwYXJhbXMtPnJlcXVlc3QpOwo+ICAJCWlmIChyZXQpCj4gLQkJCXJldHVybiByZXQ7 Cj4gKwkJCWdvdG8gZXJyb3I7Cj4gIAl9Cj4gIAo+ICAJZXhlY19sZW4gICA9IGFyZ3MtPmJhdGNo X2xlbjsKPiBAQCAtMTI2MiwxNCArMTI3NCwyMCBAQCBpOTE1X2dlbV9yaW5nYnVmZmVyX3N1Ym1p c3Npb24oc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcywKPiAgCQkJCQlleGVj X3N0YXJ0LCBleGVjX2xlbiwKPiAgCQkJCQlwYXJhbXMtPmRpc3BhdGNoX2ZsYWdzKTsKPiAgCWlm IChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCQlnb3RvIGVycm9yOwo+ICAKPiAgCXRyYWNlX2k5 MTVfZ2VtX3JpbmdfZGlzcGF0Y2gocGFyYW1zLT5yZXF1ZXN0LCBwYXJhbXMtPmRpc3BhdGNoX2Zs YWdzKTsKPiAgCj4gLQlpOTE1X2dlbV9leGVjYnVmZmVyX21vdmVfdG9fYWN0aXZlKHZtYXMsIHBh cmFtcy0+cmVxdWVzdCk7Cj4gIAlpOTE1X2dlbV9leGVjYnVmZmVyX3JldGlyZV9jb21tYW5kcyhw YXJhbXMpOwo+ICAKPiAtCXJldHVybiAwOwo+ICtlcnJvcjoKPiArCS8qCj4gKwkgKiBpbnRlbF9n cHVfYnVzeSBzaG91bGQgYWxzbyBnZXQgYSByZWYsIHNvIGl0IHdpbGwgZnJlZSB3aGVuIHRoZSBk ZXZpY2UKPiArCSAqIGlzIHJlYWxseSBpZGxlLgo+ICsJICovCj4gKwlpbnRlbF9ydW50aW1lX3Bt X3B1dChkZXZfcHJpdik7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAgLyoqCj4gQEAg LTE0MjQsOCArMTQ0Miw2IEBAIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCQlkaXNwYXRjaF9mbGFncyB8PSBJOTE1X0RJU1BBVENI X1JTOwo+ICAJfQo+ICAKPiAtCWludGVsX3J1bnRpbWVfcG1fZ2V0KGRldl9wcml2KTsKPiAtCj4g IAlyZXQgPSBpOTE1X211dGV4X2xvY2tfaW50ZXJydXB0aWJsZShkZXYpOwo+ICAJaWYgKHJldCkK PiAgCQlnb3RvIHByZV9tdXRleF9lcnI7Cj4gQEAgLTE1OTksOSArMTYxNSw2IEBAIGVycjoKPiAg CW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAKPiAgcHJlX211dGV4X2VycjoK PiAtCS8qIGludGVsX2dwdV9idXN5IHNob3VsZCBhbHNvIGdldCBhIHJlZiwgc28gaXQgd2lsbCBm cmVlIHdoZW4gdGhlIGRldmljZQo+IC0JICogaXMgcmVhbGx5IGlkbGUuICovCj4gLQlpbnRlbF9y dW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggZTUxMDczMC4uNGJmMGVlNiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTY0NywxMCArNjQ3LDcgQEAgc3RhdGljIGludCBleGVj bGlzdHNfbW92ZV90b19ncHUoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEsCj4gIAlp ZiAoZmx1c2hfZG9tYWlucyAmIEk5MTVfR0VNX0RPTUFJTl9HVFQpCj4gIAkJd21iKCk7Cj4gIAo+ IC0JLyogVW5jb25kaXRpb25hbGx5IGludmFsaWRhdGUgZ3B1IGNhY2hlcyBhbmQgZW5zdXJlIHRo YXQgd2UgZG8gZmx1c2gKPiAtCSAqIGFueSByZXNpZHVhbCB3cml0ZXMgZnJvbSB0aGUgcHJldmlv dXMgYmF0Y2guCj4gLQkgKi8KPiAtCXJldHVybiBsb2dpY2FsX3JpbmdfaW52YWxpZGF0ZV9hbGxf Y2FjaGVzKHJlcSk7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgaW50IGludGVsX2xvZ2ljYWxf cmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJl cXVlc3QpCj4gQEAgLTkxMyw2ICs5MTAsMTggQEAgaW50IGludGVsX2V4ZWNsaXN0c19zdWJtaXNz aW9uKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMsCj4gIAlpZiAocmV0KQo+ ICAJCXJldHVybiByZXQ7Cj4gIAo+ICsJaTkxNV9nZW1fZXhlY2J1ZmZlcl9tb3ZlX3RvX2FjdGl2 ZSh2bWFzLCBwYXJhbXMtPnJlcXVlc3QpOwo+ICsKPiArCS8qIFRvIGJlIHNwbGl0IGludG8gdHdv IGZ1bmN0aW9ucyBoZXJlLi4uICovCj4gKwo+ICsJLyoKPiArCSAqIFVuY29uZGl0aW9uYWxseSBp bnZhbGlkYXRlIGdwdSBjYWNoZXMgYW5kIGVuc3VyZSB0aGF0IHdlIGRvIGZsdXNoCj4gKwkgKiBh bnkgcmVzaWR1YWwgd3JpdGVzIGZyb20gdGhlIHByZXZpb3VzIGJhdGNoLgo+ICsJICovCj4gKwly ZXQgPSBsb2dpY2FsX3JpbmdfaW52YWxpZGF0ZV9hbGxfY2FjaGVzKHBhcmFtcy0+cmVxdWVzdCk7 Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICAJaWYgKHJpbmcgPT0gJmRldl9w cml2LT5yaW5nW1JDU10gJiYKPiAgCSAgICBpbnN0cF9tb2RlICE9IGRldl9wcml2LT5yZWxhdGl2 ZV9jb25zdGFudHNfbW9kZSkgewo+ICAJCXJldCA9IGludGVsX2xvZ2ljYWxfcmluZ19iZWdpbihw YXJhbXMtPnJlcXVlc3QsIDQpOwo+IEBAIC05MzcsNyArOTQ2LDYgQEAgaW50IGludGVsX2V4ZWNs aXN0c19zdWJtaXNzaW9uKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMsCj4g IAo+ICAJdHJhY2VfaTkxNV9nZW1fcmluZ19kaXNwYXRjaChwYXJhbXMtPnJlcXVlc3QsIHBhcmFt cy0+ZGlzcGF0Y2hfZmxhZ3MpOwo+ICAKPiAtCWk5MTVfZ2VtX2V4ZWNidWZmZXJfbW92ZV90b19h Y3RpdmUodm1hcywgcGFyYW1zLT5yZXF1ZXN0KTsKPiAgCWk5MTVfZ2VtX2V4ZWNidWZmZXJfcmV0 aXJlX2NvbW1hbmRzKHBhcmFtcyk7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gCgpEbyB3ZSBuZWVkIHRv IGRvIGFueXRoaW5nIGlmIHRoZSBjYWNoZSBpbnZhbGlkYXRpb24gZmFpbHMgbGlrZSBtb3ZlIHRo ZSBidWZmZXJzIGJhY2sgb2ZmIHRoZSBhY3RpdmUgbGlzdD8gIFRoZSBvcmRlciBjaGFuZ2VkIGhl cmUsIHNvIEknbSB3b25kZXJpbmcuCgpJZiB0aGF0J3Mgbm90IGEgcHJvYmxlbSwgdGhlbjoKUmV2 aWV3ZWQtYnk6IEplc3NlIEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=