From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH v4 05/38] drm/i915: Cache request pointer in *_submission_final() Date: Thu, 4 Feb 2016 09:09:36 -0800 Message-ID: <56B385D0.2090906@virtuousgeek.org> References: <1448278774-31376-1-git-send-email-John.C.Harrison@Intel.com> <1452537788-32136-1-git-send-email-John.C.Harrison@Intel.com> <1452537788-32136-6-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gproxy7-pub.mail.unifiedlayer.com (gproxy7-pub.mail.unifiedlayer.com [70.40.196.235]) by gabe.freedesktop.org (Postfix) with SMTP id 841A56E0C2 for ; Thu, 4 Feb 2016 09:09:45 -0800 (PST) In-Reply-To: <1452537788-32136-6-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gMDEvMTEvMjAxNiAxMDo0MiBBTSwgSm9obi5DLkhhcnJpc29uQEludGVsLmNvbSB3cm90ZToK PiBGcm9tOiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+IAo+IEtlZXAg YSBsb2NhbCBjb3B5IG9mIHRoZSByZXF1ZXN0IHBvaW50ZXIgaW4gdGhlIF9maW5hbCgpIGZ1bmN0 aW9ucwo+IHJhdGhlciB0aGFuIGRlcmVmZXJlbmNpbmcgdGhlIHBhcmFtcyBibG9jayByZXBlYXRl ZGx5Lgo+IAo+IHYzOiBOZXcgcGF0Y2ggaW4gc2VyaWVzLgo+IAo+IEZvcjogVklaLTE1ODcKPiBT aWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+IFNp Z25lZC1vZmYtYnk6IEpvaG4gSGFycmlzb24gPEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8IDEzICsr KysrKystLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgICAg IHwgMTEgKysrKysrLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAx MSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW1fZXhlY2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1 ZmZlci5jCj4gaW5kZXggZWZmMTcxZC4uMGFkMzJmNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiBAQCAtMTI0Myw2ICsxMjQzLDcgQEAgaTkxNV9n ZW1fcmluZ2J1ZmZlcl9zdWJtaXNzaW9uKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpw YXJhbXMsCj4gIGludCBpOTE1X2dlbV9yaW5nYnVmZmVyX3N1Ym1pc3Npb25fZmluYWwoc3RydWN0 IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcykKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gcGFyYW1zLT5kZXYtPmRldl9wcml2YXRlOwo+ICsJc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEgPSBwYXJhbXMtPnJlcXVlc3Q7Cj4gIAlzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICAqcmluZyA9IHBhcmFtcy0+cmluZzsKPiAgCXU2NCBleGVjX3N0YXJ0 LCBleGVjX2xlbjsKPiAgCWludCByZXQ7Cj4gQEAgLTEyNTYsMTIgKzEyNTcsMTIgQEAgaW50IGk5 MTVfZ2VtX3JpbmdidWZmZXJfc3VibWlzc2lvbl9maW5hbChzdHJ1Y3QgaTkxNV9leGVjYnVmZmVy X3BhcmFtcyAqcGFyYW1zKQo+ICAJICogVW5jb25kaXRpb25hbGx5IGludmFsaWRhdGUgZ3B1IGNh Y2hlcyBhbmQgZW5zdXJlIHRoYXQgd2UgZG8gZmx1c2gKPiAgCSAqIGFueSByZXNpZHVhbCB3cml0 ZXMgZnJvbSB0aGUgcHJldmlvdXMgYmF0Y2guCj4gIAkgKi8KPiAtCXJldCA9IGludGVsX3Jpbmdf aW52YWxpZGF0ZV9hbGxfY2FjaGVzKHBhcmFtcy0+cmVxdWVzdCk7Cj4gKwlyZXQgPSBpbnRlbF9y aW5nX2ludmFsaWRhdGVfYWxsX2NhY2hlcyhyZXEpOwo+ICAJaWYgKHJldCkKPiAgCQlnb3RvIGVy cm9yOwo+ICAKPiAgCS8qIFN3aXRjaCB0byB0aGUgY29ycmVjdCBjb250ZXh0IGZvciB0aGUgYmF0 Y2ggKi8KPiAtCXJldCA9IGk5MTVfc3dpdGNoX2NvbnRleHQocGFyYW1zLT5yZXF1ZXN0KTsKPiAr CXJldCA9IGk5MTVfc3dpdGNoX2NvbnRleHQocmVxKTsKPiAgCWlmIChyZXQpCj4gIAkJZ290byBl cnJvcjsKPiAgCj4gQEAgLTEyNzAsNyArMTI3MSw3IEBAIGludCBpOTE1X2dlbV9yaW5nYnVmZmVy X3N1Ym1pc3Npb25fZmluYWwoc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcykK PiAgCj4gIAlpZiAocmluZyA9PSAmZGV2X3ByaXYtPnJpbmdbUkNTXSAmJgo+ICAJICAgIHBhcmFt cy0+aW5zdHBfbW9kZSAhPSBkZXZfcHJpdi0+cmVsYXRpdmVfY29uc3RhbnRzX21vZGUpIHsKPiAt CQlyZXQgPSBpbnRlbF9yaW5nX2JlZ2luKHBhcmFtcy0+cmVxdWVzdCwgNCk7Cj4gKwkJcmV0ID0g aW50ZWxfcmluZ19iZWdpbihyZXEsIDQpOwo+ICAJCWlmIChyZXQpCj4gIAkJCWdvdG8gZXJyb3I7 Cj4gIAo+IEBAIC0xMjg0LDcgKzEyODUsNyBAQCBpbnQgaTkxNV9nZW1fcmluZ2J1ZmZlcl9zdWJt aXNzaW9uX2ZpbmFsKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMpCj4gIAl9 Cj4gIAo+ICAJaWYgKHBhcmFtcy0+YXJnc19mbGFncyAmIEk5MTVfRVhFQ19HRU43X1NPTF9SRVNF VCkgewo+IC0JCXJldCA9IGk5MTVfcmVzZXRfZ2VuN19zb2xfb2Zmc2V0cyhwYXJhbXMtPmRldiwg cGFyYW1zLT5yZXF1ZXN0KTsKPiArCQlyZXQgPSBpOTE1X3Jlc2V0X2dlbjdfc29sX29mZnNldHMo cGFyYW1zLT5kZXYsIHJlcSk7Cj4gIAkJaWYgKHJldCkKPiAgCQkJZ290byBlcnJvcjsKPiAgCX0K PiBAQCAtMTI5MywxMyArMTI5NCwxMyBAQCBpbnQgaTkxNV9nZW1fcmluZ2J1ZmZlcl9zdWJtaXNz aW9uX2ZpbmFsKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMpCj4gIAlleGVj X3N0YXJ0ID0gcGFyYW1zLT5iYXRjaF9vYmpfdm1fb2Zmc2V0ICsKPiAgCQkgICAgIHBhcmFtcy0+ YXJnc19iYXRjaF9zdGFydF9vZmZzZXQ7Cj4gIAo+IC0JcmV0ID0gcmluZy0+ZGlzcGF0Y2hfZXhl Y2J1ZmZlcihwYXJhbXMtPnJlcXVlc3QsCj4gKwlyZXQgPSByaW5nLT5kaXNwYXRjaF9leGVjYnVm ZmVyKHJlcSwKPiAgCQkJCQlleGVjX3N0YXJ0LCBleGVjX2xlbiwKPiAgCQkJCQlwYXJhbXMtPmRp c3BhdGNoX2ZsYWdzKTsKPiAgCWlmIChyZXQpCj4gIAkJZ290byBlcnJvcjsKPiAgCj4gLQl0cmFj ZV9pOTE1X2dlbV9yaW5nX2Rpc3BhdGNoKHBhcmFtcy0+cmVxdWVzdCwgcGFyYW1zLT5kaXNwYXRj aF9mbGFncyk7Cj4gKwl0cmFjZV9pOTE1X2dlbV9yaW5nX2Rpc3BhdGNoKHJlcSwgcGFyYW1zLT5k aXNwYXRjaF9mbGFncyk7Cj4gIAo+ICAJaTkxNV9nZW1fZXhlY2J1ZmZlcl9yZXRpcmVfY29tbWFu ZHMocGFyYW1zKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBpbmRleCAwMTQxODBj Li5hMzQ0YTNhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtOTI5LDcgKzky OSw4IEBAIGludCBpbnRlbF9leGVjbGlzdHNfc3VibWlzc2lvbihzdHJ1Y3QgaTkxNV9leGVjYnVm ZmVyX3BhcmFtcyAqcGFyYW1zLAo+ICBpbnQgaW50ZWxfZXhlY2xpc3RzX3N1Ym1pc3Npb25fZmlu YWwoc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcykKPiAgewo+ICAJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gcGFyYW1zLT5kZXYtPmRldl9wcml2YXRlOwo+ IC0Jc3RydWN0IGludGVsX3JpbmdidWZmZXIgKnJpbmdidWYgPSBwYXJhbXMtPnJlcXVlc3QtPnJp bmdidWY7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSA9IHBhcmFtcy0+cmVx dWVzdDsKPiArCXN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmID0gcmVxLT5yaW5nYnVm Owo+ICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyA9IHBhcmFtcy0+cmluZzsKPiAgCXU2 NCBleGVjX3N0YXJ0Owo+ICAJaW50IHJldDsKPiBAQCAtOTQxLDEzICs5NDIsMTMgQEAgaW50IGlu dGVsX2V4ZWNsaXN0c19zdWJtaXNzaW9uX2ZpbmFsKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFy YW1zICpwYXJhbXMpCj4gIAkgKiBVbmNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZSBncHUgY2FjaGVz IGFuZCBlbnN1cmUgdGhhdCB3ZSBkbyBmbHVzaAo+ICAJICogYW55IHJlc2lkdWFsIHdyaXRlcyBm cm9tIHRoZSBwcmV2aW91cyBiYXRjaC4KPiAgCSAqLwo+IC0JcmV0ID0gbG9naWNhbF9yaW5nX2lu dmFsaWRhdGVfYWxsX2NhY2hlcyhwYXJhbXMtPnJlcXVlc3QpOwo+ICsJcmV0ID0gbG9naWNhbF9y aW5nX2ludmFsaWRhdGVfYWxsX2NhY2hlcyhyZXEpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4g cmV0Owo+ICAKPiAgCWlmIChyaW5nID09ICZkZXZfcHJpdi0+cmluZ1tSQ1NdICYmCj4gIAkgICAg cGFyYW1zLT5pbnN0cF9tb2RlICE9IGRldl9wcml2LT5yZWxhdGl2ZV9jb25zdGFudHNfbW9kZSkg ewo+IC0JCXJldCA9IGludGVsX2xvZ2ljYWxfcmluZ19iZWdpbihwYXJhbXMtPnJlcXVlc3QsIDQp Owo+ICsJCXJldCA9IGludGVsX2xvZ2ljYWxfcmluZ19iZWdpbihyZXEsIDQpOwo+ICAJCWlmIChy ZXQpCj4gIAkJCXJldHVybiByZXQ7Cj4gIAo+IEBAIC05NjMsMTEgKzk2NCwxMSBAQCBpbnQgaW50 ZWxfZXhlY2xpc3RzX3N1Ym1pc3Npb25fZmluYWwoc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJh bXMgKnBhcmFtcykKPiAgCWV4ZWNfc3RhcnQgPSBwYXJhbXMtPmJhdGNoX29ial92bV9vZmZzZXQg Kwo+ICAJCSAgICAgcGFyYW1zLT5hcmdzX2JhdGNoX3N0YXJ0X29mZnNldDsKPiAgCj4gLQlyZXQg PSByaW5nLT5lbWl0X2JiX3N0YXJ0KHBhcmFtcy0+cmVxdWVzdCwgZXhlY19zdGFydCwgcGFyYW1z LT5kaXNwYXRjaF9mbGFncyk7Cj4gKwlyZXQgPSByaW5nLT5lbWl0X2JiX3N0YXJ0KHJlcSwgZXhl Y19zdGFydCwgcGFyYW1zLT5kaXNwYXRjaF9mbGFncyk7Cj4gIAlpZiAocmV0KQo+ICAJCXJldHVy biByZXQ7Cj4gIAo+IC0JdHJhY2VfaTkxNV9nZW1fcmluZ19kaXNwYXRjaChwYXJhbXMtPnJlcXVl c3QsIHBhcmFtcy0+ZGlzcGF0Y2hfZmxhZ3MpOwo+ICsJdHJhY2VfaTkxNV9nZW1fcmluZ19kaXNw YXRjaChyZXEsIHBhcmFtcy0+ZGlzcGF0Y2hfZmxhZ3MpOwo+ICAKPiAgCWk5MTVfZ2VtX2V4ZWNi dWZmZXJfcmV0aXJlX2NvbW1hbmRzKHBhcmFtcyk7Cj4gIAo+IAoKUmV2aWV3ZWQtYnk6IEplc3Nl IEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=