From: Dave Gordon <david.s.gordon@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Rodrigo Vivi <rodrigo.vivi@gmail.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH v3] drm/i915/execlists: Move WA_TAIL_DWORDS to callee
Date: Mon, 8 Feb 2016 10:59:51 +0000 [thread overview]
Message-ID: <56B87527.7030100@intel.com> (raw)
In-Reply-To: <20160206093336.GA27925@nuc-i3427.alporthouse.com>
On 06/02/16 09:33, Chris Wilson wrote:
> On Fri, Feb 05, 2016 at 02:56:51PM -0800, Rodrigo Vivi wrote:
>> On Fri, Feb 5, 2016 at 11:31 AM, Dave Gordon <david.s.gordon@intel.com> wrote:
>>> @@ -907,7 +927,8 @@ int intel_logical_ring_reserve_space(struct drm_i915_gem_request *request)
>>> * adding any commands to it then there might not actually be
>>> * sufficient room for the submission commands.
>>> */
>>> - intel_ring_reserved_space_reserve(request->ringbuf, MIN_SPACE_FOR_ADD_REQUEST);
>>> + intel_ring_reserved_space_reserve(request->ringbuf,
>>> + MIN_SPACE_FOR_ADD_REQUEST + WA_TAIL_DWORDS);
>
> This should already be included in the MIN_SPACE_FOR_ADD_REQUEST as that
> value is universal (and is adequate for the moment).
> -Chris
I didn't put it there because we needed the extra space at present, but
rather so that people changing either of those two values would be more
likely to think about whether there were any unexpected interactions.
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-08 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 19:31 [PATCH v3] drm/i915/execlists: Move WA_TAIL_DWORDS to callee Dave Gordon
2016-02-05 22:56 ` Rodrigo Vivi
2016-02-06 9:33 ` Chris Wilson
2016-02-08 10:59 ` Dave Gordon [this message]
2016-02-08 11:08 ` Dave Gordon
2016-02-08 12:58 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B87527.7030100@intel.com \
--to=david.s.gordon@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).