From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH 2/3] drm/i915: Use atomic helpers for
	suspend.
Date: Tue, 9 Feb 2016 15:05:51 +0100
Message-ID: <56B9F23F.9080502@linux.intel.com>
References: <20160203163408.GF23290@intel.com>
 <1455022343-15222-1-git-send-email-maarten.lankhorst@linux.intel.com>
 <1455022343-15222-2-git-send-email-maarten.lankhorst@linux.intel.com>
 <20160209133747.GN23290@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 2D1E16E586
 for <intel-gfx@lists.freedesktop.org>; Tue,  9 Feb 2016 06:05:53 -0800 (PST)
In-Reply-To: <20160209133747.GN23290@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T3AgMDktMDItMTYgb20gMTQ6Mzcgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVHVlLCBG
ZWIgMDksIDIwMTYgYXQgMDE6NTI6MjJQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6
Cj4+IEluc3RlYWQgb2YgZHVwbGljYXRpbmcgdGhlIGZ1bmN0aW9uYWxpdHkgbm93IHRoYXQgd2Ug
bm8gbG9uZ2VyIG5lZWQKPj4gdG8gcHJlc2VydmUgZHBsbCBzdGF0ZSB3ZSBjYW4gbW92ZSB0byB1
c2luZyB0aGUgdXBzdHJlYW0gc3VzcGVuZCBoZWxwZXIuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1h
YXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+IC0t
LQo+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgIHwgICAzICsKPj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgICAgICB8ICAgOCAtLS0KPj4gIGRyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICB8ICAgMSArCj4+ICBkcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxMTcgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0KPj4gIDQgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgODcgZGVsZXRpb25z
KC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIu
YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4+IGluZGV4IDJiNDMwYjA1
ZjM1ZC4uYTJkM2IwOTRmMjdjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0
b21pY19oZWxwZXIuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIu
Ywo+PiBAQCAtMjEwMiw2ICsyMTAyLDkgQEAgaW50IGRybV9hdG9taWNfaGVscGVyX3Jlc3VtZShz
dHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgCWVyciA9IGRybV9hdG9taWNfY29tbWl0KHN0YXRl
KTsKPj4gIAlkcm1fbW9kZXNldF91bmxvY2tfYWxsKGRldik7Cj4+ICAKPj4gKwlpZiAoZXJyKQo+
PiArCQlkcm1fYXRvbWljX3N0YXRlX2ZyZWUoc3RhdGUpOwo+PiArCj4+ICAJcmV0dXJuIGVycjsK
Pj4gIH0KPj4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfcmVzdW1lKTsKPj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pOTE1X2Rydi5jCj4+IGluZGV4IDExZDg0MTRlZGJiZS4uZmM5YjU1MmJmY2QxIDEw
MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPj4gQEAgLTYwMCwxMyArNjAwLDcgQEAgc3Rh
dGljIGludCBpOTE1X2RybV9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAKPj4g
IAlpbnRlbF9zdXNwZW5kX2d0X3Bvd2Vyc2F2ZShkZXYpOwo+PiAgCj4+IC0JLyoKPj4gLQkgKiBE
aXNhYmxlIENSVENzIGRpcmVjdGx5IHNpbmNlIHdlIHdhbnQgdG8gcHJlc2VydmUgc3cgc3RhdGUK
Pj4gLQkgKiBmb3IgX3RoYXcuIEFsc28sIHBvd2VyIGdhdGUgdGhlIENSVEMgcG93ZXIgd2VsbHMu
Cj4+IC0JICovCj4+IC0JZHJtX21vZGVzZXRfbG9ja19hbGwoZGV2KTsKPj4gIAlpbnRlbF9kaXNw
bGF5X3N1c3BlbmQoZGV2KTsKPj4gLQlkcm1fbW9kZXNldF91bmxvY2tfYWxsKGRldik7Cj4+ICAK
Pj4gIAlpbnRlbF9kcF9tc3Rfc3VzcGVuZChkZXYpOwo+PiAgCj4+IEBAIC03NjEsOSArNzU1LDcg
QEAgc3RhdGljIGludCBpOTE1X2RybV9yZXN1bWUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4g
IAkJZGV2X3ByaXYtPmRpc3BsYXkuaHBkX2lycV9zZXR1cChkZXYpOwo+PiAgCXNwaW5fdW5sb2Nr
X2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPj4gIAo+PiAtCWRybV9tb2Rlc2V0X2xvY2tfYWxs
KGRldik7Cj4+ICAJaW50ZWxfZGlzcGxheV9yZXN1bWUoZGV2KTsKPj4gLQlkcm1fbW9kZXNldF91
bmxvY2tfYWxsKGRldik7Cj4+ICAKPj4gIAlpbnRlbF9kcF9tc3RfcmVzdW1lKGRldik7Cj4+ICAK
Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IGluZGV4IDgyMTY2NjU0MDVlYi4uZWYyODk1MTRi
OTdlIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gQEAgLTE4NDgsNiArMTg0OCw3
IEBAIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlIHsKPj4gIAo+PiAgCWVudW0gbW9kZXNldF9yZXN0
b3JlIG1vZGVzZXRfcmVzdG9yZTsKPj4gIAlzdHJ1Y3QgbXV0ZXggbW9kZXNldF9yZXN0b3JlX2xv
Y2s7Cj4+ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKm1vZGVzZXRfcmVzdG9yZV9zdGF0ZTsK
Pj4gIAo+PiAgCXN0cnVjdCBsaXN0X2hlYWQgdm1fbGlzdDsgLyogR2xvYmFsIGxpc3Qgb2YgYWxs
IGFkZHJlc3Mgc3BhY2VzICovCj4+ICAJc3RydWN0IGk5MTVfZ3R0IGd0dDsgLyogVk0gcmVwcmVz
ZW50aW5nIHRoZSBnbG9iYWwgYWRkcmVzcyBzcGFjZSAqLwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jCj4+IGluZGV4IGU0OTZjMTMwMzY0ZC4uNGM5MWZkMWM1MjIyIDEwMDY0NAo+
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IEBAIC02MzkzLDU4ICs2MzkzLDE5
IEBAIHN0YXRpYyB2b2lkIGludGVsX2NydGNfZGlzYWJsZV9ub2F0b21pYyhzdHJ1Y3QgZHJtX2Ny
dGMgKmNydGMpCj4+ICAgKi8KPj4gIGludCBpbnRlbF9kaXNwbGF5X3N1c3BlbmQoc3RydWN0IGRy
bV9kZXZpY2UgKmRldikKPj4gIHsKPj4gLQlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICpjb25maWcg
PSAmZGV2LT5tb2RlX2NvbmZpZzsKPj4gLQlzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHgg
KmN0eCA9IGNvbmZpZy0+YWNxdWlyZV9jdHg7Cj4+IC0Jc3RydWN0IGRybV9hdG9taWNfc3RhdGUg
KnN0YXRlOwo+PiAtCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPj4gLQl1bnNpZ25lZCBjcnRjX21h
c2sgPSAwOwo+PiAtCWludCByZXQgPSAwOwo+PiAtCj4+IC0JaWYgKFdBUk5fT04oIWN0eCkpCj4+
IC0JCXJldHVybiAwOwo+PiAtCj4+IC0JbG9ja2RlcF9hc3NlcnRfaGVsZCgmY3R4LT53d19jdHgp
Owo+PiAtCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+PiAtCWlmIChXQVJO
X09OKCFzdGF0ZSkpCj4+IC0JCXJldHVybiAtRU5PTUVNOwo+PiAtCj4+IC0Jc3RhdGUtPmFjcXVp
cmVfY3R4ID0gY3R4Owo+PiAtCXN0YXRlLT5hbGxvd19tb2Rlc2V0ID0gdHJ1ZTsKPj4gLQo+PiAt
CWZvcl9lYWNoX2NydGMoZGV2LCBjcnRjKSB7Cj4+IC0JCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq
Y3J0Y19zdGF0ZSA9Cj4+IC0JCQlkcm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBjcnRj
KTsKPj4gLQo+PiAtCQlyZXQgPSBQVFJfRVJSX09SX1pFUk8oY3J0Y19zdGF0ZSk7Cj4+IC0JCWlm
IChyZXQpCj4+IC0JCQlnb3RvIGZyZWU7Cj4+IC0KPj4gLQkJaWYgKCFjcnRjX3N0YXRlLT5hY3Rp
dmUpCj4+IC0JCQljb250aW51ZTsKPj4gLQo+PiAtCQljcnRjX3N0YXRlLT5hY3RpdmUgPSBmYWxz
ZTsKPj4gLQkJY3J0Y19tYXNrIHw9IDEgPDwgZHJtX2NydGNfaW5kZXgoY3J0Yyk7Cj4+IC0JfQo+
PiAtCj4+IC0JaWYgKGNydGNfbWFzaykgewo+PiAtCQlyZXQgPSBkcm1fYXRvbWljX2NvbW1pdChz
dGF0ZSk7Cj4+IC0KPj4gLQkJaWYgKCFyZXQpIHsKPj4gLQkJCWZvcl9lYWNoX2NydGMoZGV2LCBj
cnRjKQo+PiAtCQkJCWlmIChjcnRjX21hc2sgJiAoMSA8PCBkcm1fY3J0Y19pbmRleChjcnRjKSkp
Cj4+IC0JCQkJCWNydGMtPnN0YXRlLT5hY3RpdmUgPSB0cnVlOwo+PiAtCj4+IC0JCQlyZXR1cm4g
cmV0Owo+PiAtCQl9Cj4+IC0JfQo+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp
diA9IHRvX2k5MTUoZGV2KTsKPj4gKwlpbnQgcmV0Owo+PiAgCj4+IC1mcmVlOgo+PiAtCWlmIChy
ZXQpCj4+ICsJZGV2X3ByaXYtPm1vZGVzZXRfcmVzdG9yZV9zdGF0ZSA9IGRybV9hdG9taWNfaGVs
cGVyX3N1c3BlbmQoZGV2KTsKPj4gKwlyZXQgPSBQVFJfRVJSX09SX1pFUk8oZGV2X3ByaXYtPm1v
ZGVzZXRfcmVzdG9yZV9zdGF0ZSk7Cj4+ICsJaWYgKHJldCkgewo+PiAgCQlEUk1fRVJST1IoIlN1
c3BlbmRpbmcgY3J0YydzIGZhaWxlZCB3aXRoICVpXG4iLCByZXQpOwo+PiAtCWRybV9hdG9taWNf
c3RhdGVfZnJlZShzdGF0ZSk7Cj4+ICsJCWRldl9wcml2LT5tb2Rlc2V0X3Jlc3RvcmVfc3RhdGUg
PSBOVUxMOwo+PiArCX0KPiBJIHdvdWxkIHVzZSBhIGxvY2FsIHN0YXRlIHBvaW50ZXIgYW5kIG9u
bHkgYXNzaWduIGl0IHRvCj4gbW9kZXNldF9yZXN0b3JlX3N0YXRlIG9uY2Ugd2Uga25vdyBpdCdz
IGdvb2QuCj4KPj4gIAlyZXR1cm4gcmV0Owo+PiAgfQo+PiAgCj4+ICsKPiBTcHVyaW91cyBuZXds
aW5lLgo+Cj4+ICB2b2lkIGludGVsX2VuY29kZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2VuY29kZXIg
KmVuY29kZXIpCj4+ICB7Cj4+ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIg
PSB0b19pbnRlbF9lbmNvZGVyKGVuY29kZXIpOwo+PiBAQCAtMTU5MDksNTEgKzE1ODcwLDQ5IEBA
IGludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4g
IAo+PiAgdm9pZCBpbnRlbF9kaXNwbGF5X3Jlc3VtZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+
PiAgewo+PiAtCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSA9IGRybV9hdG9taWNfc3Rh
dGVfYWxsb2MoZGV2KTsKPj4gLQlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uOwo+PiAtCXN0
cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmU7Cj4+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2ID0gdG9faTkxNShkZXYpOwo+PiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0
ZSA9IGRldl9wcml2LT5tb2Rlc2V0X3Jlc3RvcmVfc3RhdGU7Cj4+ICsJc3RydWN0IGRybV9tb2Rl
c2V0X2FjcXVpcmVfY3R4IGN0eDsKPj4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4+IC0JaW50
IHJldDsKPj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+ICsJaW50IHJl
dCwgaTsKPj4gKwo+PiArCWludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoZGV2KTsKPiBJc24n
dCBzb21ldGhpbmcgaW4gdGhlcmUgZ29pbmcgdG8gc2NyZWFtIGFib3V0IGxvY2tpbmc/Ckkgd2Fz
IGhvcGluZyB0byBmaW5kIG91dCBieSBydW5uaW5nIGl0IHRocm91Z2ggQ0kuLgoKSSBkb24ndCBz
ZWUgd2hhdCBwb3NzaWJseSBjb3VsZCBzY3JlYW0gaG93ZXZlciwgZnJvbSBhIGdsYW5jZSBpdCBz
ZWVtcyBub3RoaW5nIGRlcGVuZHMgb24gaXQuCj4+ICsJaTkxNV9yZWRpc2FibGVfdmdhKGRldik7
Cj4+ICsJZGV2X3ByaXYtPm1vZGVzZXRfcmVzdG9yZV9zdGF0ZSA9IE5VTEw7Cj4+ICAKPj4gIAlp
ZiAoIXN0YXRlKQo+PiAgCQlyZXR1cm47Cj4+ICAKPj4gLQlzdGF0ZS0+YWNxdWlyZV9jdHggPSBk
ZXYtPm1vZGVfY29uZmlnLmFjcXVpcmVfY3R4Owo+PiAtCj4+IC0JZm9yX2VhY2hfY3J0YyhkZXYs
IGNydGMpIHsKPj4gLQkJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlID0KPj4gLQkJ
CWRybV9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+PiAtCj4+IC0JCXJldCA9
IFBUUl9FUlJfT1JfWkVSTyhjcnRjX3N0YXRlKTsKPj4gLQkJaWYgKHJldCkKPj4gLQkJCWdvdG8g
ZXJyOwo+PiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfaW5pdCgmY3R4LCAwKTsKPj4gKwlzdGF0ZS0+
YWNxdWlyZV9jdHggPSAmY3R4Owo+PiAgCj4+IC0JCS8qIGZvcmNlIGEgcmVzdG9yZSAqLwo+PiAr
CWZvcl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsKPj4g
KwkJLyoKPj4gKwkJICogRm9yY2UgcmVjYWxjdWxhdGlvbiBldmVuIGlmIHdlIHJlc3RvcmUKPj4g
KwkJICogY3VycmVudCBzdGF0ZS4gV2l0aCBmYXN0IG1vZGVzZXQgdGhpcyBtYXkgbm90IHJlc3Vs
dAo+PiArCQkgKiBpbiBhIG1vZGVzZXQgd2hlbiB0aGUgc3RhdGUgaXMgY29tcGF0aWJsZS4KPj4g
KwkJICovCj4+ICAJCWNydGNfc3RhdGUtPm1vZGVfY2hhbmdlZCA9IHRydWU7Cj4+ICAJfQo+IEht
bS4gV2h5IGRvIHdlIG5lZWQgdG8gc2V0IHRoYXQgZXhhY3RseT8gSWYgdGhlIGN1cnJlbnQgc3Rh
dGUgZG9lc24ndAo+IG1hdGNoIHRoZSAidG8gYmUgcmVzdG9yZWQiIHN0YXRlLCBzaG91bGRuJ3Qg
c29tZXRoaW5nIHNvbWV3aGVyZSBmaWd1cmUKPiBvdXQgdGhhdCB3ZSByZWFsbHkgbmVlZCBhIG1v
ZGVzZXQ/CldlIGhhdmUgYSB3aG9sZSBidW5jaCBvZiBodyBzdGF0ZSBmcm9tIHN1c3BlbmQgdGhh
dCBtYXkgYmUgZGlmZmVyZW50IGZyb20gdGhlIGh3IHJlYWRvdXQgaW4gcmVzdW1lLiBUaGlzIGlz
IG5vdCBoYW5kbGVkIGJ5IHRoZSBjb3JlIGJlY2F1c2UgaXQgZG9lc24ndCBrbm93IGFib3V0IGRy
aXZlciBzcGVjaWZpYyBwbGwncyBldGMuIFNvIHRoYXQncyB3aGF0IHRoZSBtb2RlX2NoYW5nZWQg
PSB0cnVlIGlzIGZvci4gSXQncyBhIGhpbnQgdG8gaW50ZWxfYXRvbWljX2NoZWNrIHRoYXQgbWln
aHQgZ2V0IGRvd25ncmFkZWQgdG8gdXBkYXRlX3BpcGUgaWYgaTkxNS5mYXN0Ym9vdCBpcyB0cnVl
IGFuZCB0aGUgaHcgcmVhZG91dCBhbmQgcmVzdW1lIHN0YXRlcyBhcmUgY29tcGF0aWJsZS4KCn5N
YWFydGVuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu
dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw
czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=