From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915: Do not return stale status / remove impossible WARN Date: Fri, 12 Feb 2016 10:05:58 +0000 Message-ID: <56BDAE86.3030009@linux.intel.com> References: <1455213790-4724-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20160211210032.GB421@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id D82D96E2D9 for ; Fri, 12 Feb 2016 02:05:59 -0800 (PST) In-Reply-To: <20160211210032.GB421@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDExLzAyLzE2IDIxOjAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gVGh1LCBGZWIgMTEs IDIwMTYgYXQgMDY6MDM6MDlQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IE9ubHkgY2Fs bGVyIHRvIGdldF9jb250ZXh0X3N0YXR1cyBlbnN1cmVzIHJlYWQgcG9pbnRlciBzdGF5cyBpbgo+ PiByYW5nZSBzbyB0aGUgV0FSTiBpcyBpbXBvc3NpYmxlLiBBbHNvLCBpZiB0aGUgV0FSTiB3b3Vs ZCBiZQo+PiB0cmlnZ2VyZWQgYnkgYSBoeXBvdGhldGljYWwgbmV3IGNhbGxlciBzdGFsZSBzdGF0 dXMgd291bGQgYmUKPj4gcmV0dXJuZWQgdG8gdGhlbS4KPj4KPj4gTWF5YmUgaXQgaXMgYmV0dGVy IHRvIHdyYXAgdGhlIHBvaW50ZXIgaW4gdGhlIGZ1bmN0aW9uIGl0c2VsZgo+PiB0aGVuIHRvIGF2 b2lkIGJvdGggYW5kIGV2ZW4gcmVzdWx0cyBpbiBzbWFsbGVyIGNvZGUuCj4+Cj4+IFNpZ25lZC1v ZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+IC0tLQo+ PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMTUgKysrKysrLS0tLS0tLS0t Cj4+ICAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPj4K Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gaW5kZXggODllYjg5MmRmNGFlLi45NTFmMWU2 YWY5NDcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+IEBAIC01MDcsMTcgKzUw NywxNiBAQCBzdGF0aWMgYm9vbCBleGVjbGlzdHNfY2hlY2tfcmVtb3ZlX3JlcXVlc3Qoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqcmluZywKPj4gICAJcmV0dXJuIGZhbHNlOwo+PiAgIH0KPj4gICAK Pj4gLXN0YXRpYyB2b2lkIGdldF9jb250ZXh0X3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICpyaW5nLAo+PiAtCQkJICAgICAgIHU4IHJlYWRfcG9pbnRlciwKPj4gLQkJCSAgICAgICB1MzIg KnN0YXR1cywgdTMyICpjb250ZXh0X2lkKQo+PiArc3RhdGljIHUzMiBnZXRfY29udGV4dF9zdGF0 dXMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywgdTggcmVhZF9wb2ludGVyLAo+PiArCQkJ ICAgICAgdTMyICpjb250ZXh0X2lkKQo+PiAgIHsKPj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gcmluZy0+ZGV2LT5kZXZfcHJpdmF0ZTsKPj4gICAKPj4gLQlpZiAoV0FS Tl9PTihyZWFkX3BvaW50ZXIgPj0gR0VOOF9DU0JfRU5UUklFUykpCj4+IC0JCXJldHVybjsKPj4g KwlyZWFkX3BvaW50ZXIgJT0gR0VOOF9DU0JfRU5UUklFUzsKPj4gICAKPj4gLQkqc3RhdHVzID0g STkxNV9SRUFEKFJJTkdfQ09OVEVYVF9TVEFUVVNfQlVGX0xPKHJpbmcsIHJlYWRfcG9pbnRlcikp Owo+PiAgIAkqY29udGV4dF9pZCA9IEk5MTVfUkVBRChSSU5HX0NPTlRFWFRfU1RBVFVTX0JVRl9I SShyaW5nLCByZWFkX3BvaW50ZXIpKTsKPiAKPiBNaWNyby1vcHRpbWlzaW5nIGhhdCBzYXlzIG5v dCB0byBldmVuIGRvIHRoZSB1bmNhY2hlZCwgc3BpbmxvY2tlZCBtbWlvCj4gcmVhZCB3aGVuIG5v dCByZXF1aXJlZC4KCllvdSBtZWFuIG1vdmUgdGhlIGZvcmNld2FrZSBncmFiIG91dCBmcm9tIGVs c3Agd3JpdGUgdG8gY292ZXIgYWxsIG1taW8KcmVhZHM/IFRoZXNlIHR3byBwYXRjaGVzIG1ha2Ug dGhlIGlycSBoYW5kbGVyIGFyb3VuZCAzLjclIHNtYWxsZXIgYW5kCm1vdmluZyB0aGUgZm9yY2V3 YWtlL3VuY29yZSBsb2NrIHNocmlua3MgdGhhdCBieSBhIDElIG1vcmUuIE11c3QgYmUKZmFzdGVy IGFzIHdlbGwsIGlmIHNvbWVvbmUgY291bGQgbWVhc3VyZSBpdC4gOikKCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2xyYy5jCmluZGV4IDFlN2NjZDBhNjU3My4uNzdhNjQwMDhmNTNkIDEwMDY0NAotLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9scmMuYwpAQCAtMzc1LDggKzM3NSw2IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19l bHNwX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEwLAogCXJxMC0+ZWxzcF9z dWJtaXR0ZWQrKzsKIAogCS8qIFlvdSBtdXN0IGFsd2F5cyB3cml0ZSBib3RoIGRlc2NyaXB0b3Jz IGluIHRoZSBvcmRlciBiZWxvdy4gKi8KLQlzcGluX2xvY2soJmRldl9wcml2LT51bmNvcmUubG9j ayk7Ci0JaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXRfX2xvY2tlZChkZXZfcHJpdiwgRk9SQ0VX QUtFX0FMTCk7CiAJSTkxNV9XUklURV9GVyhSSU5HX0VMU1AocmluZyksIHVwcGVyXzMyX2JpdHMo ZGVzY1sxXSkpOwogCUk5MTVfV1JJVEVfRlcoUklOR19FTFNQKHJpbmcpLCBsb3dlcl8zMl9iaXRz KGRlc2NbMV0pKTsKIApAQCAtMzg2LDggKzM4NCw2IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19l bHNwX3dyaXRlKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEwLAogCiAJLyogRUxTUCBp cyBhIHdvIHJlZ2lzdGVyLCB1c2UgYW5vdGhlciBuZWFyYnkgcmVnIGZvciBwb3N0aW5nICovCiAJ UE9TVElOR19SRUFEX0ZXKFJJTkdfRVhFQ0xJU1RfU1RBVFVTX0xPKHJpbmcpKTsKLQlpbnRlbF91 bmNvcmVfZm9yY2V3YWtlX3B1dF9fbG9ja2VkKGRldl9wcml2LCBGT1JDRVdBS0VfQUxMKTsKLQlz cGluX3VubG9jaygmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsKIH0KIAogc3RhdGljIGludCBleGVj bGlzdHNfdXBkYXRlX2NvbnRleHQoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSkKQEAg LTUxMyw5ICs1MDksOSBAQCBzdGF0aWMgdTMyIGdldF9jb250ZXh0X3N0YXR1cyhzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICpyaW5nLCB1OCByZWFkX3BvaW50ZXIsCiAKIAlyZWFkX3BvaW50ZXIgJT0g R0VOOF9DU0JfRU5UUklFUzsKIAotCSpjb250ZXh0X2lkID0gSTkxNV9SRUFEKFJJTkdfQ09OVEVY VF9TVEFUVVNfQlVGX0hJKHJpbmcsIHJlYWRfcG9pbnRlcikpOworCSpjb250ZXh0X2lkID0gSTkx NV9SRUFEX0ZXKFJJTkdfQ09OVEVYVF9TVEFUVVNfQlVGX0hJKHJpbmcsIHJlYWRfcG9pbnRlcikp OwogCi0JcmV0dXJuIEk5MTVfUkVBRChSSU5HX0NPTlRFWFRfU1RBVFVTX0JVRl9MTyhyaW5nLCBy ZWFkX3BvaW50ZXIpKTsKKwlyZXR1cm4gSTkxNV9SRUFEX0ZXKFJJTkdfQ09OVEVYVF9TVEFUVVNf QlVGX0xPKHJpbmcsIHJlYWRfcG9pbnRlcikpOwogfQogCiAvKioKQEAgLTUzNSwxNSArNTMxLDE4 IEBAIHZvaWQgaW50ZWxfbHJjX2lycV9oYW5kbGVyKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJp bmcpCiAJdTMyIHN0YXR1c19pZDsKIAl1MzIgc3VibWl0X2NvbnRleHRzID0gMDsKIAotCXN0YXR1 c19wb2ludGVyID0gSTkxNV9SRUFEKFJJTkdfQ09OVEVYVF9TVEFUVVNfUFRSKHJpbmcpKTsKKwlz cGluX2xvY2soJnJpbmctPmV4ZWNsaXN0X2xvY2spOworCisJc3Bpbl9sb2NrKCZkZXZfcHJpdi0+ dW5jb3JlLmxvY2spOworCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0X19sb2NrZWQoZGV2X3By aXYsIEZPUkNFV0FLRV9BTEwpOworCisJc3RhdHVzX3BvaW50ZXIgPSBJOTE1X1JFQURfRlcoUklO R19DT05URVhUX1NUQVRVU19QVFIocmluZykpOwogCiAJcmVhZF9wb2ludGVyID0gcmluZy0+bmV4 dF9jb250ZXh0X3N0YXR1c19idWZmZXI7CiAJd3JpdGVfcG9pbnRlciA9IEdFTjhfQ1NCX1dSSVRF X1BUUihzdGF0dXNfcG9pbnRlcik7CiAJaWYgKHJlYWRfcG9pbnRlciA+IHdyaXRlX3BvaW50ZXIp CiAJCXdyaXRlX3BvaW50ZXIgKz0gR0VOOF9DU0JfRU5UUklFUzsKIAotCXNwaW5fbG9jaygmcmlu Zy0+ZXhlY2xpc3RfbG9jayk7Ci0KIAl3aGlsZSAocmVhZF9wb2ludGVyIDwgd3JpdGVfcG9pbnRl cikgewogCQlzdGF0dXMgPSBnZXRfY29udGV4dF9zdGF0dXMocmluZywgKytyZWFkX3BvaW50ZXIs ICZzdGF0dXNfaWQpOwogCkBAIC01NjksMjIgKzU2OCwyNiBAQCB2b2lkIGludGVsX2xyY19pcnFf aGFuZGxlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQogCSAgICBHRU44X0NUWF9TVEFU VVNfQUNUSVZFX0lETEUpKSkpCiAJCWV4ZWNsaXN0c19jb250ZXh0X3VucXVldWUocmluZyk7CiAK LQlzcGluX3VubG9jaygmcmluZy0+ZXhlY2xpc3RfbG9jayk7Ci0KLQlpZiAodW5saWtlbHkoc3Vi bWl0X2NvbnRleHRzID4gMikpCi0JCURSTV9FUlJPUigiTW9yZSB0aGFuIHR3byBjb250ZXh0IGNv bXBsZXRlIGV2ZW50cz9cbiIpOwotCiAJcmluZy0+bmV4dF9jb250ZXh0X3N0YXR1c19idWZmZXIg PSB3cml0ZV9wb2ludGVyICUgR0VOOF9DU0JfRU5UUklFUzsKIAogCS8qIFVwZGF0ZSB0aGUgcmVh ZCBwb2ludGVyIHRvIHRoZSBvbGQgd3JpdGUgcG9pbnRlci4gTWFudWFsIHJpbmdidWZmZXIKIAkg KiBtYW5hZ2VtZW50IGZ0dyA8L3NhcmNhc20+ICovCi0JSTkxNV9XUklURShSSU5HX0NPTlRFWFRf U1RBVFVTX1BUUihyaW5nKSwKLQkJICAgX01BU0tFRF9GSUVMRChHRU44X0NTQl9SRUFEX1BUUl9N QVNLLAotCQkJCSByaW5nLT5uZXh0X2NvbnRleHRfc3RhdHVzX2J1ZmZlciA8PCA4KSk7CisJSTkx NV9XUklURV9GVyhSSU5HX0NPTlRFWFRfU1RBVFVTX1BUUihyaW5nKSwKKwkJICAgICAgX01BU0tF RF9GSUVMRChHRU44X0NTQl9SRUFEX1BUUl9NQVNLLAorCQkJCSAgICByaW5nLT5uZXh0X2NvbnRl eHRfc3RhdHVzX2J1ZmZlciA8PCA4KSk7CisKKwlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1dF9f bG9ja2VkKGRldl9wcml2LCBGT1JDRVdBS0VfQUxMKTsKKwlzcGluX3VubG9jaygmZGV2X3ByaXYt PnVuY29yZS5sb2NrKTsKKworCXNwaW5fdW5sb2NrKCZyaW5nLT5leGVjbGlzdF9sb2NrKTsKKwor CWlmICh1bmxpa2VseShzdWJtaXRfY29udGV4dHMgPiAyKSkKKwkJRFJNX0VSUk9SKCJNb3JlIHRo YW4gdHdvIGNvbnRleHQgY29tcGxldGUgZXZlbnRzP1xuIik7CiB9CiAKIHN0YXRpYyBpbnQgZXhl Y2xpc3RzX2NvbnRleHRfcXVldWUoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0 KQogeworCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJlcXVlc3QtPmk5MTU7 CiAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyA9IHJlcXVlc3QtPnJpbmc7CiAJc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpjdXJzb3I7CiAJaW50IG51bV9lbGVtZW50cyA9IDA7CkBA IC02MTYsOSArNjE5LDE2IEBAIHN0YXRpYyBpbnQgZXhlY2xpc3RzX2NvbnRleHRfcXVldWUoc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQogCX0KIAogCWxpc3RfYWRkX3RhaWwo JnJlcXVlc3QtPmV4ZWNsaXN0X2xpbmssICZyaW5nLT5leGVjbGlzdF9xdWV1ZSk7Ci0JaWYgKG51 bV9lbGVtZW50cyA9PSAwKQorCWlmIChudW1fZWxlbWVudHMgPT0gMCkgeworCQlzcGluX2xvY2so JmRldl9wcml2LT51bmNvcmUubG9jayk7CisJCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0X19s b2NrZWQoZGV2X3ByaXYsIEZPUkNFV0FLRV9BTEwpOworCiAJCWV4ZWNsaXN0c19jb250ZXh0X3Vu cXVldWUocmluZyk7CiAKKwkJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXRfX2xvY2tlZChkZXZf cHJpdiwgRk9SQ0VXQUtFX0FMTCk7CisJCXNwaW5fdW5sb2NrKCZkZXZfcHJpdi0+dW5jb3JlLmxv Y2spOworCX0KKwogCXNwaW5fdW5sb2NrX2lycSgmcmluZy0+ZXhlY2xpc3RfbG9jayk7CiAKIAly ZXR1cm4gMDsKCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=