From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [PATCH v4 03/38] drm/i915: Prelude to splitting i915_gem_do_execbuffer in two Date: Fri, 12 Feb 2016 16:18:29 +0000 Message-ID: <56BE05D5.3070606@Intel.com> References: <1448278774-31376-1-git-send-email-John.C.Harrison@Intel.com> <1452537788-32136-1-git-send-email-John.C.Harrison@Intel.com> <1452537788-32136-4-git-send-email-John.C.Harrison@Intel.com> <56B383E3.104@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 6841C6E021 for ; Fri, 12 Feb 2016 08:18:31 -0800 (PST) In-Reply-To: <56B383E3.104@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes , Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gMDQvMDIvMjAxNiAxNzowMSwgSmVzc2UgQmFybmVzIHdyb3RlOgo+IE9uIDAxLzExLzIwMTYg MTA6NDIgQU0sIEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20gd3JvdGU6Cj4+IEZyb206IEpvaG4g SGFycmlzb24gPEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4+Cj4+IFRoZSBzY2hlZHVsZXIg ZGVjb3VwbGVzIHRoZSBzdWJtaXNzaW9uIG9mIGJhdGNoIGJ1ZmZlcnMgdG8gdGhlIGRyaXZlcgo+ PiB3aXRoIHRoZWlyIHN1Ym1pc3Npb24gdG8gdGhlIGhhcmR3YXJlLiBUaGlzIGJhc2ljYWxseSBt ZWFucyBzcGxpdHRpbmcKPj4gdGhlIGV4ZWNidWZmZXIoKSBmdW5jdGlvbiBpbiBoYWxmLiBUaGlz IGNoYW5nZSByZWFycmFuZ2VzIHNvbWUgY29kZQo+PiByZWFkeSBmb3IgdGhlIHNwbGl0IHRvIG9j Y3VyLgo+Pgo+PiBGb3I6IFZJWi0xNTg3Cj4+IFNpZ25lZC1vZmYtYnk6IEpvaG4gSGFycmlzb24g PEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8IDYzICsrKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAgICB8IDE4 ICsrKysrKy0tLQo+PiAgIDIgZmlsZXMgY2hhbmdlZCwgNTEgaW5zZXJ0aW9ucygrKSwgMzAgZGVs ZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9leGVjYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVy LmMKPj4gaW5kZXggYmZjNGMxNy4uMGVjYTJiNiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+PiBAQCAtOTMzLDEwICs5MzMsNyBAQCBpOTE1X2dl bV9leGVjYnVmZmVyX21vdmVfdG9fZ3B1KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVx LAo+PiAgIAlpZiAoZmx1c2hfZG9tYWlucyAmIEk5MTVfR0VNX0RPTUFJTl9HVFQpCj4+ICAgCQl3 bWIoKTsKPj4gICAKPj4gLQkvKiBVbmNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZSBncHUgY2FjaGVz IGFuZCBlbnN1cmUgdGhhdCB3ZSBkbyBmbHVzaAo+PiAtCSAqIGFueSByZXNpZHVhbCB3cml0ZXMg ZnJvbSB0aGUgcHJldmlvdXMgYmF0Y2guCj4+IC0JICovCj4+IC0JcmV0dXJuIGludGVsX3Jpbmdf aW52YWxpZGF0ZV9hbGxfY2FjaGVzKHJlcSk7Cj4+ICsJcmV0dXJuIDA7Cj4+ICAgfQo+PiAgIAo+ PiAgIHN0YXRpYyBib29sCj4+IEBAIC0xMTg5LDE3ICsxMTg2LDYgQEAgaTkxNV9nZW1fcmluZ2J1 ZmZlcl9zdWJtaXNzaW9uKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMsCj4+ ICAgCXUzMiBpbnN0cF9tYXNrOwo+PiAgIAlpbnQgcmV0Owo+PiAgIAo+PiAtCXJldCA9IGk5MTVf Z2VtX2V4ZWNidWZmZXJfbW92ZV90b19ncHUocGFyYW1zLT5yZXF1ZXN0LCB2bWFzKTsKPj4gLQlp ZiAocmV0KQo+PiAtCQlyZXR1cm4gcmV0Owo+PiAtCj4+IC0JcmV0ID0gaTkxNV9zd2l0Y2hfY29u dGV4dChwYXJhbXMtPnJlcXVlc3QpOwo+PiAtCWlmIChyZXQpCj4+IC0JCXJldHVybiByZXQ7Cj4+ IC0KPj4gLQlXQVJOKHBhcmFtcy0+Y3R4LT5wcGd0dCAmJiBwYXJhbXMtPmN0eC0+cHBndHQtPnBk X2RpcnR5X3JpbmdzICYgKDE8PHJpbmctPmlkKSwKPj4gLQkgICAgICIlcyBkaWRuJ3QgY2xlYXIg cmVsb2FkXG4iLCByaW5nLT5uYW1lKTsKPj4gLQo+PiAgIAlpbnN0cF9tb2RlID0gYXJncy0+Zmxh Z3MgJiBJOTE1X0VYRUNfQ09OU1RBTlRTX01BU0s7Cj4+ICAgCWluc3RwX21hc2sgPSBJOTE1X0VY RUNfQ09OU1RBTlRTX01BU0s7Cj4+ICAgCXN3aXRjaCAoaW5zdHBfbW9kZSkgewo+PiBAQCAtMTIz MywxMSArMTIxOSwzNyBAQCBpOTE1X2dlbV9yaW5nYnVmZmVyX3N1Ym1pc3Npb24oc3RydWN0IGk5 MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcywKPj4gICAJCXJldHVybiAtRUlOVkFMOwo+PiAg IAl9Cj4+ICAgCj4+ICsJcmV0ID0gaTkxNV9nZW1fZXhlY2J1ZmZlcl9tb3ZlX3RvX2dwdShwYXJh bXMtPnJlcXVlc3QsIHZtYXMpOwo+PiArCWlmIChyZXQpCj4+ICsJCXJldHVybiByZXQ7Cj4+ICsK Pj4gKwlpOTE1X2dlbV9leGVjYnVmZmVyX21vdmVfdG9fYWN0aXZlKHZtYXMsIHBhcmFtcy0+cmVx dWVzdCk7Cj4+ICsKPj4gKwkvKiBUbyBiZSBzcGxpdCBpbnRvIHR3byBmdW5jdGlvbnMgaGVyZS4u LiAqLwo+PiArCj4+ICsJaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+PiArCj4+ICsJ LyoKPj4gKwkgKiBVbmNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZSBncHUgY2FjaGVzIGFuZCBlbnN1 cmUgdGhhdCB3ZSBkbyBmbHVzaAo+PiArCSAqIGFueSByZXNpZHVhbCB3cml0ZXMgZnJvbSB0aGUg cHJldmlvdXMgYmF0Y2guCj4+ICsJICovCj4+ICsJcmV0ID0gaW50ZWxfcmluZ19pbnZhbGlkYXRl X2FsbF9jYWNoZXMocGFyYW1zLT5yZXF1ZXN0KTsKPj4gKwlpZiAocmV0KQo+PiArCQlnb3RvIGVy cm9yOwo+PiArCj4+ICsJLyogU3dpdGNoIHRvIHRoZSBjb3JyZWN0IGNvbnRleHQgZm9yIHRoZSBi YXRjaCAqLwo+PiArCXJldCA9IGk5MTVfc3dpdGNoX2NvbnRleHQocGFyYW1zLT5yZXF1ZXN0KTsK Pj4gKwlpZiAocmV0KQo+PiArCQlnb3RvIGVycm9yOwo+PiArCj4+ICsJV0FSTihwYXJhbXMtPmN0 eC0+cHBndHQgJiYgcGFyYW1zLT5jdHgtPnBwZ3R0LT5wZF9kaXJ0eV9yaW5ncyAmICgxPDxyaW5n LT5pZCksCj4+ICsJICAgICAiJXMgZGlkbid0IGNsZWFyIHJlbG9hZFxuIiwgcmluZy0+bmFtZSk7 Cj4+ICsKPj4gICAJaWYgKHJpbmcgPT0gJmRldl9wcml2LT5yaW5nW1JDU10gJiYKPj4gICAJICAg IGluc3RwX21vZGUgIT0gZGV2X3ByaXYtPnJlbGF0aXZlX2NvbnN0YW50c19tb2RlKSB7Cj4+ICAg CQlyZXQgPSBpbnRlbF9yaW5nX2JlZ2luKHBhcmFtcy0+cmVxdWVzdCwgNCk7Cj4+ICAgCQlpZiAo cmV0KQo+PiAtCQkJcmV0dXJuIHJldDsKPj4gKwkJCWdvdG8gZXJyb3I7Cj4+ICAgCj4+ICAgCQlp bnRlbF9yaW5nX2VtaXQocmluZywgTUlfTk9PUCk7Cj4+ICAgCQlpbnRlbF9yaW5nX2VtaXQocmlu ZywgTUlfTE9BRF9SRUdJU1RFUl9JTU0oMSkpOwo+PiBAQCAtMTI1MSw3ICsxMjYzLDcgQEAgaTkx NV9nZW1fcmluZ2J1ZmZlcl9zdWJtaXNzaW9uKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1z ICpwYXJhbXMsCj4+ICAgCWlmIChhcmdzLT5mbGFncyAmIEk5MTVfRVhFQ19HRU43X1NPTF9SRVNF VCkgewo+PiAgIAkJcmV0ID0gaTkxNV9yZXNldF9nZW43X3NvbF9vZmZzZXRzKGRldiwgcGFyYW1z LT5yZXF1ZXN0KTsKPj4gICAJCWlmIChyZXQpCj4+IC0JCQlyZXR1cm4gcmV0Owo+PiArCQkJZ290 byBlcnJvcjsKPj4gICAJfQo+PiAgIAo+PiAgIAlleGVjX2xlbiAgID0gYXJncy0+YmF0Y2hfbGVu Owo+PiBAQCAtMTI2MiwxNCArMTI3NCwyMCBAQCBpOTE1X2dlbV9yaW5nYnVmZmVyX3N1Ym1pc3Np b24oc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcywKPj4gICAJCQkJCWV4ZWNf c3RhcnQsIGV4ZWNfbGVuLAo+PiAgIAkJCQkJcGFyYW1zLT5kaXNwYXRjaF9mbGFncyk7Cj4+ICAg CWlmIChyZXQpCj4+IC0JCXJldHVybiByZXQ7Cj4+ICsJCWdvdG8gZXJyb3I7Cj4+ICAgCj4+ICAg CXRyYWNlX2k5MTVfZ2VtX3JpbmdfZGlzcGF0Y2gocGFyYW1zLT5yZXF1ZXN0LCBwYXJhbXMtPmRp c3BhdGNoX2ZsYWdzKTsKPj4gICAKPj4gLQlpOTE1X2dlbV9leGVjYnVmZmVyX21vdmVfdG9fYWN0 aXZlKHZtYXMsIHBhcmFtcy0+cmVxdWVzdCk7Cj4+ICAgCWk5MTVfZ2VtX2V4ZWNidWZmZXJfcmV0 aXJlX2NvbW1hbmRzKHBhcmFtcyk7Cj4+ICAgCj4+IC0JcmV0dXJuIDA7Cj4+ICtlcnJvcjoKPj4g KwkvKgo+PiArCSAqIGludGVsX2dwdV9idXN5IHNob3VsZCBhbHNvIGdldCBhIHJlZiwgc28gaXQg d2lsbCBmcmVlIHdoZW4gdGhlIGRldmljZQo+PiArCSAqIGlzIHJlYWxseSBpZGxlLgo+PiArCSAq Lwo+PiArCWludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPj4gKwo+PiArCXJldHVybiBy ZXQ7Cj4+ICAgfQo+PiAgIAo+PiAgIC8qKgo+PiBAQCAtMTQyNCw4ICsxNDQyLDYgQEAgaTkxNV9n ZW1fZG9fZXhlY2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+PiAg IAkJZGlzcGF0Y2hfZmxhZ3MgfD0gSTkxNV9ESVNQQVRDSF9SUzsKPj4gICAJfQo+PiAgIAo+PiAt CWludGVsX3J1bnRpbWVfcG1fZ2V0KGRldl9wcml2KTsKPj4gLQo+PiAgIAlyZXQgPSBpOTE1X211 dGV4X2xvY2tfaW50ZXJydXB0aWJsZShkZXYpOwo+PiAgIAlpZiAocmV0KQo+PiAgIAkJZ290byBw cmVfbXV0ZXhfZXJyOwo+PiBAQCAtMTU5OSw5ICsxNjE1LDYgQEAgZXJyOgo+PiAgIAltdXRleF91 bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPj4gICAKPj4gICBwcmVfbXV0ZXhfZXJyOgo+PiAt CS8qIGludGVsX2dwdV9idXN5IHNob3VsZCBhbHNvIGdldCBhIHJlZiwgc28gaXQgd2lsbCBmcmVl IHdoZW4gdGhlIGRldmljZQo+PiAtCSAqIGlzIHJlYWxseSBpZGxlLiAqLwo+PiAtCWludGVsX3J1 bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPj4gICAJcmV0dXJuIHJldDsKPj4gICB9Cj4+ICAgCj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+IGluZGV4IGU1MTA3MzAuLjRiZjBlZTYgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+IEBAIC02NDcsMTAgKzY0Nyw3IEBAIHN0YXRp YyBpbnQgZXhlY2xpc3RzX21vdmVfdG9fZ3B1KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAq cmVxLAo+PiAgIAlpZiAoZmx1c2hfZG9tYWlucyAmIEk5MTVfR0VNX0RPTUFJTl9HVFQpCj4+ICAg CQl3bWIoKTsKPj4gICAKPj4gLQkvKiBVbmNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZSBncHUgY2Fj aGVzIGFuZCBlbnN1cmUgdGhhdCB3ZSBkbyBmbHVzaAo+PiAtCSAqIGFueSByZXNpZHVhbCB3cml0 ZXMgZnJvbSB0aGUgcHJldmlvdXMgYmF0Y2guCj4+IC0JICovCj4+IC0JcmV0dXJuIGxvZ2ljYWxf cmluZ19pbnZhbGlkYXRlX2FsbF9jYWNoZXMocmVxKTsKPj4gKwlyZXR1cm4gMDsKPj4gICB9Cj4+ ICAgCj4+ICAgaW50IGludGVsX2xvZ2ljYWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4+IEBAIC05MTMsNiArOTEwLDE4IEBA IGludCBpbnRlbF9leGVjbGlzdHNfc3VibWlzc2lvbihzdHJ1Y3QgaTkxNV9leGVjYnVmZmVyX3Bh cmFtcyAqcGFyYW1zLAo+PiAgIAlpZiAocmV0KQo+PiAgIAkJcmV0dXJuIHJldDsKPj4gICAKPj4g KwlpOTE1X2dlbV9leGVjYnVmZmVyX21vdmVfdG9fYWN0aXZlKHZtYXMsIHBhcmFtcy0+cmVxdWVz dCk7Cj4+ICsKPj4gKwkvKiBUbyBiZSBzcGxpdCBpbnRvIHR3byBmdW5jdGlvbnMgaGVyZS4uLiAq Lwo+PiArCj4+ICsJLyoKPj4gKwkgKiBVbmNvbmRpdGlvbmFsbHkgaW52YWxpZGF0ZSBncHUgY2Fj aGVzIGFuZCBlbnN1cmUgdGhhdCB3ZSBkbyBmbHVzaAo+PiArCSAqIGFueSByZXNpZHVhbCB3cml0 ZXMgZnJvbSB0aGUgcHJldmlvdXMgYmF0Y2guCj4+ICsJICovCj4+ICsJcmV0ID0gbG9naWNhbF9y aW5nX2ludmFsaWRhdGVfYWxsX2NhY2hlcyhwYXJhbXMtPnJlcXVlc3QpOwo+PiArCWlmIChyZXQp Cj4+ICsJCXJldHVybiByZXQ7Cj4+ICsKPj4gICAJaWYgKHJpbmcgPT0gJmRldl9wcml2LT5yaW5n W1JDU10gJiYKPj4gICAJICAgIGluc3RwX21vZGUgIT0gZGV2X3ByaXYtPnJlbGF0aXZlX2NvbnN0 YW50c19tb2RlKSB7Cj4+ICAgCQlyZXQgPSBpbnRlbF9sb2dpY2FsX3JpbmdfYmVnaW4ocGFyYW1z LT5yZXF1ZXN0LCA0KTsKPj4gQEAgLTkzNyw3ICs5NDYsNiBAQCBpbnQgaW50ZWxfZXhlY2xpc3Rz X3N1Ym1pc3Npb24oc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcywKPj4gICAK Pj4gICAJdHJhY2VfaTkxNV9nZW1fcmluZ19kaXNwYXRjaChwYXJhbXMtPnJlcXVlc3QsIHBhcmFt cy0+ZGlzcGF0Y2hfZmxhZ3MpOwo+PiAgIAo+PiAtCWk5MTVfZ2VtX2V4ZWNidWZmZXJfbW92ZV90 b19hY3RpdmUodm1hcywgcGFyYW1zLT5yZXF1ZXN0KTsKPj4gICAJaTkxNV9nZW1fZXhlY2J1ZmZl cl9yZXRpcmVfY29tbWFuZHMocGFyYW1zKTsKPj4gICAKPj4gICAJcmV0dXJuIDA7Cj4+Cj4gRG8g d2UgbmVlZCB0byBkbyBhbnl0aGluZyBpZiB0aGUgY2FjaGUgaW52YWxpZGF0aW9uIGZhaWxzIGxp a2UgbW92ZSB0aGUgYnVmZmVycyBiYWNrIG9mZiB0aGUgYWN0aXZlIGxpc3Q/ICBUaGUgb3JkZXIg Y2hhbmdlZCBoZXJlLCBzbyBJJ20gd29uZGVyaW5nLgoKSSBkb24ndCBiZWxpZXZlIHNvLiBUaGUg b2JqZWN0cyBhcmUgYWxsIHRyYWNrZWQgYnkgcmVxdWVzdC4gVGhlIHJlcXVlc3QgCml0c2VsZiBp cyBjYW5jZWxsZWQgcmF0aGVyIHRoYW4gYWRkZWQgdG8gdGhlIHJlcXVlc3QgbGlzdC4gU28gdGhl IG5leHQgCnJ1biBvZiBpOTE1X2dlbV9yZXRpcmVfcmVxdWVzdHNfcmluZygpIHdpbGwgZG8gYWxs IHRoZSBuZWNlc3NhcnkgY2xlYW4gCnVwLiBQb3RlbnRpYWxseSB3ZSBjb3VsZCBkbyBzb21ldGhp bmcgZXhwbGljaXQgaGVyZSB0byBzcGVlZCB0aGUgcHJvY2VzcyAKdXAuIEhvd2V2ZXIsIHRoaXMg aXMgb25seSBhbiBpbnRlcm1lZGlhdGUgc3RlcCBhbmQgdGhlcmUgaXMgbm8gbmljZSBhbmQgCnNp bXBsZSBtb3ZlX3RvX2luYWN0aXZlIGZ1bmN0aW9uIHRvIGNhbGwuIE9uY2UgdGhlIHNjaGVkdWxl ciBhcnJpdmVzLCBhIApmYWlsZWQgYmFja2VuZCBzdWJtaXNzaW9uIHdvdWxkIGJlIHJldHJpZWQg YnkgdGhlIHNjaGVkdWxlci4gU28gb2JqZWN0cyAKbXVzdCBub3QgYmUgY2xlYW5lZCB1cCBhcyB0 aGF0IHdvdWxkIGJyZWFrIHRoZSByZS1zdWJtaXNzaW9uLgoKPiBJZiB0aGF0J3Mgbm90IGEgcHJv YmxlbSwgdGhlbjoKPiBSZXZpZXdlZC1ieTogSmVzc2UgQmFybmVzIDxqYmFybmVzQHZpcnR1b3Vz Z2Vlay5vcmc+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK