From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 1/7] device: prevent a NULL pointer dereference in __intel_peek_fd Date: Mon, 15 Feb 2016 14:08:24 +0000 Message-ID: <56C1DBD8.8060201@intel.com> References: <1455294689-29249-1-git-send-email-martin.peres@linux.intel.com> <1455294689-29249-2-git-send-email-martin.peres@linux.intel.com> <56C1C364.8050602@intel.com> <20160215134336.GD2330@boom> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C3266E10D for ; Mon, 15 Feb 2016 14:08:26 +0000 (UTC) In-Reply-To: <20160215134336.GD2330@boom> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: david.weinehall@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTUvMDIvMTYgMTM6NDMsIERhdmlkIFdlaW5laGFsbCB3cm90ZToKPiBPbiBNb24sIEZlYiAx NSwgMjAxNiBhdCAxMjoyNDowNFBNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gT24gMTIv MDIvMTYgMTY6MzEsIE1hcnRpbiBQZXJlcyB3cm90ZToKPj4+IFRoaXMgaXMgbm90IGEgYmlnIGlz c3VlIHRvIHJldHVybiAtMSBzaW5jZSB0aGUgb25seSBjb2RlcGF0aCB0aGF0IHVzZXMKPj4+IGl0 IGlzIGZvciBkaXNwbGF5IHB1cnBvc2VzLgo+Pj4KPj4+IENhdWdodCBieSBLbG9ja3dvcmsuCj4+ Pgo+Pj4gU2lnbmVkLW9mZi1ieTogTWFydGluIFBlcmVzIDxtYXJ0aW4ucGVyZXNAbGludXguaW50 ZWwuY29tPgo+Pj4gLS0tCj4+PiAgIHNyYy9pbnRlbF9kZXZpY2UuYyB8IDUgKysrKy0KPj4+ICAg MSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pj4KPj4+IGRp ZmYgLS1naXQgYS9zcmMvaW50ZWxfZGV2aWNlLmMgYi9zcmMvaW50ZWxfZGV2aWNlLmMKPj4+IGlu ZGV4IDU0YzE0NDMuLjM1ZTY1MmEgMTAwNjQ0Cj4+PiAtLS0gYS9zcmMvaW50ZWxfZGV2aWNlLmMK Pj4+ICsrKyBiL3NyYy9pbnRlbF9kZXZpY2UuYwo+Pj4gQEAgLTY1MCw3ICs2NTAsMTAgQEAgaW50 IF9faW50ZWxfcGVla19mZChTY3JuSW5mb1B0ciBzY3JuKQo+Pj4gICAJZGV2ID0gaW50ZWxfZGV2 aWNlKHNjcm4pOwo+Pj4gICAJYXNzZXJ0KGRldiAmJiBkZXYtPmZkICE9IC0xKTsKPj4KPj4gRG9l c24ndCBLbG9jd29yayByZWNvZ25pc2UgdGhlIGFzc2VydCgpIGFib3ZlPwo+PiBJIHRob3VnaHQg dGhhdCB3b3VsZCB0ZWxsIGl0IHRoYXQgZGV2IGNhbid0IGJlIE5VTEwuCj4KPiBNeSBndWVzcyBp cyB0aGF0IGtsb2Nrd29yayByZWNvZ25pc2VzIHRoYXQgYXNzZXJ0KCkgY2FuIGJlIGEgbm8tb3AK PiBpZiBOREVCVUcgaXMgZGVmaW5lZCBhbmQgaW4gc3VjaCBjYXNlIHdvbid0IGdlbmVyYXRlIGNv ZGUuCj4gSW4gc3VjaCBhIGNhc2UgbmVpdGhlciBvZiB0aG9zZSB0d28gY2hlY2tzIGFyZSBwZXJm b3JtZWQuCj4KPiBLaW5kIHJlZ2FyZHMsIERhdmlkCgpLbG9jd29yayBpcyBhIHN0YXRpYyBhbmFs eXNpcyB0b29sLCBpdCBkb2Vzbid0IGdlbmVyYXRlIGNvZGUgYXQgYWxsLgpJdCdzIHN1cHBvc2Vk IHRvIHJlY29nbmlzZSBhc3NlcnQoKSBhbmQgc2ltaWxhciBtYWNyb3MgYXMgY29uc3RyYWludHMg b24gCndoYXQgdmFsdWVzIHBhcnRpY3VsYXIgZXhwcmVzc2lvbnMgbWF5IGhhdmU7IGluIHBhcnRp Y3VsYXIsIGl0IGtub3dzIAp0aGF0IGlmIGEgY29kZSBwYXRoIGVuZHMgd2l0aCBhIGNhbGwgdG8g YWJvcnQoKSwgdGhhdCBwYXRoICpzaG91bGQqIApuZXZlciBiZSB0YWtlbiBhbmQgaXQgd2lsbCBh c3N1bWUgKGZvciBzdGF0aWMgYW5hbHlzaXMgcHVycG9zZXMpIHRoYXQgaXQgCip3aWxsKiBub3Qg YmUgdGFrZW4uIFRodXMgYW55IGNvbWJpbmF0aW9uIG9mIHZhbHVlcyB0aGF0IGxlYWRzIHRvIGFu IAphYm9ydCgpIGlzIGNvbnNpZGVyZWQgImltcG9zc2libGUiIGFuZCBuZWVkIG5vdCBiZSBmdXJ0 aGVyIGNoZWNrZWQuIFRoZW4gCmFzc2VydCgpIGlzIHR5cGljYWxseSBkZWZpbmVkIGFzOgoKICAg ICAjZGVmaW5lIGFzc2VydCh4KSBkbyB7IGlmKCEoeCkpIGFib3J0KCk7IH0gd2hpbGUgKDApCgph bmQgdGhlbgoKICAgICBpbnQgZm9vKGNoYXIgKnMpCiAgICAgewogICAgICAgICBhc3NlcnQocyk7 CiAgICAgICAgIHJldHVybiAqczsKICAgICB9CgpzaG91bGQgbm90IGNhdXNlIEtsb2N3b3JrIHRv IGNvbXBsYWluLCB3aGVyZWFzIHdpdGhvdXQgdGhlIGFzc2VydCgpIGl0IApzaG91bGQgc2F5IHRo YXQgJ3MnIG1pZ2h0IGJlIE5VTEwgd2hlbiBkZXJlZmVyZW5jZWQuIElmIGl0J3MgZ2V0dGluZyAK ZmFsc2UgcG9zaXRpdmVzIGl0IG1heSBiZSB0aGF0IEtsb2N3b3JrIGhhc24ndCBiZWVuIHRvbGQg dGhlIHByb3BlciAKKGNvbmRpdGlvbmFsKSBkZWZpbml0aW9uIGZvciBhc3NlcnQoKT8KCi5EYXZl LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==