From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Peres Subject: Re: [PATCH 1/7] device: prevent a NULL pointer dereference in __intel_peek_fd Date: Tue, 16 Feb 2016 13:09:13 +0200 Message-ID: <56C30359.3060601@linux.intel.com> References: <1455294689-29249-1-git-send-email-martin.peres@linux.intel.com> <1455294689-29249-2-git-send-email-martin.peres@linux.intel.com> <56C1C364.8050602@intel.com> <56C1D55A.7040707@linux.intel.com> <56C1D70B.3040204@intel.com> <56C1F512.6000606@linux.intel.com> <56C2E3AA.5080203@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id AB59A6E285 for ; Tue, 16 Feb 2016 11:09:17 +0000 (UTC) In-Reply-To: <56C2E3AA.5080203@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTYvMDIvMTYgMTA6NTQsIERhdmUgR29yZG9uIHdyb3RlOgo+IE9uIDE1LzAyLzE2IDE1OjU2 LCBNYXJ0aW4gUGVyZXMgd3JvdGU6Cj4+IE9uIDE1LzAyLzE2IDE1OjQ3LCBEYXZlIEdvcmRvbiB3 cm90ZToKPj4+IE9uIDE1LzAyLzE2IDEzOjQwLCBNYXJ0aW4gUGVyZXMgd3JvdGU6Cj4+Pj4gT24g MTUvMDIvMTYgMTQ6MjQsIERhdmUgR29yZG9uIHdyb3RlOgo+Pj4+PiBPbiAxMi8wMi8xNiAxNjoz MSwgTWFydGluIFBlcmVzIHdyb3RlOgo+Pj4+Pj4gVGhpcyBpcyBub3QgYSBiaWcgaXNzdWUgdG8g cmV0dXJuIC0xIHNpbmNlIHRoZSBvbmx5IGNvZGVwYXRoIHRoYXQKPj4+Pj4+IHVzZXMKPj4+Pj4+ IGl0IGlzIGZvciBkaXNwbGF5IHB1cnBvc2VzLgo+Pj4+Pj4KPj4+Pj4+IENhdWdodCBieSBLbG9j a3dvcmsuCj4+Pj4+Pgo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFydGluIFBlcmVzIDxtYXJ0aW4u cGVyZXNAbGludXguaW50ZWwuY29tPgo+Pj4+Pj4gLS0tCj4+Pj4+PiAgIHNyYy9pbnRlbF9kZXZp Y2UuYyB8IDUgKysrKy0KPj4+Pj4+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQo+Pj4+Pj4KPj4+Pj4+IGRpZmYgLS1naXQgYS9zcmMvaW50ZWxfZGV2aWNl LmMgYi9zcmMvaW50ZWxfZGV2aWNlLmMKPj4+Pj4+IGluZGV4IDU0YzE0NDMuLjM1ZTY1MmEgMTAw NjQ0Cj4+Pj4+PiAtLS0gYS9zcmMvaW50ZWxfZGV2aWNlLmMKPj4+Pj4+ICsrKyBiL3NyYy9pbnRl bF9kZXZpY2UuYwo+Pj4+Pj4gQEAgLTY1MCw3ICs2NTAsMTAgQEAgaW50IF9faW50ZWxfcGVla19m ZChTY3JuSW5mb1B0ciBzY3JuKQo+Pj4+Pj4gICAgICAgZGV2ID0gaW50ZWxfZGV2aWNlKHNjcm4p Owo+Pj4+Pj4gICAgICAgYXNzZXJ0KGRldiAmJiBkZXYtPmZkICE9IC0xKTsKPj4+Pj4KPj4+Pj4g RG9lc24ndCBLbG9jd29yayByZWNvZ25pc2UgdGhlIGFzc2VydCgpIGFib3ZlPwo+Pj4+PiBJIHRo b3VnaHQgdGhhdCB3b3VsZCB0ZWxsIGl0IHRoYXQgZGV2IGNhbid0IGJlIE5VTEwuCj4+Pj4KPj4+ PiBJdCBkb2VzIG5vdCwgSSBoYWQgdG8gY2xvc2UgbWFueSBmYWxzZSBwb3NpdGl2ZXMgcmVsYXRl ZCB0byB0aGlzLi4uCj4+Pgo+Pj4gSG1tbSAuLiBlbHNld2hlcmUgKGUuZy4gWzQvN10pIHlvdSBo YXZlIC9hZGRlZC8gYW4gYXNzZXJ0LCB3aGljaCBJCj4+PiB0aG91Z2h0IG11c3QgYmUgc28gdGhh dCBLbG9jd29yayBzdG9wcyBjb21wbGFpbmluZyB0aGF0IHNvbWV0aGluZyBtaWdodAo+Pj4gYmUg TlVMTCAuLi4gbWF5YmUgaXQgY2FuJ3QgaGFuZGxlIHRoZSBjb21wb3NpdGUgYXNzZXJ0aW9uPyBE b2VzIGl0Cj4+PiBzaWxlbmNlIHRoZSBjb21wbGFpbnQgaWYgeW91IGNoYW5nZToKPj4+ICAgICAg YXNzZXJ0KGRldiAmJiBkZXYtPmZkICE9IC0xKTsKPj4+IGludG86Cj4+PiAgICAgIGFzc2VydChk ZXYpOwo+Pj4gICAgICBhc3NlcnQoZGV2LT5mZCAhPSAtMSk7Cj4+PiA/Cj4+Cj4+IFN1cmUsIEkg YWRkZWQgYW4gYXNzZXJ0LCBidXQgbm90IHRvIHNpbGVuY2UgcGF0Y2h3b3JrLCBqdXN0IHRvIG1h a2Ugc3VyZQo+PiB3ZSBoYXZlIG5vIHByb2JsZW0uIEkgY2Fubm90IHJ1biBrbG9rd29yayBteXNl bGYgYW5kIG15IGdvYWwgd2FzIG5vdCB0bwo+PiBzaWxlbmNlIGJ1dCBpbnN0ZWFkIHRvIGNoZWNr IHRoZSByZXBvcnRlZCBpc3N1ZXMuCj4+Cj4+IERhdmlkIGlzIHJpZ2h0LCBJIHRoaW5rIEtsb2t3 b3JrIG9ubHkgY2FyZXMgYWJvdXQgcnVudGltZSBjaGVja3MgYW5kCj4+IHdhbnRzIHRvIG1ha2Ug c3VyZSB0aGF0IHdlIG5ldmVyIGRlLXJlZmVyZW5jZSBhIE5VTEwgcG9pbnRlci4KPj4KPj4gTWFy dGluCj4KPiBLbG9jd29yayBpcyB0cnlpbmcgKGJ5IHN0YXRpYyBhbmFseXNpcykgdG8gZmluZCBh bGwgcmVhY2hhYmxlIGNvZGUsIHdpdGgKPiBhbGwgcG9zc2libGUgcGFyYW1ldGVyIHZhbHVlcyBh dCBlYWNoIHBvaW50LiBJdCdzIGNvbmZpZ3VyZWQgd2l0aAo+IHZhcmlvdXMgY2hlY2tlcnMgdGhh dCBleGFtaW5lIGVhY2ggZXhwcmVzc2lvbiByZWFjaGVkIGZvciB0aGluZ3Mgc3VjaCBhcwo+IGRl cmVmZXJlbmNpbmcgYSBwb3NzaWJseS1OVUxMIHBvaW50ZXIsIG9yIGluZGV4aW5nIGJleW9uZCB0 aGUgYm91bmRzIG9mCj4gYW4gYXJyYXksIG9yIGludGVnZXIgb3ZlcmZsb3csIG9yIG1hbnkgb3Ro ZXIgdGhpbmdzIC4uLgo+Cj4gVGhlIHN0YW5kYXJkIGRlZmluaXRpb24gb2YgYXNzZXJ0KCkgaXMg c29tZXRoaW5nIGxpa2U6Cj4KPiAgICAgICNkZWZpbmUgYXNzZXJ0KHgpIGRvIHsgaWYoISh4KSkg YWJvcnQoKTsgfSB3aGlsZSAoMCkKPgo+IGFuZCBLbG9jd29yayBrbm93cyB0aGF0IGFib3J0KCkg ZG9lc24ndCByZXR1cm4sIHNvIGluIHRoZSBibG9jawo+Cj4gICAgICBkZXYgPSBpbnRlbF9kZXZp Y2Uoc2Nybik7Cj4gICAgICBhc3NlcnQoZGV2KTsKPiAgICAgIHJldHVybiBkZXYtPmZkOwo+Cj4g aXQgY2FuIGRlZHVjZSB0aGF0IHRoZSAncmV0dXJuJyBpcyByZWFjaGVkIG9ubHkgaWYgdGhlIGFi b3J0KCkgd2FzIG5vdCwKPiBoZW5jZSBvbmx5IGlmICdkZXYnIGlzIG5vbi1OVUxMLiBUaGVyZWZv cmUsIHRoaXMgZG9lc24ndCBwcm9kdWNlIGEKPiBjb21wbGFpbnQgYWJvdXQgYSBwb3NzaWJseS1O VUxMIHBvaW50ZXIsIGJlY2F1c2UgS2xvY3dvcmsga25vd3MgaXQgaXNuJ3QKPiBiZWNhdXNlIG9m IHRoZSBhc3NlcnQoKS4KPgo+IE9mIGNvdXJzZSB0aGVyZSBhcmUgcG90ZW50aWFsbHkgbXVsdGlw bGUgZGVmaW5pdGlvbnMgb2YgYXNzZXJ0KCksCj4gdHlwaWNhbGx5IGluY2x1ZGluZyBhIG51bGwg b25lLCBmb3IgcHJvZHVjdGlvbiBjb2RlLCBhbmQgYSBkZWJ1ZyB2ZXJzaW9uCj4gdGhhdCBnaXZl cyBtb3JlIGRldGFpbC4gU28gdGhlIHVzdWFsIHRoaW5nIGlzIHRvIGVuc3VyZSB0aGF0IHRoZXJl J3MgYQo+IEtsb2N3b3JrLXNwZWNpZmljIHZlcnNpb24gdGhhdCBhbGxvd3MgS1cgdG8gZG8gdGhl IGFuYWx5c2lzIGFib3ZlLCBldmVuCj4gaWYgdGhhdCB2ZXJzaW9uIGlzbid0IHNvbWV0aGluZyB5 b3Ugd291bGQgZXZlciBydW46Cj4KPiAjaWYgICAgZGVmaW5lZChfX0tMT0NXT1JLX18pCj4gI2Rl ZmluZSBhc3NlcnQoeCkgZG8geyBpZighKHgpKSBhYm9ydCgpOyB9IHdoaWxlICgwKQo+ICNlbGlm ICBkZWZpbmVkKE5PX0RFQlVHKQo+ICNkZWZpbmUgYXNzZXJ0KHgpIGRvIHsgLyogbm90aGluZyAq LyA7IH0gd2hpbGUgKDApCj4gI2VsaWYgIGRlZmluZWQoRVhUUkFfREVCVUcpCj4gI2RlZmluZSBh c3NlcnQoeCkgZG8geyBteV9hc3NlcnQoeCwgI3gsIF9fTElORV9fLCBfX0ZJTEVfXyk7IH0gd2hp bGUgKDApCj4gI2Vsc2UKPiAvLyAuLi4gZXRjIC4uLgo+ICNlbmRpZgoKVGhhdCBzb3VuZHMgbGlr ZSBhIGdvb2QgaWRlYSwgeWVzLgoKSGVyZSBpcyB0aGUgY3VycmVudCBkZWZpbml0aW9uOiAKaHR0 cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy94b3JnL2RyaXZlci94Zjg2LXZpZGVvLWludGVsL3Ry ZWUvc3JjL3NuYS94YXNzZXJ0LmgKCj4KPiBJZiB3ZSBkb24ndCBoYXZlIHNvbWV0aGluZyBsaWtl IHRoaXMsIEtsb2N3b3JrIG1heSBub3QgYmUgYWJsZSB0byBtYWtlCj4gZWZmZWN0aXZlIGRlZHVj dGlvbnMgYWJvdXQgdGhlIHBvc3NpYmxlIHZhbHVlcyBvZiB2YXJpYWJsZXMgYXQgc3BlY2lmaWMK PiBwb2ludHMsIHNvIGl0IHdvdWxkIGJlIHdvcnRoIGNoZWNraW5nIHRoYXQgd2UncmUgdXNpbmcg bWFjcm9zIHRoYXQgaXQKPiB1bmRlcnN0YW5kcy4KCldlIGRvbid0LCBiZWNhdXNlIHRoZXJlIGlz IGEgdGVzdCBvbiBOREVCVUcgd2hpY2ggS2xva3dvcmsgY2Fubm90IG1ha2UgCmFzc3VtcHRpb25z IG9uLCBhcyBEYXZpZCBzYWlkLgoKSSB3aWxsIGhvbGQgb24gdG8gdGhpcyBpZGVhIGEgbGl0dGxl IGFzIHRoZXJlIGFyZSB0YWxrcyBpbnRlcm5hbGx5IG9uIHRvIAp3aGljaCBzdGF0aWMgYW5hbHlz aXMgdG9vbCBuZWVkcyB0byBiZSB1c2VkLgoKVGhhbmtzIGZvciB5b3VyIGZlZWRiYWNrLApNYXJ0 aW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==