From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH v5 15/35] drm/i915: Added tracking/locking of batch buffer objects Date: Fri, 19 Feb 2016 11:42:15 -0800 Message-ID: <56C77017.6080905@virtuousgeek.org> References: <1455805644-6450-1-git-send-email-John.C.Harrison@Intel.com> <1455805644-6450-16-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gproxy6-pub.mail.unifiedlayer.com (gproxy6-pub.mail.unifiedlayer.com [67.222.39.168]) by gabe.freedesktop.org (Postfix) with SMTP id D81F86E051 for ; Fri, 19 Feb 2016 19:42:20 +0000 (UTC) In-Reply-To: <1455805644-6450-16-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gMDIvMTgvMjAxNiAwNjoyNyBBTSwgSm9obi5DLkhhcnJpc29uQEludGVsLmNvbSB3cm90ZToK PiBGcm9tOiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25ASW50ZWwuY29tPgo+IAo+IFRo ZSBzY2hlZHVsZXIgbmVlZHMgdG8gdHJhY2sgaW50ZXJkZXBlbmRlbmNpZXMgYmV0d2VlbiBiYXRj aCBidWZmZXJzLgo+IFRoZXNlIGFyZSBjYWxjdWxhdGVkIGJ5IGFuYWx5c2luZyB0aGUgb2JqZWN0 IGxpc3RzIG9mIHRoZSBidWZmZXJzIGFuZAo+IGxvb2tpbmcgZm9yIGNvbW1vbmFsaXR5LiBUaGUg c2NoZWR1bGVyIGFsc28gbmVlZHMgdG8ga2VlcCB0aG9zZQo+IGJ1ZmZlcnMgbG9ja2VkIGxvbmcg YWZ0ZXIgdGhlIGluaXRpYWwgSU9DVEwgY2FsbCBoYXMgcmV0dXJuZWQgdG8gdXNlcgo+IGxhbmQu Cj4gCj4gdjM6IFVwZGF0ZWQgdG8gc3VwcG9ydCByZWFkLXJlYWQgb3B0aW1pc2F0aW9uLgo+IAo+ IHY1OiBVcGRhdGVkIGR1ZSB0byBjaGFuZ2VzIHRvIGVhcmxpZXIgcGF0Y2hlcyBpbiBzZXJpZXMg Zm9yIHNwbGl0dGluZwo+IGJ5cGFzcyBtb2RlIGludG8gYSBzZXBhcmF0ZSBmdW5jdGlvbiBhbmQg Y29uc29saWRpbmcgdGhlIGNsZWFuIHVwIGNvZGUuCj4gCj4gRm9yOiBWSVotMTU4Nwo+IFNpZ25l ZC1vZmYtYnk6IEpvaG4gSGFycmlzb24gPEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8IDQ4ICsrKysr KysrKysrKysrKysrKysrKysrKysrKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Nj aGVkdWxlci5jICAgICAgfCAxNSArKysrKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNjEgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW1fZXhlY2J1ZmZlci5jCj4gaW5kZXggMTFiZWE4ZC4uZjQ1ZjRkYyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiBAQCAtMTQyOCw3ICsxNDI4 LDcgQEAgaTkxNV9nZW1fZG9fZXhlY2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lk ICpkYXRhLAo+ICAJc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcyA9ICZxZS5w YXJhbXM7Cj4gIAljb25zdCB1MzIgY3R4X2lkID0gaTkxNV9leGVjYnVmZmVyMl9nZXRfY29udGV4 dF9pZCgqYXJncyk7Cj4gIAl1MzIgZGlzcGF0Y2hfZmxhZ3M7Cj4gLQlpbnQgcmV0Owo+ICsJaW50 IHJldCwgaTsKPiAgCWJvb2wgbmVlZF9yZWxvY3M7Cj4gIAo+ICAJaWYgKCFpOTE1X2dlbV9jaGVj a19leGVjYnVmZmVyKGFyZ3MpKQo+IEBAIC0xNTQzLDYgKzE1NDMsMTQgQEAgaTkxNV9nZW1fZG9f ZXhlY2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJCWdvdG8g cHJlX211dGV4X2VycjsKPiAgCX0KPiAgCj4gKwlxZS5zYXZlZF9vYmplY3RzID0ga3phbGxvYygK PiArCQkJc2l6ZW9mKCpxZS5zYXZlZF9vYmplY3RzKSAqIGFyZ3MtPmJ1ZmZlcl9jb3VudCwKPiAr CQkJR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIXFlLnNhdmVkX29iamVjdHMpIHsKPiArCQlyZXQgPSAt RU5PTUVNOwo+ICsJCWdvdG8gZXJyOwo+ICsJfQo+ICsKPiAgCS8qIExvb2sgdXAgb2JqZWN0IGhh bmRsZXMgKi8KPiAgCXJldCA9IGViX2xvb2t1cF92bWFzKGViLCBleGVjLCBhcmdzLCB2bSwgZmls ZSk7Cj4gIAlpZiAocmV0KQo+IEBAIC0xNjYzLDcgKzE2NzEsMzAgQEAgaTkxNV9nZW1fZG9fZXhl Y2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJcGFyYW1zLT5h cmdzX0RSMSAgICAgICAgICAgICAgICA9IGFyZ3MtPkRSMTsKPiAgCXBhcmFtcy0+YXJnc19EUjQg ICAgICAgICAgICAgICAgPSBhcmdzLT5EUjQ7Cj4gIAlwYXJhbXMtPmJhdGNoX29iaiAgICAgICAg ICAgICAgID0gYmF0Y2hfb2JqOwo+IC0JcGFyYW1zLT5jdHggICAgICAgICAgICAgICAgICAgICA9 IGN0eDsKPiArCj4gKwkvKgo+ICsJICogU2F2ZSBhd2F5IHRoZSBsaXN0IG9mIG9iamVjdHMgdXNl ZCBieSB0aGlzIGJhdGNoIGJ1ZmZlciBmb3IgdGhlCj4gKwkgKiBwdXJwb3NlIG9mIHRyYWNraW5n IGludGVyLWJ1ZmZlciBkZXBlbmRlbmNpZXMuCj4gKwkgKi8KPiArCWZvciAoaSA9IDA7IGkgPCBh cmdzLT5idWZmZXJfY291bnQ7IGkrKykgewo+ICsJCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0 ICpvYmo7Cj4gKwo+ICsJCS8qCj4gKwkJICogTkI6ICdkcm1fZ2VtX29iamVjdF9sb29rdXAoKScg aW5jcmVtZW50cyB0aGUgb2JqZWN0J3MKPiArCQkgKiByZWZlcmVuY2UgY291bnQgYW5kIHNvIG11 c3QgYmUgbWF0Y2hlZCBieSBhCj4gKwkJICogJ2RybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlJyBj YWxsLgo+ICsJCSAqLwo+ICsJCW9iaiA9IHRvX2ludGVsX2JvKGRybV9nZW1fb2JqZWN0X2xvb2t1 cChkZXYsIGZpbGUsCj4gKwkJCQkJCQkgIGV4ZWNbaV0uaGFuZGxlKSk7Cj4gKwkJcWUuc2F2ZWRf b2JqZWN0c1tpXS5vYmogICAgICAgPSBvYmo7Cj4gKwkJcWUuc2F2ZWRfb2JqZWN0c1tpXS5yZWFk X29ubHkgPSBvYmotPmJhc2UucGVuZGluZ193cml0ZV9kb21haW4gPT0gMDsKPiArCj4gKwl9Cj4g KwlxZS5udW1fb2JqcyA9IGk7Cj4gKwo+ICsJLyogTG9jayBhbmQgc2F2ZSB0aGUgY29udGV4dCBv YmplY3QgYXMgd2VsbC4gKi8KPiArCWk5MTVfZ2VtX2NvbnRleHRfcmVmZXJlbmNlKGN0eCk7Cj4g KwlwYXJhbXMtPmN0eCA9IGN0eDsKPiAgCj4gIAlyZXQgPSBkZXZfcHJpdi0+Z3QuZXhlY2J1Zl9z dWJtaXQocGFyYW1zLCBhcmdzLCAmZWItPnZtYXMpOwo+ICAJaWYgKHJldCkKPiBAQCAtMTY5Niw2 ICsxNzI3LDE5IEBAIGVycjoKPiAgCWk5MTVfZ2VtX2NvbnRleHRfdW5yZWZlcmVuY2UoY3R4KTsK PiAgCWViX2Rlc3Ryb3koZWIpOwo+ICAKPiArCS8qIE5lZWQgdG8gcmVsZWFzZSB0aGUgb2JqZWN0 czogKi8KPiArCWlmIChxZS5zYXZlZF9vYmplY3RzKSB7Cj4gKwkJZm9yIChpID0gMDsgaSA8IHFl Lm51bV9vYmpzOyBpKyspCj4gKwkJCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKAo+ICsJCQkJ CSZxZS5zYXZlZF9vYmplY3RzW2ldLm9iai0+YmFzZSk7Cj4gKwo+ICsJCWtmcmVlKHFlLnNhdmVk X29iamVjdHMpOwo+ICsJfQo+ICsKPiArCS8qIENvbnRleHQgdG9vICovCj4gKwlpZiAocGFyYW1z LT5jdHgpCj4gKwkJaTkxNV9nZW1fY29udGV4dF91bnJlZmVyZW5jZShwYXJhbXMtPmN0eCk7Cj4g Kwo+ICAJLyoKPiAgCSAqIElmIHRoZSByZXF1ZXN0IHdhcyBjcmVhdGVkIGJ1dCBub3Qgc3VjY2Vz c2Z1bGx5IHN1Ym1pdHRlZCB0aGVuIGl0Cj4gIAkgKiBtdXN0IGJlIGZyZWVkIGFnYWluLiBJZiBp dCB3YXMgc3VibWl0dGVkIHRoZW4gaXQgaXMgYmVpbmcgdHJhY2tlZAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3NjaGVkdWxlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9zY2hlZHVsZXIuYwo+IGluZGV4IGEzZmZkMDQuLjYwYTU5ZDMgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXIuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfc2NoZWR1bGVyLmMKPiBAQCAtNzE5LDYgKzcxOSw4IEBAIHZvaWQg aTkxNV9zY2hlZHVsZXJfd2FrZXVwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAqLwo+ICB2 b2lkIGk5MTVfc2NoZWR1bGVyX2NsZWFuX25vZGUoc3RydWN0IGk5MTVfc2NoZWR1bGVyX3F1ZXVl X2VudHJ5ICpub2RlKQo+ICB7Cj4gKwlpbnQgaTsKPiArCj4gIAlpZiAoIUk5MTVfU1FTX0lTX0NP TVBMRVRFKG5vZGUpKSB7Cj4gIAkJV0FSTighbm9kZS0+cGFyYW1zLnJlcXVlc3QtPmNhbmNlbGxl ZCwKPiAgCQkgICAgICJDbGVhbmluZyBhY3RpdmUgbm9kZTogJWQhXG4iLCBub2RlLT5zdGF0dXMp Owo+IEBAIC03MzYsNiArNzM4LDE5IEBAIHZvaWQgaTkxNV9zY2hlZHVsZXJfY2xlYW5fbm9kZShz dHJ1Y3QgaTkxNV9zY2hlZHVsZXJfcXVldWVfZW50cnkgKm5vZGUpCj4gIAkJbm9kZS0+cGFyYW1z LmJhdGNoX29iaiA9IE5VTEw7Cj4gIAl9Cj4gIAo+ICsJLyogUmVsZWFzZSB0aGUgbG9ja2VkIGJ1 ZmZlcnM6ICovCj4gKwlmb3IgKGkgPSAwOyBpIDwgbm9kZS0+bnVtX29ianM7IGkrKykKPiArCQlk cm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmbm9kZS0+c2F2ZWRfb2JqZWN0c1tpXS5vYmotPmJh c2UpOwo+ICsJa2ZyZWUobm9kZS0+c2F2ZWRfb2JqZWN0cyk7Cj4gKwlub2RlLT5zYXZlZF9vYmpl Y3RzID0gTlVMTDsKPiArCW5vZGUtPm51bV9vYmpzID0gMDsKPiArCj4gKwkvKiBDb250ZXh0IHRv bzogKi8KPiArCWlmIChub2RlLT5wYXJhbXMuY3R4KSB7Cj4gKwkJaTkxNV9nZW1fY29udGV4dF91 bnJlZmVyZW5jZShub2RlLT5wYXJhbXMuY3R4KTsKPiArCQlub2RlLT5wYXJhbXMuY3R4ID0gTlVM TDsKPiArCX0KPiArCj4gIAkvKiBBbmQgYW55dGhpbmcgZWxzZSBvd25lZCBieSB0aGUgbm9kZTog Ki8KPiAgCWlmIChub2RlLT5wYXJhbXMuY2xpcHJlY3RzKSB7Cj4gIAkJa2ZyZWUobm9kZS0+cGFy YW1zLmNsaXByZWN0cyk7Cj4gCgpSZXZpZXdlZC1ieTogSmVzc2UgQmFybmVzIDxqYmFybmVzQHZp cnR1b3VzZ2Vlay5vcmc+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=