From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v4 2/3] drm/i915: refactor duplicate object
 vmap functions (reworked)
Date: Tue, 23 Feb 2016 10:31:08 +0000
Message-ID: <56CC34EC.8050300@linux.intel.com>
References: <1456154308-9342-1-git-send-email-david.s.gordon@intel.com>
 <1456154308-9342-3-git-send-email-david.s.gordon@intel.com>
 <56CB320F.5050108@linux.intel.com>
 <20160223100614.GC27386@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 264E26E108
 for <intel-gfx@lists.freedesktop.org>; Tue, 23 Feb 2016 10:31:30 +0000 (UTC)
In-Reply-To: <20160223100614.GC27386@nuc-i3427.alporthouse.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDIzLzAyLzE2IDEwOjA2LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gTW9uLCBGZWIgMjIs
IDIwMTYgYXQgMDQ6MDY6MzlQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IFtD
YyBDaHJpcyBhcyB0aGUgYXV0aG9yIG9mIHRoZSBpZGVhLl0KPj4KPj4gSGksCj4+Cj4+IE9uIDIy
LzAyLzE2IDE1OjE4LCBEYXZlIEdvcmRvbiB3cm90ZToKPj4+IFRoaXMgaXMgZXNzZW50aWFsbHkg
Q2hyaXMgV2lsc29uJ3MgcGF0Y2ggb2YgYSBzaW1pbGFyIG5hbWUsIHJld29ya2VkIG9uCj4+PiB0
b3Agb2YgQWxleCBEYWkncyByZWNlbnQgcGF0Y2g6Cj4+PiAgICBkcm0vaTkxNTogQWRkIGk5MTVf
Z2VtX29iamVjdF92bWFwIHRvIG1hcCBHRU0gb2JqZWN0IHRvIHZpcnR1YWwgc3BhY2UKPj4+IENo
cmlzJyBvcmlnaW5hbCBjb21tZW50YXJ5IHNhaWQ6Cj4+Pgo+Pj4gICAgV2Ugbm93IGhhdmUgdHdv
IGltcGxlbWVudGF0aW9ucyBmb3Igdm1hcHBpbmcgYSB3aG9sZSBvYmplY3QsIG9uZSBmb3IKPj4+
ICAgIGRtYS1idWYgYW5kIG9uZSBmb3IgdGhlIHJpbmdidWZmZXIuIElmIHdlIGNvdXBsZSB0aGUg
dm1hcHBpbmcgaW50bwo+Pj4gICAgdGhlIG9iai0+cGFnZXMgbGlmZXRpbWUsIHRoZW4gd2UgY2Fu
IHJldXNlIGFuIG9iai0+dm1hcHBpbmcgZm9yIGJvdGgKPj4+ICAgIGFuZCBhdCB0aGUgc2FtZSB0
aW1lIGNvdXBsZSBpdCBpbnRvIHRoZSBzaHJpbmtlci4KPj4KPj4gQXMgYSBnZW5lcmFsIGNvbmNl
cHQgbXkgd29ycnkgaXMgdGhhdCBieSBpbXBsZW1lbnRpbmcgdGhpcyBhcHByb2FjaAo+PiB3ZSB0
aWUgdHdvIHVucmVsYXRlZCBjb25jZXB0cyB0b2dldGhlci4KPj4KPj4gU2hyaW5rZXIgaXMgYWJv
dXQgYmFja2luZyBzdG9yYWdlICh1c2VkL2ZyZWUgcGFnZXMgaW4gYSBtYWNoaW5lKSwKPj4gd2hp
bGUgdm1hcCBpcyBhYm91dCBrZXJuZWwgYWRkcmVzcyBzcGFjZS4gQW5kIHRoZW4gb24gMzItYml0
IHdpdGgKPj4gaXRzIGxpbWl0ZWQgdm1hcCBzcGFjZSAoMTI4TWlCLCByaWdodD8pLCBpdCBjYW4g
YmVjb21lIGV4aGF1c3RlZAo+PiBtdWNoIHNvb25lciB0aGF0IHRoZSBzaHJpbmtlciB3b3VsZCBi
ZSB0cmlnZ2VyZWQuIEFuZCB3ZSB3b3VsZCByZWx5Cj4+IG9uIHRoZSBzaHJpbmtlciBydW5uaW5n
IHRvIGZyZWUgdXAgYWRkcmVzcyBzcGFjZSBhcyB3ZWxsIG5vdywgcmlnaHQ/Cj4KPiBZZXMsIHdl
IHVzZSB0aGUgc2hyaW5rZXIgdG8gZnJlZSBhZGRyZXNzIHNwYWNlLgo+Cj4+IFNvIHVubGVzcyBJ
IGFtIG1pc3Npbmcgc29tZXRoaW5nIHRoYXQgZG9lc24ndCBmaXQgd2VsbC4KPgo+IFRoZSBvcHBv
c2l0ZS4gRXZlbiBtb3JlIHJlYXNvbiBmb3IgdGhlIHNocmlua2VyIHRvIGJlIGFibGUgdG8gcmVj
b3Zlcgo+IHZtYXAgc3BhY2Ugb24gMzJiaXQgc3lzdGVtcyAoZm9yIGV4dGVybmFsIHVzZXJzLCBu
b3QganVzdCBvdXJzZWx2ZXMpLgoKSG93PyBJIGRvbid0IHNlZSB0aGF0IGZhaWxlZCB2bWFwcGlu
ZyB3aWxsIHRyaWdnZXIgc2hyaW5raW5nLiBXaGF0IHdpbGwgCnByZXZlbnQgaTkxNSBmcm9tIGFj
Y3VtdWxhdGluZyBvYmplY3RzIHdpdGggdm1hcHMgc3RpY2tpbmcgYXJvdW5kIGZvciAKdG9vIGxv
bmcgcG90ZW50aWFsbHk/Cgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu
Ywo+Pj4gaW5kZXggNDM0YTQ1Mi4uNDdmMTg2ZSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+PiBAQCAtMjA1Niw3ICsyMDU2LDcgQEAgc3RhdGljIGlu
dCBpbml0X3BoeXNfc3RhdHVzX3BhZ2Uoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykKPj4+
ICAgdm9pZCBpbnRlbF91bnBpbl9yaW5nYnVmZmVyX29iaihzdHJ1Y3QgaW50ZWxfcmluZ2J1ZmZl
ciAqcmluZ2J1ZikKPj4+ICAgewo+Pj4gICAJaWYgKEhBU19MTEMocmluZ2J1Zi0+b2JqLT5iYXNl
LmRldikgJiYgIXJpbmdidWYtPm9iai0+c3RvbGVuKQo+Pj4gLQkJdnVubWFwKHJpbmdidWYtPnZp
cnR1YWxfc3RhcnQpOwo+Pj4gKwkJaTkxNV9nZW1fb2JqZWN0X3VucGluX3ZtYXAocmluZ2J1Zi0+
b2JqKTsKPj4+ICAgCWVsc2UKPj4+ICAgCQlpb3VubWFwKHJpbmdidWYtPnZpcnR1YWxfc3RhcnQp
Owo+Pj4gICAJcmluZ2J1Zi0+dmlydHVhbF9zdGFydCA9IE5VTEw7Cj4+PiBAQCAtMjA3NywxNiAr
MjA3NywxNCBAQCBpbnQgaW50ZWxfcGluX2FuZF9tYXBfcmluZ2J1ZmZlcl9vYmooc3RydWN0IGRy
bV9kZXZpY2UgKmRldiwKPj4+ICAgCQkJcmV0dXJuIHJldDsKPj4+Cj4+PiAgIAkJcmV0ID0gaTkx
NV9nZW1fb2JqZWN0X3NldF90b19jcHVfZG9tYWluKG9iaiwgdHJ1ZSk7Cj4+PiAtCQlpZiAocmV0
KSB7Cj4+PiAtCQkJaTkxNV9nZW1fb2JqZWN0X2dndHRfdW5waW4ob2JqKTsKPj4+IC0JCQlyZXR1
cm4gcmV0Owo+Pj4gLQkJfQo+Pj4gKwkJaWYgKHJldCkKPj4+ICsJCQlnb3RvIHVucGluOwo+Pj4K
Pj4+IC0JCXJpbmdidWYtPnZpcnR1YWxfc3RhcnQgPSBpOTE1X2dlbV9vYmplY3Rfdm1hcF9yYW5n
ZShvYmosIDAsCj4+PiAtCQkJCQkJcmluZ2J1Zi0+c2l6ZSA+PiBQQUdFX1NISUZUKTsKPj4+IC0J
CWlmIChyaW5nYnVmLT52aXJ0dWFsX3N0YXJ0ID09IE5VTEwpIHsKPj4+IC0JCQlpOTE1X2dlbV9v
YmplY3RfZ2d0dF91bnBpbihvYmopOwo+Pj4gLQkJCXJldHVybiAtRU5PTUVNOwo+Pj4gKwkJcmlu
Z2J1Zi0+dmlydHVhbF9zdGFydCA9IGk5MTVfZ2VtX29iamVjdF9waW5fdm1hcChvYmopOwo+Pj4g
KwkJaWYgKElTX0VSUihyaW5nYnVmLT52aXJ0dWFsX3N0YXJ0KSkgewo+Pj4gKwkJCXJldCA9IFBU
Ul9FUlIocmluZ2J1Zi0+dmlydHVhbF9zdGFydCk7Cj4+PiArCQkJcmluZ2J1Zi0+dmlydHVhbF9z
dGFydCA9IE5VTEw7Cj4+PiArCQkJZ290byB1bnBpbjsKPj4+ICAgCQl9Cj4+PiAgIAl9IGVsc2Ug
ewo+Pj4gICAJCXJldCA9IGk5MTVfZ2VtX29ial9nZ3R0X3BpbihvYmosIFBBR0VfU0laRSwgUElO
X01BUFBBQkxFKTsKPj4+IEBAIC0yMDk0LDEwICsyMDkyLDggQEAgaW50IGludGVsX3Bpbl9hbmRf
bWFwX3JpbmdidWZmZXJfb2JqKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+PiAgIAkJCXJldHVy
biByZXQ7Cj4+Pgo+Pj4gICAJCXJldCA9IGk5MTVfZ2VtX29iamVjdF9zZXRfdG9fZ3R0X2RvbWFp
bihvYmosIHRydWUpOwo+Pj4gLQkJaWYgKHJldCkgewo+Pj4gLQkJCWk5MTVfZ2VtX29iamVjdF9n
Z3R0X3VucGluKG9iaik7Cj4+PiAtCQkJcmV0dXJuIHJldDsKPj4+IC0JCX0KPj4+ICsJCWlmIChy
ZXQpCj4+PiArCQkJZ290byB1bnBpbjsKPj4+Cj4+PiAgIAkJLyogQWNjZXNzIHRocm91Z2ggdGhl
IEdUVCByZXF1aXJlcyB0aGUgZGV2aWNlIHRvIGJlIGF3YWtlLiAqLwo+Pj4gICAJCWFzc2VydF9y
cG1fd2FrZWxvY2tfaGVsZChkZXZfcHJpdik7Cj4+PiBAQCAtMjEwNSwxNCArMjEwMSwxOCBAQCBp
bnQgaW50ZWxfcGluX2FuZF9tYXBfcmluZ2J1ZmZlcl9vYmooc3RydWN0IGRybV9kZXZpY2UgKmRl
diwKPj4+ICAgCQlyaW5nYnVmLT52aXJ0dWFsX3N0YXJ0ID0gaW9yZW1hcF93YyhkZXZfcHJpdi0+
Z3R0Lm1hcHBhYmxlX2Jhc2UgKwo+Pj4gICAJCQkJCQkgICAgaTkxNV9nZW1fb2JqX2dndHRfb2Zm
c2V0KG9iaiksIHJpbmdidWYtPnNpemUpOwo+Pj4gICAJCWlmIChyaW5nYnVmLT52aXJ0dWFsX3N0
YXJ0ID09IE5VTEwpIHsKPj4+IC0JCQlpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihvYmopOwo+
Pj4gLQkJCXJldHVybiAtRUlOVkFMOwo+Pj4gKwkJCXJldCA9IC1FTk9NRU07Cj4+PiArCQkJZ290
byB1bnBpbjsKPj4KPj4gQW5vdGhlciByZWZhY3RvcmluZyBub3QgcmVhbGx5IGJlbG9uZ2luZyB0
byB0aGlzIHBhdGNoLiBJIGFtIG5vdAo+PiBzdXJlIGl0IGlzIHRoYXQgZ29vZCB0byBzaGFyZSB0
aGUgY2xlYW51cCBwYXRoIGZyb20gdGhlIHR3bwo+PiBsb2dpY2FsbHkgc3BsaXQgYnJhbmNoZXMu
IE1heSBiZSBmcmFnaWxlIGluIHRoZSBmdXR1cmUuIEJ1dCBpdCBpcwo+PiBzaG9ydCBlbm91Z2gg
c28gT0suCj4+Cj4+IEJ1dCBhcyBhIHJlbGF0ZWQgcXVlc3Rpb24sIEkgd29uZGVyIHdoeSBkb2Vz
bid0IHRoZSBMUkMgcmVxdWlyZSB0aGUKPj4gc2FtZSAhSEFTX0xMQyBhcHByb2FjaCB3aGVuIG1h
cHBpbmcgYXMgcmluZyBidWZmZXIgZG9lcyBoZXJlPwo+Cj4gV2UgZG9uJ3QgdHJ5IHRvIHVzZSBz
dG9sZW4gZm9yIExSQy4gVGhlIG1haW4gZGlmZmljdWx0eSBsaWVzIGluCj4gZGVjaWRpbmcgaG93
IHRvIG1hcCB0aGUgc3RhdGUgb2JqZWN0LCBzdG9sZW4gZm9yY2VzIHVzIHRvIHVzZSBhbgo+IGlv
cmVtYXBwaW5nIHRocm91Z2ggdGhlIEdUVCBhbmQgc28gb25seSBzdWl0YWJsZSBmb3Igd3JpdGUt
b25seQo+IG1hcHBpbmdzLiBIb3dldmVyLCB3ZSBjb3VsZCBiZSB1c2luZyB0aGUgcGVyLWNvbnRl
eHQgSFdTLCBmb3Igd2hpY2ggd2UKPiB3YW50IGEgQ1BVIGFjY2Vzc2libGUsIGRpcmVjdCBwb2lu
dGVyLgoKSSB3YXNuJ3QgYXNraW5nIGFib3V0IHN0b2xlbiBidXQgdGhlICFIQVNfTExDIHBhdGgu
IEV2ZW4gbm9uLXN0b2xlbiByaW5nIApidWZmZXJzIHdpbGwgYmUgbWFwcGVkIHZpZSB0aGUgYXBl
cnR1cmUgb24gIUhBU19MTEMgcGxhdGZvcm1zLiBUaGF0IAppbXBsaWVzIGl0IGlzIGFib3V0IGNh
Y2hlIGNvaGVyZW5jeSBhbmQgd2UgZG9uJ3QgaGF2ZSB0aGUgc2FtZSB0cmVhdG1lbnQgCmZvciB0
aGUgTFJDIHBhZ2UuCgpVbnRpbCB5b3VyIHZtYS0+aW9tYXAgcHJvdG90eXBlIHdoaWNoIGFkZGVk
IHRoZSBzYW1lIHVuY2FjaGVkIGFjY2VzcyB0byAKdGhlIExSQyBhcyB3ZWxsLgoKU28gbXkgcXVl
c3Rpb24gd2FzLCBkbyB3ZSBuZWVkIHRoaXMgZm9yIGNhY2hlIGNvbnNpZGVyYXRpb25zIHRvZGF5
LCAKaXJyZXNwZWN0aXZlIG9mIGNhY2hpbmcgdGhlIHBvaW50ZXIgaW4gdGhlIFZNQS4KClJlZ2Fy
ZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4
Cg==