From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: John Harrison <John.C.Harrison@Intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [PATCH v6 3/7] drm/i915: Add per context timelines to fence object
Date: Wed, 24 Feb 2016 11:45:34 +0100 [thread overview]
Message-ID: <56CD89CE.4070901@linux.intel.com> (raw)
In-Reply-To: <56CB1C35.4070900@Intel.com>
Op 22-02-16 om 15:33 schreef John Harrison:
> On 18/02/2016 14:49, Chris Wilson wrote:
>> On Thu, Feb 18, 2016 at 02:24:06PM +0000, John.C.Harrison@Intel.com wrote:
>>> From: John Harrison <John.C.Harrison@Intel.com>
>>>
>>> The fence object used inside the request structure requires a sequence
>>> number. Although this is not used by the i915 driver itself, it could
>>> potentially be used by non-i915 code if the fence is passed outside of
>>> the driver. This is the intention as it allows external kernel drivers
>>> and user applications to wait on batch buffer completion
>>> asynchronously via the dma-buff fence API.
>>>
>>> To ensure that such external users are not confused by strange things
>>> happening with the seqno, this patch adds in a per context timeline
>>> that can provide a guaranteed in-order seqno value for the fence. This
>>> is safe because the scheduler will not re-order batch buffers within a
>>> context - they are considered to be mutually dependent.
>> This is still nonsense. Just implement per-context seqno.
> If you already have a set of patches to implement per-context seqno then let's get them merged. Otherwise, that is follow up work to be done once the scheduler has landed. There has already been too much churn and delay. So the decision is to get the scheduler in as soon as possible and any 'could do better' issues should be logged for follow up work.
Seems to me that per context seqno would be cleaner than this hack..
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-24 14:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 14:24 [PATCH v6 0/7] Convert requests to use struct fence John.C.Harrison
2016-02-18 14:24 ` [PATCH v6 1/7] drm/i915: " John.C.Harrison
2016-02-18 14:24 ` [PATCH v6 2/7] drm/i915: Removed now redudant parameter to i915_gem_request_completed() John.C.Harrison
2016-02-18 14:24 ` [PATCH v6 3/7] drm/i915: Add per context timelines to fence object John.C.Harrison
2016-02-18 14:49 ` Chris Wilson
2016-02-22 14:33 ` John Harrison
2016-02-24 10:45 ` Maarten Lankhorst [this message]
2016-02-18 14:24 ` [PATCH v6 4/7] drm/i915: Delay the freeing of requests until retire time John.C.Harrison
2016-02-18 14:48 ` Chris Wilson
2016-02-22 14:34 ` John Harrison
2016-03-01 15:18 ` Maarten Lankhorst
2016-03-14 15:20 ` John Harrison
2016-02-18 14:24 ` [PATCH v6 5/7] drm/i915: Interrupt driven fences John.C.Harrison
2016-02-18 14:24 ` [PATCH v6 6/7] drm/i915: Updated request structure tracing John.C.Harrison
2016-02-18 14:24 ` [PATCH v6 7/7] drm/i915: Cache last IRQ seqno to reduce IRQ overhead John.C.Harrison
2016-02-18 14:51 ` [PATCH v6 0/7] Convert requests to use struct fence Chris Wilson
2016-02-22 14:36 ` John Harrison
2016-02-18 15:01 ` ✗ Fi.CI.BAT: failure for Convert requests to use struct fence (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CD89CE.4070901@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=John.C.Harrison@Intel.com \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).