From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 1/2] drm/i915: Add i915_gem_object_vmap to map GEM object to virtual space Date: Mon, 29 Feb 2016 12:03:35 +0000 Message-ID: <56D43397.1060204@linux.intel.com> References: <1455820298-5463-1-git-send-email-yu.dai@intel.com> <1455820298-5463-2-git-send-email-yu.dai@intel.com> <56C6F782.1090102@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 2964C6E295 for ; Mon, 29 Feb 2016 12:03:38 +0000 (UTC) In-Reply-To: <56C6F782.1090102@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: yu.dai@intel.com, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzAyLzE2IDExOjA3LCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPgo+IE9uIDE4LzAyLzE2 IDE4OjMxLCB5dS5kYWlAaW50ZWwuY29tIHdyb3RlOgo+PiBGcm9tOiBBbGV4IERhaSA8eXUuZGFp QGludGVsLmNvbT4KPj4KPj4gVGhlcmUgYXJlIHNldmVyYWwgcGxhY2VzIGluc2lkZSBkcml2ZXIg d2hlcmUgYSBHRU0gb2JqZWN0IGlzIG1hcHBlZCB0bwo+PiBrZXJuZWwgdmlydHVhbCBzcGFjZS4g VGhlIG1hcHBpbmcgaXMgZWl0aGVyIGRvbmUgZm9yIHRoZSB3aG9sZSBvYmplY3QKPj4gb3IgY2Vy dGFpbiBwYWdlIHJhbmdlIG9mIGl0Lgo+Pgo+PiBUaGlzIHBhdGNoIGludHJvZHVjZXMgYSBmdW5j dGlvbiBpOTE1X2dlbV9vYmplY3Rfdm1hcCB0byBkbyBzdWNoIGpvYi4KPj4KPj4gdjI6IFVzZSBv YmotPnBhZ2VzLT5uZW50cyBmb3IgaXRlcmF0aW9uIHdpdGhpbiBpOTE1X2dlbV9vYmplY3Rfdm1h cDsKPj4gICAgICBicmVhayB3aGVuIGl0IGZpbmlzaGVzIGFsbCBkZXNpcmVkIHBhZ2VzLiBUaGUg Y2FsbGVyIG5lZWQgdG8gcGFzcwo+PiAgICAgIGluIGFjdHVhbCBwYWdlIG51bWJlci4gKFR2cnRr byBVcnN1bGluKQo+Cj4gTG9vayBPSyB0byBtZS4gSnVzdCBvbmUgbW9yZSB0aGluZywgaXQgd291 bGQgYmUgZ29vZCB0byBhZGQgYSBXQVJOX09OCj4gYW5kIGJhaWwgb3V0IGlmIHBhZ2VzIGFyZSBu b3QgcGlubmVkLiBKdXN0IGJlY2F1c2UgdGhlIGZ1bmN0aW9uIGlzIG5vdwo+IHB1YmxpYyBhbmQg dGhhdCBpcyBhIGJpdCBzdHJvbmdlciB0aGFuIGtlcm5lbGRvYy4KPgo+IFdpdGggdGhhdCBhZGRl ZDoKPgo+IFJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu Y29tPgoKSGF2ZSB0byByZXRyYWN0IHRoaXMgZHVlIHRoaW5nIEkgbm90aWNlZCBpbiBEYXZlJ3Mg cmVwb3N0IG9mIHRoaXMgcGF0Y2gsIApiZWxvdzoKCj4gUmVnYXJkcywKPgo+IFR2cnRrbwo+Cj4K Pj4gU2lnbmVkLW9mZi1ieTogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+IENjOiBEYXZl IEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+PiBDYzogRGFuaWVsIFZldHRlciA8 ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJz dWxpbkBpbnRlbC5jb20+Cj4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5j by51az4KPj4gU2lnbmVkLW9mZi1ieTogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+IC0t LQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfY21kX3BhcnNlci5jICB8IDI4ICstLS0t LS0tLS0tLS0tLS0tLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAg ICAgIHwgIDMgKysrCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAg IHwgNDcKPj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZG1hYnVmLmMgIHwgMTYgKysrLS0tLS0tLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCAyNCArKy0tLS0tLS0tLS0tLS0t LQo+PiAgIDUgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgNjIgZGVsZXRpb25zKC0p Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2NtZF9wYXJzZXIu Ywo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfY21kX3BhcnNlci5jCj4+IGluZGV4IDgx NGQ4OTQuLjkxNWU4YzEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Y21kX3BhcnNlci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfY21kX3BhcnNl ci5jCj4+IEBAIC04NjMsMzcgKzg2MywxMSBAQCBmaW5kX3JlZyhjb25zdCBzdHJ1Y3QgZHJtX2k5 MTVfcmVnX2Rlc2NyaXB0b3IKPj4gKnRhYmxlLAo+PiAgIHN0YXRpYyB1MzIgKnZtYXBfYmF0Y2go c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPj4gICAgICAgICAgICAgICAgICB1bnNp Z25lZCBzdGFydCwgdW5zaWduZWQgbGVuKQo+PiAgIHsKPj4gLSAgICBpbnQgaTsKPj4gLSAgICB2 b2lkICphZGRyID0gTlVMTDsKPj4gLSAgICBzdHJ1Y3Qgc2dfcGFnZV9pdGVyIHNnX2l0ZXI7Cj4+ ICAgICAgIGludCBmaXJzdF9wYWdlID0gc3RhcnQgPj4gUEFHRV9TSElGVDsKPj4gICAgICAgaW50 IGxhc3RfcGFnZSA9IChsZW4gKyBzdGFydCArIDQwOTUpID4+IFBBR0VfU0hJRlQ7Cj4+ICAgICAg IGludCBucGFnZXMgPSBsYXN0X3BhZ2UgLSBmaXJzdF9wYWdlOwo+PiAtICAgIHN0cnVjdCBwYWdl ICoqcGFnZXM7Cj4+IC0KPj4gLSAgICBwYWdlcyA9IGRybV9tYWxsb2NfYWIobnBhZ2VzLCBzaXpl b2YoKnBhZ2VzKSk7Cj4+IC0gICAgaWYgKHBhZ2VzID09IE5VTEwpIHsKPj4gLSAgICAgICAgRFJN X0RFQlVHX0RSSVZFUigiRmFpbGVkIHRvIGdldCBzcGFjZSBmb3IgcGFnZXNcbiIpOwo+PiAtICAg ICAgICBnb3RvIGZpbmlzaDsKPj4gLSAgICB9Cj4+IC0KPj4gLSAgICBpID0gMDsKPj4gLSAgICBm b3JfZWFjaF9zZ19wYWdlKG9iai0+cGFnZXMtPnNnbCwgJnNnX2l0ZXIsIG9iai0+cGFnZXMtPm5l bnRzLAo+PiBmaXJzdF9wYWdlKSB7Cj4+IC0gICAgICAgIHBhZ2VzW2krK10gPSBzZ19wYWdlX2l0 ZXJfcGFnZSgmc2dfaXRlcik7Cj4+IC0gICAgICAgIGlmIChpID09IG5wYWdlcykKPj4gLSAgICAg ICAgICAgIGJyZWFrOwo+PiAtICAgIH0KPj4gLQo+PiAtICAgIGFkZHIgPSB2bWFwKHBhZ2VzLCBp LCAwLCBQQUdFX0tFUk5FTCk7Cj4+IC0gICAgaWYgKGFkZHIgPT0gTlVMTCkgewo+PiAtICAgICAg ICBEUk1fREVCVUdfRFJJVkVSKCJGYWlsZWQgdG8gdm1hcCBwYWdlc1xuIik7Cj4+IC0gICAgICAg IGdvdG8gZmluaXNoOwo+PiAtICAgIH0KPj4KPj4gLWZpbmlzaDoKPj4gLSAgICBpZiAocGFnZXMp Cj4+IC0gICAgICAgIGRybV9mcmVlX2xhcmdlKHBhZ2VzKTsKPj4gLSAgICByZXR1cm4gKHUzMiop YWRkcjsKPj4gKyAgICByZXR1cm4gKHUzMiopaTkxNV9nZW1fb2JqZWN0X3ZtYXAob2JqLCBmaXJz dF9wYWdlLCBucGFnZXMpOwo+PiAgIH0KPj4KPj4gICAvKiBSZXR1cm5zIGEgdm1hcCdkIHBvaW50 ZXIgdG8gZGVzdF9vYmosIHdoaWNoIHRoZSBjYWxsZXIgbXVzdCB1bm1hcCAqLwo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5kZXggNjY0NGMyZS4uNWIwMGE2YSAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4+IEBAIC0yODk5LDYgKzI4OTksOSBAQCBzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX29iamVjdAo+PiAqaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9mcm9tX2RhdGEoCj4+ICAg ICAgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBjb25zdCB2b2lkICpkYXRhLCBzaXplX3Qg c2l6ZSk7Cj4+ICAgdm9pZCBpOTE1X2dlbV9mcmVlX29iamVjdChzdHJ1Y3QgZHJtX2dlbV9vYmpl Y3QgKm9iaik7Cj4+ICAgdm9pZCBpOTE1X2dlbV92bWFfZGVzdHJveShzdHJ1Y3QgaTkxNV92bWEg KnZtYSk7Cj4+ICt2b2lkICppOTE1X2dlbV9vYmplY3Rfdm1hcChzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X29iamVjdCAqb2JqLAo+PiArICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGZpcnN0LAo+PiAr ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5wYWdlcyk7Cj4+Cj4+ICAgLyogRmxhZ3MgdXNl ZCBieSBwaW4vYmluZCZmcmllbmRzLiAqLwo+PiAgICNkZWZpbmUgUElOX01BUFBBQkxFICAgICgx PDwwKQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4gaW5kZXggZjY4ZjM0Ni4uNGJjMGNl NyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+IEBAIC01MzU2LDMgKzUzNTYsNTAg QEAgZmFpbDoKPj4gICAgICAgZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoJm9iai0+YmFzZSk7 Cj4+ICAgICAgIHJldHVybiBFUlJfUFRSKHJldCk7Cj4+ICAgfQo+PiArCj4+ICsvKioKPj4gKyAq IGk5MTVfZ2VtX29iamVjdF92bWFwIC0gbWFwIGEgR0VNIG9iaiBpbnRvIGtlcm5lbCB2aXJ0dWFs IHNwYWNlCj4+ICsgKiBAb2JqOiB0aGUgR0VNIG9iaiB0byBiZSBtYXBwZWQKPj4gKyAqIEBmaXJz dDogaW5kZXggb2YgdGhlIGZpcnN0IHBhZ2Ugd2hlcmUgbWFwcGluZyBzdGFydHMKPj4gKyAqIEBu cGFnZXM6IGhvdyBtYW55IHBhZ2VzIHRvIGJlIG1hcHBlZCwgc3RhcnRpbmcgZnJvbSBmaXJzdCBw YWdlCj4+ICsgKgo+PiArICogTWFwIGEgZ2l2ZW4gcGFnZSByYW5nZSBvZiBHRU0gb2JqIGludG8g a2VybmVsIHZpcnR1YWwgc3BhY2UuIFRoZQo+PiBjYWxsZXIgbXVzdAo+PiArICogbWFrZSBzdXJl IHRoZSBhc3NvY2lhdGVkIHBhZ2VzIGFyZSBnYXRoZXJlZCBhbmQgcGlubmVkIGJlZm9yZQo+PiBj YWxsaW5nIHRoaXMKPj4gKyAqIGZ1bmN0aW9uLiB2dW5tYXAgc2hvdWxkIGJlIGNhbGxlZCBhZnRl ciB1c2UuCj4+ICsgKgo+PiArICogTlVMTCB3aWxsIGJlIHJldHVybmVkIGlmIGZhaWxzLgo+PiAr ICovCj4+ICt2b2lkICppOTE1X2dlbV9vYmplY3Rfdm1hcChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29i amVjdCAqb2JqLAo+PiArICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGZpcnN0LAo+PiArICAg ICAgICAgICAgICAgdW5zaWduZWQgaW50IG5wYWdlcykKPj4gK3sKPj4gKyAgICBzdHJ1Y3Qgc2df cGFnZV9pdGVyIHNnX2l0ZXI7Cj4+ICsgICAgc3RydWN0IHBhZ2UgKipwYWdlczsKPj4gKyAgICB2 b2lkICphZGRyOwo+PiArICAgIGludCBpOwo+PiArCj4+ICsgICAgaWYgKGZpcnN0ICsgbnBhZ2Vz ID4gb2JqLT5wYWdlcy0+bmVudHMpIHsKPj4gKyAgICAgICAgRFJNX0RFQlVHX0RSSVZFUigiSW52 YWxpZCBwYWdlIGNvdW50XG4iKTsKCm5lbnRzIGNhbiBiZSBlcXVhbCBvciBsZXNzIHRoYW4gbnVt YmVyIG9mIHBhZ2VzIGluIGFuIG9iamVjdCBzbyB0aGlzIGNhbiAKZmFpbCB0aGUgYXR0ZW1wdCBp bmNvcnJlY3RseS4gU2hvdWxkIGNoZWNrIGFnYWluc3Qgb2JqLT5iYXNlLnNpemUgPj4gClBBR0Vf U0hJRlQgaW5zdGVhZC4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==