From: Dave Gordon <david.s.gordon@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Derek Morton <derek.j.morton@intel.com>,
intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch
Subject: Re: [PATCH i-g-t v2 4/7] tests/gem_scheduler: Add gem_scheduler test
Date: Mon, 7 Mar 2016 12:40:38 +0000 [thread overview]
Message-ID: <56DD76C6.3090704@intel.com> (raw)
In-Reply-To: <20160302201501.GP30782@nuc-i3427.alporthouse.com>
On 02/03/16 20:15, Chris Wilson wrote:
>> +static struct ring {
>> + const char *name;
>> + int id;
>> + bool exists;
>> +} rings[] = {
>> + { "render", I915_EXEC_RENDER, false },
>> + { "bsd1", I915_EXEC_BSD | 1<<13, false },
>> + { "bsd2", I915_EXEC_BSD | 2<<13, false },
>
> This is wrong. The timeline is coupled to the exec_id, which is the same
> for "both" BSD engines. To fix that, properly split up the two rings
> with separate ids and deprecate HAS_BSD2.
>
>> + { "blt", I915_EXEC_BLT, false },
>> + { "vebox", I915_EXEC_VEBOX, false },
>> +};
>> +
>> +#define NBR_RINGS (sizeof(rings)/sizeof(struct ring))
>
> Also see intel_execution_engines to save on duplicating code.
> -Chris
exec_id is indeed the same for both BSD engines, but it is used ONLY in
i915_gem_busy_ioctl(), whose result can tell you that "a" BSD engine is
busy but not which one -- probably callers don't care anyway.
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-07 12:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 18:10 [PATCH i-g-t v2 0/7] Scheduler tests Derek Morton
2016-03-02 18:10 ` [PATCH i-g-t v2 1/7] ioctl_wrappers: make gem_has_ring non static Derek Morton
2016-03-02 18:10 ` [PATCH i-g-t v2 2/7] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks Derek Morton
2016-03-02 18:41 ` Chris Wilson
2016-03-04 15:14 ` Morton, Derek J
2016-03-07 11:56 ` Dave Gordon
2016-03-07 12:34 ` Dave Gordon
2016-03-02 18:10 ` [PATCH i-g-t v2 3/7] lib/intel_batchbuffer: Add functions to be used in the scheduler test Derek Morton
2016-03-02 18:10 ` [PATCH i-g-t v2 4/7] tests/gem_scheduler: Add gem_scheduler test Derek Morton
2016-03-02 20:15 ` Chris Wilson
2016-03-04 15:19 ` Morton, Derek J
2016-03-07 12:40 ` Dave Gordon [this message]
2016-03-02 18:10 ` [PATCH i-g-t v2 5/7] igt/gem_ctx_param_basic: Updated to support scheduler priority interface Derek Morton
2016-03-02 18:10 ` [PATCH i-g-t v2 6/7] tests/gem_scheduler: Add subtests to test batch priority behaviour Derek Morton
2016-03-02 18:10 ` [PATCH i-g-t v2 7/7] gem_scheduler: Added subtests to test priority bumping Derek Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DD76C6.3090704@intel.com \
--to=david.s.gordon@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=derek.j.morton@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox