From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [i-g-t PATCH v1 08/14] lib: Add
 igt_create_bo_with_dimensions
Date: Mon, 7 Mar 2016 17:19:18 +0100
Message-ID: <56DDAA06.2000305@collabora.com>
References: <1456927221-32421-1-git-send-email-tomeu.vizoso@collabora.com>
 <1456927221-32421-9-git-send-email-tomeu.vizoso@collabora.com>
 <20160305123034.GG18536@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk
 [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 269D16E32E
 for <intel-gfx@lists.freedesktop.org>; Mon,  7 Mar 2016 16:19:23 +0000 (UTC)
In-Reply-To: <20160305123034.GG18536@phenom.ffwll.local>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Micah Fedke <micah.fedke@collabora.com>, Intel GFX discussion <intel-gfx@lists.freedesktop.org>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, Daniel Stone <daniels@collabora.com>, Emil Velikov <emil.velikov@collabora.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gMDMvMDUvMjAxNiAwMTozMCBQTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBXZWQsIE1h
ciAwMiwgMjAxNiBhdCAwMzowMDoxNVBNICswMTAwLCBUb21ldSBWaXpvc28gd3JvdGU6Cj4+IGln
dF9jcmVhdGVfYm9fd2l0aF9kaW1lbnNpb25zKCkgaXMgaW50ZW5kZWQgdG8gYWJzdHJhY3QgZGlm
ZmVyZW5jZXMKPj4gYmV0d2VlbiBkcml2ZXJzIGluIGJ1ZmZlciBvYmplY3QgY3JlYXRpb24uCj4+
Cj4+IFRoZSBkcml2ZXItc3BlY2lmaWMgaW9jdGxzIHdpbGwgYmUgY2FsbGVkIGlmIHRoZSBkcml2
ZXIgdGhhdCBpcyBiZWluZwo+PiB0ZXN0ZWQgY2FuIHNhdGlzZnkgdGhlIG5lZWRzIG9mIHRoZSBj
YWxsaW5nIHN1YnRlc3QsIG9yIGl0IHdpbGwgYmUKPj4gc2tpcHBlZCBvdGhlcndpc2UuCj4+Cj4+
IFNpZ25lZC1vZmYtYnk6IFRvbWV1IFZpem9zbyA8dG9tZXUudml6b3NvQGNvbGxhYm9yYS5jb20+
Cj4+IC0tLQo+Pgo+PiAgbGliL2lndF9mYi5jIHwgODMgKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICBsaWIvaWd0X2ZiLmggfCAg
NiArKysrKwo+PiAgMiBmaWxlcyBjaGFuZ2VkLCA2NSBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlv
bnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+PiBp
bmRleCBjZDE2MDUzMDgzMDguLjBhMzUyNmY0ZTRlYSAxMDA2NDQKPj4gLS0tIGEvbGliL2lndF9m
Yi5jCj4+ICsrKyBiL2xpYi9pZ3RfZmIuYwo+PiBAQCAtMTc0LDMwICsxNzQsNjYgQEAgdm9pZCBp
Z3RfY2FsY19mYl9zaXplKGludCBmZCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LCBpbnQgYnBwLCB1
aW50NjRfdCB0aWxpbmcsCj4+ICAJKnNpemVfcmV0ID0gc2l6ZTsKPj4gIH0KPj4gIAo+PiAraW50
IGlndF9jcmVhdGVfYm9fd2l0aF9kaW1lbnNpb25zKGludCBmZCwgaW50IHdpZHRoLCBpbnQgaGVp
Z2h0LAo+IAo+IE5lZWRzIGd0a2RvYy4gQWxzbyB0aGlzIHNlZW1zIHRvIG92ZXJsYXAgaW4gZnVu
Y3Rpb25hbGl0eSB3aXRoIHRoZSB2ZXJ5Cj4gcmVjZW50bHkgYWRkZWQgaWd0X2NhbGNfZmJfc2l6
ZS4gQ291bGQgd2UgcGVyaGFwcyBpbXBsZW1lbnQgeW91ciBuZXcKPiBmdW5jdGlvbiBoZXJlIHVz
aW5nIGlndF9jYWxjX2ZiX3NpemUgcGx1cyBpZ3RfY3JlYXRlX2ZiX3dpdGhfc2l6ZT8gVGhlbgo+
IHRoaXMgd291bGQganVzdCBiZSBhIGNvbnZlbmllbmNlIHdyYXBwZXIuCgpGZWVsIGEgYml0IGxv
c3QgaGVyZSwgc29ycnkuIGlndF9jcmVhdGVfYm9fd2l0aF9kaW1lbnNpb25zIGlzCmltcGxlbWVu
dGVkIGluIHRlcm1zIG9mIGlndF9jYWxjX2ZiX3NpemUgYWxyZWFkeSwgYW5kCmlndF9jcmVhdGVf
ZmJfd2l0aF9zaXplIGRvZXNuJ3QgZXhpc3QuCgpJIHNlZSB0aGF0IHRoZXJlJ3MgaWd0X2NyZWF0
ZV9mYl93aXRoX2JvX3NpemUsIGJ1dCB3aHkgYSBmdW5jdGlvbgpjcmVhdGluZyBCT3Mgd291bGQg
Y2FsbCBhbm90aGVyIHRoYXQgY3JlYXRlcyBGQnM/CgpUaGFua3MsCgpUb21ldQoKPiBJIGp1c3Qg
d2FudCB0byBtYWtlIHN1cmUgdGhhdCB3ZSBoYXZlIGEgY29uc2lzdGVudCBpbnRlcmZhY2UgdG8g
aWd0X2ZiLmMKPiBmdW5jdGlvbmFsaXR5IGFuZCBhdm9pZCB0aGUgbmVlZCB0aGF0IGRyaXZlci1z
cGVjaWZpYyB0aWxpbmcgZm9ybWF0cyBuZWVkCj4gdG8gb3ZlcndyaXRlIGJhemlsbGlvbiBvZiBk
aWZmZXJlbnQgcGxhY2VzLgo+IC1EYW5pZWwKPiAKPj4gKwkJCQkgIHVpbnQzMl90IGZvcm1hdCwg
dWludDY0X3QgbW9kaWZpZXIsCj4+ICsJCQkJICB1bnNpZ25lZCBzdHJpZGUsIHVuc2lnbmVkICpz
aXplX3JldCwKPj4gKwkJCQkgIHVuc2lnbmVkICpzdHJpZGVfcmV0LCBib29sICppc19kdW1iKQo+
PiArewo+PiArCWludCBicHAgPSBpZ3RfZHJtX2Zvcm1hdF90b19icHAoZm9ybWF0KTsKPj4gKwlp
bnQgYm87Cj4+ICsKPj4gKwlpZ3RfYXNzZXJ0KChtb2RpZmllciAmJiBzdHJpZGUpIHx8ICghbW9k
aWZpZXIgJiYgIXN0cmlkZSkpOwo+PiArCj4+ICsJaWYgKG1vZGlmaWVyKSB7Cj4+ICsJCXVuc2ln
bmVkIHNpemUsIGNhbGN1bGF0ZWRfc3RyaWRlOwo+PiArCj4+ICsJCWlndF9jYWxjX2ZiX3NpemUo
ZmQsIHdpZHRoLCBoZWlnaHQsIGJwcCwgbW9kaWZpZXIsICZzaXplLAo+PiArCQkJCSAmY2FsY3Vs
YXRlZF9zdHJpZGUpOwo+PiArCQlpZiAoc3RyaWRlID09IDApCj4+ICsJCQlzdHJpZGUgPSBjYWxj
dWxhdGVkX3N0cmlkZTsKPj4gKwo+PiArCQlpZiAoaXNfZHVtYikKPj4gKwkJCSppc19kdW1iID0g
ZmFsc2U7Cj4+ICsKPj4gKwkJaWYgKGlzX2k5MTVfZGV2aWNlKGZkKSkgewo+PiArCj4+ICsJCQli
byA9IGdlbV9jcmVhdGUoZmQsIHNpemUpOwo+PiArCQkJZ2VtX3NldF90aWxpbmcoZmQsIGJvLCBt
b2RpZmllciwgc3RyaWRlKTsKPj4gKwo+PiArCQkJaWYgKHNpemVfcmV0KQo+PiArCQkJCSpzaXpl
X3JldCA9IHNpemU7Cj4+ICsKPj4gKwkJCWlmIChzdHJpZGVfcmV0KQo+PiArCQkJCSpzdHJpZGVf
cmV0ID0gc3RyaWRlOwo+PiArCj4+ICsJCQlyZXR1cm4gYm87Cj4+ICsJCX0gZWxzZSB7Cj4+ICsJ
CQlib29sIGRyaXZlcl9oYXNfdGlsaW5nX3N1cHBvcnQgPSBmYWxzZTsKPj4gKwo+PiArCQkJaWd0
X3JlcXVpcmUoZHJpdmVyX2hhc190aWxpbmdfc3VwcG9ydCk7Cj4+ICsJCQlyZXR1cm4gLUVJTlZB
TDsKPj4gKwkJfQo+PiArCX0gZWxzZSB7Cj4+ICsJCWlmIChpc19kdW1iKQo+PiArCQkJKmlzX2R1
bWIgPSB0cnVlOwo+PiArCQlyZXR1cm4gZHVtYl9jcmVhdGUoZmQsIHdpZHRoLCBoZWlnaHQsIGJw
cCwgc3RyaWRlX3JldCwgc2l6ZV9yZXQpOwo+PiArCX0KPj4gK30KPj4gKwo+PiAgLyogaGVscGVy
cyB0byBjcmVhdGUgbmljZS1sb29raW5nIGZyYW1lYnVmZmVycyAqLwo+PiAtc3RhdGljIGludCBj
cmVhdGVfYm9fZm9yX2ZiKGludCBmZCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LCBpbnQgYnBwLAo+
PiArc3RhdGljIGludCBjcmVhdGVfYm9fZm9yX2ZiKGludCBmZCwgaW50IHdpZHRoLCBpbnQgaGVp
Z2h0LCB1aW50MzJfdCBmb3JtYXQsCj4+ICAJCQkgICAgdWludDY0X3QgdGlsaW5nLCB1bnNpZ25l
ZCBib19zaXplLAo+PiAgCQkJICAgIHVuc2lnbmVkIGJvX3N0cmlkZSwgdWludDMyX3QgKmdlbV9o
YW5kbGVfcmV0LAo+PiAtCQkJICAgIHVuc2lnbmVkICpzaXplX3JldCwgdW5zaWduZWQgKnN0cmlk
ZV9yZXQpCj4+ICsJCQkgICAgdW5zaWduZWQgKnNpemVfcmV0LCB1bnNpZ25lZCAqc3RyaWRlX3Jl
dCwKPj4gKwkJCSAgICBib29sICppc19kdW1iKQo+PiAgewo+PiAgCXVpbnQzMl90IGdlbV9oYW5k
bGU7Cj4+ICAJaW50IHJldCA9IDA7Cj4+IC0JdW5zaWduZWQgc2l6ZSwgc3RyaWRlOwo+PiAtCj4+
IC0JaWd0X2NhbGNfZmJfc2l6ZShmZCwgd2lkdGgsIGhlaWdodCwgYnBwLCB0aWxpbmcsICZzaXpl
LCAmc3RyaWRlKTsKPj4gLQlpZiAoYm9fc2l6ZSA9PSAwKQo+PiAtCQlib19zaXplID0gc2l6ZTsK
Pj4gLQlpZiAoYm9fc3RyaWRlID09IDApCj4+IC0JCWJvX3N0cmlkZSA9IHN0cmlkZTsKPj4gLQo+
PiAtCWdlbV9oYW5kbGUgPSBnZW1fY3JlYXRlKGZkLCBib19zaXplKTsKPj4gIAo+PiAtCWlmICh0
aWxpbmcgPT0gTE9DQUxfSTkxNV9GT1JNQVRfTU9EX1hfVElMRUQpCj4+IC0JCXJldCA9IF9fZ2Vt
X3NldF90aWxpbmcoZmQsIGdlbV9oYW5kbGUsIEk5MTVfVElMSU5HX1gsCj4+IC0JCQkJICAgICAg
IGJvX3N0cmlkZSk7Cj4+ICsJZ2VtX2hhbmRsZSA9IGlndF9jcmVhdGVfYm9fd2l0aF9kaW1lbnNp
b25zKGZkLCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsCj4+ICsJCQkJCQkgICB0aWxpbmcsIGJvX3N0
cmlkZSwgc2l6ZV9yZXQsCj4+ICsJCQkJCQkgICBzdHJpZGVfcmV0LCBpc19kdW1iKTsKPj4gIAo+
PiAtCSpzdHJpZGVfcmV0ID0gYm9fc3RyaWRlOwo+PiAtCSpzaXplX3JldCA9IGJvX3NpemU7Cj4+
ICAJKmdlbV9oYW5kbGVfcmV0ID0gZ2VtX2hhbmRsZTsKPj4gIAo+PiAgCXJldHVybiByZXQ7Cj4+
IEBAIC01MDEsMTcgKzUzNywxNCBAQCBpZ3RfY3JlYXRlX2ZiX3dpdGhfYm9fc2l6ZShpbnQgZmQs
IGludCB3aWR0aCwgaW50IGhlaWdodCwKPj4gIAkJCSAgIHVuc2lnbmVkIGJvX3N0cmlkZSkKPj4g
IHsKPj4gIAl1aW50MzJfdCBmYl9pZDsKPj4gLQlpbnQgYnBwOwo+PiAgCj4+ICAJbWVtc2V0KGZi
LCAwLCBzaXplb2YoKmZiKSk7Cj4+ICAKPj4gLQlicHAgPSBpZ3RfZHJtX2Zvcm1hdF90b19icHAo
Zm9ybWF0KTsKPj4gLQo+PiAtCWlndF9kZWJ1ZygiJXMod2lkdGg9JWQsIGhlaWdodD0lZCwgZm9y
bWF0PTB4JXggW2JwcD0lZF0sIHRpbGluZz0weCUiUFJJeDY0Iiwgc2l6ZT0lZClcbiIsCj4+IC0J
CSAgX19mdW5jX18sIHdpZHRoLCBoZWlnaHQsIGZvcm1hdCwgYnBwLCB0aWxpbmcsIGJvX3NpemUp
Owo+PiAtCWRvX29yX2RpZShjcmVhdGVfYm9fZm9yX2ZiKGZkLCB3aWR0aCwgaGVpZ2h0LCBicHAs
IHRpbGluZywgYm9fc2l6ZSwKPj4gKwlpZ3RfZGVidWcoIiVzKHdpZHRoPSVkLCBoZWlnaHQ9JWQs
IGZvcm1hdD0weCV4LCB0aWxpbmc9MHglIlBSSXg2NCIsIHNpemU9JWQpXG4iLAo+PiArCQkgIF9f
ZnVuY19fLCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsIHRpbGluZywgYm9fc2l6ZSk7Cj4+ICsJZG9f
b3JfZGllKGNyZWF0ZV9ib19mb3JfZmIoZmQsIHdpZHRoLCBoZWlnaHQsIGZvcm1hdCwgdGlsaW5n
LCBib19zaXplLAo+PiAgCQkJCSAgIGJvX3N0cmlkZSwgJmZiLT5nZW1faGFuZGxlLCAmZmItPnNp
emUsCj4+IC0JCQkJICAgJmZiLT5zdHJpZGUpKTsKPj4gKwkJCQkgICAmZmItPnN0cmlkZSwgJmZi
LT5pc19kdW1iKSk7Cj4+ICAKPj4gIAlpZ3RfZGVidWcoIiVzKGhhbmRsZT0lZCwgcGl0Y2g9JWQp
XG4iLAo+PiAgCQkgIF9fZnVuY19fLCBmYi0+Z2VtX2hhbmRsZSwgZmItPnN0cmlkZSk7Cj4+IEBA
IC04NjAsNiArODkzLDcgQEAgc3RydWN0IGZiX2JsaXRfdXBsb2FkIHsKPj4gIAkJdWludDMyX3Qg
aGFuZGxlOwo+PiAgCQl1bnNpZ25lZCBzaXplLCBzdHJpZGU7Cj4+ICAJCXVpbnQ4X3QgKm1hcDsK
Pj4gKwkJYm9vbCBpc19kdW1iOwo+PiAgCX0gbGluZWFyOwo+PiAgfTsKPj4gIAo+PiBAQCAtOTI4
LDcgKzk2Miw4IEBAIHN0YXRpYyB2b2lkIGNyZWF0ZV9jYWlyb19zdXJmYWNlX19ibGl0KGludCBm
ZCwgc3RydWN0IGlndF9mYiAqZmIpCj4+ICAJCQkJTE9DQUxfRFJNX0ZPUk1BVF9NT0RfTk9ORSwg
MCwgMCwKPj4gIAkJCQkmYmxpdC0+bGluZWFyLmhhbmRsZSwKPj4gIAkJCQkmYmxpdC0+bGluZWFy
LnNpemUsCj4+IC0JCQkJJmJsaXQtPmxpbmVhci5zdHJpZGUpOwo+PiArCQkJCSZibGl0LT5saW5l
YXIuc3RyaWRlLAo+PiArCQkJCSZibGl0LT5saW5lYXIuaXNfZHVtYik7Cj4+ICAKPj4gIAlpZ3Rf
YXNzZXJ0KHJldCA9PSAwKTsKPj4gIAo+PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5oIGIvbGli
L2lndF9mYi5oCj4+IGluZGV4IDRlNmE3Njk0N2MxOC4uMTBlNTlkZWViZTg4IDEwMDY0NAo+PiAt
LS0gYS9saWIvaWd0X2ZiLmgKPj4gKysrIGIvbGliL2lndF9mYi5oCj4+IEBAIC00Nyw2ICs0Nyw3
IEBAIHR5cGVkZWYgc3RydWN0IF9jYWlybyBjYWlyb190Owo+PiAgc3RydWN0IGlndF9mYiB7Cj4+
ICAJdWludDMyX3QgZmJfaWQ7Cj4+ICAJdWludDMyX3QgZ2VtX2hhbmRsZTsKPj4gKwlib29sIGlz
X2R1bWI7Cj4+ICAJdWludDMyX3QgZHJtX2Zvcm1hdDsKPj4gIAlpbnQgd2lkdGg7Cj4+ICAJaW50
IGhlaWdodDsKPj4gQEAgLTk3LDYgKzk4LDExIEBAIHVuc2lnbmVkIGludCBpZ3RfY3JlYXRlX3N0
ZXJlb19mYihpbnQgZHJtX2ZkLCBkcm1Nb2RlTW9kZUluZm8gKm1vZGUsCj4+ICAJCQkJICB1aW50
MzJfdCBmb3JtYXQsIHVpbnQ2NF90IHRpbGluZyk7Cj4+ICB2b2lkIGlndF9yZW1vdmVfZmIoaW50
IGZkLCBzdHJ1Y3QgaWd0X2ZiICpmYik7Cj4+ICAKPj4gK2ludCBpZ3RfY3JlYXRlX2JvX3dpdGhf
ZGltZW5zaW9ucyhpbnQgZmQsIGludCB3aWR0aCwgaW50IGhlaWdodCwgdWludDMyX3QgZm9ybWF0
LAo+PiArCQkJCSAgdWludDY0X3QgbW9kaWZpZXIsIHVuc2lnbmVkIHN0cmlkZSwKPj4gKwkJCQkg
IHVuc2lnbmVkICpzdHJpZGVfb3V0LCB1bnNpZ25lZCAqc2l6ZV9vdXQsCj4+ICsJCQkJICBib29s
ICppc19kdW1iKTsKPj4gKwo+PiAgLyogY2Fpcm8tYmFzZWQgcGFpbnRpbmcgKi8KPj4gIGNhaXJv
X3QgKmlndF9nZXRfY2Fpcm9fY3R4KGludCBmZCwgc3RydWN0IGlndF9mYiAqZmIpOwo+PiAgdm9p
ZCBpZ3RfcGFpbnRfY29sb3IoY2Fpcm9fdCAqY3IsIGludCB4LCBpbnQgeSwgaW50IHcsIGludCBo
LAo+PiAtLSAKPj4gMi41LjAKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m
cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9pbnRlbC1nZngK