From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v7 6/7] drm/i915: refactor duplicate object
 vmap functions (the final rework?)
Date: Tue, 8 Mar 2016 09:43:32 +0000
Message-ID: <56DE9EC4.2000007@linux.intel.com>
References: <1456850039-25856-1-git-send-email-david.s.gordon@intel.com>
 <1456850039-25856-7-git-send-email-david.s.gordon@intel.com>
 <20160302120810.GB25660@nuc-i3427.alporthouse.com>
 <56D70961.6080806@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id D53EB6E635
 for <intel-gfx@lists.freedesktop.org>; Tue,  8 Mar 2016 09:43:33 +0000 (UTC)
In-Reply-To: <56D70961.6080806@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDAyLzAzLzE2IDE1OjQwLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAwMi8wMy8xNiAxMjow
OCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+PiBPbiBUdWUsIE1hciAwMSwgMjAxNiBhdCAwNDozMzo1
OFBNICswMDAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4+IFRoaXMgaXMgZXNzZW50aWFsbHkgQ2hy
aXMgV2lsc29uJ3MgcGF0Y2ggb2YgYSBzaW1pbGFyIG5hbWUsIHJld29ya2VkIG9uCj4+PiB0b3Ag
b2YgQWxleCBEYWkncyByZWNlbnQgcGF0Y2g6Cj4+PiB8IGRybS9pOTE1OiBBZGQgaTkxNV9nZW1f
b2JqZWN0X3ZtYXAgdG8gbWFwIEdFTSBvYmplY3QgdG8gdmlydHVhbCBzcGFjZQo+Pj4KPj4+IENo
cmlzJyBvcmlnaW5hbCBjb21tZW50YXJ5IHNhaWQ6Cj4+PiB8IFdlIG5vdyBoYXZlIHR3byBpbXBs
ZW1lbnRhdGlvbnMgZm9yIHZtYXBwaW5nIGEgd2hvbGUgb2JqZWN0LCBvbmUgZm9yCj4+PiB8IGRt
YS1idWYgYW5kIG9uZSBmb3IgdGhlIHJpbmdidWZmZXIuIElmIHdlIGNvdXBsZSB0aGUgdm1hcHBp
bmcgaW50bwo+Pj4gfCB0aGUgb2JqLT5wYWdlcyBsaWZldGltZSwgdGhlbiB3ZSBjYW4gcmV1c2Ug
YW4gb2JqLT52bWFwcGluZyBmb3IgYm90aAo+Pj4gfCBhbmQgYXQgdGhlIHNhbWUgdGltZSBjb3Vw
bGUgaXQgaW50byB0aGUgc2hyaW5rZXIuCj4+PiB8Cj4+PiB8IHYyOiBNYXJrIHRoZSBmYWlsYWJs
ZSBrbWFsbG9jKCkgYXMgX19HRlBfTk9XQVJOICh2c3lyamFsYSkKPj4+IHwgdjM6IENhbGwgdW5w
aW5fdm1hcCBmcm9tIHRoZSByaWdodCBkbWFidWYgdW5tYXBwZXIKPj4+Cj4+PiB2NDogcmVpbXBs
ZW1lbnRzIHRoZSBzYW1lIGZ1bmN0aW9uYWxpdHksIGJ1dCBub3cgYXMgd3JhcHBlcnMgcm91bmQg
dGhlCj4+PiAgICAgIHJlY2VudGx5LWludHJvZHVjZWQgaTkxNV9nZW1fb2JqZWN0X3ZtYXBfcmFu
Z2UoKSBmcm9tIEFsZXgncyBwYXRjaAo+Pj4gICAgICBtZW50aW9uZWQgYWJvdmUuCj4+Pgo+Pj4g
djU6IHNlcGFyYXRlZCBmcm9tIHR3byBtaW5vciBidXQgdW5yZWxhdGVkIGNoYW5nZXMgW1R2cnRr
byBVcnN1bGluXTsKPj4+ICAgICAgdGhpcyBpcyB0aGUgdGhpcmQgYW5kIG1vc3Qgc3Vic3RhbnRp
YWwgcG9ydGlvbi4KPj4+Cj4+PiAgICAgIERlY2lkZWQgbm90IHRvIGhvbGQgb250byB2bWFwcGlu
Z3MgYWZ0ZXIgdGhlIHBpbiBjb3VudCBnb2VzIHRvCj4+PiB6ZXJvLgo+Pj4gICAgICBUaGlzIG1h
eSByZWR1Y2UgdGhlIGJlbmVmaXQgb2YgQ2hyaXMnIHNjaGVtZSBhIGJpdCwgYnV0IGRvZXMgYXZv
aWQKPj4+ICAgICAgYW55IGluY3JlYXNlZCByaXNrIG9mIGV4aGF1c3Rpbmcga2VybmVsIHZtYXAg
c3BhY2Ugb24gMzItYml0Cj4+PiBrZXJuZWxzCj4+PiAgICAgIFtUdnJ0a28gVXJzdWxpbl0uIFBv
dGVudGlhbGx5LCB0aGUgdnVubWFwKCkgY291bGQgYmUgZGVmZXJyZWQgdW50aWwKPj4+ICAgICAg
dGhlIHB1dF9wYWdlcygpIHN0YWdlIGlmIGEgc3VpdGFibGUgbm90aWZpZXIgd2VyZSB3cml0dGVu
LCBidXQKPj4+IHdlJ3JlCj4+PiAgICAgIG5vdCBkb2luZyB0aGF0IGhlcmUuIE5vbmV0aGVsZXNz
LCB0aGUgc2ltcGxpZmljYXRpb24gb2YgYm90aCBkbWFidWYKPj4+ICAgICAgYW5kIHJpbmdidWZm
ZXIgY29kZSBtYWtlcyBpdCB3b3J0aHdoaWxlIGluIGl0cyBvd24gcmlnaHQuCj4+Pgo+Pj4gdjY6
IGNoYW5nZSBCVUdfT04oKSB0byBXQVJOX09OKCkuIFtUdnJ0a28gVXJzdWxpbl0KPj4+Cj4+PiBT
aWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+Pj4g
UmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+
PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiBDYzogQWxl
eCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9kcnYuaCAgICAgICAgIHwgMjIgKysrKysrKysrKysrKystLS0tLQo+Pj4gICBkcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgfCAzOQo+Pj4gKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt
X2RtYWJ1Zi5jICB8IDM2Cj4+PiArKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+ICAg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgIDkgKysrKy0tLS0KPj4+
ICAgNCBmaWxlcyBjaGFuZ2VkLCA2NSBpbnNlcnRpb25zKCspLCA0MSBkZWxldGlvbnMoLSkKPj4+
Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4gYi9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+PiBpbmRleCBiM2FlMTkxLi5mMWFkM2Iz
IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4gQEAgLTIxNzIsMTAgKzIxNzIs
NyBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCB7Cj4+PiAgICAgICAgICAgc3RydWN0IHNj
YXR0ZXJsaXN0ICpzZzsKPj4+ICAgICAgICAgICBpbnQgbGFzdDsKPj4+ICAgICAgIH0gZ2V0X3Bh
Z2U7Cj4+PiAtCj4+PiAtICAgIC8qIHByaW1lIGRtYS1idWYgc3VwcG9ydCAqLwo+Pj4gLSAgICB2
b2lkICpkbWFfYnVmX3ZtYXBwaW5nOwo+Pj4gLSAgICBpbnQgdm1hcHBpbmdfY291bnQ7Cj4+PiAr
ICAgIHZvaWQgKnZtYXBwaW5nOwo+Pj4KPj4+ICAgICAgIC8qKiBCcmVhZGNydW1iIG9mIGxhc3Qg
cmVuZGVyaW5nIHRvIHRoZSBidWZmZXIuCj4+PiAgICAgICAgKiBUaGVyZSBjYW4gb25seSBiZSBv
bmUgd3JpdGVyLCBidXQgd2UgYWxsb3cgZm9yIG11bHRpcGxlCj4+PiByZWFkZXJzLgo+Pj4gQEAg
LTI5ODAsNyArMjk3NywyMiBAQCBzdGF0aWMgaW5saW5lIHZvaWQKPj4+IGk5MTVfZ2VtX29iamVj
dF9waW5fcGFnZXMoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPj4+ICAgc3RhdGlj
IGlubGluZSB2b2lkIGk5MTVfZ2VtX29iamVjdF91bnBpbl9wYWdlcyhzdHJ1Y3QKPj4+IGRybV9p
OTE1X2dlbV9vYmplY3QgKm9iaikKPj4+ICAgewo+Pj4gICAgICAgQlVHX09OKG9iai0+cGFnZXNf
cGluX2NvdW50ID09IDApOwo+Pj4gLSAgICBvYmotPnBhZ2VzX3Bpbl9jb3VudC0tOwo+Pj4gKyAg
ICBpZiAoLS1vYmotPnBhZ2VzX3Bpbl9jb3VudCA9PSAwICYmIG9iai0+dm1hcHBpbmcpIHsKPj4+
ICsgICAgICAgIC8qCj4+PiArICAgICAgICAgKiBSZWxlYXNpbmcgdGhlIHZtYXBwaW5nIGhlcmUg
bWF5IHlpZWxkIGxlc3MgYmVuZWZpdCB0aGFuCj4+PiArICAgICAgICAgKiBpZiB3ZSBrZXB0IGl0
IHVudGlsIHB1dF9wYWdlcygpLCBidXQgb24gdGhlIG90aGVyIGhhbmQKPj4KPj4gWWllbGRzIG5v
IGJlbmVmaXQuIE1ha2VzIHRoZSBwYXRjaCBwb2ludGxlc3MuCj4+IFBsdXMgdGhlcmUgaXMgYWxz
byBwcmVzc3VyZSB0byBlbmFibGUgV0Mgdm1hcHMuCj4+IC1DaHJpcwo+Cj4gVGhlIHBhdGNoIGlz
IG5vdCBwb2ludGxlc3MgLS0gYXQgdGhlIHZlcnkgbGVhc3QsIGl0Ogo+ICsgcmVkdWNlcyB0aGUg
c2l6ZSBvZiAic3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QiIChPSywgb25seSBieSA0IGJ5dGVz
KQo+ICsgcmVwbGFjZXMgc3BlY2lhbC1mdW5jdGlvbiBjb2RlIGZvciBkbWFidWZzIHdpdGggbW9y
ZSBnZW5lcmljIGNvZGUgdGhhdAo+IGNhbiBiZSByZXVzZWQgZm9yIG90aGVyIG9iamVjdHMgKGZv
ciBub3csIHJpbmdidWZmZXJzOyBuZXh0IEd1Qy1zaGFyZWQKPiBvYmplY3RzIC0tIHNlZSBBbGV4
J3MgcGF0Y2ggImRybS9pOTE1L2d1YzogU2ltcGxpZnkgY29kZSBieSBrZWVwaW5nIHZtYXAKPiBv
ZiBndWNfY2xpZW50IG9iamVjdCIgd2hpY2ggd2lsbCBlbGltaW5hdGUgbG90IG9mIHNob3J0LXRl
cm0KPiBrbWFwX2F0b21pY3Mgd2l0aCBwZXJzaXN0ZW50IGttYXBzKS4KPiArIHByb3ZpZGVzIGEg
c2hvcnRoYW5kIGZvciB0aGUgc2VxdWVuY2Ugb2YgeyBnZXRfcGFnZXMoKSwgcGluX3BhZ2VzKCks
Cj4gdm1hcCgpIH0gc28gd2UgZG9uJ3QgaGF2ZSB0byBvcGVuLWNvZGUgaXQgKGFuZCBkZWFsIHdp
dGggYWxsIHRoZSBlcnJvcgo+IHBhdGhzKSBpbiBzZXZlcmFsIGRpZmZlcmVudCBwbGFjZXMKPgo+
IFRodXMgdGhlcmUgaXMgYW4gZW5naW5lZXJpbmcgYmVuZWZpdCBldmVuIGlmIHRoaXMgdmVyc2lv
biBkb2Vzbid0Cj4gcHJvdmlkZSBhbnkgcGVyZm9ybWFuY2UgYmVuZWZpdC4gQW5kIGlmLCBhcyB0
aGUgbmV4dCBzdGVwLCB5b3Ugd2FudCB0bwo+IGV4dGVuZCB0aGUgdm1hcCBsaWZldGltZSwgeW91
IGp1c3QgaGF2ZSB0byByZW1vdmUgdGhvc2UgZmV3IGxpbmVzIGluCj4gaTkxNV9nZW1fb2JqZWN0
X3VucGluX3BhZ2VzKCkgYW5kIGluY29ycG9yYXRlIHRoZSBub3RpZmllciB0aGF0IHlvdQo+IHBy
b3RvdHlwZWQgZWFybGllciAtLSBpZiBpdCBhY3R1YWxseSBwcm92aWRlcyBhbnkgcGVyZm9ybWFu
Y2UgYm9vc3QuCgpTbyBDaHJpcyBkbyB5b3UgYWNrIG9uIHRoaXMgc2VyaWVzIG9uIHRoZSBiYXNp
cyBvZiB0aGUgYWJvdmUgLSB0aGF0IGl0IApjb25zb2xpZGF0ZXMgdGhlIGN1cnJlbnQgY29kZSBh
bmQgZm9sbG93aW5nIEd1QyBwYXRjaCB3aWxsIGJlIGFub3RoZXIgCnVzZXIgb2YgdGhlIHBpbl92
bWFwIEFQST8KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4Cg==