From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH i-g-t v7] lib/igt_kms: Add COMMIT_ATOMIC to igt_display_commit2() Date: Tue, 8 Mar 2016 16:56:30 +0100 Message-ID: <56DEF62E.1080401@linux.intel.com> References: <1457345934-28943-1-git-send-email-pratik.vishwakarma@intel.com> <56DD78FE.2090000@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F5A46E731 for ; Tue, 8 Mar 2016 15:56:32 +0000 (UTC) In-Reply-To: <56DD78FE.2090000@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lionel Landwerlin , Pratik Vishwakarma , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDctMDMtMTYgb20gMTM6NTAgc2NocmVlZiBMaW9uZWwgTGFuZHdlcmxpbjoKPiBIaSBQcmF0 aWssCj4KPiBJJ20gcmVhbGx5IGxvb2tpbmcgZm9yd2FyZCB0byBnZXQgdGhpcyBtZXJnZWQuCj4g SnVzdCBhIGZldyBjb21tZW50cyBvbiB0aGUgcGxhbmUgY29tbWl0IHBhcnQgYmVsb3cuCgpXb3Vs ZCB0aGUgZm9sbG93aW5nIGRpZmYgdG8gdGhlIHBhdGNoIHNhdGlzZnkgeW91PyBJdCB3b3VsZCBj bGVhbiB1cCB0aGluZ3MgYSBsb3QuCgpkaWZmIC0tZ2l0IGEvbGliL2lndF9rbXMuYyBiL2xpYi9p Z3Rfa21zLmMKaW5kZXggMWY3MzhlMTRmNTJmLi40NTRmZjc1NTJiNGEgMTAwNjQ0Ci0tLSBhL2xp Yi9pZ3Rfa21zLmMKKysrIGIvbGliL2lndF9rbXMuYwpAQCAtMTUzNCwxNCArMTUzNCw2IEBAIGln dF9hdG9taWNfcHJlcGFyZV9wbGFuZV9jb21taXQoaWd0X3BsYW5lX3QgKnBsYW5lLCBpZ3Rfb3V0 cHV0X3QgKm91dHB1dCwKIAogCWlndF9kaXNwbGF5X3QgKmRpc3BsYXkgPSBvdXRwdXQtPmRpc3Bs YXk7CiAJdWludDMyX3QgZmJfaWQsIGNydGNfaWQ7Ci0JdWludDMyX3Qgc3JjX3g7Ci0JdWludDMy X3Qgc3JjX3k7Ci0JdWludDMyX3Qgc3JjX3c7Ci0JdWludDMyX3Qgc3JjX2g7Ci0JaW50MzJfdCBj cnRjX3g7Ci0JaW50MzJfdCBjcnRjX3k7Ci0JdWludDMyX3QgY3J0Y193OwotCXVpbnQzMl90IGNy dGNfaDsKIAogCWlndF9hc3NlcnQocGxhbmUtPmRybV9wbGFuZSk7CiAKQEAgLTE1NTIsNTQgKzE1 NDQsMzAgQEAgaWd0X2F0b21pY19wcmVwYXJlX3BsYW5lX2NvbW1pdChpZ3RfcGxhbmVfdCAqcGxh bmUsIGlndF9vdXRwdXRfdCAqb3V0cHV0LAogCWZiX2lkID0gaWd0X3BsYW5lX2dldF9mYl9pZChw bGFuZSk7CiAJY3J0Y19pZCA9IG91dHB1dC0+Y29uZmlnLmNydGMtPmNydGNfaWQ7CiAKLQlpZiAo KHBsYW5lLT5mYl9jaGFuZ2VkIHx8IHBsYW5lLT5zaXplX2NoYW5nZWQpICYmIGZiX2lkID09IDAp IHsKLQotCQlMT0coZGlzcGxheSwKLQkJICAgICIlczogcG9wdWxhdGluZyBwbGFuZSBkYXRhOiBw aXBlICVzLCBwbGFuZSAlZCwgZGlzYWJsaW5nXG4iLAotCQkgICAgIGlndF9vdXRwdXRfbmFtZShv dXRwdXQpLAotCQkgICAgIGttc3Rlc3RfcGlwZV9uYW1lKG91dHB1dC0+Y29uZmlnLnBpcGUpLAot CQkgICAgIHBsYW5lLT5pbmRleCk7Ci0KLQkJLyogcG9wdWxhdGUgcGxhbmUgcmVxICovCi0JCWln dF9hdG9taWNfcG9wdWxhdGVfcGxhbmVfcmVxKHJlcSwgcGxhbmUsIElHVF9QTEFORV9DUlRDX0lE LCAwKTsKLQkJaWd0X2F0b21pY19wb3B1bGF0ZV9wbGFuZV9yZXEocmVxLCBwbGFuZSwgSUdUX1BM QU5FX0ZCX0lELCAwKTsKLQotCQlpZ3RfYXRvbWljX3BvcHVsYXRlX3BsYW5lX3JlcShyZXEsIHBs YW5lLCBJR1RfUExBTkVfU1JDX1gsIElHVF9GSVhFRCgwLCAwKSk7Ci0JCWlndF9hdG9taWNfcG9w dWxhdGVfcGxhbmVfcmVxKHJlcSwgcGxhbmUsIElHVF9QTEFORV9TUkNfWSwgSUdUX0ZJWEVEKDAs IDApKTsKLQkJaWd0X2F0b21pY19wb3B1bGF0ZV9wbGFuZV9yZXEocmVxLCBwbGFuZSwgSUdUX1BM QU5FX1NSQ19XLCBJR1RfRklYRUQoMCwgMCkpOwotCQlpZ3RfYXRvbWljX3BvcHVsYXRlX3BsYW5l X3JlcShyZXEsIHBsYW5lLCBJR1RfUExBTkVfU1JDX0gsIElHVF9GSVhFRCgwLCAwKSk7Ci0KLQkJ aWd0X2F0b21pY19wb3B1bGF0ZV9wbGFuZV9yZXEocmVxLCBwbGFuZSwgSUdUX1BMQU5FX0NSVENf WCwgMCk7Ci0JCWlndF9hdG9taWNfcG9wdWxhdGVfcGxhbmVfcmVxKHJlcSwgcGxhbmUsIElHVF9Q TEFORV9DUlRDX1ksIDApOwotCQlpZ3RfYXRvbWljX3BvcHVsYXRlX3BsYW5lX3JlcShyZXEsIHBs YW5lLCBJR1RfUExBTkVfQ1JUQ19XLCAwKTsKLQkJaWd0X2F0b21pY19wb3B1bGF0ZV9wbGFuZV9y ZXEocmVxLCBwbGFuZSwgSUdUX1BMQU5FX0NSVENfSCwgMCk7Ci0KLQl9IGVsc2UgaWYgKHBsYW5l LT5mYl9jaGFuZ2VkIHx8IHBsYW5lLT5wb3NpdGlvbl9jaGFuZ2VkIHx8Ci0JCQlwbGFuZS0+c2l6 ZV9jaGFuZ2VkKSB7Ci0KLQkJc3JjX3ggPSBJR1RfRklYRUQocGxhbmUtPmZiLT5zcmNfeCwgMCk7 IC8qIHNyY194ICovCi0JCXNyY195ID0gSUdUX0ZJWEVEKHBsYW5lLT5mYi0+c3JjX3ksIDApOyAv KiBzcmNfeSAqLwotCQlzcmNfdyA9IElHVF9GSVhFRChwbGFuZS0+ZmItPnNyY193LCAwKTsgLyog c3JjX3cgKi8KLQkJc3JjX2ggPSBJR1RfRklYRUQocGxhbmUtPmZiLT5zcmNfaCwgMCk7IC8qIHNy Y19oICovCi0JCWNydGNfeCA9IHBsYW5lLT5jcnRjX3g7Ci0JCWNydGNfeSA9IHBsYW5lLT5jcnRj X3k7Ci0JCWNydGNfdyA9IHBsYW5lLT5jcnRjX3c7Ci0JCWNydGNfaCA9IHBsYW5lLT5jcnRjX2g7 Ci0KLQkJTE9HKGRpc3BsYXksCi0JCSAgICAiJXM6IHBvcHVsYXRpbmcgcGxhbmUgZGF0YTogJXMu JWQsIGZiICV1LCBzcmMgPSAoJWQsICVkKSAiCi0JCSAgICAiJXV4JXUgZHN0ID0gKCV1LCAldSkg JXV4JXVcbiIsCi0JCSAgICBpZ3Rfb3V0cHV0X25hbWUob3V0cHV0KSwKLQkJICAgIGttc3Rlc3Rf cGlwZV9uYW1lKG91dHB1dC0+Y29uZmlnLnBpcGUpLAotCQkgICAgcGxhbmUtPmluZGV4LAotCQkg ICAgZmJfaWQsCi0JCSAgICBzcmNfeCA+PiAxNiwgc3JjX3kgPj4gMTYsIHNyY193ID4+IDE2LCBz cmNfaCA+PiAxNiwKLQkJICAgIGNydGNfeCwgY3J0Y195LCBjcnRjX3csIGNydGNfaCk7Ci0KLQot CQkvKiBwb3B1bGF0ZSBwbGFuZSByZXEgKi8KLQkJaWd0X2F0b21pY19wb3B1bGF0ZV9wbGFuZV9y ZXEocmVxLCBwbGFuZSwgSUdUX1BMQU5FX0NSVENfSUQsIGNydGNfaWQpOworCUxPRyhkaXNwbGF5 LAorCSAgICAiJXM6IHBvcHVsYXRpbmcgcGxhbmUgZGF0YTogJXMuJWQsIGZiICV1LCBzcmMgPSAo JWQsICVkKSAiCisJICAgICIldXgldSBkc3QgPSAoJXUsICV1KSAldXgldVxuIiwKKwkgICAgaWd0 X291dHB1dF9uYW1lKG91dHB1dCksCisJICAgIGttc3Rlc3RfcGlwZV9uYW1lKG91dHB1dC0+Y29u ZmlnLnBpcGUpLAorCSAgICBwbGFuZS0+aW5kZXgsCisJICAgIGZiX2lkLAorCSAgICBzcmNfeCA+ PiAxNiwgc3JjX3kgPj4gMTYsIHNyY193ID4+IDE2LCBzcmNfaCA+PiAxNiwKKwkgICAgY3J0Y194 LCBjcnRjX3ksIGNydGNfdywgY3J0Y19oKTsKKworCWlmIChwbGFuZS0+ZmJfY2hhbmdlZCkgewor CQlpZ3RfYXRvbWljX3BvcHVsYXRlX3BsYW5lX3JlcShyZXEsIHBsYW5lLCBJR1RfUExBTkVfQ1JU Q19JRCwgZmJfaWQgPyBjcnRjX2lkIDogMCk7CiAJCWlndF9hdG9taWNfcG9wdWxhdGVfcGxhbmVf cmVxKHJlcSwgcGxhbmUsIElHVF9QTEFORV9GQl9JRCwgZmJfaWQpOworCX0KKworCWlmIChwbGFu ZS0+cG9zaXRpb25fY2hhbmdlZCB8fCBwbGFuZS0+c2l6ZV9jaGFuZ2VkKSB7CisJCXVpbnQzMl90 IHNyY194ID0gSUdUX0ZJWEVEKHBsYW5lLT5mYi0+c3JjX3gsIDApOyAvKiBzcmNfeCAqLworCQl1 aW50MzJfdCBzcmNfeSA9IElHVF9GSVhFRChwbGFuZS0+ZmItPnNyY195LCAwKTsgLyogc3JjX3kg Ki8KKwkJdWludDMyX3Qgc3JjX3cgPSBJR1RfRklYRUQocGxhbmUtPmZiLT5zcmNfdywgMCk7IC8q IHNyY193ICovCisJCXVpbnQzMl90IHNyY19oID0gSUdUX0ZJWEVEKHBsYW5lLT5mYi0+c3JjX2gs IDApOyAvKiBzcmNfaCAqLworCQlpbnQzMl90IGNydGNfeCA9IHBsYW5lLT5jcnRjX3g7CisJCWlu dDMyX3QgY3J0Y195ID0gcGxhbmUtPmNydGNfeTsKKwkJdWludDMyX3QgY3J0Y193ID0gcGxhbmUt PmNydGNfdzsKKwkJdWludDMyX3QgY3J0Y19oID0gcGxhbmUtPmNydGNfaDsKIAogCQlpZ3RfYXRv bWljX3BvcHVsYXRlX3BsYW5lX3JlcShyZXEsIHBsYW5lLCBJR1RfUExBTkVfU1JDX1gsIHNyY194 KTsKIAkJaWd0X2F0b21pY19wb3B1bGF0ZV9wbGFuZV9yZXEocmVxLCBwbGFuZSwgSUdUX1BMQU5F X1NSQ19ZLCBzcmNfeSk7CkBAIC0xNjEwLDE4ICsxNTc4LDE1IEBAIGlndF9hdG9taWNfcHJlcGFy ZV9wbGFuZV9jb21taXQoaWd0X3BsYW5lX3QgKnBsYW5lLCBpZ3Rfb3V0cHV0X3QgKm91dHB1dCwK IAkJaWd0X2F0b21pY19wb3B1bGF0ZV9wbGFuZV9yZXEocmVxLCBwbGFuZSwgSUdUX1BMQU5FX0NS VENfWSwgY3J0Y195KTsKIAkJaWd0X2F0b21pY19wb3B1bGF0ZV9wbGFuZV9yZXEocmVxLCBwbGFu ZSwgSUdUX1BMQU5FX0NSVENfVywgY3J0Y193KTsKIAkJaWd0X2F0b21pY19wb3B1bGF0ZV9wbGFu ZV9yZXEocmVxLCBwbGFuZSwgSUdUX1BMQU5FX0NSVENfSCwgY3J0Y19oKTsKLQotCQlpZiAocGxh bmUtPnJvdGF0aW9uX2NoYW5nZWQpCi0JCQlpZ3RfYXRvbWljX3BvcHVsYXRlX3BsYW5lX3JlcShy ZXEsIHBsYW5lLAotCQkJCUlHVF9QTEFORV9ST1RBVElPTiwgcGxhbmUtPnJvdGF0aW9uKTsKLQog CX0KIAorCWlmIChwbGFuZS0+cm90YXRpb25fY2hhbmdlZCkKKwkJaWd0X2F0b21pY19wb3B1bGF0 ZV9wbGFuZV9yZXEocmVxLCBwbGFuZSwKKwkJCUlHVF9QTEFORV9ST1RBVElPTiwgcGxhbmUtPnJv dGF0aW9uKTsKKwogCXBsYW5lLT5mYl9jaGFuZ2VkID0gZmFsc2U7CiAJcGxhbmUtPnBvc2l0aW9u X2NoYW5nZWQgPSBmYWxzZTsKIAlwbGFuZS0+c2l6ZV9jaGFuZ2VkID0gZmFsc2U7Ci0KLQlyZXR1 cm47CiB9CiAKIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==