public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915: More renaming of rings to engines
Date: Thu, 10 Mar 2016 14:59:38 +0000	[thread overview]
Message-ID: <56E18BDA.7030702@linux.intel.com> (raw)
In-Reply-To: <20160310144935.GA14143@nuc-i3427.alporthouse.com>


On 10/03/16 14:49, Chris Wilson wrote:
> On Thu, Mar 10, 2016 at 02:21:08PM +0000, Tvrtko Ursulin wrote:
>> @@ -4952,14 +4952,14 @@ int i915_gem_init(struct drm_device *dev)
>>
>>   	if (!i915.enable_execlists) {
>>   		dev_priv->gt.execbuf_submit = i915_gem_ringbuffer_submission;
>> -		dev_priv->gt.init_rings = i915_gem_init_rings;
>> -		dev_priv->gt.cleanup_ring = intel_cleanup_ring_buffer;
>> -		dev_priv->gt.stop_ring = intel_stop_ring_buffer;
>> +		dev_priv->gt.init_engines = i915_gem_init_engines;
>> +		dev_priv->gt.cleanup_engine = intel_cleanup_engine;
>> +		dev_priv->gt.stop_engine = intel_stop_engine;
>>   	} else {
>>   		dev_priv->gt.execbuf_submit = intel_execlists_submission;
>> -		dev_priv->gt.init_rings = intel_logical_rings_init;
>> -		dev_priv->gt.cleanup_ring = intel_logical_ring_cleanup;
>> -		dev_priv->gt.stop_ring = intel_logical_ring_stop;
>> +		dev_priv->gt.init_engines = intel_logical_rings_init;
>> +		dev_priv->gt.cleanup_engine = intel_logical_ring_cleanup;
>> +		dev_priv->gt.stop_engine = intel_logical_ring_stop;
>
> Making these changes manually or another patch?

Another *s*patch? No, this was manually. I was running out of steam with 
Coccinelle and 5/5 are just a few I've spotted and done by hand (or 
sed). Possibly I've missed some but the main body of churn is all here I 
think.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-03-10 14:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 14:21 [PATCH 0/5] intel_engine_cs renaming bomb Tvrtko Ursulin
2016-03-10 14:21 ` [PATCH 1/5] drm/i915: Rename local struct intel_engine_cs variables Tvrtko Ursulin
2016-03-10 14:21 ` [PATCH 2/5] drm/i915: Rename intel_engine_cs function parameters Tvrtko Ursulin
2016-03-10 15:33   ` kbuild test robot
2016-03-10 14:21 ` [PATCH 3/5] drm/i915: Rename intel_engine_cs struct members Tvrtko Ursulin
2016-03-10 15:18   ` kbuild test robot
2016-03-10 15:47   ` [PATCH 3/5 v2] " Tvrtko Ursulin
2016-03-10 14:21 ` [PATCH 4/5] drm/i915: More intel_engine_cs renaming Tvrtko Ursulin
2016-03-10 15:47   ` [PATCH 4/5 v2] " Tvrtko Ursulin
2016-03-10 14:21 ` [PATCH 5/5] drm/i915: More renaming of rings to engines Tvrtko Ursulin
2016-03-10 14:49   ` Chris Wilson
2016-03-10 14:59     ` Tvrtko Ursulin [this message]
2016-03-11 11:38   ` [PATCH v2 " Tvrtko Ursulin
2016-03-11 13:19   ` [PATCH 5/5 v3] " Tvrtko Ursulin
2016-03-10 14:52 ` [PATCH 0/5] intel_engine_cs renaming bomb Chris Wilson
2016-03-10 15:00 ` Arun Siluvery
2016-03-10 16:28   ` Tvrtko Ursulin
2016-03-10 16:43     ` Arun Siluvery
2016-03-10 16:47       ` Tvrtko Ursulin
2016-03-10 15:10 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-10 16:30 ` ✗ Fi.CI.BAT: warning for intel_engine_cs renaming bomb (rev3) Patchwork
2016-03-11  9:49   ` Tvrtko Ursulin
2016-03-11  9:52     ` Arun Siluvery
2016-03-11 12:30 ` ✗ Fi.CI.BAT: warning for intel_engine_cs renaming bomb (rev4) Patchwork
2016-03-11 14:32 ` ✗ Fi.CI.BAT: failure for intel_engine_cs renaming bomb (rev5) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2016-03-16 11:00 [PATCH 1/5] drm/i915: Rename local struct intel_engine_cs variables Tvrtko Ursulin
2016-03-16 11:00 ` [PATCH 5/5] drm/i915: More renaming of rings to engines Tvrtko Ursulin
2016-03-16 11:15   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E18BDA.7030702@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox