From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Dai Subject: Re: [PATCH v2 2/2] drm/i915/guc: Reset GuC and retry on firmware load failure Date: Thu, 10 Mar 2016 09:57:46 -0800 Message-ID: <56E1B59A.7050208@intel.com> References: <1457437098-21689-1-git-send-email-arun.siluvery@linux.intel.com> <1457437098-21689-3-git-send-email-arun.siluvery@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 253E36E25A for ; Thu, 10 Mar 2016 18:08:27 +0000 (UTC) In-Reply-To: <1457437098-21689-3-git-send-email-arun.siluvery@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arun Siluvery , intel-gfx@lists.freedesktop.org Cc: Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org TEdUTS4gUmV2aWV3ZWQtYnk6IEFsZXggRGFpIDx5dS5kYWlAaW50ZWwuY29tPgoKT24gMDMvMDgv MjAxNiAwMzozOCBBTSwgQXJ1biBTaWx1dmVyeSB3cm90ZToKPiBEdWUgdG8gdGltaW5nIGlzc3Vl cyBpbiB0aGUgSFcgc29tZSBvZiB0aGUgc3RhdHVzIGJpdHMgcmVxdWlyZWQgZm9yIEd1Qwo+IGF1 dGhlbnRpY2F0aW9uIGRvZXNuJ3QgZ2V0IHNldCBvY2Nhc3Npb25hbGx5LCB3aGVuIHRoYXQgaGFw cGVucywgR3VDIGNhbm5vdAo+IGJlIGluaXRpYWxpemVkIGFuZCB3ZSB3aWxsIGJlIGxlZnQgd2l0 aCBhIHdlZGdlZCBHUFUuIFRoZSBXQSBzdWdnZXN0ZWQgaXMKPiB0byBwZXJmb3JtIGEgc29mdCBy ZXNldCBvZiBHdUMgYW5kIGF0dGVtcHQgdG8gcmVsb2FkIHRoZSBmdyBhZ2FpbiBmb3IgZmV3Cj4g dGltZXMgYmVmb3JlIGdpdmluZyB1cC4KPgo+IEFzIHRoZSBmYWlsdXJlIGlzIGRlcGVuZGVudCBv biB0aW1pbmcsIHRlc3RzIHBlcmZvcm1lZCBieSB0cmlnZ2VyaW5nIG1hbnVhbAo+IGZ1bGwgZ3B1 IHJlc2V0IChpOTE1X3dlZGdlZCkgc2hvd2VkIHRoYXQgd2UgY291bGQgc29tZXRpbWVzIGhpdCB0 aGlzIGFmdGVyCj4gc2V2ZXJhbCB0aG91c2FuZCBpdGVyYXRpb25zIGJ1dCBzb21ldGltZXMgdGVz dHMgcmFuIGV2ZW4gbG9uZ2VyIHdpdGhvdXQgYW55Cj4gaXNzdWVzLiBSZXNldCBhbmQgcmVsb2Fk IG1lY2hhbmlzbSBwcm92ZWQgaGVscGZ1bCB3aGVuIHdlIGluZGVlZCBoaXQgZncKPiBsb2FkIGZh aWx1cmUgc28gaXQgaXMgYmV0dGVyIHRvIGluY2x1ZGUgdGhpcyB0byBpbXByb3ZlIGRyaXZlciBz dGFiaWxpdHkuCj4KPiBUaGlzIGNoYW5nZSBpbXBsZW1lbnRzIHRoZSBmb2xsb3dpbmcgV0EsCj4K PiBXYUVuYWJsZXVLZXJuZWxIZWFkZXJWYWxpZEZpeDpza2wsYnh0Cj4gV2FFbmFibGVHdUNCb290 SGFzaENoZWNrTm90U2V0OnNrbCxieHQKPgo+IENjOiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jk b25AaW50ZWwuY29tPgo+IENjOiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiBTaWduZWQt b2ZmLWJ5OiBBcnVuIFNpbHV2ZXJ5IDxhcnVuLnNpbHV2ZXJ5QGxpbnV4LmludGVsLmNvbT4KPiAt LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICB8ICAxICsKPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3JlZy5oICAgICB8ICAxICsKPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgICAgICB8ICAxICsKPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyB8IDQ5ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgICAgIHwg MTkgKysrKysrKysrKysrKwo+ICAgNSBmaWxlcyBjaGFuZ2VkLCA2OSBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggZjM3YWMxMi4u MGRmN2M4MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0yNzU3LDYgKzI3NTcs NyBAQCBleHRlcm4gbG9uZyBpOTE1X2NvbXBhdF9pb2N0bChzdHJ1Y3QgZmlsZSAqZmlscCwgdW5z aWduZWQgaW50IGNtZCwKPiAgIGV4dGVybiBpbnQgaW50ZWxfZ3B1X3Jlc2V0KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpOwo+ICAgZXh0ZXJuIGJvb2wgaW50ZWxfaGFzX2dwdV9yZXNldChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2KTsKPiAgIGV4dGVybiBpbnQgaTkxNV9yZXNldChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KTsKPiArZXh0ZXJuIGludCBpbnRlbF9ndWNfcmVzZXQoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgIGV4dGVybiB1bnNpZ25lZCBsb25nIGk5MTVfY2hpcHNl dF92YWwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgIGV4dGVybiB1bnNp Z25lZCBsb25nIGk5MTVfbWNoX3ZhbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Owo+ICAgZXh0ZXJuIHVuc2lnbmVkIGxvbmcgaTkxNV9nZnhfdmFsKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3VjX3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfcmVnLmgKPiBpbmRl eCBlNGJhNTgyLi45NGNlZWU1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3VjX3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfcmVnLmgK PiBAQCAtMjcsNiArMjcsNyBAQAo+ICAgLyogRGVmaW5pdGlvbnMgb2YgR3VDIEgvVyByZWdpc3Rl cnMsIGJpdHMsIGV0YyAqLwo+ICAgCj4gICAjZGVmaW5lIEdVQ19TVEFUVVMJCQlfTU1JTygweGMw MDApCj4gKyNkZWZpbmUgICBHU19NSUFfSU5fUkVTRVQJCSgxIDw8IDApCj4gICAjZGVmaW5lICAg R1NfQk9PVFJPTV9TSElGVAkJMQo+ICAgI2RlZmluZSAgIEdTX0JPT1RST01fTUFTSwkJICAoMHg3 RiA8PCBHU19CT09UUk9NX1NISUZUKQo+ICAgI2RlZmluZSAgIEdTX0JPT1RST01fUlNBX0ZBSUxF RAkJICAoMHg1MCA8PCBHU19CT09UUk9NX1NISUZUKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ IGluZGV4IDdkZmM0MDAuLjQ4YTIzZGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBA QCAtMTY0LDYgKzE2NCw3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpOTE1X21taW9fcmVnX3ZhbGlk KGk5MTVfcmVnX3QgcmVnKQo+ICAgI2RlZmluZSAgR0VONl9HUkRPTV9SRU5ERVIJCSgxIDw8IDEp Cj4gICAjZGVmaW5lICBHRU42X0dSRE9NX01FRElBCQkoMSA8PCAyKQo+ICAgI2RlZmluZSAgR0VO Nl9HUkRPTV9CTFQJCQkoMSA8PCAzKQo+ICsjZGVmaW5lICBHRU45X0dSRE9NX0dVQwkJCSgxIDw8 IDUpCj4gICAKPiAgICNkZWZpbmUgUklOR19QUF9ESVJfQkFTRShyaW5nKQkJX01NSU8oKHJpbmcp LT5tbWlvX2Jhc2UrMHgyMjgpCj4gICAjZGVmaW5lIFJJTkdfUFBfRElSX0JBU0VfUkVBRChyaW5n KQlfTU1JTygocmluZyktPm1taW9fYmFzZSsweDUxOCkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjX2xvYWRlci5jCj4gaW5kZXggODJhM2MwMy4uZjljYjgxNCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiBAQCAtMzUzLDYgKzM1MywyNCBAQCBzdGF0 aWMgaW50IGd1Y191Y29kZV94ZmVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiAgIAlyZXR1cm4gcmV0Owo+ICAgfQo+ICAgCj4gK3N0YXRpYyBpbnQgaTkxNV9yZXNldF9ndWMo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwlpbnQgcmV0Owo+ICsJ dTMyIGd1Y19zdGF0dXM7Cj4gKwo+ICsJcmV0ID0gaW50ZWxfZ3VjX3Jlc2V0KGRldl9wcml2KTsK PiArCWlmIChyZXQpIHsKPiArCQlEUk1fRVJST1IoIkd1QyByZXNldCBmYWlsZWQsIHJldCA9ICVk XG4iLCByZXQpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJZ3VjX3N0YXR1cyA9IEk5 MTVfUkVBRChHVUNfU1RBVFVTKTsKPiArCVdBUk4oIShndWNfc3RhdHVzICYgR1NfTUlBX0lOX1JF U0VUKSwKPiArCSAgICAgIkd1QyBzdGF0dXM6IDB4JXgsIE1JQSBjb3JlIGV4cGVjdGVkIHRvIGJl IGluIHJlc2V0XG4iLCBndWNfc3RhdHVzKTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ ICAgLyoqCj4gICAgKiBpbnRlbF9ndWNfdWNvZGVfbG9hZCgpIC0gbG9hZCBHdUMgdUNvZGUgaW50 byB0aGUgZGV2aWNlCj4gICAgKiBAZGV2Oglkcm0gZGV2aWNlCj4gQEAgLTQxNyw5ICs0MzUsMzYg QEAgaW50IGludGVsX2d1Y191Y29kZV9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJ aWYgKGVycikKPiAgIAkJZ290byBmYWlsOwo+ICAgCj4gKwkvKgo+ICsJICogV2FFbmFibGV1S2Vy bmVsSGVhZGVyVmFsaWRGaXg6c2tsLGJ4dAo+ICsJICogRm9yIEJYVCwgdGhpcyBpcyBvbmx5IHVw dG8gQjAgYnV0IGJlbG93IFdBIGlzIHJlcXVpcmVkIGZvciBsYXRlcgo+ICsJICogc3RlcHBpbmdz IGFsc28gc28gdGhpcyBpcyBleHRlbmRlZCBhcyB3ZWxsLgo+ICsJICovCj4gKwkvKiBXYUVuYWJs ZUd1Q0Jvb3RIYXNoQ2hlY2tOb3RTZXQ6c2tsLGJ4dCAqLwo+ICAgCWVyciA9IGd1Y191Y29kZV94 ZmVyKGRldl9wcml2KTsKPiAtCWlmIChlcnIpCj4gLQkJZ290byBmYWlsOwo+ICsJaWYgKGVycikg ewo+ICsJCWludCByZXRyaWVzID0gMzsKPiArCj4gKwkJRFJNX0VSUk9SKCJHdUMgZncgbG9hZCBm YWlsZWQsIGVycj0lZCwgYXR0ZW1wdGluZyByZXNldCBhbmQgcmV0cnlcbiIsIGVycik7Cj4gKwo+ ICsJCXdoaWxlIChyZXRyaWVzLS0pIHsKPiArCQkJZXJyID0gaTkxNV9yZXNldF9ndWMoZGV2X3By aXYpOwo+ICsJCQlpZiAoZXJyKQo+ICsJCQkJYnJlYWs7Cj4gKwo+ICsJCQllcnIgPSBndWNfdWNv ZGVfeGZlcihkZXZfcHJpdik7Cj4gKwkJCWlmICghZXJyKSB7Cj4gKwkJCQlEUk1fREVCVUdfRFJJ VkVSKCJHdUMgZncgcmVsb2FkIHN1Y2NlZWRlZCBhZnRlciByZXNldFxuIik7Cj4gKwkJCQlicmVh azsKPiArCQkJfQo+ICsJCQlEUk1fREVCVUdfRFJJVkVSKCJHdUMgZncgcmVsb2FkIHJldHJpZXMg bGVmdDogJWRcbiIsIHJldHJpZXMpOwo+ICsJCX0KPiArCj4gKwkJaWYgKGVycikgewo+ICsJCQlE Uk1fRVJST1IoIkd1QyBmdyByZWxvYWQgYXR0ZW1wdCBmYWlsZWQsIHJldD0lZFxuIiwgZXJyKTsK PiArCQkJZ290byBmYWlsOwo+ICsJCX0KPiArCX0KPiAgIAo+ICAgCWd1Y19mdy0+Z3VjX2Z3X2xv YWRfc3RhdHVzID0gR1VDX0ZJUk1XQVJFX1NVQ0NFU1M7Cj4gICAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF91bmNvcmUuYwo+IGluZGV4IDgwZTM4ZDUuLjkyYmU3NmEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91bmNvcmUuYwo+IEBAIC0xNjQ3LDYgKzE2NDcsMjUgQEAgYm9vbCBpbnRlbF9o YXNfZ3B1X3Jlc2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJcmV0dXJuIGludGVsX2dl dF9ncHVfcmVzZXQoZGV2KSAhPSBOVUxMOwo+ICAgfQo+ICAgCj4gK2ludCBpbnRlbF9ndWNfcmVz ZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwlpbnQgcmV0Owo+ ICsJdW5zaWduZWQgbG9uZyBpcnFmbGFnczsKPiArCj4gKwlpZiAoIWk5MTUuZW5hYmxlX2d1Y19z dWJtaXNzaW9uKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCWludGVsX3VuY29yZV9mb3Jj ZXdha2VfZ2V0KGRldl9wcml2LCBGT1JDRVdBS0VfQUxMKTsKPiArCXNwaW5fbG9ja19pcnFzYXZl KCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPiArCj4gKwlyZXQgPSBnZW42X2Rv bWFpbl9yZXNldChkZXZfcHJpdiwgR0VOOV9HUkRPTV9HVUMpOwo+ICsKPiArCXNwaW5fdW5sb2Nr X2lycXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+ICsJaW50ZWxf dW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIEZPUkNFV0FLRV9BTEwpOwo+ICsKPiArCXJl dHVybiByZXQ7Cj4gK30KPiArCj4gICBib29sIGludGVsX3VuY29yZV91bmNsYWltZWRfbW1pbyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICB7Cj4gICAJcmV0dXJuIGNoZWNr X2Zvcl91bmNsYWltZWRfbW1pbyhkZXZfcHJpdik7CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK