Re: [PATCH 0/5] intel_engine_cs renaming bomb

Chris Wilson
2016-03-10T14:52:46Z

On Thu, Mar 10, 2016 at 02:21:03PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> I think there is consesus to do this, but the question
> is whether now is the time to do it?
>
> If desired, needs to go in quickly before it goes stale.
>
> But if not, it was an interesting exercise of learning
> Coccinelle nevertheless.
>
> Tvrtko Ursulin (5):
> drm/i915: Rename local struct intel_engine_cs variables
> drm/i915: Rename intel_engine_cs function parameters
> drm/i915: Rename intel_engine_cs struct members
> drm/i915: More intel_engine_cs renaming
> drm/i915: More renaming of rings to engines

Actually read all 5, some I felt missing from the manual fixup in 5, but
I am very much in favour and could not spot a mistake in the mechanical
changes.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre